)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a0a2ea1101c4c4a4da993c3f20db539616abc1e4","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        access_point_ssh \u003d self._connect_to_access_point(tenant)"},{"line_number":423,"context_line":"        mac_addr \u003d access_point_ssh.get_mac_address()"},{"line_number":424,"context_line":"        mac_addr \u003d mac_addr.strip().lower()"},{"line_number":425,"context_line":"        port_list \u003d self.network_client.list_ports()[\u0027ports\u0027]"},{"line_number":426,"context_line":"        port_detail_list \u003d ["},{"line_number":427,"context_line":"            (port[\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027],"},{"line_number":428,"context_line":"             port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9VcI%3D","line":425,"updated":"2014-04-06 20:10:02.000000000","message":"if you are fixing this, then you might as well filter the ports on the server (as arguments to the list method).","commit_id":"024642bb183ba238f7c024c9b14d4ec4748c73fc"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d69e0a1a3153f32f3fa8c86e26cdb41cdccebbf0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        access_point_ssh \u003d self._connect_to_access_point(tenant)"},{"line_number":423,"context_line":"        mac_addr \u003d access_point_ssh.get_mac_address()"},{"line_number":424,"context_line":"        mac_addr \u003d mac_addr.strip().lower()"},{"line_number":425,"context_line":"        port_list \u003d self.network_client.list_ports()[\u0027ports\u0027]"},{"line_number":426,"context_line":"        port_detail_list \u003d ["},{"line_number":427,"context_line":"            (port[\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027],"},{"line_number":428,"context_line":"             port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9VX8%3D","line":425,"in_reply_to":"AAAAWH%2F9VcI%3D","updated":"2014-04-06 20:57:06.000000000","message":"Done","commit_id":"024642bb183ba238f7c024c9b14d4ec4748c73fc"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9bd2415904edd87ece332040341223f18ed58d6c","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        mac_addr \u003d access_point_ssh.get_mac_address()"},{"line_number":424,"context_line":"        mac_addr \u003d mac_addr.strip().lower()"},{"line_number":425,"context_line":"        port_list \u003d self.network_client.list_ports("},{"line_number":426,"context_line":"            fields\u003d[\u0027fixed_ips\u0027, \u0027mac_address\u0027])[\u0027ports\u0027]"},{"line_number":427,"context_line":"        port_detail_list \u003d ["},{"line_number":428,"context_line":"            (port[\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027],"},{"line_number":429,"context_line":"             port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FcJo%3D","line":426,"updated":"2014-04-21 19:15:59.000000000","message":"I think this probably warrants a comment.  Without having the context of the bug It\u0027s not exactly obvious why your doing this.","commit_id":"56e7a60b9c54b1763cb3afa876e70c96ab421334"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a018a602dde04f5f0b2b1dd066aedd8c8af51f81","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        mac_addr \u003d access_point_ssh.get_mac_address()"},{"line_number":424,"context_line":"        mac_addr \u003d mac_addr.strip().lower()"},{"line_number":425,"context_line":"        port_list \u003d self.network_client.list_ports("},{"line_number":426,"context_line":"            fields\u003d[\u0027fixed_ips\u0027, \u0027mac_address\u0027])[\u0027ports\u0027]"},{"line_number":427,"context_line":"        port_detail_list \u003d ["},{"line_number":428,"context_line":"            (port[\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027],"},{"line_number":429,"context_line":"             port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2Fa6Q%3D","line":426,"in_reply_to":"AAAAXH%2F%2FbO4%3D","updated":"2014-04-21 22:47:45.000000000","message":"I fully agree a comment is needed. Just wanted to clarify/discuss first so I can make a meaningful comment. Thanks!","commit_id":"56e7a60b9c54b1763cb3afa876e70c96ab421334"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"f080967c73bccce2ccd9b37851407141a3e4235c","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        mac_addr \u003d access_point_ssh.get_mac_address()"},{"line_number":424,"context_line":"        mac_addr \u003d mac_addr.strip().lower()"},{"line_number":425,"context_line":"        port_list \u003d self.network_client.list_ports("},{"line_number":426,"context_line":"            fields\u003d[\u0027fixed_ips\u0027, \u0027mac_address\u0027])[\u0027ports\u0027]"},{"line_number":427,"context_line":"        port_detail_list \u003d ["},{"line_number":428,"context_line":"            (port[\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027],"},{"line_number":429,"context_line":"             port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FbO4%3D","line":426,"in_reply_to":"AAAAXH%2F%2FbaY%3D","updated":"2014-04-21 21:51:49.000000000","message":"Oh I just assumed it was a query filter, I didn\u0027t realize it was a column selection. (or that you could do that) Knowing that this call does make more sense by itself. But, I think that my confusion is even more reason to leave a comment. :) \n\nSomething like:\n\n # Grab only fixed_ips and mac address fields by selection only those columns\n\n(or something better worded)\n\nDoing a query filter would put the burden on neutron to do the filtering, but I\u0027m not sure it\u0027s necessary, it\u0027s simple enough to just do what you did down there.","commit_id":"56e7a60b9c54b1763cb3afa876e70c96ab421334"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"878e5ebe3233030baf44ed4bb315a6f6a613bf73","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        mac_addr \u003d access_point_ssh.get_mac_address()"},{"line_number":424,"context_line":"        mac_addr \u003d mac_addr.strip().lower()"},{"line_number":425,"context_line":"        port_list \u003d self.network_client.list_ports("},{"line_number":426,"context_line":"            fields\u003d[\u0027fixed_ips\u0027, \u0027mac_address\u0027])[\u0027ports\u0027]"},{"line_number":427,"context_line":"        port_detail_list \u003d ["},{"line_number":428,"context_line":"            (port[\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027],"},{"line_number":429,"context_line":"             port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FbaY%3D","line":426,"in_reply_to":"AAAAXH%2F%2FcJo%3D","updated":"2014-04-21 21:21:03.000000000","message":"I don\u0027t think this is really related to the bug. Specifying fields\u003d in the request is column selection, not a query filter. See http://docs.openstack.org/api/openstack-network/2.0/content/General_API_Information-d1e436.html#filtering\n\nEven if a port has no \u0027fixed_ips\u0027 field, it will still be returned in the response. I don\u0027t know if Yair\u0027s comment in patch set 2 is suggesting that I should do a query filter for \"ports with non-empty fixed_ips\". I don\u0027t know how to do that.","commit_id":"56e7a60b9c54b1763cb3afa876e70c96ab421334"}]}