)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42a165dbbcdad83fbe2ffecb119ef697cb02ecc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8f8a28e8_3d68063c","updated":"2023-05-01 20:21:41.000000000","message":"recheck refresh the log","commit_id":"fc5d292c4af5e083905da1773fbb7d861edd0dff"}],"tempest/api/compute/base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9ea9db0e17b38ea479ace87786dafc6adb296612","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":41,"context_line":"    # Set this to True in subclasses to create a default network. See"},{"line_number":42,"context_line":"    # https://bugs.launchpad.net/tempest/+bug/1844568"},{"line_number":43,"context_line":"    create_default_network \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # TODO(andreaf) We should care also for the alt_manager here"},{"line_number":46,"context_line":"    # but only once client lazy load in the manager is done"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f7993b3_1193f11c","line":43,"updated":"2022-05-30 15:22:24.000000000","message":"This is not enough today. Either you need to add \n    @classmethod\n    def setup_credentials(cls):\n        cls.prepare_instance_network()\n        super(LiveMigrationTest, cls).setup_credentials()\n\nor we need to resurrect and merge https://review.opendev.org/c/openstack/tempest/+/817771 first","commit_id":"16c48d98c4616e056e94f59bd632704f43cff246"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4b46ead5894f7f06539f935daa470c54bf40d9ef","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":41,"context_line":"    # Set this to True in subclasses to create a default network. See"},{"line_number":42,"context_line":"    # https://bugs.launchpad.net/tempest/+bug/1844568"},{"line_number":43,"context_line":"    create_default_network \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # TODO(andreaf) We should care also for the alt_manager here"},{"line_number":46,"context_line":"    # but only once client lazy load in the manager is done"}],"source_content_type":"text/x-python","patch_set":4,"id":"32082e77_345c511c","line":43,"in_reply_to":"1f7993b3_1193f11c","updated":"2022-05-30 16:58:26.000000000","message":"ah thanks, I think doing it in 817771 way is better. I will update that.","commit_id":"16c48d98c4616e056e94f59bd632704f43cff246"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"75f63943165da7bad2b953d8e151cac84b998217","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":41,"context_line":"    # Set this to True in subclasses to create a default network. See"},{"line_number":42,"context_line":"    # https://bugs.launchpad.net/tempest/+bug/1844568"},{"line_number":43,"context_line":"    create_default_network \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # TODO(andreaf) We should care also for the alt_manager here"},{"line_number":46,"context_line":"    # but only once client lazy load in the manager is done"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1f4ad47_9f44e6e1","line":43,"in_reply_to":"32082e77_345c511c","updated":"2022-05-31 08:02:30.000000000","message":"Ack","commit_id":"16c48d98c4616e056e94f59bd632704f43cff246"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ada147ebf1a8592902ede5f7e8597bc9adde09c7","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            subnet\u003dcls.create_default_network,"},{"line_number":70,"context_line":"            router\u003dcls.create_default_network,"},{"line_number":71,"context_line":"            dhcp\u003dcls.create_default_network)"},{"line_number":72,"context_line":"        cls.prepare_instance_network()"},{"line_number":73,"context_line":"        super(BaseV2ComputeTest, cls).setup_credentials()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a25e681_5aa11c64","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":38},"updated":"2022-11-25 20:03:37.000000000","message":"this will not set network resource as they are already set in previous line (they can be set only once and not overridable). We need to make create_default_network default to true so that network is setup for server to inject the validation resource and ssh.","commit_id":"692f517c62863ef7c18010a4de2f0e1cc3aa80bc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a3aec31152b5c7c704d8cdc779dbbfd28afa4c62","unresolved":true,"context_lines":[{"line_number":632,"context_line":"        # NOTE(gmann): If test are attaching volume then they detach also"},{"line_number":633,"context_line":"        # either explicitly in test or in the cleanup method added in this"},{"line_number":634,"context_line":"        # method. In both cases, let\u0027s make sure server is SSH-able before"},{"line_number":635,"context_line":"        # detach operation is called, more details are in bug#1960346."},{"line_number":636,"context_line":"        if CONF.validation.run_validation:"},{"line_number":637,"context_line":"            validation_resources \u003d self.get_test_validation_resources("},{"line_number":638,"context_line":"                self.os_primary)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5664b433_45fb8da5","line":635,"updated":"2023-05-02 13:39:42.000000000","message":"Actually I think the assertion is that it\u0027s the *attach* we might miss, which causes the detach to never occur. So if you\u0027re going to do this, it would probably be better to do it before L603.\n\nThis does seem like a good optimization, but it also may be leaky.. if we have this problem with volumes we might have problems with other things and/or something could bypass this attach_volume() helper and not get the sshable check.\n\nHonestly, I\u0027m not sure which I prefer... I guess probably wait_until\u003dSSHABLE as the recommendation, but this as a fail-safe?","commit_id":"7094e7580222035ad02f56685618dc5b33ba71b4"}]}