)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d35cd4381b7e020181098fd70d78fe0b09ef13e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbea1a02_ab9bf1a0","updated":"2022-06-15 14:03:06.000000000","message":"-1 not for the change but for the class and they way its implemented.\nLets keep the instance shared among all tests and catch the failures and not hooking by Exception if something goes wrong.","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"2a30d90c9000cd4cb9d02216fdfe0ff69a4eab6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9652623b_27256ada","updated":"2022-06-15 14:45:38.000000000","message":"Ack , lets handle it on a serpate patch","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8c22440f8721f7807b1688c30724001f50981f3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42d99e80_39d11b44","updated":"2022-06-15 16:09:10.000000000","message":"let\u0027s merge this, the tests are passing in the gates plus we\u0027ve executed tests on rhel9 to verify the sshable issues in the related tests are fixed","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d8554932ab2adbabced4003af81d42898eebf9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70781271_f6cf9253","updated":"2022-06-15 21:10:02.000000000","message":"recheck","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bd5fbdecf2d9971656987a127eeb66057ef5171d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2feae3ed_107b62a4","updated":"2022-05-30 15:23:21.000000000","message":"recheck openstack-tox-py36 issue has been fixed","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a394787b42b3228449bcc19ad38fe373a4414f9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b73369f_95788433","updated":"2022-06-16 06:19:32.000000000","message":"recheck time out","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5819720af0665dd1b10fb6034e23e03d6733f3a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ce4f940_701ff533","in_reply_to":"dbea1a02_ab9bf1a0","updated":"2022-06-15 14:30:04.000000000","message":"I don\u0027t follow, we vote for this particular change and idea you\u0027re proposing is not related to this change at all, why then vote -1 here?","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d35cd4381b7e020181098fd70d78fe0b09ef13e8","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            waiters.wait_for_server_status(self.client,"},{"line_number":58,"context_line":"                                           self.server_id, \u0027ACTIVE\u0027)"},{"line_number":59,"context_line":"        except lib_exc.NotFound:"},{"line_number":60,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":61,"context_line":"            # Use class level validation resources to avoid them being"},{"line_number":62,"context_line":"            # deleted once a test is over"},{"line_number":63,"context_line":"            validation_resources \u003d self.get_class_validation_resources("}],"source_content_type":"text/x-python","patch_set":1,"id":"1ce460b5_8be9e22e","line":60,"updated":"2022-06-15 14:03:06.000000000","message":"We use a shared server which created in resource_setup and a testcase deletes it.\nSo we create in setup (testcase level) another instance and assign it to cls. \nself.__class__.server_id \u003d server[\u0027id\u0027]\n\nif we delete the server in a testcase why the resource is shared  ?","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5819720af0665dd1b10fb6034e23e03d6733f3a0","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            waiters.wait_for_server_status(self.client,"},{"line_number":58,"context_line":"                                           self.server_id, \u0027ACTIVE\u0027)"},{"line_number":59,"context_line":"        except lib_exc.NotFound:"},{"line_number":60,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":61,"context_line":"            # Use class level validation resources to avoid them being"},{"line_number":62,"context_line":"            # deleted once a test is over"},{"line_number":63,"context_line":"            validation_resources \u003d self.get_class_validation_resources("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf280672_35f69bf4","line":60,"in_reply_to":"1ce460b5_8be9e22e","updated":"2022-06-15 14:30:04.000000000","message":"My assumption is not all test cases delete the instance, therefore it\u0027s shared and recreated here in case a test case deleted it.","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d35cd4381b7e020181098fd70d78fe0b09ef13e8","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    @classmethod"},{"line_number":93,"context_line":"    def resource_setup(cls):"},{"line_number":94,"context_line":"        super(ServerActionsTestJSON, cls).resource_setup()"},{"line_number":95,"context_line":"        cls.server_id \u003d cls.recreate_server(None, validatable\u003dTrue,"},{"line_number":96,"context_line":"                                            wait_until\u003d\u0027SSHABLE\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @decorators.idempotent_id(\u00276158df09-4b82-4ab3-af6d-29cf36af858d\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d1405c3_ac196480","line":95,"updated":"2022-06-15 14:03:06.000000000","message":"if we decide to work with a shared instance ,thats a good idea but lets keep it without delete and we should assume that all actions should pass and the testcase order has not meaning .\ni would refactor this class first.\n\nBenny","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5819720af0665dd1b10fb6034e23e03d6733f3a0","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    @classmethod"},{"line_number":93,"context_line":"    def resource_setup(cls):"},{"line_number":94,"context_line":"        super(ServerActionsTestJSON, cls).resource_setup()"},{"line_number":95,"context_line":"        cls.server_id \u003d cls.recreate_server(None, validatable\u003dTrue,"},{"line_number":96,"context_line":"                                            wait_until\u003d\u0027SSHABLE\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @decorators.idempotent_id(\u00276158df09-4b82-4ab3-af6d-29cf36af858d\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"37b10042_844a9e7a","line":95,"in_reply_to":"9d1405c3_ac196480","updated":"2022-06-15 14:30:04.000000000","message":"any refactoring of the test should be done in a separate review, it\u0027s not related to this change","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d35cd4381b7e020181098fd70d78fe0b09ef13e8","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        self.client.resize_server(self.server_id, self.flavor_ref_alt)"},{"line_number":424,"context_line":"        # NOTE(zhufl): Explicitly delete the server to get a new one for later"},{"line_number":425,"context_line":"        # tests. Avoids resize down race issues."},{"line_number":426,"context_line":"        self.addCleanup(self.delete_server, self.server_id)"},{"line_number":427,"context_line":"        waiters.wait_for_server_status(self.client, self.server_id,"},{"line_number":428,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"86ab2368_9246883a","line":426,"updated":"2022-06-15 14:03:06.000000000","message":"Here we delete the instance in testcase level and breaks the shared instance (cls) and assume that test may run in a different order in some cases ... \n\nI think we can remove this testcase from this class to different one or keep the shared instance","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5819720af0665dd1b10fb6034e23e03d6733f3a0","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        self.client.resize_server(self.server_id, self.flavor_ref_alt)"},{"line_number":424,"context_line":"        # NOTE(zhufl): Explicitly delete the server to get a new one for later"},{"line_number":425,"context_line":"        # tests. Avoids resize down race issues."},{"line_number":426,"context_line":"        self.addCleanup(self.delete_server, self.server_id)"},{"line_number":427,"context_line":"        waiters.wait_for_server_status(self.client, self.server_id,"},{"line_number":428,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"910563e9_bcbacc96","line":426,"in_reply_to":"86ab2368_9246883a","updated":"2022-06-15 14:30:04.000000000","message":"the comment above the line explains why the server is deleted here, any testcase removal needs to be a separate review and is not related to this particular change.","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d35cd4381b7e020181098fd70d78fe0b09ef13e8","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        self.client.resize_server(self.server_id, self.flavor_ref_alt)"},{"line_number":456,"context_line":"        # Explicitly delete the server to get a new one for later"},{"line_number":457,"context_line":"        # tests. Avoids resize down race issues."},{"line_number":458,"context_line":"        self.addCleanup(self.delete_server, self.server_id)"},{"line_number":459,"context_line":"        waiters.wait_for_server_status("},{"line_number":460,"context_line":"            self.client, self.server_id, \u0027VERIFY_RESIZE\u0027)"},{"line_number":461,"context_line":"        # Now revert the resize which should move the instance and it\u0027s volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"71cd0d3b_1ed786f1","line":458,"updated":"2022-06-15 14:03:06.000000000","message":"Same here, why do we delete the shared instance , we can keep the same instance or move the tests  from here.","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5819720af0665dd1b10fb6034e23e03d6733f3a0","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        self.client.resize_server(self.server_id, self.flavor_ref_alt)"},{"line_number":456,"context_line":"        # Explicitly delete the server to get a new one for later"},{"line_number":457,"context_line":"        # tests. Avoids resize down race issues."},{"line_number":458,"context_line":"        self.addCleanup(self.delete_server, self.server_id)"},{"line_number":459,"context_line":"        waiters.wait_for_server_status("},{"line_number":460,"context_line":"            self.client, self.server_id, \u0027VERIFY_RESIZE\u0027)"},{"line_number":461,"context_line":"        # Now revert the resize which should move the instance and it\u0027s volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"706f0f49_e1427572","line":458,"in_reply_to":"71cd0d3b_1ed786f1","updated":"2022-06-15 14:30:04.000000000","message":"seems like the comment above this line explains that","commit_id":"34ea7e9e0420b96aff4a44b5f230413ca941939b"}]}