)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"03cb6220bf56d5a651195152bc905eaf86833703","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a680bea1_69efdca8","updated":"2022-08-06 15:38:06.000000000","message":"Tempest is not suitable place for the API negative tests when they can be added in unit or functional test at project side, https://docs.openstack.org/tempest/latest/HACKING.html#negative-tests","commit_id":"b07c328599d398c5fda012cfef357db6c13f8ac7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b413b0b3cb926cd3965279040fdf600abd524716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a32aa23_35a87151","updated":"2022-07-14 10:05:03.000000000","message":"the test is ok, so +1, I\u0027m just thinking whether this is something tempest should test, it\u0027s a very simple negative test (we can create practically infinite number of negative tests), wouldn\u0027t be this caught by openstack CLI client or GUI itself?","commit_id":"b07c328599d398c5fda012cfef357db6c13f8ac7"}],"tempest/api/volume/admin/test_volume_types_negative.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b413b0b3cb926cd3965279040fdf600abd524716","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        # New volume type details"},{"line_number":90,"context_line":"        name \u003d \u0027\u0027"},{"line_number":91,"context_line":"        description \u003d data_utils.rand_name(\"volume-type-description\")"},{"line_number":92,"context_line":"        is_public \u003d not volume_type[\u0027is_public\u0027]"},{"line_number":93,"context_line":"        # Updating volume type details with wrong parameters"},{"line_number":94,"context_line":"        kwargs \u003d {\u0027name\u0027: name,"},{"line_number":95,"context_line":"                  \u0027description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":4,"id":"27116913_f6b5612c","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":23},"updated":"2022-07-14 10:05:03.000000000","message":"just curious, is it safe to change the is_public value? I mean we wanna test that using empty name will fail, right now it seems we also test we can change the is_public attribute ...","commit_id":"b07c328599d398c5fda012cfef357db6c13f8ac7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5259817c1c661fda42eb16ff25411f1228b6702d","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        description \u003d data_utils.rand_name(\"volume-type-description\")"},{"line_number":92,"context_line":"        is_public \u003d not volume_type[\u0027is_public\u0027]"},{"line_number":93,"context_line":"        # Updating volume type details with wrong parameters"},{"line_number":94,"context_line":"        kwargs \u003d {\u0027name\u0027: name,"},{"line_number":95,"context_line":"                  \u0027description\u0027: description,"},{"line_number":96,"context_line":"                  \u0027is_public\u0027: is_public}"},{"line_number":97,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"dfe5b481_1ac1231e","line":94,"updated":"2022-06-20 07:38:31.000000000","message":"You dont need the \"name\" here , you can set \u0027\u0027 because you do not use it anymore ... or you can change the name to empty_name ...  \nlooks good to me","commit_id":"b07c328599d398c5fda012cfef357db6c13f8ac7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b413b0b3cb926cd3965279040fdf600abd524716","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        description \u003d data_utils.rand_name(\"volume-type-description\")"},{"line_number":92,"context_line":"        is_public \u003d not volume_type[\u0027is_public\u0027]"},{"line_number":93,"context_line":"        # Updating volume type details with wrong parameters"},{"line_number":94,"context_line":"        kwargs \u003d {\u0027name\u0027: name,"},{"line_number":95,"context_line":"                  \u0027description\u0027: description,"},{"line_number":96,"context_line":"                  \u0027is_public\u0027: is_public}"},{"line_number":97,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"d98d91fa_396350b6","line":94,"in_reply_to":"dfe5b481_1ac1231e","updated":"2022-07-14 10:05:03.000000000","message":"+1","commit_id":"b07c328599d398c5fda012cfef357db6c13f8ac7"}]}