)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d3127cc227b2b21776a89e2751c476e62ac451c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"057600a2_92fb5b5a","updated":"2022-06-17 14:39:31.000000000","message":"may be we can try with using class level validation resource.","commit_id":"d5d26ec07957be8efdc7d9d6390a33c85ec9e944"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7fc551e6a2e8672218d66521c9a8edc3d5cb18a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44f0ed3c_ef278efb","updated":"2022-06-17 12:06:43.000000000","message":"right, I didn\u0027t notice the job failure when i originally merged that, I\u0027m sorry for that, thanks gibi for proposing the revert","commit_id":"d5d26ec07957be8efdc7d9d6390a33c85ec9e944"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4581430f4d94937e2dfa7a72f39488c8a3b22da9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a09464d5_844e6525","updated":"2022-06-17 17:52:34.000000000","message":"fix is in gate, removing W to avoid conflict in gate in case this gets rechecked https://review.opendev.org/c/openstack/tempest/+/846345/3\n","commit_id":"56a0c5c7c814449dee6ab365f8208dfdb4e75ea3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"346a9d8cbd83bc3f6af0178f77e134b7c08047fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e8487171_f0b088db","updated":"2022-06-17 17:39:30.000000000","message":"fix is ready and can merge before this revert. https://review.opendev.org/c/openstack/tempest/+/846345/2","commit_id":"56a0c5c7c814449dee6ab365f8208dfdb4e75ea3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ea47e5f90e4098fefa645132e1062ec3846aa8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d282175_17968080","updated":"2022-06-17 14:47:08.000000000","message":"let\u0027s merge this and unblock the gate and try the fix in https://review.opendev.org/c/openstack/tempest/+/846345/1","commit_id":"56a0c5c7c814449dee6ab365f8208dfdb4e75ea3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6daced9a493bad77cf96c99628d93ccab9bb5796","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00601918_17cdb220","updated":"2022-06-20 15:17:19.000000000","message":"removing +2 as no revert is needed at the end, the patch which was about to be reverted here got fixed by https://review.opendev.org/c/openstack/tempest/+/846345","commit_id":"56a0c5c7c814449dee6ab365f8208dfdb4e75ea3"}],"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"27a2526ecc581afb7fa9717ed9c0e7020922cd80","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def setup_credentials(cls):"},{"line_number":104,"context_line":"        cls.prepare_instance_network()"},{"line_number":105,"context_line":"        super(LiveMigrationTest, cls).setup_credentials()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _test_live_migration(self, state\u003d\u0027ACTIVE\u0027, volume_backed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"56245c5c_6ac22d0f","side":"PARENT","line":104,"updated":"2022-06-17 12:24:11.000000000","message":"Shouldn\u0027t this be combined with overriding\n\ncreate_default_network \u003d False\n\nfrom the parent class?","commit_id":"00bdb22cc31db962986ca910a909c0a25b3f590f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3b150728d64a0c807aa9cb7120559e6b20c5120e","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def setup_credentials(cls):"},{"line_number":104,"context_line":"        cls.prepare_instance_network()"},{"line_number":105,"context_line":"        super(LiveMigrationTest, cls).setup_credentials()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _test_live_migration(self, state\u003d\u0027ACTIVE\u0027, volume_backed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f10595e9_d18f7212","side":"PARENT","line":104,"in_reply_to":"56245c5c_6ac22d0f","updated":"2022-06-17 14:50:55.000000000","message":"the parent has create_default_network \u003d True","commit_id":"00bdb22cc31db962986ca910a909c0a25b3f590f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d3127cc227b2b21776a89e2751c476e62ac451c","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        attach volume. This differs from test_volume_backed_live_migration"},{"line_number":183,"context_line":"        above that tests live-migration with only an attached volume."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":186,"context_line":"            self.os_primary)"},{"line_number":187,"context_line":"        server \u003d self.create_test_server("},{"line_number":188,"context_line":"            validatable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"67e3a541_a60e08dd","side":"PARENT","line":185,"updated":"2022-06-17 14:39:31.000000000","message":"I think we need to use the class level validation resource here instead of test because server is created/cleanup at class level.","commit_id":"00bdb22cc31db962986ca910a909c0a25b3f590f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3b150728d64a0c807aa9cb7120559e6b20c5120e","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        attach volume. This differs from test_volume_backed_live_migration"},{"line_number":183,"context_line":"        above that tests live-migration with only an attached volume."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":186,"context_line":"            self.os_primary)"},{"line_number":187,"context_line":"        server \u003d self.create_test_server("},{"line_number":188,"context_line":"            validatable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c019fca_cb59dcab","side":"PARENT","line":185,"in_reply_to":"67e3a541_a60e08dd","updated":"2022-06-17 14:50:55.000000000","message":"I will try in https://review.opendev.org/c/openstack/tempest/+/846345","commit_id":"00bdb22cc31db962986ca910a909c0a25b3f590f"}]}
