)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86c1c6b8e4b4cffea2078db428bcf40c65010361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"313ef34d_ab95d03b","updated":"2022-08-06 15:37:57.000000000","message":"Tempest is not suitable place for the API negative tests when they can be added in unit or functional test at project side, https://docs.openstack.org/tempest/latest/HACKING.html#negative-tests","commit_id":"0c55616869e83b4e6543996ffe2ddfec69be5106"}],"tempest/api/volume/admin/test_volume_types_negative.py":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"09b4c2219f2c18bca6c0af3e994add9d7d8e3f04","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":84,"context_line":"    @decorators.idempotent_id(\u00276c201b14-228b-4dd8-a91c-69dc04610af1\u0027)"},{"line_number":85,"context_line":"    def test_volume_type_update_error_is_public(self):"},{"line_number":86,"context_line":"        \"\"\"Test update volume type details with wrong is_public\"\"\""},{"line_number":87,"context_line":"        # Create volume type"},{"line_number":88,"context_line":"        volume_type \u003d self.create_volume_type()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fc00f4a_f78170cf","line":85,"updated":"2022-07-13 13:28:40.000000000","message":"Can you clarify why do we require this test to be added in tempest?","commit_id":"0c55616869e83b4e6543996ffe2ddfec69be5106"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"791b6394fa0cc5ee0c637b93338bff62bb5e70ca","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":84,"context_line":"    @decorators.idempotent_id(\u00276c201b14-228b-4dd8-a91c-69dc04610af1\u0027)"},{"line_number":85,"context_line":"    def test_volume_type_update_error_is_public(self):"},{"line_number":86,"context_line":"        \"\"\"Test update volume type details with wrong is_public\"\"\""},{"line_number":87,"context_line":"        # Create volume type"},{"line_number":88,"context_line":"        volume_type \u003d self.create_volume_type()"}],"source_content_type":"text/x-python","patch_set":1,"id":"61b7d354_a799f1cf","line":85,"in_reply_to":"9fc00f4a_f78170cf","updated":"2022-07-14 10:08:01.000000000","message":"just to expand on this, this is a very simple negative test and as we can practically create an infinite number of negative tests, we should be always asking whether a new negative test has a value / whether it makes sense to have it in tempest \n\njust curious, wouldn\u0027t be this type of an error (user passing semantically incorrect value for the is_public attribute) caught by openstack CLI client or GUI itself?","commit_id":"0c55616869e83b4e6543996ffe2ddfec69be5106"}]}