)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"4bd601986274462684dd23f9991e798f77161dbc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    @tempest.test.ignore_client_errors([\u0027servers_client\u0027])"},{"line_number":137,"context_line":"    def clear_servers(cls):"},{"line_number":138,"context_line":"        for server in cls.servers:"},{"line_number":139,"context_line":"            cls.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":140,"context_line":"        for server in cls.servers:"},{"line_number":141,"context_line":"            cls.servers_client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_aed6a3ef","line":139,"updated":"2014-06-16 17:39:16.000000000","message":"If the first server deletion fails, the others even will not be tread.\nIt can means mass resource leakage.","commit_id":"2b1547921a7d92f4d1b2706f1050ff447ebdafd8"}],"tempest/common/rest_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"502b7c1031911e268234321d7c7d003304707e25","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        if resp.status \u003c 400:"},{"line_number":482,"context_line":"            return"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        if self.no_error_check:"},{"line_number":485,"context_line":"            self.LOG.warn("},{"line_number":486,"context_line":"                \u0027Request failed (but ignored) (%s): %s %s %s\u0027 % ("},{"line_number":487,"context_line":"                    self._find_caller(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9nHg%3D","line":484,"updated":"2014-04-03 11:23:01.000000000","message":"I think this logs resp.status\u003d\u003d404. The behaviour is not occurred in original code. So we got the several warnings: http://logs.openstack.org/45/84645/3/check/check-tempest-dsvm-full/cc5ff16/logs/tempest.txt.gz?level\u003dWARNING .\nCan we check resp.status\u003d\u003d404 for just returning(not logging) here?","commit_id":"8d3ff0a3bc9414166b585297687fd7465650bfef"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1b8326a6851750dbead77b93002d3caca0e475ec","unresolved":false,"context_lines":[{"line_number":40,"context_line":"HTTP_SUCCESS \u003d (200, 201, 202, 203, 204, 205, 206)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def need_error_check(f):"},{"line_number":44,"context_line":"    \"\"\"This flags a client function that it\u0027s mandatory to have an error check"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    @functools.wraps(f)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_6ac43e92","line":43,"updated":"2014-06-10 17:59:51.000000000","message":"Perhaps this should be in test.py like the other decorators?","commit_id":"2b1547921a7d92f4d1b2706f1050ff447ebdafd8"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1b8326a6851750dbead77b93002d3caca0e475ec","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        if resp.status \u003c 400:"},{"line_number":460,"context_line":"            return"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if self.no_error_check:"},{"line_number":463,"context_line":"            if resp.status \u003d\u003d 404:"},{"line_number":464,"context_line":"                return"},{"line_number":465,"context_line":"            self._log_request(method, req_url\u003durl, resp\u003dresp,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_f92f4e3c","line":462,"updated":"2014-06-10 17:59:51.000000000","message":"perhaps \"tolerate_http_errors\" would be more descriptive?","commit_id":"2b1547921a7d92f4d1b2706f1050ff447ebdafd8"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1b8326a6851750dbead77b93002d3caca0e475ec","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            return"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if self.no_error_check:"},{"line_number":463,"context_line":"            if resp.status \u003d\u003d 404:"},{"line_number":464,"context_line":"                return"},{"line_number":465,"context_line":"            self._log_request(method, req_url\u003durl, resp\u003dresp,"},{"line_number":466,"context_line":"                              req_headers\u003dheaders, req_body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_206fbfc6","line":463,"updated":"2014-06-10 17:59:51.000000000","message":"You defined this logic in the rest_client, as a generic mechanism to turn error checking / exception raising on and off, so I think an hard-coded 404 doesn\u0027t fit here.\n\nI would log a message (info?) saying that error code X was ignored.","commit_id":"2b1547921a7d92f4d1b2706f1050ff447ebdafd8"}],"tempest/test.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5a52f03d391e8f2bebec5ea4e1e10c720348f1f8","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        @functools.wraps(f)"},{"line_number":90,"context_line":"        def wrapper(cls, *func_args, **func_kwargs):"},{"line_number":91,"context_line":"            set_no_error_check_flag(cls, clients, True)"},{"line_number":92,"context_line":"            result \u003d f(cls)"},{"line_number":93,"context_line":"            set_no_error_check_flag(cls, clients, False)"},{"line_number":94,"context_line":"            return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9xtg%3D","line":91,"updated":"2014-04-02 08:04:29.000000000","message":"\"try: ... except\" seems necessary for ignoring a client error.","commit_id":"6b2b661bee517708bf212c11edbd5637741a123b"}]}