)]}'
{"tempest/api/orchestration/base.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"5babc483a80797542b3bf6082272afbe91dc3ccc","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def get_stack_output(self, stack_identifier, output_key):"},{"line_number":142,"context_line":"        resp, body \u003d self.client.get_stack(stack_identifier)"},{"line_number":143,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":144,"context_line":"        return self.stack_output(body, output_key)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FFWA%3D","line":144,"updated":"2014-04-24 06:23:19.000000000","message":"For me there is an assert missing. If the given output_key does not exist stack_output returns \"None\". I think an additional assert if the key really exist would make sense.","commit_id":"6cb2a23bfe3a98f3c89e507375985134535d169e"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"a169b2c585223794ab15bd24333f381e7116429f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def get_stack_output(self, stack_identifier, output_key):"},{"line_number":142,"context_line":"        resp, body \u003d self.client.get_stack(stack_identifier)"},{"line_number":143,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":144,"context_line":"        return self.stack_output(body, output_key)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCwI%3D","line":144,"in_reply_to":"AAAAXH%2F%2FFWA%3D","updated":"2014-04-24 12:48:20.000000000","message":"Hmm, I think that is actually an issue with stack_output, we need to assert if an output_key is requested which doesn\u0027t exist in stack[\u0027outputs\u0027], but we should not assert if the key exists and the output_value is actually None (that is a valid value which should be evaluated and if necessary asserted on in the test itself)\n\nI can modify that in this patch, but if it\u0027s changing the behavior of existing code, should I propose it as a follow-up patch?","commit_id":"6cb2a23bfe3a98f3c89e507375985134535d169e"}]}