)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"75a83c44b9ffe1b8c41ac2a4753501ebf55a0608","unresolved":true,"context_lines":[{"line_number":14,"context_line":"bug 1980255. This patch starts doing that."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I05e079237aec332925a88476e45071b34dc722c6"},{"line_number":17,"context_line":"Closes-bug: 1980255"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bd866c93_c94b1a62","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":19},"updated":"2022-07-13 12:25:27.000000000","message":"-1 for this since\nthise really should be Related-Bug:\n\nif you use the neutron api closes woudl be fine but tempest should ideally avoid using the proxy apis in nova in thest that are not explcitly testing the proxy apis.\n\nso nova proxy apis for neutron shoudl be avoided in the senario tests.","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"aae92ca079c2af8b47127fa4206a8f7db5da0d9e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"bug 1980255. This patch starts doing that."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I05e079237aec332925a88476e45071b34dc722c6"},{"line_number":17,"context_line":"Closes-bug: 1980255"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"18a8ec56_4a67361b","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":19},"in_reply_to":"bd866c93_c94b1a62","updated":"2022-07-13 19:46:18.000000000","message":"I\u0027ve changed it to Related-bug, but at least in Nova\u0027s api-ref for the \u0027show server details\u0027 API that tempest is hitting to assert that the floating IP has been associated correctly [1], I can find no mention of the deprecation of server[\u0027addresses\u0027].\n\nI\u0027m not against changing Tempest to stop using that field if it\u0027s really deprecated, but:\n\n1. That smells like a big chunk of work\n2. Nova would have to properly mark is as deprecated, like we did for the image, interfaces, volumes etc proxy APIs.\n\n[1] https://docs.openstack.org/api-ref/compute/?expanded\u003dshow-server-details-detail#show-server-details","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"75a83c44b9ffe1b8c41ac2a4753501ebf55a0608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e7a147b_29123992","updated":"2022-07-13 12:25:27.000000000","message":"this ","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"30eb0bfe7219af0fe09a204dda4fe4e81f40b59f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e3bbf72_00ef36c5","updated":"2022-07-18 15:19:09.000000000","message":"Based on my testing on tripleo-ci jobs:\nhttps://review.opendev.org/c/openstack/tripleo-ci/+/850156/1#message-977af8b73a09f8b161a4fb408cab2aec369b8369\n\nhere are the results:\nhttps://d3e2fe24de71030ee8aa-add3baf7d164319a1fbb45a2e58a56e9.ssl.cf5.rackcdn.com/850156/1/check/tripleo-ci-centos-9-standalone/1d100da/logs/undercloud/var/log/tempest/tempest_run.log\n\n```\n{0} tempest.scenario.test_minimum_basic.TestMinimumBasicScenario.test_minimum_basic_instance_hard_reboot_after_vol_snap_deletion [104.413968s] ... ok\n```\n\nand\n\nhttps://4dd0377b7a30aa622b30-38e6ee403788ae1bf863236e5a7d9ac3.ssl.cf5.rackcdn.com/850156/1/check/tripleo-ci-centos-9-standalone-fips/3409145/logs/undercloud/var/log/tempest/tempest_run.log\n\n```\n{0} tempest.scenario.test_minimum_basic.TestMinimumBasicScenario.test_minimum_basic_instance_hard_reboot_after_vol_snap_deletion [132.275445s] ... ok\n```\nWe can merge this change.","commit_id":"719242d27e72c3e5afd700eb75ab65b875d764e8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a1c38f8b795ad3d7258707e97a38b8b9c075ea2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73bfef8e_8675efc9","updated":"2022-07-15 14:28:00.000000000","message":"I think it is good, and later we can add a method to use Neutron API for FIP check","commit_id":"719242d27e72c3e5afd700eb75ab65b875d764e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84b8c959ed1f22d9548f0536e1fb2bcd0b509b1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c81f474_1be6d1a2","updated":"2022-07-15 14:40:18.000000000","message":"sure this can be improved later but i jsut want to be clear that\nif a floating ip is reported form nova api as associated with the vm its\nhas no baring on if that floating ip can be used to connect to the vm.\n\nnova just provides a cached view on the data stored in the neutron db.\nneutron is the only source of truth for floating ip to fixed ip mapping.","commit_id":"719242d27e72c3e5afd700eb75ab65b875d764e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"625849e99ef3e07b0c3b006454ce91b98b692354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9b8a37d_1998a957","updated":"2022-07-25 19:00:53.000000000","message":"Let\u0027s merge to fix the issue, it\u0027s basically the same what we\u0027ve done for this other test in https://review.opendev.org/c/openstack/tempest/+/811191","commit_id":"3f7c50cc3eb51d40205f990adb9103cac6a19efa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4abfea427c2fa33cb29325f3feed3268285c8515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8434cbca_e12db46d","updated":"2022-07-25 11:49:09.000000000","message":"lgtm, thanks","commit_id":"3f7c50cc3eb51d40205f990adb9103cac6a19efa"}],"tempest/scenario/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"75a83c44b9ffe1b8c41ac2a4753501ebf55a0608","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":1049,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":1050,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":1051,"context_line":"        waiters.wait_for_server_floating_ip(self.servers_client, server,"},{"line_number":1052,"context_line":"                                            floating_ip)"},{"line_number":1053,"context_line":"        return floating_ip"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def disassociate_floating_ip(self, floating_ip):"}],"source_content_type":"text/x-python","patch_set":1,"id":"51684d98_56b7806e","line":1052,"range":{"start_line":1051,"start_character":8,"end_line":1052,"end_character":56},"updated":"2022-07-13 12:25:27.000000000","message":"a better fix would be to actully call neutron to get this info isntead of useing the deprecated proxy apis in nova.","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5445772c8af5ef744c87e1cad364821afc13b805","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":1049,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":1050,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":1051,"context_line":"        waiters.wait_for_server_floating_ip(self.servers_client, server,"},{"line_number":1052,"context_line":"                                            floating_ip)"},{"line_number":1053,"context_line":"        return floating_ip"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def disassociate_floating_ip(self, floating_ip):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc02aad4_3f146030","line":1052,"range":{"start_line":1051,"start_character":8,"end_line":1052,"end_character":56},"in_reply_to":"3db28ac5_ccbd5fb3","updated":"2022-07-21 12:39:03.000000000","message":"If I understand it correctly it might happen that the wait_for_server_floating_ip() function can end successfully even though the floating IP is not fully associated with a port? \n\nI am not sure how important this is but if this is true, it sounds to me like the wait_for_server_floating_ip() needs to be fixed.","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc4ce34b575e2edbbbfd83aac062819c9cea3cc8","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":1049,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":1050,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":1051,"context_line":"        waiters.wait_for_server_floating_ip(self.servers_client, server,"},{"line_number":1052,"context_line":"                                            floating_ip)"},{"line_number":1053,"context_line":"        return floating_ip"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def disassociate_floating_ip(self, floating_ip):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f086859f_2d21e19a","line":1052,"range":{"start_line":1051,"start_character":8,"end_line":1052,"end_character":56},"in_reply_to":"51684d98_56b7806e","updated":"2022-07-15 14:26:27.000000000","message":"Would be good but I don\u0027t think that Neutron API can give back this information, I mean that a FIP is used by a VM, or it would be something like this:\n* Check the server uuid\n* Get the FIP which has the port_details[\u0027device_id\u0027] as the server uuid\n* Check the FIP floating_ip_address\n* Check the FIP port_details[\u0027status\u0027] \u003d ACTIVE\n\nAfter thinking on it perhaps not much more steps than what we have now in wait_for_server_floating_ip","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ca99ee47e809acaef98cc282b2955d0c9ef70191","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":1049,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":1050,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":1051,"context_line":"        waiters.wait_for_server_floating_ip(self.servers_client, server,"},{"line_number":1052,"context_line":"                                            floating_ip)"},{"line_number":1053,"context_line":"        return floating_ip"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def disassociate_floating_ip(self, floating_ip):"}],"source_content_type":"text/x-python","patch_set":1,"id":"43646c31_625a5c52","line":1052,"range":{"start_line":1051,"start_character":8,"end_line":1052,"end_character":56},"in_reply_to":"cc02aad4_3f146030","updated":"2022-07-26 15:21:41.000000000","message":"seems like it could be a good improvement of the waiter - to check the above mentioned association of an FIP with the port.","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84b8c959ed1f22d9548f0536e1fb2bcd0b509b1f","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":1049,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":1050,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":1051,"context_line":"        waiters.wait_for_server_floating_ip(self.servers_client, server,"},{"line_number":1052,"context_line":"                                            floating_ip)"},{"line_number":1053,"context_line":"        return floating_ip"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def disassociate_floating_ip(self, floating_ip):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3db28ac5_ccbd5fb3","line":1052,"range":{"start_line":1051,"start_character":8,"end_line":1052,"end_character":56},"in_reply_to":"f086859f_2d21e19a","updated":"2022-07-15 14:40:18.000000000","message":"nova is getting its floating IP info from neutron.\nthe associations are stored in the neutron DB and we\ncache that info in nova network_info_cache as part of the fixed IP object\nhttps://github.com/openstack/nova/blob/master/nova/network/model.py#L261-L262\u003d\n\nbut that cache and take multiple minutes to update passive or will be actively rebuild only after we receive a network-vif changed event from neutron.\n\nso neutron is the source of truth for fip info.\n\nall you have to check is that the floating IP is associated with a neutron port\n\nwhen a floating IP is reported vai nova api that does not provide any gurarentee that that floating ip is assocated with the port at the dataplane level.\n\nneutron notifies nova of the accoration fo the floating ip with the port/fixed ip when the ascoiated is done in the db not after its set up in the set up in the dataplane. so there is not added value in retriving this info form nova instead of driectly form neutron.","commit_id":"39e60fd7ff54d430b9f68bb828adc43d10134438"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d967aa29dfdf05464b957cf89255b67967a5fc8d","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":1049,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":1050,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":1051,"context_line":"        waiters.wait_for_server_floating_ip(self.servers_client, server,"},{"line_number":1052,"context_line":"                                            floating_ip)"},{"line_number":1053,"context_line":"        return floating_ip"},{"line_number":1054,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cdaa2122_ce4e47c9","line":1051,"range":{"start_line":1051,"start_character":8,"end_line":1051,"end_character":43},"updated":"2022-07-21 12:01:36.000000000","message":"if we add this here, then test_minimum_basic_scenario test will call this waiter twice - once as part of this method and once right after it - see https://opendev.org/openstack/tempest/src/commit/97be23ea6402649652991983f3f2b85873eba4d8/tempest/scenario/test_minimum_basic.py#L144-L147\n\nWe should either remove the first wait_for_server_floating_ip call (right after calling associate_floating_ip) from the test_minimum_basic_scenario test or put this waiter directly to the test_minimum_basic_instance_hard_reboot_after_vol_snap_deletion test instead.\n\nI\u0027m for option 2 (putting the waiter to the test_minimum_basic_instance_hard_reboot_after_vol_snap_deletion test) as associate_floating_ip is called from multiple different tests (maybe even plugins) and waiting for the floating ip is not always required, why prolong the execution by waiting for the ip then?","commit_id":"719242d27e72c3e5afd700eb75ab65b875d764e8"}]}