)]}'
{"tempest/api/identity/admin/v3/test_endpoints.py":[{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        region \u003d data_utils.rand_name(\u0027region\u0027)"},{"line_number":137,"context_line":"        url \u003d data_utils.rand_name(\u0027url\u0027)"},{"line_number":138,"context_line":"        interface \u003d \u0027public\u0027"},{"line_number":139,"context_line":"        #create a service"},{"line_number":140,"context_line":"        s_name \u003d data_utils.rand_name(\u0027service-\u0027)"},{"line_number":141,"context_line":"        s_type \u003d data_utils.rand_name(\u0027type--\u0027)"},{"line_number":142,"context_line":"        s_description \u003d data_utils.rand_name(\u0027description-\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F%2B%2FU%3D","line":139,"updated":"2014-04-08 05:03:34.000000000","message":"Give a space after # in the comment","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                                               description\u003ds_description)"},{"line_number":146,"context_line":"        service1_id \u003d service1[\u0027id\u0027]"},{"line_number":147,"context_line":"        self.service_ids.append(service1_id)"},{"line_number":148,"context_line":"        #create an endpoint"},{"line_number":149,"context_line":"        resp, endpoint1 \u003d\\"},{"line_number":150,"context_line":"            self.client.create_endpoint(service1_id, interface,"},{"line_number":151,"context_line":"                                        url, region\u003dregion,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F%2B9g%3D","line":148,"updated":"2014-04-08 05:03:34.000000000","message":"Give a space after # in the comment","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.client.create_endpoint(service1_id, interface,"},{"line_number":151,"context_line":"                                        url, region\u003dregion,"},{"line_number":152,"context_line":"                                        enabled\u003dTrue)"},{"line_number":153,"context_line":"        self.addCleanup(self.client.delete_endpoint, endpoint1[\u0027id\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027201\u0027)"},{"line_number":155,"context_line":"        resp, endpoint \u003d self.client.get_endpoint({\u0027service_id\u0027: service1_id})"},{"line_number":156,"context_line":"        self.assertNotIn(self.service_id, map(lambda x: x[\u0027service_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F%2B%2Bk%3D","line":153,"updated":"2014-04-08 05:03:34.000000000","message":"Need not assert response status of create endpoint. so please remove below assert statement.","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                        url, region\u003dregion,"},{"line_number":152,"context_line":"                                        enabled\u003dTrue)"},{"line_number":153,"context_line":"        self.addCleanup(self.client.delete_endpoint, endpoint1[\u0027id\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027201\u0027)"},{"line_number":155,"context_line":"        resp, endpoint \u003d self.client.get_endpoint({\u0027service_id\u0027: service1_id})"},{"line_number":156,"context_line":"        self.assertNotIn(self.service_id, map(lambda x: x[\u0027service_id\u0027],"},{"line_number":157,"context_line":"                                              endpoint))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F%2B64%3D","line":154,"updated":"2014-04-08 05:03:34.000000000","message":"change the variable name to \u0027endpoints\u0027 instead of \u0027endpoint\u0027 as we generally use plural form for LIST calls.","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                        enabled\u003dTrue)"},{"line_number":153,"context_line":"        self.addCleanup(self.client.delete_endpoint, endpoint1[\u0027id\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027201\u0027)"},{"line_number":155,"context_line":"        resp, endpoint \u003d self.client.get_endpoint({\u0027service_id\u0027: service1_id})"},{"line_number":156,"context_line":"        self.assertNotIn(self.service_id, map(lambda x: x[\u0027service_id\u0027],"},{"line_number":157,"context_line":"                                              endpoint))"},{"line_number":158,"context_line":"        self.assertIn(service1_id, map(lambda x: x[\u0027service_id\u0027], endpoint))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F%2B90%3D","line":155,"updated":"2014-04-08 05:03:34.000000000","message":"Add assert of response status for this list call. Also use the existing method \"list_endpoints\" instead of \"get_endpoint\".","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"}],"tempest/services/identity/v3/json/endpoints_client.py":[{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        resp, body \u003d self.get(\u0027endpoints\u0027)"},{"line_number":35,"context_line":"        body \u003d json.loads(body)"},{"line_number":36,"context_line":"        return resp, body[\u0027endpoints\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_endpoint(self, params\u003dNone):"},{"line_number":39,"context_line":"        url \u003d \u0027endpoints\u0027"},{"line_number":40,"context_line":"        if params:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9RBA%3D","line":37,"updated":"2014-04-08 05:03:34.000000000","message":"Hi Meera,\n\nA new method is not required to add params for listing. The existing list_endpoints can be modified as follows:\n\ndef list_endpoints(self, params\u003dNone):\n    url \u003d \u0027endpoints\u0027\n    if params:\n        url +\u003d \u0027?%s\u0027 % urllib.urlencode(params)\n    resp, body \u003d self.get(url)\n    body \u003d json.loads(body)\n    return resp, body[\u0027endpoints\u0027]\n\nparams would be passed if test cases passes the argument. Else onlu url \"endpoints\" would be sent.\nIf the list_endpoints method is modified as mentioned here, you may use list_endpoints instead of get_endpoint in the test case.","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c14eb0c887699d6db3baa98645af51199e3a2ffd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"from tempest.common import rest_client"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2Fx%2Fg%3D","line":19,"updated":"2014-04-10 13:11:37.000000000","message":"I think urllib is stdlib. So I think this should be \n import json\n import urllib\n \n from tempest.common import rest_client\n from tempest import config\n\nPlease see http://docs.openstack.org/developer/hacking/#imports","commit_id":"cea6b0ae1ab51304d539f39777e808e2ad9604e1"},{"author":{"_account_id":2846,"name":"meera-belur","email":"meera.belur@suse.com","username":"meera-belur"},"change_message_id":"839e9e9551550726e809caf7e4a4bcd2108fd1bd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"from tempest.common import rest_client"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FvzY%3D","line":19,"in_reply_to":"AAAAW3%2F%2Fx%2Fg%3D","updated":"2014-04-10 16:59:58.000000000","message":"Hi Masayuki,\nI had the imports ordered  as suggested in your feedback but when I ran it through tox utility:\n./tempest/services/identity/v3/json/endpoints_client.py:18:1: H306  imports not in alphabetical order (urllib, tempest.common.rest_client)\nfrom tempest.common import rest_client\n^\nWith the original import order, tox runs fine.\nRegards,\nMeera","commit_id":"cea6b0ae1ab51304d539f39777e808e2ad9604e1"}],"tempest/services/identity/v3/xml/endpoints_client.py":[{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"faa406e4f1760fbbef2c09923747f277de7b1620","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        resp, body \u003d self.get(\"endpoints\")"},{"line_number":63,"context_line":"        body \u003d self._parse_array(etree.fromstring(body))"},{"line_number":64,"context_line":"        return resp, body"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_endpoint(self, params\u003dNone):"},{"line_number":67,"context_line":"        url \u003d \u0027endpoints\u0027"},{"line_number":68,"context_line":"        if params:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9Q%2B4%3D","line":65,"updated":"2014-04-08 05:03:34.000000000","message":"Ditto as mentioned in json endpoints_client.py","commit_id":"2dc69f3f2598ab36e403ed1fe183ff310a61caca"}]}