)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"4c3bc9313b6fc7cf88a381c7031ba44610a81586","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{"},{"line_number":20,"context_line":"    \"adminPass\": \"%(password)s\""},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The response body of rescue server V3 APIs is below:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_f83c9fe4","line":22,"updated":"2014-06-03 08:00:19.000000000","message":"For both the v2 and v3 apis this is actually dependent on CONF.enable_instance_password (in Nova). So I guess we\u0027ll need a corresponding conf flag on tempest so it can be configured dependent on how the Nova it is testing is configured","commit_id":"d6e7612f39059dc4573695937d81f1c1593bd7b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ab9ff6f0b85f87b2bf8f266078cf98ff8afe70c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{"},{"line_number":20,"context_line":"    \"adminPass\": \"%(password)s\""},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The response body of rescue server V3 APIs is below:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_06f809e4","line":22,"in_reply_to":"1ae5cdf2_f83c9fe4","updated":"2014-06-03 09:56:41.000000000","message":"Yes, I will update this also according to decision on https://review.openstack.org/#/c/95409/1/\n\nI saw in Nova V2 API it is being returned irrespective of CONF.enable_instance_password. (may be bug :))\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/rescue.py#L82","commit_id":"d6e7612f39059dc4573695937d81f1c1593bd7b5"}],"tempest/services/compute/json/servers_client.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"c4d61d191a9c966d2245dc28bcc732c2f317961f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            # supposed to validate their response."},{"line_number":212,"context_line":"            if schema is not None:"},{"line_number":213,"context_line":"                self.validate_response(schema, resp, body)"},{"line_number":214,"context_line":"            body \u003d body[response_key]"},{"line_number":215,"context_line":"        return resp, body"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def create_backup(self, server_id, backup_type, rotation, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9U7A%3D","line":214,"updated":"2014-04-07 01:48:56.000000000","message":"This patch will need a rebase this same change here is in https://review.openstack.org/#/c/84636/","commit_id":"ce31e551e9d1112614fa67fa04bbc7060b559863"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"897d7efb13406a329606036834212999157cd238","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            # supposed to validate their response."},{"line_number":212,"context_line":"            if schema is not None:"},{"line_number":213,"context_line":"                self.validate_response(schema, resp, body)"},{"line_number":214,"context_line":"            body \u003d body[response_key]"},{"line_number":215,"context_line":"        return resp, body"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def create_backup(self, server_id, backup_type, rotation, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9UkY%3D","line":214,"in_reply_to":"AAAAWH%2F9U7A%3D","updated":"2014-04-07 04:45:32.000000000","message":"Yes, I will rebase once VNC patch is merged.","commit_id":"ce31e551e9d1112614fa67fa04bbc7060b559863"}],"tempest/services/compute/v3/json/servers_client.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"f40422049e87359065ea10285dddc1df09a86d57","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        post_body \u003d json.dumps({action_name: kwargs})"},{"line_number":203,"context_line":"        resp, body \u003d self.post(\u0027servers/%s/action\u0027 % str(server_id),"},{"line_number":204,"context_line":"                               post_body)"},{"line_number":205,"context_line":"        if response_key is not None:"},{"line_number":206,"context_line":"            body \u003d json.loads(body)[response_key]"},{"line_number":207,"context_line":"        return resp, body"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FHvM%3D","side":"PARENT","line":205,"updated":"2014-04-23 21:04:53.000000000","message":"Because you may be passing response_key as not None, this change is not just adding validation but is also changing the value of \u0027body\u0027 returned from the call. If that is intended then the commit message should say so. At present this does not cause a failure because none of the callers of this function are using the returned body value.","commit_id":"1da029e32bc79a8e516260a0a17414da7196c592"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c629e35e0a4076549f8440c63af4bc4edc77d2f0","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        post_body \u003d json.dumps({action_name: kwargs})"},{"line_number":203,"context_line":"        resp, body \u003d self.post(\u0027servers/%s/action\u0027 % str(server_id),"},{"line_number":204,"context_line":"                               post_body)"},{"line_number":205,"context_line":"        if response_key is not None:"},{"line_number":206,"context_line":"            body \u003d json.loads(body)[response_key]"},{"line_number":207,"context_line":"        return resp, body"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FGkc%3D","side":"PARENT","line":205,"in_reply_to":"AAAAXH%2F%2FHvM%3D","updated":"2014-04-24 01:19:06.000000000","message":"Thanks David for review.\nYes rescue_server() return value is being changed by this changes and that is intended (same way as other server actions return the wrapped object). I will mention that in commit msg.","commit_id":"1da029e32bc79a8e516260a0a17414da7196c592"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"087801d1913b3188ba8214a577c05d58fd12ebdc","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                               post_body)"},{"line_number":207,"context_line":"        if response_key is not None:"},{"line_number":208,"context_line":"            body \u003d json.loads(body)[response_key]"},{"line_number":209,"context_line":"        return resp, body"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def create_backup(self, server_id, backup_type, rotation, name):"},{"line_number":212,"context_line":"        \"\"\"Backup a server instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_84bc6d6e","side":"PARENT","line":209,"updated":"2014-04-30 20:22:33.000000000","message":"Looking at the general code around here it seems that if the caller of the \u0027action\u0027 method does not supply \u0027response_key\u0027, then there is no response. So this code should validate that. I think v2 has the same problem.","commit_id":"0f500811ac37c09f9848ffade6ffe7589ddd071f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24bb649884e1eb7558d5ed2b4ab241b92b4fd256","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                               post_body)"},{"line_number":207,"context_line":"        if response_key is not None:"},{"line_number":208,"context_line":"            body \u003d json.loads(body)[response_key]"},{"line_number":209,"context_line":"        return resp, body"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def create_backup(self, server_id, backup_type, rotation, name):"},{"line_number":212,"context_line":"        \"\"\"Backup a server instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_003c36c7","side":"PARENT","line":209,"in_reply_to":"9ad9bd40_84bc6d6e","updated":"2014-05-07 01:54:51.000000000","message":"Yes, that is in review - https://review.openstack.org/#/c/84380/. I will rebase once that is merged which will make this patch more clear.","commit_id":"0f500811ac37c09f9848ffade6ffe7589ddd071f"}]}