)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bd225b704e103ed100569bad7a5cca1ed8511def","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add possibility to passes client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the use of admin client into manager, this patch"},{"line_number":10,"context_line":"adds the possibility of tests specify which client to be used,"},{"line_number":11,"context_line":"adding the clients option into the signature of the functions."},{"line_number":12,"context_line":"If no client is passed, it will use the admin client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"12a94a2f_4d2eb15b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":55},"updated":"2022-09-16 04:51:41.000000000","message":"this need more clarification, how and why we need to remove. I do not think we can remove the admin dependency from scenario manager as many operations are done in scenario testing are at admin level. For example delete volume type - https://github.com/openstack/cinder/blob/cbc5ecba70d96008d61455dcf38099c9c146daf9/cinder/policies/volume_type.py#L120\n\nAlso, you are not removing the admin usage instead giving option to pass admin client in function.","commit_id":"196c86d7b9de1bc331f42952a08ff8dc1e771fe2"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"a167c4f5de0cd233c149bcbff09cc90f9f8d6367","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add possibility to passes client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the use of admin client into manager, this patch"},{"line_number":10,"context_line":"adds the possibility of tests specify which client to be used,"},{"line_number":11,"context_line":"adding the clients option into the signature of the functions."},{"line_number":12,"context_line":"If no client is passed, it will use the admin client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7bed532e_7083e411","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":55},"in_reply_to":"12a94a2f_4d2eb15b","updated":"2022-09-19 08:11:49.000000000","message":"Thanks, I update the commit message to say in order to avoid unnecessary use of admin client.","commit_id":"196c86d7b9de1bc331f42952a08ff8dc1e771fe2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3574a6d615623a779ecafa09f44f0c84b6b6aabe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-19 10:10:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add possibility to passes service client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the unnecessary use of admin client into manager,"},{"line_number":10,"context_line":"this patch adds the possibility of tests specify which client to be used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1277a549_7be5754d","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"updated":"2022-09-30 12:59:38.000000000","message":"nit:ability","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3574a6d615623a779ecafa09f44f0c84b6b6aabe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-19 10:10:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add possibility to passes service client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the unnecessary use of admin client into manager,"},{"line_number":10,"context_line":"this patch adds the possibility of tests specify which client to be used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"eefc8d9f_24489a3b","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":25},"updated":"2022-09-30 12:59:38.000000000","message":"nit:pass","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7d8d2ff63504254aa00e800584a2a20ba57a1f81","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-19 10:10:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add possibility to passes service client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the unnecessary use of admin client into manager,"},{"line_number":10,"context_line":"this patch adds the possibility of tests specify which client to be used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"a40db47e_b72de3a0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"in_reply_to":"1277a549_7be5754d","updated":"2022-10-19 09:06:29.000000000","message":"Done","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7d8d2ff63504254aa00e800584a2a20ba57a1f81","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-19 10:10:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add possibility to passes service client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the unnecessary use of admin client into manager,"},{"line_number":10,"context_line":"this patch adds the possibility of tests specify which client to be used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"b49bb37a_1e0a881c","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":25},"in_reply_to":"eefc8d9f_24489a3b","updated":"2022-10-19 09:06:29.000000000","message":"Done","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3574a6d615623a779ecafa09f44f0c84b6b6aabe","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add possibility to passes service client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the unnecessary use of admin client into manager,"},{"line_number":10,"context_line":"this patch adds the possibility of tests specify which client to be used."},{"line_number":11,"context_line":"If no client is passed to the manager, it will use the default admin client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic838fe18ccd1aa1658a3c972148534c11c8c71da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"73011471_c9b4c594","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":73},"updated":"2022-09-30 12:59:38.000000000","message":"maybe something along these lines? \"allows tests to specify which client to use.\"","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7d8d2ff63504254aa00e800584a2a20ba57a1f81","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add possibility to passes service client in manager.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid the unnecessary use of admin client into manager,"},{"line_number":10,"context_line":"this patch adds the possibility of tests specify which client to be used."},{"line_number":11,"context_line":"If no client is passed to the manager, it will use the default admin client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic838fe18ccd1aa1658a3c972148534c11c8c71da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"f4fe3b55_6bc35659","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":73},"in_reply_to":"73011471_c9b4c594","updated":"2022-10-19 09:06:29.000000000","message":"Done","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9b926301920bf7bbffb885d4493fb84bce81525c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7ac7fe56_a4928a00","updated":"2022-08-15 11:47:55.000000000","message":"Can you share more info ?  why do you remove the admin client ? ","commit_id":"7e9dc8daa8abb5022706187799d173bc008b641b"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"0002af6dfd63cd18d2da8f6c55851e42eca47dec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"64f2527d_3b359273","updated":"2022-09-14 14:22:35.000000000","message":"recheck","commit_id":"196c86d7b9de1bc331f42952a08ff8dc1e771fe2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3574a6d615623a779ecafa09f44f0c84b6b6aabe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"46d8c4eb_05c466ce","updated":"2022-09-30 12:59:38.000000000","message":"lgtm, what would be the next step? this allows tests to use a client of their choice, however, it doesn\u0027t decrease use of admin clients, yet","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7d8d2ff63504254aa00e800584a2a20ba57a1f81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"665a8112_af6a3600","in_reply_to":"46d8c4eb_05c466ce","updated":"2022-10-19 09:06:29.000000000","message":"Yes, the next step is go case by case checking which test requires or not admin clients and change as required","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a1b6239cdf9025f45402ee5e532ceb34799f9b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c2d1c812_f72f1373","updated":"2022-11-22 17:33:31.000000000","message":"\u003e Patch Set 13:\n\u003e \n\u003e Ghanshyam wrote:\n\u003e \n\u003e \u003e (1 comment)\n\u003e And that\u0027s the intent of this patch, to be able to pass the non-admin client for tests who don\u0027t require admin client. \n\u003e Right now the patch just add the optional argument, and future patches will go test/case by test/case and check wether it requires admin client or not\n\n\"to be able to pass the non-admin client for tests\"\nI tried to explain this in my previous comment also, passing a non-admin client in these admin only API operation is not possible. Please give me one test example (existing or future you are going to change) of passing non-admin client in the methods you are changing?","commit_id":"2320168a29a8a6723f5c19de7d4e174e4615d55c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"153276ccd2bb84964ff95253ebdc27b0985db278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f1eb0f88_0b73a26b","updated":"2022-10-28 17:59:27.000000000","message":"I am not getting what benefit we want to achieve here. in current change we are using admin client as default and asking tests to pass the admin client only (if test pass non-admin client then it will fail) so we are removing use of admin client at all right?\n\nWhat I would like to see is audit the case by case and fix the case where we can use non-admin client instead of admin client is used. means if we are using admin client to make non-admin API those test/manager we can fix to ise non-admin client.","commit_id":"2320168a29a8a6723f5c19de7d4e174e4615d55c"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"d971dcddc716a279154cc258da1dfbc69737d789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b5352f9f_b2032d80","updated":"2022-10-28 06:29:57.000000000","message":"LGTM","commit_id":"2320168a29a8a6723f5c19de7d4e174e4615d55c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d730070ca18d13640657bbb57903e2ede729f0e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"12d9127b_b1e34566","in_reply_to":"82134ab2_9d083e32","updated":"2022-11-04 18:18:51.000000000","message":"Actually test cannot pass any custom client as this is admin only API operation and if any test pass non-admin client (different than default admin client) it will fail. So we are not removing the admin client usage at all.\n\nI am saying for admin tests we cannot remove the admin client usage that is what API need on service side. We need to audit the tests and if they are non-admin API test and we are using admin client then we can change those admin to non-admin client.","commit_id":"2320168a29a8a6723f5c19de7d4e174e4615d55c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5ed4af92d3a580805928ec22db8f31b4af41f767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"82134ab2_9d083e32","in_reply_to":"f1eb0f88_0b73a26b","updated":"2022-11-04 09:54:12.000000000","message":"The 3 methods Arx edited didn\u0027t accept any client and they used admin client by default, this change just adds an option (optional argument) to pass a custom client based on the caller\u0027s needs .. my understanding is that we\u0027ll goo case by case and try to use non-admin client in every caller of manager\u0027s methods or basically every test.","commit_id":"2320168a29a8a6723f5c19de7d4e174e4615d55c"}],"tempest/scenario/manager.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9b926301920bf7bbffb885d4493fb84bce81525c","unresolved":true,"context_lines":[{"line_number":1569,"context_line":"    @classmethod"},{"line_number":1570,"context_line":"    def setup_clients(cls):"},{"line_number":1571,"context_line":"        super(EncryptionScenarioTest, cls).setup_clients()"},{"line_number":1572,"context_line":"        cls.admin_volume_types_client \u003d cls.os_primary.volume_types_client_latest"},{"line_number":1573,"context_line":"        cls.admin_encryption_types_client \u003d\\"},{"line_number":1574,"context_line":"            cls.os_admin.encryption_types_client_latest"},{"line_number":1575,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"89dd2316_988c8f20","line":1572,"updated":"2022-08-15 11:47:55.000000000","message":"Not sure, Why do you remote the admin client  ? why do you keep the same name admin_volume_types_client ?  \n\nCan you share more info about ?","commit_id":"7e9dc8daa8abb5022706187799d173bc008b641b"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4e6a85517ffa8ed32333a79f39b002588bd4ba53","unresolved":true,"context_lines":[{"line_number":1569,"context_line":"    @classmethod"},{"line_number":1570,"context_line":"    def setup_clients(cls):"},{"line_number":1571,"context_line":"        super(EncryptionScenarioTest, cls).setup_clients()"},{"line_number":1572,"context_line":"        cls.admin_volume_types_client \u003d cls.os_primary.volume_types_client_latest"},{"line_number":1573,"context_line":"        cls.admin_encryption_types_client \u003d\\"},{"line_number":1574,"context_line":"            cls.os_admin.encryption_types_client_latest"},{"line_number":1575,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f69d272d_c45168e4","line":1572,"in_reply_to":"89dd2316_988c8f20","updated":"2022-08-15 13:00:04.000000000","message":"Right now I\u0027m just testing and playing around what requires the admin or not, based on https://etherpad.opendev.org/p/qa-zed-priority#L36","commit_id":"7e9dc8daa8abb5022706187799d173bc008b641b"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"a167c4f5de0cd233c149bcbff09cc90f9f8d6367","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"    @classmethod"},{"line_number":1570,"context_line":"    def setup_clients(cls):"},{"line_number":1571,"context_line":"        super(EncryptionScenarioTest, cls).setup_clients()"},{"line_number":1572,"context_line":"        cls.admin_volume_types_client \u003d cls.os_primary.volume_types_client_latest"},{"line_number":1573,"context_line":"        cls.admin_encryption_types_client \u003d\\"},{"line_number":1574,"context_line":"            cls.os_admin.encryption_types_client_latest"},{"line_number":1575,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"b797df65_e782d523","line":1572,"in_reply_to":"f69d272d_c45168e4","updated":"2022-09-19 08:11:49.000000000","message":"Done","commit_id":"7e9dc8daa8abb5022706187799d173bc008b641b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bd225b704e103ed100569bad7a5cca1ed8511def","unresolved":true,"context_lines":[{"line_number":506,"context_line":"            test_utils.call_and_ignore_notfound_exc("},{"line_number":507,"context_line":"                volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":508,"context_line":"            volumes_client.wait_for_resource_deletion(volume[\u0027id\u0027])"},{"line_number":509,"context_line":"        volume_types_client.delete_volume_type(volume_type[\u0027id\u0027])"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone,"},{"line_number":512,"context_line":"                           **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"71d29414_11eb300b","line":509,"range":{"start_line":509,"start_character":0,"end_line":509,"end_character":65},"updated":"2022-09-16 04:51:41.000000000","message":"but how we will delete the volume type with non admin client. This can be done by admin client only https://github.com/openstack/cinder/blob/cbc5ecba70d96008d61455dcf38099c9c146daf9/cinder/policies/volume_type.py#L120","commit_id":"196c86d7b9de1bc331f42952a08ff8dc1e771fe2"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"a167c4f5de0cd233c149bcbff09cc90f9f8d6367","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            test_utils.call_and_ignore_notfound_exc("},{"line_number":507,"context_line":"                volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":508,"context_line":"            volumes_client.wait_for_resource_deletion(volume[\u0027id\u0027])"},{"line_number":509,"context_line":"        volume_types_client.delete_volume_type(volume_type[\u0027id\u0027])"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone,"},{"line_number":512,"context_line":"                           **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"08cefaf0_192559dd","line":509,"range":{"start_line":509,"start_character":0,"end_line":509,"end_character":65},"in_reply_to":"71d29414_11eb300b","updated":"2022-09-19 08:11:49.000000000","message":"Done","commit_id":"196c86d7b9de1bc331f42952a08ff8dc1e771fe2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3574a6d615623a779ecafa09f44f0c84b6b6aabe","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"    @classmethod"},{"line_number":1575,"context_line":"    def setup_clients(cls):"},{"line_number":1576,"context_line":"        super(EncryptionScenarioTest, cls).setup_clients()"},{"line_number":1577,"context_line":"        cls.admin_volume_types_client \u003d\\"},{"line_number":1578,"context_line":"            cls.os_admin.volume_types_client_latest"},{"line_number":1579,"context_line":"        cls.admin_encryption_types_client \u003d\\"},{"line_number":1580,"context_line":"            cls.os_admin.encryption_types_client_latest"}],"source_content_type":"text/x-python","patch_set":12,"id":"af252f0f_6d1cfa7b","line":1577,"range":{"start_line":1577,"start_character":38,"end_line":1577,"end_character":40},"updated":"2022-09-30 12:59:38.000000000","message":"was this necessary?","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7d8d2ff63504254aa00e800584a2a20ba57a1f81","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"    @classmethod"},{"line_number":1575,"context_line":"    def setup_clients(cls):"},{"line_number":1576,"context_line":"        super(EncryptionScenarioTest, cls).setup_clients()"},{"line_number":1577,"context_line":"        cls.admin_volume_types_client \u003d\\"},{"line_number":1578,"context_line":"            cls.os_admin.volume_types_client_latest"},{"line_number":1579,"context_line":"        cls.admin_encryption_types_client \u003d\\"},{"line_number":1580,"context_line":"            cls.os_admin.encryption_types_client_latest"}],"source_content_type":"text/x-python","patch_set":12,"id":"6c252efc_3b070b59","line":1577,"range":{"start_line":1577,"start_character":38,"end_line":1577,"end_character":40},"in_reply_to":"af252f0f_6d1cfa7b","updated":"2022-10-19 09:06:29.000000000","message":"Done","commit_id":"a6463a3567c918a567bf16491b0617ae8d0e5591"}]}