)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"030c3567d409cab1a77d2b3947f6b31c5a74e406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"850cf184_8c407aa1","updated":"2022-08-09 23:37:14.000000000","message":"I found more schema that I need to update.","commit_id":"8d52512c84c7085e218d178dda35a86e8c66c762"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3902b338ad4f97b3ed7497258007a825f1c56974","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef603ad7_e4450265","updated":"2022-08-23 05:36:38.000000000","message":"I\u0027ve confirmed that the new tests are executed. \n\n\u003e 2022-08-10 04:40:55.610426 | controller | {0} tempest.api.volume.test_volume_transfers.VolumesTransfersV357Test.test_create_get_list_accept_volume_transfer [4.841451s] ... ok\n\u003e 2022-08-10 04:40:59.448304 | controller | {0} tempest.api.volume.test_volume_transfers.VolumesTransfersV357Test.test_create_list_delete_volume_transfer [3.838027s] ... ok\n\nand Adding ~9 seconds for the execution looks reasonable to me.","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09c64616fd617cd90c3556e357c37d13cecb0611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b0750807_3c7ef566","updated":"2022-08-26 14:39:07.000000000","message":"lgtm, one comment inline but I am ok if you want to do that as followup.","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a6944c8b6b3dfada59b60ef24b9c4af7e99d81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6217e1a4_017ce410","updated":"2022-08-10 03:45:22.000000000","message":"recheck\n\nspurious error in one test\u0027s cleanups","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"76a1b17055e109bf94f87915b39159919d7d2a0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5984d0ca_d8935784","updated":"2022-08-26 18:42:00.000000000","message":"thanks lgtm","commit_id":"6712d9b260fae1cb21b1308c61d633cb9e9fd21d"}],"tempest/api/volume/test_volume_transfers.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9071e0f6acb7991dda46c10096bcbe8906c35fd8","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"},{"line_number":141,"context_line":"    def setup_clients(cls):"},{"line_number":142,"context_line":"        super(VolumesTransfersV357Test, cls).setup_clients()"},{"line_number":143,"context_line":"        # Use the mv355 client (only the responses differ for mv 3.57)."},{"line_number":144,"context_line":"        cls.client \u003d cls.os_primary.volume_transfers_mv355_client_latest"},{"line_number":145,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_mv355_client_latest"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c4d62d9_bcbc912e","line":142,"updated":"2022-08-09 18:05:57.000000000","message":"I think we should not run setup_clients again here , \nPlease change and inherit from VolumesTransfersV355Test","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"cf1eaed317d1fccaec74dcc6b7569d6aed2e3f3c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"},{"line_number":141,"context_line":"    def setup_clients(cls):"},{"line_number":142,"context_line":"        super(VolumesTransfersV357Test, cls).setup_clients()"},{"line_number":143,"context_line":"        # Use the mv355 client (only the responses differ for mv 3.57)."},{"line_number":144,"context_line":"        cls.client \u003d cls.os_primary.volume_transfers_mv355_client_latest"},{"line_number":145,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_mv355_client_latest"}],"source_content_type":"text/x-python","patch_set":2,"id":"126892b6_d322afc4","line":142,"in_reply_to":"9c4d62d9_bcbc912e","updated":"2022-08-09 19:58:05.000000000","message":"Done","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9071e0f6acb7991dda46c10096bcbe8906c35fd8","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    @decorators.idempotent_id(\u0027d746bd69-bb30-4414-9a1c-577959fac6a1\u0027)"},{"line_number":148,"context_line":"    def test_create_get_list_accept_volume_transfer(self):"},{"line_number":149,"context_line":"        \"\"\"Test create, get, list, accept with volume-transfers API mv 3.57\"\"\""},{"line_number":150,"context_line":"        super(VolumesTransfersV357Test, self). \\"},{"line_number":151,"context_line":"            test_create_get_list_accept_volume_transfer()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @decorators.idempotent_id(\u0027d4b20ec2-e1bb-4068-adcf-6c20020a8e05\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa65e2f1_3a93a6be","line":150,"updated":"2022-08-09 18:05:57.000000000","message":"We duplicate testcases for micro-versions due to uuid per testcase , maybe we can do something without this overhead ... (i did not try but we may do):\nin resource_setup \ncls.test_create_get_list_accept_volume_transfer \u003d decorators.idempotent_id(\u0027d746bd69-bb30-4414-9a1c-577959fac6a1\u0027)(VolumesTransfersV355Test.test_create_get_list_accept_volume_transfer)\n\nand we wont need the duplication for testcases , its only a suggestion.\n\n\nI dont see any reason to duplicate the tests if there is no real changes.","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"aa232cfb5156e5c139870e03d0d3bd488299bfab","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    @decorators.idempotent_id(\u0027d746bd69-bb30-4414-9a1c-577959fac6a1\u0027)"},{"line_number":148,"context_line":"    def test_create_get_list_accept_volume_transfer(self):"},{"line_number":149,"context_line":"        \"\"\"Test create, get, list, accept with volume-transfers API mv 3.57\"\"\""},{"line_number":150,"context_line":"        super(VolumesTransfersV357Test, self). \\"},{"line_number":151,"context_line":"            test_create_get_list_accept_volume_transfer()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @decorators.idempotent_id(\u0027d4b20ec2-e1bb-4068-adcf-6c20020a8e05\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"235a27e4_968406e8","line":150,"in_reply_to":"6172542d_48de1ce7","updated":"2022-08-23 06:17:01.000000000","message":"about the uuid issues, maybe we can have a seperate patch if it will bother someone...","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"80311bb03aaa0734917501fbc7781a9e90374dd7","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    @decorators.idempotent_id(\u0027d746bd69-bb30-4414-9a1c-577959fac6a1\u0027)"},{"line_number":148,"context_line":"    def test_create_get_list_accept_volume_transfer(self):"},{"line_number":149,"context_line":"        \"\"\"Test create, get, list, accept with volume-transfers API mv 3.57\"\"\""},{"line_number":150,"context_line":"        super(VolumesTransfersV357Test, self). \\"},{"line_number":151,"context_line":"            test_create_get_list_accept_volume_transfer()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @decorators.idempotent_id(\u0027d4b20ec2-e1bb-4068-adcf-6c20020a8e05\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6172542d_48de1ce7","line":150,"in_reply_to":"8072f890_aca24795","updated":"2022-08-09 20:07:29.000000000","message":"We should not duplicate uuid if its a  different class/test ,it should have different uuid.\n\nok , never mind about the hook of uuid .. not critical","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"cf1eaed317d1fccaec74dcc6b7569d6aed2e3f3c","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    @decorators.idempotent_id(\u0027d746bd69-bb30-4414-9a1c-577959fac6a1\u0027)"},{"line_number":148,"context_line":"    def test_create_get_list_accept_volume_transfer(self):"},{"line_number":149,"context_line":"        \"\"\"Test create, get, list, accept with volume-transfers API mv 3.57\"\"\""},{"line_number":150,"context_line":"        super(VolumesTransfersV357Test, self). \\"},{"line_number":151,"context_line":"            test_create_get_list_accept_volume_transfer()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @decorators.idempotent_id(\u0027d4b20ec2-e1bb-4068-adcf-6c20020a8e05\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8072f890_aca24795","line":150,"in_reply_to":"fa65e2f1_3a93a6be","updated":"2022-08-09 19:58:05.000000000","message":"I tried your suggestion but couldn\u0027t get it to work. Tempest still reported the V357 tests had the same uuids as the V355 tests. On the other hand, since the tests only differ in how they validate the response schema, maybe it\u0027s OK if V355 and V357 share the same test uuids?","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"}],"tempest/lib/api_schema/response/volume/v3_55/transfers.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"80311bb03aaa0734917501fbc7781a9e90374dd7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.volume import transfers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Volume microversion 3.55:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b91cada_ca44a044","line":17,"updated":"2022-08-09 20:07:29.000000000","message":"Looks good to me , using deepcopy so we are safe here and not shallow copy","commit_id":"895a225caa81f69c3a60b1588e8d45780cb982aa"}],"tempest/lib/services/volume/v3/transfers_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09c64616fd617cd90c3556e357c37d13cecb0611","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_volume_transfer(self, transfer_id):"},{"line_number":85,"context_line":"        \"\"\"Delete a volume transfer.\"\"\""},{"line_number":86,"context_line":"        resp, body \u003d self.delete(\"%s/%s\" % (self.resource_path, transfer_id))"},{"line_number":87,"context_line":"        self.validate_response(schema.delete_volume_transfer, resp, body)"},{"line_number":88,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"51415dec_62fcefaa","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":77},"updated":"2022-08-26 14:39:07.000000000","message":"let\u0027s add get_schema function here too as we may have change in their schema for future microversion and then it will be less chance to miss it.\n\n        schema \u003d self.get_schema(self.schema_versions_info)","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b0023e731d8d3c418ebcddf237d6afe85912375a","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_volume_transfer(self, transfer_id):"},{"line_number":85,"context_line":"        \"\"\"Delete a volume transfer.\"\"\""},{"line_number":86,"context_line":"        resp, body \u003d self.delete(\"%s/%s\" % (self.resource_path, transfer_id))"},{"line_number":87,"context_line":"        self.validate_response(schema.delete_volume_transfer, resp, body)"},{"line_number":88,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"19e1c9f1_bbf1f44f","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":77},"in_reply_to":"51415dec_62fcefaa","updated":"2022-08-26 15:44:24.000000000","message":"Done","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09c64616fd617cd90c3556e357c37d13cecb0611","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        url \u003d \u0027%s/%s/accept\u0027 % (self.resource_path, transfer_id)"},{"line_number":98,"context_line":"        post_body \u003d json.dumps({\u0027accept\u0027: kwargs})"},{"line_number":99,"context_line":"        resp, body \u003d self.post(url, post_body)"},{"line_number":100,"context_line":"        body \u003d json.loads(body)"},{"line_number":101,"context_line":"        self.validate_response(schema.accept_volume_transfer, resp, body)"},{"line_number":102,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ecaf0cc_529121e1","line":100,"range":{"start_line":100,"start_character":30,"end_line":100,"end_character":31},"updated":"2022-08-26 14:39:07.000000000","message":"ditto","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b0023e731d8d3c418ebcddf237d6afe85912375a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        url \u003d \u0027%s/%s/accept\u0027 % (self.resource_path, transfer_id)"},{"line_number":98,"context_line":"        post_body \u003d json.dumps({\u0027accept\u0027: kwargs})"},{"line_number":99,"context_line":"        resp, body \u003d self.post(url, post_body)"},{"line_number":100,"context_line":"        body \u003d json.loads(body)"},{"line_number":101,"context_line":"        self.validate_response(schema.accept_volume_transfer, resp, body)"},{"line_number":102,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"108a3e04_b5cdc690","line":100,"range":{"start_line":100,"start_character":30,"end_line":100,"end_character":31},"in_reply_to":"5ecaf0cc_529121e1","updated":"2022-08-26 15:44:24.000000000","message":"Done","commit_id":"7b357ff3dce1959744370881f34a6db50ebdc995"}]}