)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d2e503eb5310e7aa7fae172bcef3640cfeddd470","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b02eda86_1b542541","updated":"2022-08-19 11:59:30.000000000","message":"there is one more call of the image_import with the old argument:\nhttps://opendev.org/openstack/tempest/src/commit/13036879e254f8f917ff0986a48461703be5a9a7/tempest/api/image/v2/test_images_negative.py#L209\n\nother than that it looks ok","commit_id":"55ef0ad1a07f3835c64633ecff5654024dfca177"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba9d99c886243a5ff491645a9894f8c9d479c34f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5f5aee6_62f88ac5","in_reply_to":"b02eda86_1b542541","updated":"2022-08-19 13:32:11.000000000","message":"Ack thanks, will get that","commit_id":"55ef0ad1a07f3835c64633ecff5654024dfca177"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32b8adc604cf0eb10a3655e35c73c51981475562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"40d2fc3e_57cb7b88","updated":"2022-08-24 14:58:53.000000000","message":"lgtm","commit_id":"5ac5c1887b72af2dd1b75e5669f03586ef868816"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"957fac5b3189b2f88efccb5b4b28150d1fb3f544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d738378d_36848730","updated":"2022-08-23 18:45:06.000000000","message":"thanks","commit_id":"5ac5c1887b72af2dd1b75e5669f03586ef868816"}],"tempest/lib/services/image/v2/images_client.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d2e503eb5310e7aa7fae172bcef3640cfeddd470","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def image_import(self, image_id, method\u003d\u0027glance-direct\u0027,"},{"line_number":208,"context_line":"                     all_stores_must_succeed\u003dNone, all_stores\u003dTrue,"},{"line_number":209,"context_line":"                     stores\u003dNone, import_params\u003dNone):"},{"line_number":210,"context_line":"        \"\"\"Import data from staging area to glance store."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c003eb0_9b050b4a","line":209,"range":{"start_line":209,"start_character":48,"end_line":209,"end_character":52},"updated":"2022-08-19 11:59:30.000000000","message":"can we assign empty dict instead of None here? It would save us the \u0027if import_params is None\u0027 statement below.","commit_id":"55ef0ad1a07f3835c64633ecff5654024dfca177"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba9d99c886243a5ff491645a9894f8c9d479c34f","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def image_import(self, image_id, method\u003d\u0027glance-direct\u0027,"},{"line_number":208,"context_line":"                     all_stores_must_succeed\u003dNone, all_stores\u003dTrue,"},{"line_number":209,"context_line":"                     stores\u003dNone, import_params\u003dNone):"},{"line_number":210,"context_line":"        \"\"\"Import data from staging area to glance store."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"8d207cfc_b699aae6","line":209,"range":{"start_line":209,"start_character":48,"end_line":209,"end_character":52},"in_reply_to":"3c003eb0_9b050b4a","updated":"2022-08-19 13:32:11.000000000","message":"No, this is a python anti-pattern:\n\nhttps://stackoverflow.com/questions/26320899/why-is-the-empty-dictionary-a-dangerous-default-value-in-python\n\nYou should never use a mutable object as a default parameter for a method because if it gets modified, the default changes.","commit_id":"55ef0ad1a07f3835c64633ecff5654024dfca177"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"957fac5b3189b2f88efccb5b4b28150d1fb3f544","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def image_import(self, image_id, method\u003d\u0027glance-direct\u0027,"},{"line_number":208,"context_line":"                     all_stores_must_succeed\u003dNone, all_stores\u003dTrue,"},{"line_number":209,"context_line":"                     stores\u003dNone, import_params\u003dNone):"},{"line_number":210,"context_line":"        \"\"\"Import data from staging area to glance store."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"5eddf34c_b2188e50","line":209,"range":{"start_line":209,"start_character":48,"end_line":209,"end_character":52},"in_reply_to":"8d207cfc_b699aae6","updated":"2022-08-23 18:45:06.000000000","message":"oh, right, sorry, my bad","commit_id":"55ef0ad1a07f3835c64633ecff5654024dfca177"}]}