)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9f618666cdda96ecc1ffb483deb169c50cfe2485","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38b1feaf_d3b056a2","updated":"2022-08-09 16:57:18.000000000","message":"Thank you for the start!","commit_id":"ea322f9a012c31eea6879898a1c2af0de9068770"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0a5daacdb3cc42721fdeb8bb1e7a2762c298413d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fb7758a_6dbdb650","updated":"2022-08-09 20:49:07.000000000","message":"BTW, here\u0027s a DNM patch that depends-on this and has a few of the corrections needed to get two of the tests to work:\n\nhttps://8d7b74a759ef45636123-e95fa72ee90c44566fe24f9777fa290e.ssl.cf5.rackcdn.com/852609/3/check/tempest-integrated-storage-import/da4efa1/testr_results.html\n\nWhen those get merged into the base patch, and the state revert is fixed, then this should pass.","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2fa0dc3fd3538b487a076c1c1e1e9f7f95da0bdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21737b56_0e27ad45","updated":"2022-08-09 20:43:48.000000000","message":"Thanks Benny!","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"437e10c4e52ef0f7721dfee889c00590c92610a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aadb3e01_42a9f4eb","updated":"2022-08-24 15:08:24.000000000","message":"overall lgtm, 1 comment about checking the import method used in the test.\n\nAll tests passing fine in https://review.opendev.org/c/openstack/glance/+/852609","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"52f90665ea04d4a0cc0c6229d39bca37eb187168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e9f7aa2_05dbbb5c","updated":"2022-08-23 17:39:54.000000000","message":"recheck glance patch fixed","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"894b8491f9b56985d43669e226c92ad44c35b120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"66fcbfa0_fc5c438d","updated":"2022-08-31 17:17:49.000000000","message":"I thought Martin can check this but he is on leave and will be back on sept 7. Approving it.","commit_id":"994662f1fd6dfb22abc3fd75e31f63a0e2cfcb5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f576219c95d79446c0522b97300807962130ed07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0b76cc8f_e90c316f","updated":"2022-08-25 13:38:05.000000000","message":"The test patch is still passing with this change: https://review.opendev.org/c/openstack/glance/+/852609","commit_id":"994662f1fd6dfb22abc3fd75e31f63a0e2cfcb5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"de27398219a712281c658b78ef8353ca9d010313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d51a7fd4_14c24a39","updated":"2022-08-24 20:05:27.000000000","message":"recheck unrelated volume failure","commit_id":"994662f1fd6dfb22abc3fd75e31f63a0e2cfcb5e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a087d50452fb3e048784666bae5ab08fe59d2a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"94dc4e42_fbeed4cc","updated":"2022-08-26 18:31:44.000000000","message":"thanks, lgtm","commit_id":"994662f1fd6dfb22abc3fd75e31f63a0e2cfcb5e"}],"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9f618666cdda96ecc1ffb483deb169c50cfe2485","unresolved":true,"context_lines":[{"line_number":149,"context_line":"            {\u0027add\u0027: \u0027/hw_cpu_cores\u0027, \u0027value\u0027: \u00275\u0027},"},{"line_number":150,"context_line":"            {\u0027add\u0027: \u0027/trait:STORAGE_DISK_SSD\u0027, \u0027value\u0027: \u0027required\u0027},"},{"line_number":151,"context_line":"            {\u0027add\u0027: \u0027/os_distro\u0027, \u0027value\u0027: \u0027rhel\u0027},"},{"line_number":152,"context_line":"            {\u0027add\u0027: \u0027/speed\u0027, \u0027value\u0027: \u002788mph\u0027},"},{"line_number":153,"context_line":"        ])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Make sure our properties stuck on the source image"}],"source_content_type":"text/x-python","patch_set":1,"id":"ee541e87_4d042de3","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":47},"updated":"2022-08-09 16:57:18.000000000","message":"nit: this also needs to be verified at line 160","commit_id":"ea322f9a012c31eea6879898a1c2af0de9068770"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1017c004148ebfa3f90d5e04a0675b856a48b44","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            {\u0027add\u0027: \u0027/hw_cpu_cores\u0027, \u0027value\u0027: \u00275\u0027},"},{"line_number":150,"context_line":"            {\u0027add\u0027: \u0027/trait:STORAGE_DISK_SSD\u0027, \u0027value\u0027: \u0027required\u0027},"},{"line_number":151,"context_line":"            {\u0027add\u0027: \u0027/os_distro\u0027, \u0027value\u0027: \u0027rhel\u0027},"},{"line_number":152,"context_line":"            {\u0027add\u0027: \u0027/speed\u0027, \u0027value\u0027: \u002788mph\u0027},"},{"line_number":153,"context_line":"        ])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Make sure our properties stuck on the source image"}],"source_content_type":"text/x-python","patch_set":1,"id":"1676a8e0_a1d83b91","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":47},"in_reply_to":"ecad7f60_a1775fa5","updated":"2022-08-09 17:45:26.000000000","message":"Done","commit_id":"ea322f9a012c31eea6879898a1c2af0de9068770"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"582be4a5a7778ddb00adbf0b26b26795fcd4a09a","unresolved":true,"context_lines":[{"line_number":149,"context_line":"            {\u0027add\u0027: \u0027/hw_cpu_cores\u0027, \u0027value\u0027: \u00275\u0027},"},{"line_number":150,"context_line":"            {\u0027add\u0027: \u0027/trait:STORAGE_DISK_SSD\u0027, \u0027value\u0027: \u0027required\u0027},"},{"line_number":151,"context_line":"            {\u0027add\u0027: \u0027/os_distro\u0027, \u0027value\u0027: \u0027rhel\u0027},"},{"line_number":152,"context_line":"            {\u0027add\u0027: \u0027/speed\u0027, \u0027value\u0027: \u002788mph\u0027},"},{"line_number":153,"context_line":"        ])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Make sure our properties stuck on the source image"}],"source_content_type":"text/x-python","patch_set":1,"id":"ecad7f60_a1775fa5","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":47},"in_reply_to":"ee541e87_4d042de3","updated":"2022-08-09 17:21:02.000000000","message":"Ah, yep, thanks :)","commit_id":"ea322f9a012c31eea6879898a1c2af0de9068770"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5adf85c5732b58f8ce2069ed2679b9ec5b4dcd32","unresolved":true,"context_lines":[{"line_number":169,"context_line":"        }"},{"line_number":170,"context_line":"        self.client.image_import(dst, method\u003d\u0027glance-download\u0027,"},{"line_number":171,"context_line":"                                 import_params\u003dparams)"},{"line_number":172,"context_line":"        waiters.wait_for_image_tasks_status(self.client, dst, \u0027success\u0027)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # Make sure the new image has all the keys imported from the"},{"line_number":175,"context_line":"        # original image that we expect"}],"source_content_type":"text/x-python","patch_set":3,"id":"680723b6_fca7cadf","line":172,"updated":"2022-08-09 20:03:19.000000000","message":"Is there anyway to cleanup the task_list ?","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2fa0dc3fd3538b487a076c1c1e1e9f7f95da0bdb","unresolved":true,"context_lines":[{"line_number":169,"context_line":"        }"},{"line_number":170,"context_line":"        self.client.image_import(dst, method\u003d\u0027glance-download\u0027,"},{"line_number":171,"context_line":"                                 import_params\u003dparams)"},{"line_number":172,"context_line":"        waiters.wait_for_image_tasks_status(self.client, dst, \u0027success\u0027)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # Make sure the new image has all the keys imported from the"},{"line_number":175,"context_line":"        # original image that we expect"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e3eab27_98e6f071","line":172,"in_reply_to":"680723b6_fca7cadf","updated":"2022-08-09 20:43:48.000000000","message":"Not directly, no:\n\nhttps://github.com/openstack/glance/blob/bfcab95ff2d7e13afe05fed8835159949490afd8/glance/api/v2/tasks.py#L151-L159","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5adf85c5732b58f8ce2069ed2679b9ec5b4dcd32","unresolved":true,"context_lines":[{"line_number":183,"context_line":"        self.assertNotIn(\u0027speed\u0027, dst_image)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @decorators.idempotent_id(\u002736d4b546-64a2-4bb9-bdd0-ba676aa48f2c\u0027)"},{"line_number":186,"context_line":"    def test_image_glance_download_import_bad_uuid(self):"},{"line_number":187,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":188,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"},{"line_number":189,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"2bc18533_7d6ad71a","line":186,"updated":"2022-08-09 20:03:19.000000000","message":"decorate it as a negative ?","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2fa0dc3fd3538b487a076c1c1e1e9f7f95da0bdb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertNotIn(\u0027speed\u0027, dst_image)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @decorators.idempotent_id(\u002736d4b546-64a2-4bb9-bdd0-ba676aa48f2c\u0027)"},{"line_number":186,"context_line":"    def test_image_glance_download_import_bad_uuid(self):"},{"line_number":187,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":188,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"},{"line_number":189,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"425f3797_6898149c","line":186,"in_reply_to":"2bc18533_7d6ad71a","updated":"2022-08-09 20:43:48.000000000","message":"Ack","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5adf85c5732b58f8ce2069ed2679b9ec5b4dcd32","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        self.assertIn(\u0027image id does not look like a UUID\u0027, str(e))"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @decorators.idempotent_id(\u002777644240-dbbe-4744-ae28-09b2ac12e218\u0027)"},{"line_number":203,"context_line":"    def test_image_glance_download_import_bad_endpoint(self):"},{"line_number":204,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":205,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"},{"line_number":206,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"b3db1cf8_b522316f","line":203,"updated":"2022-08-09 20:03:19.000000000","message":"Do we want to decorate it as a negative ?  @decorators.attr(type\u003d[\u0027negative\u0027])","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2fa0dc3fd3538b487a076c1c1e1e9f7f95da0bdb","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.assertIn(\u0027image id does not look like a UUID\u0027, str(e))"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @decorators.idempotent_id(\u002777644240-dbbe-4744-ae28-09b2ac12e218\u0027)"},{"line_number":203,"context_line":"    def test_image_glance_download_import_bad_endpoint(self):"},{"line_number":204,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":205,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"},{"line_number":206,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"95a3ab39_fac2d630","line":203,"in_reply_to":"b3db1cf8_b522316f","updated":"2022-08-09 20:43:48.000000000","message":"Ack","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1017c004148ebfa3f90d5e04a0675b856a48b44","unresolved":true,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Make sure we reverted the image status to queued on failure"},{"line_number":219,"context_line":"        image \u003d self.client.show_image(image_id)"},{"line_number":220,"context_line":"        self.assertEqual(\u0027queued\u0027, image[\u0027status\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u0027c7edec8e-24b5-416a-9d42-b3e773bab62c\u0027)"},{"line_number":223,"context_line":"    def test_image_glance_download_import_bad_missing_image(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f93f00e_786b21ab","line":220,"updated":"2022-08-09 17:45:26.000000000","message":"These will still fail until the glance patch is fixed, but I changed this to wait for the task to fail, so this should be stable and start working once the fix is in place.","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"36af5fe6c3f08aee430000092724105797a4694f","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Make sure we reverted the image status to queued on failure"},{"line_number":219,"context_line":"        image \u003d self.client.show_image(image_id)"},{"line_number":220,"context_line":"        self.assertEqual(\u0027queued\u0027, image[\u0027status\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u0027c7edec8e-24b5-416a-9d42-b3e773bab62c\u0027)"},{"line_number":223,"context_line":"    def test_image_glance_download_import_bad_missing_image(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"470078d5_fa7b69eb","line":220,"in_reply_to":"2f93f00e_786b21ab","updated":"2022-08-23 20:52:16.000000000","message":"This is fixed in the glance patch now and is thus passing as expected.","commit_id":"618e4a0d8db83ea08f28801c9f5b80af8fe44b08"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"edc96c18bb77e7d75eab2d9d5c5d0d36f8d2aca3","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        image \u003d self._create_image()"},{"line_number":78,"context_line":"        # Stage image data"},{"line_number":79,"context_line":"        file_content \u003d data_utils.random_bytes()"},{"line_number":80,"context_line":"        image_file \u003d io.BytesIO(file_content)"},{"line_number":81,"context_line":"        self.client.stage_image_file(image[\u0027id\u0027], image_file)"},{"line_number":82,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":83,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"8e79549a_cc3bdd97","line":80,"updated":"2022-08-23 20:36:14.000000000","message":"Wondering why do we use random bytes for image when we have files ready for image and will allows us to boot an instance with valid image (assume we want to extend tests)\n\nWe have in the config.py img_file under scenario ... (maybe it should be common to all api and scenarios....)\n\nsince the images are cirros , i dont see any problem work with real images...","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"45d4c85e7c153b54b5ef490a464cd92aef309023","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        image \u003d self._create_image()"},{"line_number":78,"context_line":"        # Stage image data"},{"line_number":79,"context_line":"        file_content \u003d data_utils.random_bytes()"},{"line_number":80,"context_line":"        image_file \u003d io.BytesIO(file_content)"},{"line_number":81,"context_line":"        self.client.stage_image_file(image[\u0027id\u0027], image_file)"},{"line_number":82,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":83,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"cd43534c_ffb2cc32","line":80,"in_reply_to":"64e72371_825f0e10","updated":"2022-08-24 06:08:12.000000000","message":"Ack , thanks!","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"36af5fe6c3f08aee430000092724105797a4694f","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        image \u003d self._create_image()"},{"line_number":78,"context_line":"        # Stage image data"},{"line_number":79,"context_line":"        file_content \u003d data_utils.random_bytes()"},{"line_number":80,"context_line":"        image_file \u003d io.BytesIO(file_content)"},{"line_number":81,"context_line":"        self.client.stage_image_file(image[\u0027id\u0027], image_file)"},{"line_number":82,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":83,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"64e72371_825f0e10","line":80,"in_reply_to":"8e79549a_cc3bdd97","updated":"2022-08-23 20:52:16.000000000","message":"I assume you\u0027re not asking for a change in this patch since these lines are pre-existing right?\n\nNo particular reason for random data, other than that it\u0027s much smaller than uploading even a cirros image. We\u0027re not testing anything related to the actual functionality of the image itself, so no reason to upload a 16M image when 1K of random data will do.\n\nAlso, if the glance endpoint we\u0027re using has image conversion configured, a real image (of whatever format is provided to tempest.conf) will trigger the in-flight format detection and could result in an unnecessary conversion or complaint that we don\u0027t want, since we declare this as bare/raw.\n\nThat, and it\u0027s the convention for many of the not-needed-to-boot image tests :)","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"437e10c4e52ef0f7721dfee889c00590c92610a3","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Create an image via the normal import process to be our source"},{"line_number":142,"context_line":"        src \u003d self._stage_and_check()"},{"line_number":143,"context_line":"        self.client.image_import(src, method\u003d\u0027glance-direct\u0027)"},{"line_number":144,"context_line":"        waiters.wait_for_image_imported_to_stores(self.client, src)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Add some properties to it that will be copied by the default"}],"source_content_type":"text/x-python","patch_set":6,"id":"e380da0a_0def928d","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":61},"updated":"2022-08-24 15:08:24.000000000","message":"we should check if \u0027glance-direct\u0027 import method available or not","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6e127944f1f05d419f9bbeedb5f09a3f90c58443","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Create an image via the normal import process to be our source"},{"line_number":142,"context_line":"        src \u003d self._stage_and_check()"},{"line_number":143,"context_line":"        self.client.image_import(src, method\u003d\u0027glance-direct\u0027)"},{"line_number":144,"context_line":"        waiters.wait_for_image_imported_to_stores(self.client, src)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Add some properties to it that will be copied by the default"}],"source_content_type":"text/x-python","patch_set":6,"id":"0b1c3fdb_63ad5d25","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":61},"in_reply_to":"e380da0a_0def928d","updated":"2022-08-24 15:11:39.000000000","message":"Is this not done on L139?","commit_id":"e98b0a62ffafa86cdb09759511211af1f45c5f78"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3fb7c17ca04e284bc30af52da61600420d393e9b","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":199,"context_line":"    @decorators.idempotent_id(\u002736d4b546-64a2-4bb9-bdd0-ba676aa48f2c\u0027)"},{"line_number":200,"context_line":"    def test_image_glance_download_import_bad_uuid(self):"},{"line_number":201,"context_line":"        # We use glance-direct initially, then glance-download for test"},{"line_number":202,"context_line":"        self._require_import_method(\u0027glance-direct\u0027)"},{"line_number":203,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"d60382bd_6d642591","line":202,"range":{"start_line":201,"start_character":0,"end_line":202,"end_character":52},"updated":"2022-08-24 16:02:50.000000000","message":"\u0027glance-direct\u0027 is not used in this test so we do not need to check it.","commit_id":"002b8d264c697db2665942d733552512ebbac3ad"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8fdead8a355d74119272abb73ef1c4ef816c6648","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":199,"context_line":"    @decorators.idempotent_id(\u002736d4b546-64a2-4bb9-bdd0-ba676aa48f2c\u0027)"},{"line_number":200,"context_line":"    def test_image_glance_download_import_bad_uuid(self):"},{"line_number":201,"context_line":"        # We use glance-direct initially, then glance-download for test"},{"line_number":202,"context_line":"        self._require_import_method(\u0027glance-direct\u0027)"},{"line_number":203,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"d539c04e_158a9a8c","line":202,"range":{"start_line":201,"start_character":0,"end_line":202,"end_character":52},"in_reply_to":"d60382bd_6d642591","updated":"2022-08-24 16:31:43.000000000","message":"Yeah, sorry I forgot that I didn\u0027t need to actually create a working image in the negative tests, so I just tagged those as requiring it too, which they don\u0027t.","commit_id":"002b8d264c697db2665942d733552512ebbac3ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3fb7c17ca04e284bc30af52da61600420d393e9b","unresolved":true,"context_lines":[{"line_number":219,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002777644240-dbbe-4744-ae28-09b2ac12e218\u0027)"},{"line_number":221,"context_line":"    def test_image_glance_download_import_bad_endpoint(self):"},{"line_number":222,"context_line":"        # We use glance-direct initially, then glance-download for test"},{"line_number":223,"context_line":"        self._require_import_method(\u0027glance-direct\u0027)"},{"line_number":224,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"e9b6c566_6143a1cb","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":52},"updated":"2022-08-24 16:02:50.000000000","message":"ditto","commit_id":"002b8d264c697db2665942d733552512ebbac3ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3fb7c17ca04e284bc30af52da61600420d393e9b","unresolved":true,"context_lines":[{"line_number":257,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":258,"context_line":"    @decorators.idempotent_id(\u0027c7edec8e-24b5-416a-9d42-b3e773bab62c\u0027)"},{"line_number":259,"context_line":"    def test_image_glance_download_import_bad_missing_image(self):"},{"line_number":260,"context_line":"        # We use glance-direct initially, then glance-download for test"},{"line_number":261,"context_line":"        self._require_import_method(\u0027glance-direct\u0027)"},{"line_number":262,"context_line":"        self._require_import_method(\u0027glance-download\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        image_id \u003d self._create_image()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3130c4cf_a26d18b7","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":52},"updated":"2022-08-24 16:02:50.000000000","message":"ditto","commit_id":"002b8d264c697db2665942d733552512ebbac3ad"}]}