)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"466ee2058bccaf10bf997fbebadc2e8c37b9694a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57e368d1_b3cfd9cd","updated":"2023-07-20 22:15:36.000000000","message":"sorry for late review, a few comments inline. and can you add some unit test for the system scope account?","commit_id":"5dbd1d67780fc79c0afcc6c4fd515cedc88af9ca"}],"tempest/lib/common/preprov_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"466ee2058bccaf10bf997fbebadc2e8c37b9694a","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                types \u003d account.pop(\u0027types\u0027)"},{"line_number":149,"context_line":"            if \u0027resources\u0027 in account:"},{"line_number":150,"context_line":"                resources \u003d account.pop(\u0027resources\u0027)"},{"line_number":151,"context_line":"            if \u0027system\u0027 in account:"},{"line_number":152,"context_line":"                scope \u003d \u0027system\u0027"},{"line_number":153,"context_line":"            elif {\u0027project_name\u0027, \u0027tenant_name\u0027} \u0026 account.keys():"},{"line_number":154,"context_line":"                scope \u003d \u0027project\u0027"},{"line_number":155,"context_line":"            elif \u0027domain_name\u0027 in account:"}],"source_content_type":"text/x-python","patch_set":2,"id":"00e5454e_0468e0e8","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":32},"updated":"2023-07-20 22:15:36.000000000","message":"why you are moving this up, we can give priority to project scope as any system scope account should not have project_name and we can consider that as project scoped token if porject_nme exist","commit_id":"5dbd1d67780fc79c0afcc6c4fd515cedc88af9ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"466ee2058bccaf10bf997fbebadc2e8c37b9694a","unresolved":true,"context_lines":[{"line_number":201,"context_line":"                        \u0027Unknown resource type %s, ignoring this field\u0027,"},{"line_number":202,"context_line":"                        resource"},{"line_number":203,"context_line":"                    )"},{"line_number":204,"context_line":"            if scope \u003d\u003d \u0027project\u0027:"},{"line_number":205,"context_line":"                hash_dict \u003d cls._append_project(account, temp_hash_key,"},{"line_number":206,"context_line":"                                                hash_dict)"},{"line_number":207,"context_line":"        return hash_dict"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def is_multi_user(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c45f41e0_9c5a592c","line":206,"range":{"start_line":204,"start_character":0,"end_line":206,"end_character":58},"updated":"2023-07-20 22:15:36.000000000","message":"how about domain or system scope?","commit_id":"5dbd1d67780fc79c0afcc6c4fd515cedc88af9ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"466ee2058bccaf10bf997fbebadc2e8c37b9694a","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        getattr(used_projects, method)(project)"},{"line_number":233,"context_line":"        with open(self._used_projects_file, \u0027w\u0027) as file:"},{"line_number":234,"context_line":"            file.write(\u0027\\n\u0027.join(used_projects) + \u0027\\n\u0027)"},{"line_number":235,"context_line":"        return project"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_used_projects(self):"},{"line_number":238,"context_line":"        used_projects \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"db668942_fc04fda6","line":235,"range":{"start_line":235,"start_character":0,"end_line":235,"end_character":22},"updated":"2023-07-20 22:15:36.000000000","message":"do we need to return project ?","commit_id":"5dbd1d67780fc79c0afcc6c4fd515cedc88af9ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"466ee2058bccaf10bf997fbebadc2e8c37b9694a","unresolved":true,"context_lines":[{"line_number":331,"context_line":"            msg \u003d \u0027No users configured for type/roles %s\u0027 % roles"},{"line_number":332,"context_line":"            raise lib_exc.InvalidCredentials(msg)"},{"line_number":333,"context_line":"        if scope \u003d\u003d \u0027system\u0027:"},{"line_number":334,"context_line":"            free_hash \u003d next(iter(usable_hashes))"},{"line_number":335,"context_line":"        else:"},{"line_number":336,"context_line":"            free_hash \u003d self._get_free_hash(usable_hashes)"},{"line_number":337,"context_line":"        clean_creds \u003d self._sanitize_creds("}],"source_content_type":"text/x-python","patch_set":2,"id":"721c2ede_5e9dfe8d","line":334,"range":{"start_line":334,"start_character":24,"end_line":334,"end_character":49},"updated":"2023-07-20 22:15:36.000000000","message":"this should be free hash but usable_hash might have used one right?","commit_id":"5dbd1d67780fc79c0afcc6c4fd515cedc88af9ca"}]}