)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57745ed7fe35b5d22d8dc9734797d72070dc965e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"System-scoped credentials don\u0027t have an associated project, so don\u0027t try"},{"line_number":10,"context_line":"to cleanup the project nor its default security group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I32707d1e7b4465cb0d713b7c245f3668f70e6de7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ca93f65f_b1aae009","line":11,"updated":"2022-08-29 12:05:10.000000000","message":"Related-Bug: #1988026","commit_id":"85022e31cf5b45ef19a04038300229d6e4187d1c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c8f8dd2c46575676ea60d2b1a8324358a9194b4b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"System-scoped credentials don\u0027t have an associated project, so don\u0027t try"},{"line_number":10,"context_line":"to cleanup the project nor its default security group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I32707d1e7b4465cb0d713b7c245f3668f70e6de7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d6edec86_b8fc37dc","line":11,"in_reply_to":"ca93f65f_b1aae009","updated":"2022-08-29 12:10:37.000000000","message":"Done","commit_id":"85022e31cf5b45ef19a04038300229d6e4187d1c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1bb942908566bd359e7f444cb664fd80639a4850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36f686a8_4a75a553","updated":"2022-08-29 08:52:45.000000000","message":"Related bug: https://bugs.launchpad.net/neutron/+bug/1988026","commit_id":"85022e31cf5b45ef19a04038300229d6e4187d1c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c8f8dd2c46575676ea60d2b1a8324358a9194b4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea41ecc9_9fb04173","updated":"2022-08-29 12:10:37.000000000","message":"Testing in https://review.opendev.org/c/openstack/designate/+/854584 looks promising. Test failure here seems unrelated (timeout in wallaby).","commit_id":"568ea2aec23caab6c47452b80940290c2f48caf3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1104e73beeb20b19cdce87c1f99ccf51eda102a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23672445_caaa022f","updated":"2022-08-29 15:23:32.000000000","message":"lgtm, agree that any further change/improvement can be done as separate change. thakns","commit_id":"568ea2aec23caab6c47452b80940290c2f48caf3"}],"tempest/lib/common/dynamic_creds.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57745ed7fe35b5d22d8dc9734797d72070dc965e","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            except lib_exc.NotFound:"},{"line_number":560,"context_line":"                LOG.warning(\"user with name: %s not found for delete\","},{"line_number":561,"context_line":"                            creds.username)"},{"line_number":562,"context_line":"            if creds.tenant_id:"},{"line_number":563,"context_line":"                # NOTE(zhufl): Only when neutron\u0027s security_group ext is"},{"line_number":564,"context_line":"                # enabled, cleanup_default_secgroup will not raise error. But"},{"line_number":565,"context_line":"                # here cannot use test_utils.is_extension_enabled for it will"}],"source_content_type":"text/x-python","patch_set":1,"id":"aeabdffa_46274b42","line":562,"range":{"start_line":562,"start_character":12,"end_line":562,"end_character":31},"updated":"2022-08-29 12:05:10.000000000","message":"good catch","commit_id":"85022e31cf5b45ef19a04038300229d6e4187d1c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c8f8dd2c46575676ea60d2b1a8324358a9194b4b","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            except lib_exc.NotFound:"},{"line_number":560,"context_line":"                LOG.warning(\"user with name: %s not found for delete\","},{"line_number":561,"context_line":"                            creds.username)"},{"line_number":562,"context_line":"            if creds.tenant_id:"},{"line_number":563,"context_line":"                # NOTE(zhufl): Only when neutron\u0027s security_group ext is"},{"line_number":564,"context_line":"                # enabled, cleanup_default_secgroup will not raise error. But"},{"line_number":565,"context_line":"                # here cannot use test_utils.is_extension_enabled for it will"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b76b424_7977cf33","line":562,"range":{"start_line":562,"start_character":12,"end_line":562,"end_character":31},"in_reply_to":"aeabdffa_46274b42","updated":"2022-08-29 12:10:37.000000000","message":"Ack","commit_id":"85022e31cf5b45ef19a04038300229d6e4187d1c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8a8aa7f2775ddaf37a752a9c0947a42c53e2aacb","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            except lib_exc.NotFound:"},{"line_number":560,"context_line":"                LOG.warning(\"user with name: %s not found for delete\","},{"line_number":561,"context_line":"                            creds.username)"},{"line_number":562,"context_line":"            if creds.tenant_id:"},{"line_number":563,"context_line":"                # NOTE(zhufl): Only when neutron\u0027s security_group ext is"},{"line_number":564,"context_line":"                # enabled, cleanup_default_secgroup will not raise error. But"},{"line_number":565,"context_line":"                # here cannot use test_utils.is_extension_enabled for it will"}],"source_content_type":"text/x-python","patch_set":2,"id":"68b46a47_b9edb82f","line":562,"updated":"2022-08-29 13:06:39.000000000","message":"We have two params here that should be None : tenant_id and project_id\n\nmaybe its better to keep same style as we have, see line #583 , .\n\nif(hasattr(creds, \u0027tenant_id\u0027) and creds.tenant_id:\n\nif you want maybe adding checks for both tenant_id and project_id.\n\nWhat do you think","commit_id":"568ea2aec23caab6c47452b80940290c2f48caf3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d10b5cf8673c6ad736548fc4d6811b30f8505eb","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            except lib_exc.NotFound:"},{"line_number":560,"context_line":"                LOG.warning(\"user with name: %s not found for delete\","},{"line_number":561,"context_line":"                            creds.username)"},{"line_number":562,"context_line":"            if creds.tenant_id:"},{"line_number":563,"context_line":"                # NOTE(zhufl): Only when neutron\u0027s security_group ext is"},{"line_number":564,"context_line":"                # enabled, cleanup_default_secgroup will not raise error. But"},{"line_number":565,"context_line":"                # here cannot use test_utils.is_extension_enabled for it will"}],"source_content_type":"text/x-python","patch_set":2,"id":"518ab4cd_56eb6bef","line":562,"in_reply_to":"68b46a47_b9edb82f","updated":"2022-08-29 13:34:23.000000000","message":"I check creds.tenant_id because that is what is being used in the code below. The whole usage of tenant_id/name needs cleaning up, but that\u0027s a larger task for another patch.","commit_id":"568ea2aec23caab6c47452b80940290c2f48caf3"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"642fb8d23cf30eb5dbb80c3beeceb8d094862d7e","unresolved":true,"context_lines":[{"line_number":566,"context_line":"                # cause \"circular dependency\". So here just use try...except to"},{"line_number":567,"context_line":"                # ensure tenant deletion without big changes."},{"line_number":568,"context_line":"                try:"},{"line_number":569,"context_line":"                    if self.neutron_available:"},{"line_number":570,"context_line":"                        self.cleanup_default_secgroup("},{"line_number":571,"context_line":"                            self.security_groups_admin_client, creds.tenant_id)"},{"line_number":572,"context_line":"                except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"97f6ebc9_e967621b","line":569,"updated":"2022-08-29 13:10:10.000000000","message":"Why do we need to get into try to run if self.neutron_available: ?\nmaybe its better:\nif self.neutron_available:\n    try:\n    ....\n    except:","commit_id":"568ea2aec23caab6c47452b80940290c2f48caf3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d10b5cf8673c6ad736548fc4d6811b30f8505eb","unresolved":false,"context_lines":[{"line_number":566,"context_line":"                # cause \"circular dependency\". So here just use try...except to"},{"line_number":567,"context_line":"                # ensure tenant deletion without big changes."},{"line_number":568,"context_line":"                try:"},{"line_number":569,"context_line":"                    if self.neutron_available:"},{"line_number":570,"context_line":"                        self.cleanup_default_secgroup("},{"line_number":571,"context_line":"                            self.security_groups_admin_client, creds.tenant_id)"},{"line_number":572,"context_line":"                except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5c229c84_f0f4accc","line":569,"in_reply_to":"97f6ebc9_e967621b","updated":"2022-08-29 13:34:23.000000000","message":"That block I didn\u0027t change, feel free to submit a patch to it if you think it is necessary.","commit_id":"568ea2aec23caab6c47452b80940290c2f48caf3"}]}