)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1fd7bd074bf844c97b95daaa7516b629d20fa866","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     b39bbcc0 (Switch to the master constraint in tox.ini)"},{"line_number":2,"context_line":"Author:     Mitya_Eremeev \u003cmitossvyaz@mail.ru\u003e"},{"line_number":3,"context_line":"AuthorDate: 2022-09-16 15:49:53 +0300"},{"line_number":4,"context_line":"Commit:     mitya-eremeev-2 \u003cmitossvyaz@mail.ru\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"07c65bcd_aca0bade","line":1,"updated":"2022-09-30 12:54:16.000000000","message":"Please add a more detailed description.","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"85dbf9262580013ed486a8cf768528107c280300","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     b39bbcc0 (Switch to the master constraint in tox.ini)"},{"line_number":2,"context_line":"Author:     Mitya_Eremeev \u003cmitossvyaz@mail.ru\u003e"},{"line_number":3,"context_line":"AuthorDate: 2022-09-16 15:49:53 +0300"},{"line_number":4,"context_line":"Commit:     mitya-eremeev-2 \u003cmitossvyaz@mail.ru\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"27e6fb0d_262eed9d","line":1,"in_reply_to":"07c65bcd_aca0bade","updated":"2022-10-03 14:51:51.000000000","message":"Done","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"38dedbd38285f37f953ac872d67b1d3fd01edfdb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"All image clients must use image build timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image client for compute section uses compute build timeout."},{"line_number":10,"context_line":"It\u0027s not right."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1989459"},{"line_number":13,"context_line":"Change-Id: I04fda53890025fad3bfd5b0e0aa39667da094109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5eb025ff_cf9d9f84","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":15},"updated":"2022-10-03 15:29:14.000000000","message":"I would prefer a more detailed description. Usually, I want to mention at least two things: what is wrong and how it is fixed. In this commit message, I see only what is wrong.","commit_id":"9519d4c84712fd086ac064726b17f70d1414f311"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"51916e81b9f952719eb9fbff729c73e810815779","unresolved":false,"context_lines":[{"line_number":7,"context_line":"All image clients must use image build timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image client for compute section uses compute build timeout."},{"line_number":10,"context_line":"It\u0027s not right."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1989459"},{"line_number":13,"context_line":"Change-Id: I04fda53890025fad3bfd5b0e0aa39667da094109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"274cb0a0_660058da","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":15},"in_reply_to":"5eb025ff_cf9d9f84","updated":"2022-10-03 15:34:54.000000000","message":"Done","commit_id":"9519d4c84712fd086ac064726b17f70d1414f311"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1fd7bd074bf844c97b95daaa7516b629d20fa866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cb6f904d_fd1e6e24","updated":"2022-09-30 12:54:16.000000000","message":"Looks good to me. I only added two comments.","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"a7f55cd98c7007aef590ed21a0e9e4e97d3941a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b6e5a03e_754f7eaf","updated":"2022-09-20 07:50:45.000000000","message":"recheck","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"38dedbd38285f37f953ac872d67b1d3fd01edfdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2ee1dff1_6124ee01","updated":"2022-10-03 15:29:14.000000000","message":"Thanks for the update!","commit_id":"9519d4c84712fd086ac064726b17f70d1414f311"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3d0c23180fb6ae848154863b6786a15ff7e05b85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34bd9a5c_73ec529a","updated":"2022-10-04 08:57:14.000000000","message":"Looks good to me","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8cd3eef03c68eaca7c5e79f7bf010fbf69b9924d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"02867535_738ada0e","updated":"2022-10-07 08:02:27.000000000","message":"Looks good to me.","commit_id":"b7fec8a2d2be996670744a83bb63dd74a07cb599"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c580bc49e42318a7fb5dbc513394a1061ab485bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3c97802c_517052ac","updated":"2022-10-07 08:18:27.000000000","message":"Looks good to me!","commit_id":"6caf3b35732deffe4bca83151f6aa2f6c1975bb1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5ef9ba3cf695cc3f137dd68d3e67b7f8f580a8d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"80a06dfc_b15f2954","updated":"2022-10-07 18:45:29.000000000","message":"recheck some unrelated failure in migration job \"/bin/bash: coredumpctl: command not found\"","commit_id":"6caf3b35732deffe4bca83151f6aa2f6c1975bb1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21e31c743c6e637e2b0f79f2777d9dabab463266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ffaa1212_2b6ebf0b","updated":"2022-10-07 18:45:13.000000000","message":"thanks, lgtm","commit_id":"6caf3b35732deffe4bca83151f6aa2f6c1975bb1"}],"tempest/clients.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1fd7bd074bf844c97b95daaa7516b629d20fa866","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _set_image_clients(self):"},{"line_number":85,"context_line":"        if CONF.service_available.glance:"},{"line_number":86,"context_line":"            self.image_client \u003d self.image_v1.ImagesClient("},{"line_number":87,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":88,"context_line":"            self.image_member_client \u003d self.image_v1.ImageMembersClient()"},{"line_number":89,"context_line":"            self.image_client_v2 \u003d self.image_v2.ImagesClient("},{"line_number":90,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":91,"context_line":"            self.image_member_client_v2 \u003d self.image_v2.ImageMembersClient()"},{"line_number":92,"context_line":"            self.image_cache_client \u003d self.image_v2.ImageCacheClient()"},{"line_number":93,"context_line":"            self.namespaces_client \u003d self.image_v2.NamespacesClient()"}],"source_content_type":"text/x-python","patch_set":4,"id":"27eb8fc3_83d020db","line":90,"range":{"start_line":86,"start_character":12,"end_line":90,"end_character":55},"updated":"2022-09-30 12:54:16.000000000","message":"I\u0027ve tried to debug the creation of these clients and the build_timeout value was set correctly to the CONF.image.build_timeout value in both cases. The reason for this is that we use the self.image_v1 ClientsFactory to get the ImagesClient(). Or is there another motivation behind this change?","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"3ab4822a57c87a34589bb79b0ed4c65f59c3e48d","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _set_image_clients(self):"},{"line_number":85,"context_line":"        if CONF.service_available.glance:"},{"line_number":86,"context_line":"            self.image_client \u003d self.image_v1.ImagesClient("},{"line_number":87,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":88,"context_line":"            self.image_member_client \u003d self.image_v1.ImageMembersClient()"},{"line_number":89,"context_line":"            self.image_client_v2 \u003d self.image_v2.ImagesClient("},{"line_number":90,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":91,"context_line":"            self.image_member_client_v2 \u003d self.image_v2.ImageMembersClient()"},{"line_number":92,"context_line":"            self.image_cache_client \u003d self.image_v2.ImageCacheClient()"},{"line_number":93,"context_line":"            self.namespaces_client \u003d self.image_v2.NamespacesClient()"}],"source_content_type":"text/x-python","patch_set":4,"id":"78b42da7_aacf094d","line":90,"range":{"start_line":86,"start_character":12,"end_line":90,"end_character":55},"in_reply_to":"27eb8fc3_83d020db","updated":"2022-09-30 13:01:29.000000000","message":"I believe it\u0027s not true.\nIf you set custom value for CONF.image.build_timeout, but image clients will not get them","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"0c479de861264551adf55f7ef6aa88789989b012","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _set_image_clients(self):"},{"line_number":85,"context_line":"        if CONF.service_available.glance:"},{"line_number":86,"context_line":"            self.image_client \u003d self.image_v1.ImagesClient("},{"line_number":87,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":88,"context_line":"            self.image_member_client \u003d self.image_v1.ImageMembersClient()"},{"line_number":89,"context_line":"            self.image_client_v2 \u003d self.image_v2.ImagesClient("},{"line_number":90,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":91,"context_line":"            self.image_member_client_v2 \u003d self.image_v2.ImageMembersClient()"},{"line_number":92,"context_line":"            self.image_cache_client \u003d self.image_v2.ImageCacheClient()"},{"line_number":93,"context_line":"            self.namespaces_client \u003d self.image_v2.NamespacesClient()"}],"source_content_type":"text/x-python","patch_set":4,"id":"c9a0d1cf_7d58fe71","line":90,"range":{"start_line":86,"start_character":12,"end_line":90,"end_character":55},"in_reply_to":"3f482a61_f47b4726","updated":"2022-10-03 09:37:01.000000000","message":"Done","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"f774cdd5c96bdf237dff1835111a51f332ba3d7a","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _set_image_clients(self):"},{"line_number":85,"context_line":"        if CONF.service_available.glance:"},{"line_number":86,"context_line":"            self.image_client \u003d self.image_v1.ImagesClient("},{"line_number":87,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":88,"context_line":"            self.image_member_client \u003d self.image_v1.ImageMembersClient()"},{"line_number":89,"context_line":"            self.image_client_v2 \u003d self.image_v2.ImagesClient("},{"line_number":90,"context_line":"                build_timeout\u003dCONF.image.build_timeout)"},{"line_number":91,"context_line":"            self.image_member_client_v2 \u003d self.image_v2.ImageMembersClient()"},{"line_number":92,"context_line":"            self.image_cache_client \u003d self.image_v2.ImageCacheClient()"},{"line_number":93,"context_line":"            self.namespaces_client \u003d self.image_v2.NamespacesClient()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f482a61_f47b4726","line":90,"range":{"start_line":86,"start_character":12,"end_line":90,"end_character":55},"in_reply_to":"78b42da7_aacf094d","updated":"2022-09-30 13:17:47.000000000","message":"That is weird. I\u0027ve manually debugged this piece of code and checked the value in self.image_client.build_timeout. I set the CONF.image.build_timeout value to 222 and got the exact same value back in self.image_client.build_timeout. Maybe I\u0027m missing something. \n\nTo be more precise, I agree with your change on line 123 but disagree with the change on lines 86 - 90.","commit_id":"afba734a43f226680c5e296dfd00d959c45b49c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fee205bcf0116f0961081eddbbd6b46cffaa0a81","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ff1af75_7bde9e8d","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"updated":"2022-10-05 18:39:42.000000000","message":"this is image client proxy API of compute service not image. there is separate glance client using image build_timeout.","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8cd3eef03c68eaca7c5e79f7bf010fbf69b9924d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d569ffe5_4cdb11d4","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"in_reply_to":"160338bc_f67d6ee0","updated":"2022-10-07 08:02:27.000000000","message":"ack, gmann. Thanks for the explanation.","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"afc4dd78dfb97ed8bcb93d9063b3308ad3fa7b7c","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ac2a7b51_7ba8881a","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"in_reply_to":"1ff1af75_7bde9e8d","updated":"2022-10-06 07:57:43.000000000","message":"Any image client must use image build timeout.\nImage client should not use compute build timeout.\nImage build timeout and compute build timeout have different purposes.","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"e48e4580a69e547fcbb479251252c99a02769e7e","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f770b05a_96596a27","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"in_reply_to":"ac2a7b51_7ba8881a","updated":"2022-10-06 08:07:49.000000000","message":"Isn\u0027t this case the same as this one [1] as this client is a proxy to the image service?\n\n[1] https://github.com/openstack/tempest/blob/f1d0e395e95d3502a9c3904ce56520d116e6bf48/tempest/clients.py#L149","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"e27b1bd47408434e414f291c6abc8a6c1bedbdea","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"160338bc_f67d6ee0","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"in_reply_to":"ac8beb23_d213c595","updated":"2022-10-07 07:31:03.000000000","message":"Done","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"96f8d09c90439424c1def3937f973b7ca1858c88","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc55dc85_d96e631c","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"in_reply_to":"f770b05a_96596a27","updated":"2022-10-06 09:51:51.000000000","message":"Yes, these cases are the same.","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a0e09d4948fbf2f0e6f90a8aca3c8e346e75ce7","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            enable_instance_password\u003deip)"},{"line_number":119,"context_line":"        self.server_groups_client \u003d self.compute.ServerGroupsClient()"},{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":122,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":123,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":124,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ac8beb23_d213c595","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":63},"in_reply_to":"fc55dc85_d96e631c","updated":"2022-10-07 04:09:12.000000000","message":"yeah it is not easy to say which one to use that is why proxy APIs are not good interfaces and we have deprecated them in nova side. basically build timeout we add for any service we are interacting via API and in proxy APIs we interact to compute service and then compute service interact to image and return the response. If we take example of any other non-proxy API, in that case also main service might be calling other service to get/perform something (for example create server, nova interact to glance and neutron also) but we use the main service timeout.\n\nBut on the same time, another argument can be, main time in proxy APIs case are proceeded by proxy service only so we can say using proxy service timeout is right choice.\n\nAnyways those APIs are deprecated and not recommended to use so let\u0027s go with what we did for volume in client you pointed out. But can you please add same comment here too so that we know why we are using image build timeout here.","commit_id":"230810d9d7e785674618464ec562206130215460"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8cd3eef03c68eaca7c5e79f7bf010fbf69b9924d","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        # NOTE: The following client needs special timeout value because"},{"line_number":122,"context_line":"        # the API is a proxy for the other component."},{"line_number":123,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":124,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":125,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":126,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"},{"line_number":127,"context_line":"        self.quotas_client \u003d self.compute.QuotasClient()"}],"source_content_type":"text/x-python","patch_set":9,"id":"6c960af3_9b757a8f","line":124,"range":{"start_line":123,"start_character":8,"end_line":124,"end_character":51},"updated":"2022-10-07 08:02:27.000000000","message":"I\u0027d move this to line 164 so we have the proxy API clients with different timeout values together in one place. But it\u0027s just a nit I think.","commit_id":"b7fec8a2d2be996670744a83bb63dd74a07cb599"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"21566c6b62288e464374a712b7666fbca55f56e0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.limits_client \u003d self.compute.LimitsClient()"},{"line_number":121,"context_line":"        # NOTE: The following client needs special timeout value because"},{"line_number":122,"context_line":"        # the API is a proxy for the other component."},{"line_number":123,"context_line":"        self.compute_images_client \u003d self.compute.ImagesClient("},{"line_number":124,"context_line":"            build_timeout\u003dCONF.image.build_timeout)"},{"line_number":125,"context_line":"        self.keypairs_client \u003d self.compute.KeyPairsClient("},{"line_number":126,"context_line":"            ssh_key_type\u003dCONF.validation.ssh_key_type)"},{"line_number":127,"context_line":"        self.quotas_client \u003d self.compute.QuotasClient()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3386b18d_9f21a8ed","line":124,"range":{"start_line":123,"start_character":8,"end_line":124,"end_character":51},"in_reply_to":"6c960af3_9b757a8f","updated":"2022-10-07 08:10:20.000000000","message":"Done","commit_id":"b7fec8a2d2be996670744a83bb63dd74a07cb599"}]}