)]}'
{"tempest/api/baremetal/test_nodestates.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"da7202d3d115146652984ed0e38b7c36ceeee4bd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":50,"context_line":"    def test_set_node_power_state(self):"},{"line_number":51,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self._delete_node, node[\u0027uuid\u0027])"},{"line_number":53,"context_line":"        #Set power state to \u0027power on\u0027"},{"line_number":54,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":55,"context_line":"                                                      \"power on\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FoS4%3D","line":52,"updated":"2014-04-11 15:15:31.000000000","message":"addCleanup could be removed as node will be deleted in tearDownClass of base.BaseBaremetalTest","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"9b3ef54419a09048f0aba439e56283ca02c7d150","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":50,"context_line":"    def test_set_node_power_state(self):"},{"line_number":51,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self._delete_node, node[\u0027uuid\u0027])"},{"line_number":53,"context_line":"        #Set power state to \u0027power on\u0027"},{"line_number":54,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":55,"context_line":"                                                      \"power on\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FjoE%3D","line":52,"in_reply_to":"AAAAW3%2F%2FoS4%3D","updated":"2014-04-12 18:43:51.000000000","message":"Agree","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ff3b491981726821ec4e8c60947c0ca95196e60","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":57,"context_line":"        #Check power state after state set to on"},{"line_number":58,"context_line":"        #power state should be \u0027power on\u0027"},{"line_number":59,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":60,"context_line":"        self.assertEqual(\u0027power on\u0027, node[\u0027power_state\u0027])"},{"line_number":61,"context_line":"        #Set power state to \u0027power reboot\u0027"},{"line_number":62,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F%2FUw%3D","line":59,"updated":"2014-04-09 01:14:48.000000000","message":"As the status code is 202, there might be possibility that node state change is not completed till show node. I think we should wait to complete the action. \r\nAnd also want to see other reviwer`s opinion.","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"6fc3992bc606937eff3961456bfb4b87445ec7b7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":57,"context_line":"        #Check power state after state set to on"},{"line_number":58,"context_line":"        #power state should be \u0027power on\u0027"},{"line_number":59,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":60,"context_line":"        self.assertEqual(\u0027power on\u0027, node[\u0027power_state\u0027])"},{"line_number":61,"context_line":"        #Set power state to \u0027power reboot\u0027"},{"line_number":62,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2Fjh0%3D","line":59,"in_reply_to":"AAAAW3%2F%2F%2Boc%3D","updated":"2014-04-12 19:24:05.000000000","message":"I believe Ghanshyam is correct. It is making sense to me also.","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eff63adf6596faca7eff371bad20e03f093782d1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":57,"context_line":"        #Check power state after state set to on"},{"line_number":58,"context_line":"        #power state should be \u0027power on\u0027"},{"line_number":59,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":60,"context_line":"        self.assertEqual(\u0027power on\u0027, node[\u0027power_state\u0027])"},{"line_number":61,"context_line":"        #Set power state to \u0027power reboot\u0027"},{"line_number":62,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F%2Boc%3D","line":59,"in_reply_to":"AAAAW3%2F%2F%2BxE%3D","updated":"2014-04-09 23:24:53.000000000","message":"This request is not synchronous request. So you cannot say request will be completed immediately all the time. What will happen if during show_node call, state has been changed it will fail this test. I would like to have logic to wait until there is any change in state (not for desired state) and after that only we should check for desired state.","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"28f80f5eb9a73b368b34a5e137aaf443c8e15181","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":57,"context_line":"        #Check power state after state set to on"},{"line_number":58,"context_line":"        #power state should be \u0027power on\u0027"},{"line_number":59,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":60,"context_line":"        self.assertEqual(\u0027power on\u0027, node[\u0027power_state\u0027])"},{"line_number":61,"context_line":"        #Set power state to \u0027power reboot\u0027"},{"line_number":62,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F%2BxE%3D","line":59,"in_reply_to":"AAAAW3%2F%2F%2FUw%3D","updated":"2014-04-09 04:18:50.000000000","message":"I don\u0027t think that there are some time out for state change.\nAgain if wait is based on status to reached desired state, then it will not be fine I think.\nI mean our motive is to check status changed to desired state, and if we are going to use a wait function based on desired state to reach, will that be better ??","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ff3b491981726821ec4e8c60947c0ca95196e60","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        #Set power state to \u0027power reboot\u0027"},{"line_number":62,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":63,"context_line":"                                                      \"rebooting\")"},{"line_number":64,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":65,"context_line":"        #Check power state after state set to rebooting"},{"line_number":66,"context_line":"        #power state should be \u0027power on\u0027"},{"line_number":67,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F%2FUs%3D","line":64,"updated":"2014-04-09 01:14:48.000000000","message":"Please reuse the code. Convert this in loop on state.","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"28f80f5eb9a73b368b34a5e137aaf443c8e15181","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        #Set power state to \u0027power reboot\u0027"},{"line_number":62,"context_line":"        resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":63,"context_line":"                                                      \"rebooting\")"},{"line_number":64,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":65,"context_line":"        #Check power state after state set to rebooting"},{"line_number":66,"context_line":"        #power state should be \u0027power on\u0027"},{"line_number":67,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F%2Bxw%3D","line":64,"in_reply_to":"AAAAW3%2F%2F%2FUs%3D","updated":"2014-04-09 04:18:50.000000000","message":"Fine, will be done in next patch.","commit_id":"f967a4ce664959dd496699c71db274c01ca4a614"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"752dccc433648b2f79aeca56c3545c3be3259f43","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest import exceptions"},{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNodeStates(base.BaseBaremetalTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fz6E%3D","line":19,"updated":"2014-04-17 09:05:24.000000000","message":"Put \u0027import time\u0027 on the top. the order should be \"pylib -\u003e third party lib -\u003e tempest lib\"","commit_id":"d3bb91c47e4853992c2851e1a1f9baeeafb50877"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"017b0a6cae66e166ac2db4d47fff8c2a64ba5219","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest import exceptions"},{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNodeStates(base.BaseBaremetalTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fz4Q%3D","line":19,"in_reply_to":"AAAAXH%2F%2Fz6E%3D","updated":"2014-04-17 09:09:30.000000000","message":"will be done in next","commit_id":"d3bb91c47e4853992c2851e1a1f9baeeafb50877"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"752dccc433648b2f79aeca56c3545c3be3259f43","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"},{"line_number":29,"context_line":"        self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_node(self, node_uuid):"},{"line_number":32,"context_line":"        # delete node, if it exists"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fz7w%3D","line":31,"updated":"2014-04-17 09:05:24.000000000","message":"this method could be deleted.","commit_id":"d3bb91c47e4853992c2851e1a1f9baeeafb50877"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"017b0a6cae66e166ac2db4d47fff8c2a64ba5219","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"},{"line_number":29,"context_line":"        self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_node(self, node_uuid):"},{"line_number":32,"context_line":"        # delete node, if it exists"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fz4U%3D","line":31,"in_reply_to":"AAAAXH%2F%2Fz7w%3D","updated":"2014-04-17 09:09:30.000000000","message":"will be done in next","commit_id":"d3bb91c47e4853992c2851e1a1f9baeeafb50877"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"752dccc433648b2f79aeca56c3545c3be3259f43","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _validate_power_state(self, node_uuid, power_state):"},{"line_number":46,"context_line":"        # Validate that power state is set within timeout"},{"line_number":47,"context_line":"        start \u003d int(time.time())"},{"line_number":48,"context_line":"        resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":49,"context_line":"        timed_out \u003d int(time.time()) - start \u003e\u003d self.power_timeout"},{"line_number":50,"context_line":"        if node[\u0027power_state\u0027] !\u003d power_state and timed_out:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fz7A%3D","line":47,"updated":"2014-04-17 09:05:24.000000000","message":"it only check state one time. here need a loop to validate the state and timeout.","commit_id":"d3bb91c47e4853992c2851e1a1f9baeeafb50877"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"017b0a6cae66e166ac2db4d47fff8c2a64ba5219","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _validate_power_state(self, node_uuid, power_state):"},{"line_number":46,"context_line":"        # Validate that power state is set within timeout"},{"line_number":47,"context_line":"        start \u003d int(time.time())"},{"line_number":48,"context_line":"        resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":49,"context_line":"        timed_out \u003d int(time.time()) - start \u003e\u003d self.power_timeout"},{"line_number":50,"context_line":"        if node[\u0027power_state\u0027] !\u003d power_state and timed_out:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fz4I%3D","line":47,"in_reply_to":"AAAAXH%2F%2Fz7A%3D","updated":"2014-04-17 09:09:30.000000000","message":"will be done in next","commit_id":"d3bb91c47e4853992c2851e1a1f9baeeafb50877"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8032622fb58327a48ff2b99b8ade8297ed13499c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":57,"context_line":"        states \u003d [\"power on\", \"rebooting\", \"power off\"]"},{"line_number":58,"context_line":"        for state in states:"},{"line_number":59,"context_line":"            #Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FD%2Fc%3D","line":59,"updated":"2014-04-24 09:44:50.000000000","message":"space after #","commit_id":"ee7e3c49a0189fb9e79c19786904538a62859780"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"28b1dbc6fb6120e0a08785108a4ab6d7d48ef59c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":57,"context_line":"        states \u003d [\"power on\", \"rebooting\", \"power off\"]"},{"line_number":58,"context_line":"        for state in states:"},{"line_number":59,"context_line":"            #Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FD58%3D","line":59,"in_reply_to":"AAAAXH%2F%2FD%2Fc%3D","updated":"2014-04-24 09:50:10.000000000","message":"Done","commit_id":"ee7e3c49a0189fb9e79c19786904538a62859780"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8032622fb58327a48ff2b99b8ade8297ed13499c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            #Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FD%2FY%3D","line":63,"updated":"2014-04-24 09:44:50.000000000","message":"space after #","commit_id":"ee7e3c49a0189fb9e79c19786904538a62859780"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"28b1dbc6fb6120e0a08785108a4ab6d7d48ef59c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            #Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FD54%3D","line":63,"in_reply_to":"AAAAXH%2F%2FD%2FY%3D","updated":"2014-04-24 09:50:10.000000000","message":"Done","commit_id":"ee7e3c49a0189fb9e79c19786904538a62859780"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"a5f27ddb857b394cd4ac1b13a7e19978e527755a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(self):"},{"line_number":27,"context_line":"        super(TestNodeStates, self).setUpClass()"},{"line_number":28,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"},{"line_number":29,"context_line":"        self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _validate_power_state(self, node_uuid, power_state):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_35d3e239","line":28,"updated":"2014-04-29 08:37:03.000000000","message":"it\u0027s classmethod, may be following use cls instead self?","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2420bf04e4edeb9776b9cc20e23db243a6f15a2a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(self):"},{"line_number":27,"context_line":"        super(TestNodeStates, self).setUpClass()"},{"line_number":28,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"},{"line_number":29,"context_line":"        self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _validate_power_state(self, node_uuid, power_state):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_cac9345c","line":28,"in_reply_to":"bad4c104_35d3e239","updated":"2014-04-29 10:05:09.000000000","message":"Done","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"a5f27ddb857b394cd4ac1b13a7e19978e527755a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        if power_state \u003d\u003d \u0027rebooting\u0027:"},{"line_number":34,"context_line":"            power_state \u003d \u0027power on\u0027"},{"line_number":35,"context_line":"        start \u003d int(time.time())"},{"line_number":36,"context_line":"        resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":37,"context_line":"        node_state \u003d node[\u0027power_state\u0027]"},{"line_number":38,"context_line":"        while node_state !\u003d power_state:"},{"line_number":39,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_35ba02e2","line":36,"updated":"2014-04-29 08:37:03.000000000","message":"unused variable \"resp\"","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2420bf04e4edeb9776b9cc20e23db243a6f15a2a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        if power_state \u003d\u003d \u0027rebooting\u0027:"},{"line_number":34,"context_line":"            power_state \u003d \u0027power on\u0027"},{"line_number":35,"context_line":"        start \u003d int(time.time())"},{"line_number":36,"context_line":"        resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":37,"context_line":"        node_state \u003d node[\u0027power_state\u0027]"},{"line_number":38,"context_line":"        while node_state !\u003d power_state:"},{"line_number":39,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_aaecf0c8","line":36,"in_reply_to":"bad4c104_35ba02e2","updated":"2014-04-29 10:05:09.000000000","message":"Done","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"a5f27ddb857b394cd4ac1b13a7e19978e527755a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":37,"context_line":"        node_state \u003d node[\u0027power_state\u0027]"},{"line_number":38,"context_line":"        while node_state !\u003d power_state:"},{"line_number":39,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":40,"context_line":"            node_state \u003d node[\u0027power_state\u0027]"},{"line_number":41,"context_line":"            timed_out \u003d int(time.time()) - start \u003e\u003d self.power_timeout"},{"line_number":42,"context_line":"            if node[\u0027power_state\u0027] !\u003d power_state and timed_out:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_b5cd3289","line":39,"updated":"2014-04-29 08:37:03.000000000","message":"unused variable \"resp\"","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2420bf04e4edeb9776b9cc20e23db243a6f15a2a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":37,"context_line":"        node_state \u003d node[\u0027power_state\u0027]"},{"line_number":38,"context_line":"        while node_state !\u003d power_state:"},{"line_number":39,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":40,"context_line":"            node_state \u003d node[\u0027power_state\u0027]"},{"line_number":41,"context_line":"            timed_out \u003d int(time.time()) - start \u003e\u003d self.power_timeout"},{"line_number":42,"context_line":"            if node[\u0027power_state\u0027] !\u003d power_state and timed_out:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_cad054fa","line":39,"in_reply_to":"bad4c104_b5cd3289","updated":"2014-04-29 10:05:09.000000000","message":"Done","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"a5f27ddb857b394cd4ac1b13a7e19978e527755a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        states \u003d [\"power on\", \"rebooting\", \"power off\"]"},{"line_number":58,"context_line":"        for state in states:"},{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_75abaa89","line":60,"updated":"2014-04-29 08:37:03.000000000","message":"unused variable \"body\"","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2420bf04e4edeb9776b9cc20e23db243a6f15a2a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        states \u003d [\"power on\", \"rebooting\", \"power off\"]"},{"line_number":58,"context_line":"        for state in states:"},{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_eacd185f","line":60,"in_reply_to":"bad4c104_75abaa89","updated":"2014-04-29 10:05:09.000000000","message":"Done","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6e16455aa7d6e187e89a3bbcd28a8c17446b2b53","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F9hU%3D","line":62,"updated":"2014-04-25 01:07:00.000000000","message":"How about checking the target_power_state by GET /v1/nodes/\u003cuuid\u003e/state?\nhttp://docs.openstack.org/developer/ironic/webapi/v1.html#get--v1-nodes--uuid--state","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1adcdafcead2f5e06028ae141240e2e515b4a225","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F7YE%3D","line":62,"in_reply_to":"AAAAXX%2F%2F700%3D","updated":"2014-04-25 08:37:42.000000000","message":"I understood, that\u0027s probably right it should be done in the scenario tests, not in this test.","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"f8e1dd351f2b9b030cff7cca38d18c70252bcba4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F700%3D","line":62,"in_reply_to":"AAAAXX%2F%2F71w%3D","updated":"2014-04-25 07:51:54.000000000","message":"Because this patch objective is test_set_node_power_state. amendment required is apart from this objective I think. what you say ??","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"94fa6c66eb3012dc95ae314d82274b287414e210","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F7Ik%3D","line":62,"in_reply_to":"AAAAXX%2F%2F7YE%3D","updated":"2014-04-25 08:59:46.000000000","message":"Thanks :)","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"ce418c27a613ea3c494bb292874ff3a1d1af91fd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F8YM%3D","line":62,"in_reply_to":"AAAAXX%2F%2F80w%3D","updated":"2014-04-25 06:21:29.000000000","message":"Will it be good to check in this patch ??","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"ce418c27a613ea3c494bb292874ff3a1d1af91fd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F80w%3D","line":62,"in_reply_to":"AAAAXX%2F%2F824%3D","updated":"2014-04-25 04:44:06.000000000","message":"Yes I will do it also :) thanks","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"859b32f12c59e242040c9d0162a3fc48f4daba5d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F824%3D","line":62,"in_reply_to":"AAAAXX%2F%2F83o%3D","updated":"2014-04-25 04:21:31.000000000","message":"I think it\u0027s better to check whether target_power_state is same as new power_state, not just checking the key.","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"95c40979f29a1d0fd01c6f3a2315e324af2de592","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F71w%3D","line":62,"in_reply_to":"AAAAXX%2F%2F8YM%3D","updated":"2014-04-25 07:50:00.000000000","message":"I think so. Why?","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3fd4a786de70f58e25ae1edbc952654bd9a5c99a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            # Set power state"},{"line_number":60,"context_line":"            resp, body \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"},{"line_number":61,"context_line":"                                                          state)"},{"line_number":62,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":63,"context_line":"            # Check power state after state is set"},{"line_number":64,"context_line":"            self._validate_power_state(node[\u0027uuid\u0027], state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2F83o%3D","line":62,"in_reply_to":"AAAAXX%2F%2F9hU%3D","updated":"2014-04-25 04:15:17.000000000","message":"takada san -\nL#47-L#52 is implemented for that, as its parent.","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d7819458683327019e925f6c5f74ca2efbf881f6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        cls.chassis \u003d cls.create_chassis()[\u0027chassis\u0027]"},{"line_number":29,"context_line":"        cls.node \u003d cls.create_node(cls.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _validate_power_state(self, node_uuid, power_state):"},{"line_number":32,"context_line":"        # Validate that power state is set within timeout"},{"line_number":33,"context_line":"        if power_state \u003d\u003d \u0027rebooting\u0027:"},{"line_number":34,"context_line":"            power_state \u003d \u0027power on\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad9bd40_14097831","line":31,"updated":"2014-04-30 12:54:48.000000000","message":"I think it is more readable\n\ndef _validate_power_state(self, node_uuid, power_state):\n    # Validate that power state is set within timeout\n    if power_state \u003d\u003d \u0027rebooting\u0027:\n        power_state \u003d \u0027power on\u0027\n    start \u003d timeutils.utcnow()\n    raise_error \u003d True\n    while timeutils.delta_seconds(\n            start, timeutils.utcnow()) \u003c self.power_timeout:\n        resp, node \u003d self.client.show_node(node_uuid)\n        self.assertEqual(200, resp.status)\n        if node[\u0027power_state\u0027] \u003d\u003d power_state:\n            raise_error \u003d False\n            break\n\n    if raise_error:\n        message \u003d (\u0027Failed to set power state within \u0027\n                   \u0027the required time: %s sec.\u0027 % self.power_timeout)\n        raise exceptions.TimeoutException(message)\n\nif you use this code, you need to import \"timeutils\" module\n\nfrom tempest.openstack.common import timeutils","commit_id":"7b7efd40fe9c256ef9109ebaf5cf9eb16ef39c48"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"76692d360be11e057fd5ad5fed1d40dacca76e1b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":39,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":40,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":41,"context_line":"                raise_error \u003d False"},{"line_number":42,"context_line":"                break"},{"line_number":43,"context_line":"        if raise_error:"},{"line_number":44,"context_line":"            message \u003d (\u0027Failed to set power state within \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_2bf87be4","line":41,"updated":"2014-05-05 06:43:20.000000000","message":"may be would be better remove \u0027raise_error\u0027 variable? you can use \u0027return\u0027 instead \u0027break\u0027, and don\u0027t use \u0027if\u0027 statment, just call \u0027raise exceptions.TimeoutException(message)\u0027 after \u0027while\u0027","commit_id":"0b0e8c96ad8f642345cc148eb9b9de147d397e6b"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a95367b83993fb6a1e94160a99fff25fd5a6c4f3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":39,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":40,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":41,"context_line":"                raise_error \u003d False"},{"line_number":42,"context_line":"                break"},{"line_number":43,"context_line":"        if raise_error:"},{"line_number":44,"context_line":"            message \u003d (\u0027Failed to set power state within \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_d72169a0","line":41,"in_reply_to":"9ad9bd40_2bf87be4","updated":"2014-06-03 11:21:24.000000000","message":"Done","commit_id":"0b0e8c96ad8f642345cc148eb9b9de147d397e6b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"0d64dd6da3006ce52558f0ac95a71c6161d5f0f9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":39,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":40,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":41,"context_line":"                raise_error \u003d False"},{"line_number":42,"context_line":"                break"},{"line_number":43,"context_line":"        if raise_error:"},{"line_number":44,"context_line":"            message \u003d (\u0027Failed to set power state within \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_c4a539b6","line":41,"in_reply_to":"9ad9bd40_2bf87be4","updated":"2014-05-05 11:48:52.000000000","message":"I like Sergey\u0027s advice.","commit_id":"0b0e8c96ad8f642345cc148eb9b9de147d397e6b"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a95367b83993fb6a1e94160a99fff25fd5a6c4f3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":39,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":40,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":41,"context_line":"                raise_error \u003d False"},{"line_number":42,"context_line":"                break"},{"line_number":43,"context_line":"        if raise_error:"},{"line_number":44,"context_line":"            message \u003d (\u0027Failed to set power state within \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_b72a1d7c","line":41,"in_reply_to":"9ad9bd40_c4a539b6","updated":"2014-06-03 11:21:24.000000000","message":"Done","commit_id":"0b0e8c96ad8f642345cc148eb9b9de147d397e6b"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d958ac3028600e774aec652876446c43925bf67c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":38,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":39,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":40,"context_line":"                 return False\t"},{"line_number":41,"context_line":"        message \u003d (\u0027Failed to set power state within \u0027"},{"line_number":42,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.power_timeout)"},{"line_number":43,"context_line":"        raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_f724a5b0","line":40,"updated":"2014-06-03 11:21:20.000000000","message":"please remove \u003e\u003e","commit_id":"08857f9029e9d53de6747c903c9e555275604090"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a95367b83993fb6a1e94160a99fff25fd5a6c4f3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":38,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":39,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":40,"context_line":"                 return False\t"},{"line_number":41,"context_line":"        message \u003d (\u0027Failed to set power state within \u0027"},{"line_number":42,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.power_timeout)"},{"line_number":43,"context_line":"        raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_f772e5ab","line":40,"in_reply_to":"1ae5cdf2_f724a5b0","updated":"2014-06-03 11:22:55.000000000","message":"Done","commit_id":"08857f9029e9d53de6747c903c9e555275604090"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":38,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":39,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":40,"context_line":"                 return False"},{"line_number":41,"context_line":"        message \u003d (\u0027Failed to set power state within \u0027"},{"line_number":42,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.power_timeout)"},{"line_number":43,"context_line":"        raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_f7866512","line":40,"updated":"2014-06-03 11:29:22.000000000","message":"should be 1 letter shifted left.","commit_id":"1af071895f6ec4bc2b321678bf926edad8475ff1"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a95367b83993fb6a1e94160a99fff25fd5a6c4f3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":38,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":39,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":40,"context_line":"                 return False"},{"line_number":41,"context_line":"        message \u003d (\u0027Failed to set power state within \u0027"},{"line_number":42,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.power_timeout)"},{"line_number":43,"context_line":"        raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_f78745d5","line":40,"in_reply_to":"1ae5cdf2_f7866512","updated":"2014-06-03 11:31:58.000000000","message":"Nice catch Takada-san :) thanks","commit_id":"1af071895f6ec4bc2b321678bf926edad8475ff1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":38,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":39,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":40,"context_line":"                return False"},{"line_number":41,"context_line":"        message \u003d (\u0027Failed to set power state within \u0027"},{"line_number":42,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.power_timeout)"},{"line_number":43,"context_line":"        raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_c0da7c4b","line":40,"updated":"2014-06-03 15:08:21.000000000","message":"Why do you return False here? You can just write \u0027return\u0027.\n\n    if node[\u0027power_state\u0027] \u003d\u003d power_state:\n        return","commit_id":"ccdfaee330972f2ec143e807dba6df0fb9afc6ed"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a95367b83993fb6a1e94160a99fff25fd5a6c4f3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            resp, node \u003d self.client.show_node(node_uuid)"},{"line_number":38,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":39,"context_line":"            if node[\u0027power_state\u0027] \u003d\u003d power_state:"},{"line_number":40,"context_line":"                return False"},{"line_number":41,"context_line":"        message \u003d (\u0027Failed to set power state within \u0027"},{"line_number":42,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.power_timeout)"},{"line_number":43,"context_line":"        raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_10901b49","line":40,"in_reply_to":"1ae5cdf2_c0da7c4b","updated":"2014-06-04 05:18:36.000000000","message":"Done","commit_id":"ccdfaee330972f2ec143e807dba6df0fb9afc6ed"}],"tempest/services/baremetal/base.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"a5f27ddb857b394cd4ac1b13a7e19978e527755a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        uri \u003d self._get_uri(resource)"},{"line_number":209,"context_line":"        put_body \u003d json.dumps(put_object)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        resp, body \u003d self.put(uri, body\u003dput_body)"},{"line_number":212,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_f59eda62","line":211,"updated":"2014-04-29 08:37:03.000000000","message":"may be would be better:\n\nreturn self.put(uri, body\u003dput_body)\n\n?","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2420bf04e4edeb9776b9cc20e23db243a6f15a2a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        uri \u003d self._get_uri(resource)"},{"line_number":209,"context_line":"        put_body \u003d json.dumps(put_object)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        resp, body \u003d self.put(uri, body\u003dput_body)"},{"line_number":212,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_8aabac88","line":211,"in_reply_to":"bad4c104_f59eda62","updated":"2014-04-29 10:05:09.000000000","message":"I think resp, body is fine because in future there be some cases where return body also needed to checked.","commit_id":"72f525e257646205f872d2786730eb1fe754e9f0"}]}