)]}'
{"tempest/api/compute/images/test_images.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"206b1082de10ed08dc3229c72938cfabff3dae7f","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                                       server[\u0027id\u0027], \u0027SHUTOFF\u0027)"},{"line_number":93,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":94,"context_line":"        image \u003d self.create_snapshot(server)"},{"line_number":95,"context_line":"        self.addCleanup(self.client.delete_image, image[\u0027id\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @decorators.idempotent_id(\u002771bcb732-0261-11e7-9086-fa163e4fa634\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ad052f81_44909ae1","line":95,"updated":"2022-10-12 15:08:52.000000000","message":"Why are you not moving this addCleanup() and the assertEqual() call into your helper? Otherwise this patch only saves six lines of code -- hardly a critical refactor worth delaying other work, IMHO.\n\nTo be honest, I think there\u0027s value in making it as easy as possible to read a test case without having to chase a lot of pointers to other stuff. I should be able to look at a test and see high-level things that it is doing, asserts it is making, etc. Absolute minimal line count can be quite harmful in tests.","commit_id":"bf48557570a259a80024e33066cb6d3e6d74a978"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"206b1082de10ed08dc3229c72938cfabff3dae7f","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":94,"context_line":"        image \u003d self.create_snapshot(server)"},{"line_number":95,"context_line":"        self.addCleanup(self.client.delete_image, image[\u0027id\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @decorators.idempotent_id(\u002771bcb732-0261-11e7-9086-fa163e4fa634\u0027)"},{"line_number":99,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1d360c2_7a452fe1","line":96,"updated":"2022-10-12 15:08:52.000000000","message":"NameError here right?","commit_id":"bf48557570a259a80024e33066cb6d3e6d74a978"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"206b1082de10ed08dc3229c72938cfabff3dae7f","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":108,"context_line":"        image \u003d self.create_snapshot(server)"},{"line_number":109,"context_line":"        self.addCleanup(self.client.delete_image, image[\u0027id\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00278ca07fec-0262-11e7-907e-fa163e4fa634\u0027)"},{"line_number":113,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b2dbe18_3a48a2cc","line":110,"range":{"start_line":110,"start_character":25,"end_line":110,"end_character":38},"updated":"2022-10-12 15:08:52.000000000","message":"Also here","commit_id":"bf48557570a259a80024e33066cb6d3e6d74a978"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"206b1082de10ed08dc3229c72938cfabff3dae7f","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":122,"context_line":"        image \u003d self.create_snapshot(server)"},{"line_number":123,"context_line":"        self.addCleanup(self.client.delete_image, image[\u0027id\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"b1170dca_fd0a93af","line":124,"range":{"start_line":124,"start_character":25,"end_line":124,"end_character":38},"updated":"2022-10-12 15:08:52.000000000","message":"And here","commit_id":"bf48557570a259a80024e33066cb6d3e6d74a978"}]}