)]}'
{"tempest/tests/common/utils/linux/test_remote_client.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"fc9a8b6cd0cefa5a60a360e254e9693423449f3f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d free_output"},{"line_number":72,"context_line":"        # TODO(maurosr): this inconsistency between return types"},{"line_number":73,"context_line":"        # (sometimes integers like in vcpus\u0027s one, sometimes strings like here)"},{"line_number":74,"context_line":"        # bothers me. better fix it before submit."},{"line_number":75,"context_line":"        self.assertEqual(self.conn.get_ram_size_in_mb(), \u002748294\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_write_to_console_regular_str(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FUjA%3D","line":74,"updated":"2014-04-29 01:29:58.000000000","message":"are you going to fix it? :)","commit_id":"eff189767b75c2123d6949ac62ae4f7e83b859ac"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"c83f50aa1f46004c765f04b7ac8e4edc24c279a3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d free_output"},{"line_number":72,"context_line":"        # TODO(maurosr): this inconsistency between return types"},{"line_number":73,"context_line":"        # (sometimes integers like in vcpus\u0027s one, sometimes strings like here)"},{"line_number":74,"context_line":"        # bothers me. better fix it before submit."},{"line_number":75,"context_line":"        self.assertEqual(self.conn.get_ram_size_in_mb(), \u002748294\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_write_to_console_regular_str(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_2296d54c","line":74,"in_reply_to":"AAAAXH%2F%2FUjA%3D","updated":"2014-05-05 13:08:37.000000000","message":"sure, my bad missing this, thanks!","commit_id":"eff189767b75c2123d6949ac62ae4f7e83b859ac"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"afdd500c95a1e16f4f1a68d2ddd8d43ded2d9143","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d free_output"},{"line_number":69,"context_line":"        # TODO(maurosr): this inconsistency between return types"},{"line_number":70,"context_line":"        # (sometimes integers like in vcpus\u0027s one, sometimes strings like here)"},{"line_number":71,"context_line":"        # bothers me. better fix it before submit."},{"line_number":72,"context_line":"        self.assertEqual(self.conn.get_ram_size_in_mb(), \u002748294\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_write_to_console_regular_str(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_70329811","line":71,"updated":"2014-05-09 21:49:10.000000000","message":"I\u0027m not sure if you forgot to remove this comment or if you intended to fix it.","commit_id":"1fef2d43b5ce91d84ad9048f0559e14e5022a595"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"1fe74288e8233ea03dce0ead163ae4ddfa2858d9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d free_output"},{"line_number":69,"context_line":"        # TODO(maurosr): this inconsistency between return types"},{"line_number":70,"context_line":"        # (sometimes integers like in vcpus\u0027s one, sometimes strings like here)"},{"line_number":71,"context_line":"        # bothers me. better fix it before submit."},{"line_number":72,"context_line":"        self.assertEqual(self.conn.get_ram_size_in_mb(), \u002748294\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_write_to_console_regular_str(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_eb07881b","line":71,"in_reply_to":"7adec928_70329811","updated":"2014-05-12 14:30:31.000000000","message":"realmente esqueci","commit_id":"1fef2d43b5ce91d84ad9048f0559e14e5022a595"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"a6d804f44c84ae0b53c1e1d2cbe8ca3b0046f628","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d free_output"},{"line_number":69,"context_line":"        # TODO(maurosr): this inconsistency between return types"},{"line_number":70,"context_line":"        # (sometimes integers like in vcpus\u0027s one, sometimes strings like here)"},{"line_number":71,"context_line":"        # bothers me. better fix it before submit."},{"line_number":72,"context_line":"        self.assertEqual(self.conn.get_ram_size_in_mb(), \u002748294\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_write_to_console_regular_str(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_ae458e18","line":71,"in_reply_to":"7adec928_eb07881b","updated":"2014-05-12 14:44:34.000000000","message":"sorry, monday morning slowness.. I meant that I really forgot, another version in a sec","commit_id":"1fef2d43b5ce91d84ad9048f0559e14e5022a595"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"dc38961026a9689e78a7da2e4b6476a226c5d730","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.ssh_mock \u003d self.useFixture(mockpatch.PatchObject(self.conn,"},{"line_number":37,"context_line":"                                                              \u0027ssh_client\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_exec_command(self):"},{"line_number":40,"context_line":"        self.conn.exec_command(\u0027test\u0027)"},{"line_number":41,"context_line":"        self.ssh_mock.mock.exec_command.assert_called_once_with(\u0027test\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_4a5a5984","line":39,"updated":"2014-05-22 06:19:12.000000000","message":"IMHO the test coverage of this test is a bit questionable since it\u0027s just:\n\n    def exec_command(self, cmd):\n        return self.ssh_client.exec_command(cmd)","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"454c9d7610c2ac5a43666f562e37fb57db72ab4c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.ssh_mock \u003d self.useFixture(mockpatch.PatchObject(self.conn,"},{"line_number":37,"context_line":"                                                              \u0027ssh_client\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_exec_command(self):"},{"line_number":40,"context_line":"        self.conn.exec_command(\u0027test\u0027)"},{"line_number":41,"context_line":"        self.ssh_mock.mock.exec_command.assert_called_once_with(\u0027test\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_ecaa80d3","line":39,"in_reply_to":"7adec928_4a5a5984","updated":"2014-05-30 13:50:06.000000000","message":"agreed","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"dc38961026a9689e78a7da2e4b6476a226c5d730","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.conn.exec_command(\u0027test\u0027)"},{"line_number":41,"context_line":"        self.ssh_mock.mock.exec_command.assert_called_once_with(\u0027test\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_validation_auth(self):"},{"line_number":44,"context_line":"        self.conn.validate_authentication()"},{"line_number":45,"context_line":"        self.ssh_mock.mock.test_connection_auth.assert_any_call()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_8a53816b","line":43,"updated":"2014-05-22 06:19:12.000000000","message":"Same here.","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"454c9d7610c2ac5a43666f562e37fb57db72ab4c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.conn.exec_command(\u0027test\u0027)"},{"line_number":41,"context_line":"        self.ssh_mock.mock.exec_command.assert_called_once_with(\u0027test\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_validation_auth(self):"},{"line_number":44,"context_line":"        self.conn.validate_authentication()"},{"line_number":45,"context_line":"        self.ssh_mock.mock.test_connection_auth.assert_any_call()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_4cb9b42d","line":43,"in_reply_to":"7adec928_8a53816b","updated":"2014-05-30 13:50:06.000000000","message":"Done","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"dc38961026a9689e78a7da2e4b6476a226c5d730","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_get_files(self):"},{"line_number":57,"context_line":"        files \u003d [\u0027nova_stuff\u0027, \u0027tempest_stuff\u0027, \u0027test.py\u0027]"},{"line_number":58,"context_line":"        # ls -1 has a new line at the end so explicitly (unfortunately) add it"},{"line_number":59,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d \u0027\\n\u0027.join(files) + \u0027\\n\u0027"},{"line_number":60,"context_line":"        self.assertEqual(self.conn.get_files(\u0027/tmp\u0027), files)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_6aed558b","line":58,"updated":"2014-05-22 06:19:12.000000000","message":"But it\u0027s a \"ls -m\" and not \"-l\"","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"1c99520e1339ba08f7f1501b1d2f04ba6ec9933f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_get_files(self):"},{"line_number":57,"context_line":"        files \u003d [\u0027nova_stuff\u0027, \u0027tempest_stuff\u0027, \u0027test.py\u0027]"},{"line_number":58,"context_line":"        # ls -1 has a new line at the end so explicitly (unfortunately) add it"},{"line_number":59,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d \u0027\\n\u0027.join(files) + \u0027\\n\u0027"},{"line_number":60,"context_line":"        self.assertEqual(self.conn.get_files(\u0027/tmp\u0027), files)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_aa211db6","line":58,"in_reply_to":"7adec928_6aed558b","updated":"2014-05-22 06:20:52.000000000","message":"Oh, I missed that you changed that in a dependent patch. So ignore this comment.","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"dc38961026a9689e78a7da2e4b6476a226c5d730","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def test_get_files(self):"},{"line_number":57,"context_line":"        files \u003d [\u0027nova_stuff\u0027, \u0027tempest_stuff\u0027, \u0027test.py\u0027]"},{"line_number":58,"context_line":"        # ls -1 has a new line at the end so explicitly (unfortunately) add it"},{"line_number":59,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d \u0027\\n\u0027.join(files) + \u0027\\n\u0027"},{"line_number":60,"context_line":"        self.assertEqual(self.conn.get_files(\u0027/tmp\u0027), files)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_get_files_empty(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_eaf8854b","line":59,"updated":"2014-05-22 06:19:12.000000000","message":"I think it should be something like this:\n\n  \u0027, \u0027.join(files) + \u0027\\n\u0027","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"dc38961026a9689e78a7da2e4b6476a226c5d730","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._assert_exec_called_with("},{"line_number":87,"context_line":"            \u0027sudo sh -c \"echo \\\\\"\\\\\\\\$\\\\\" \u003e/dev/console\"\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # NOTE(maurosr): The tests above  end up closer to an output format"},{"line_number":90,"context_line":"    # assurance than a test since it\u0027s basically using comand_exec to format"},{"line_number":91,"context_line":"    # the information using gnu linux tools."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_aaacbd36","line":89,"updated":"2014-05-22 06:19:12.000000000","message":"- There are two blanks between \"above\" and \"end\"\n-  Could you move this comment to the test that you are actually commenting.","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"454c9d7610c2ac5a43666f562e37fb57db72ab4c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._assert_exec_called_with("},{"line_number":87,"context_line":"            \u0027sudo sh -c \"echo \\\\\"\\\\\\\\$\\\\\" \u003e/dev/console\"\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # NOTE(maurosr): The tests above  end up closer to an output format"},{"line_number":90,"context_line":"    # assurance than a test since it\u0027s basically using comand_exec to format"},{"line_number":91,"context_line":"    # the information using gnu linux tools."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_cc0f84e0","line":89,"in_reply_to":"7adec928_aaacbd36","updated":"2014-05-30 13:50:06.000000000","message":"So this comment is valid though for all the tests *bellow* so I would like to keep it here (s/above/below/)","commit_id":"dfdc48c2f5051a3907669db8e9da16f0612929b8"}]}