)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"5fcfcfc7c9c3510da7c97b5d471e78e62eb39f3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4787e650_a4653459","updated":"2022-11-17 09:30:46.000000000","message":"There is an issue with ironic deployed with nova-compute for VMs in one region. It is good idea to somehow fix this issue.","commit_id":"cacdc7bb48f904cc6423d636eb69c0d6c10c1998"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"81dade63317766b51be9550d2cde4257aa47e280","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a13c14a3_ea23d250","updated":"2022-11-23 11:54:15.000000000","message":"Will it work fine when we will setup compute+controllers on the same server/host? It is fairly often scenario, especially for undercloud.","commit_id":"cacdc7bb48f904cc6423d636eb69c0d6c10c1998"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"06bbd9253c9968a90b91c4c1ac6b561ef092d2ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d113268_1cecf8f5","updated":"2022-11-23 09:22:32.000000000","message":"makes sense, the tests which use the get_host_other_than method (live migration tests) are passing just fine - https://616799dc92342e4339ac-2c89d144870e68b4db6a058941a05dc8.ssl.cf5.rackcdn.com/864789/1/check/nova-live-migration/69343f7/testr_results.html\n\n thanks for proposing this","commit_id":"cacdc7bb48f904cc6423d636eb69c0d6c10c1998"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c411cd0b1dab1e1cda537c69f99a833959eee7af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71088368_31a7fa79","updated":"2022-11-24 05:38:40.000000000","message":"lgtm","commit_id":"f4970a3f8a07e0b7d1ee98dd1289e0a14e8f25b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6f1b820befac786992a02a1ed7f3e4a07415c034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"154aa6cf_556d839f","updated":"2022-11-24 07:53:27.000000000","message":"looks good to me, thanks","commit_id":"f4970a3f8a07e0b7d1ee98dd1289e0a14e8f25b3"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0633f21adb5a34da2433883ad767900ab44be1b0","unresolved":true,"context_lines":[{"line_number":702,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":703,"context_line":"        hosts \u003d []"},{"line_number":704,"context_line":"        for svc in svcs:"},{"line_number":705,"context_line":"            if svc[\u0027host\u0027].endswith(\u0027-ironic\u0027) or svc[\u0027host\u0027] in controllers:"},{"line_number":706,"context_line":"                continue"},{"line_number":707,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":708,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b52ab81d_412c2fab","line":705,"range":{"start_line":705,"start_character":50,"end_line":705,"end_character":77},"updated":"2022-11-23 16:52:11.000000000","message":"but if compute service is also running in controller service node then it does not prevent to live migrate to that right?","commit_id":"cacdc7bb48f904cc6423d636eb69c0d6c10c1998"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"138ba6ddf8ada02285c55a44bbc0d225d9bd1f73","unresolved":true,"context_lines":[{"line_number":702,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":703,"context_line":"        hosts \u003d []"},{"line_number":704,"context_line":"        for svc in svcs:"},{"line_number":705,"context_line":"            if svc[\u0027host\u0027].endswith(\u0027-ironic\u0027) or svc[\u0027host\u0027] in controllers:"},{"line_number":706,"context_line":"                continue"},{"line_number":707,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":708,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c37862ae_c1dbc094","line":705,"range":{"start_line":705,"start_character":50,"end_line":705,"end_character":77},"in_reply_to":"b52ab81d_412c2fab","updated":"2022-11-23 17:12:51.000000000","message":"this can be only in all-in-one configurations where migrations should\u0027t work at all","commit_id":"cacdc7bb48f904cc6423d636eb69c0d6c10c1998"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"38cc86fc80030bcd0bed1cf88b6345f4c8defff3","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":703,"context_line":"        hosts \u003d []"},{"line_number":704,"context_line":"        for svc in svcs:"},{"line_number":705,"context_line":"            if svc[\u0027host\u0027].endswith(\u0027-ironic\u0027) or svc[\u0027host\u0027] in controllers:"},{"line_number":706,"context_line":"                continue"},{"line_number":707,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":708,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":1,"id":"410f401c_381e9cd4","line":705,"range":{"start_line":705,"start_character":50,"end_line":705,"end_character":77},"in_reply_to":"c37862ae_c1dbc094","updated":"2022-11-23 20:04:36.000000000","message":"Ghanshyam Mann right, some deployment schemes (Undercloud for example) can combine compute with controller services, so lets fix the issue only where we can.","commit_id":"cacdc7bb48f904cc6423d636eb69c0d6c10c1998"}]}