)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0e88654cdfdb2837bce9b9ed3a2ab53fd289ebd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f876ec2_45303d33","updated":"2022-11-21 10:15:20.000000000","message":"Looks good to me.\n\nThe test is passing. I tested the test also on my local environment and it worked fine. I added just two comments I am not 100 % sure about. ","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fa6c7e77d37b828fd83f0dca652419e1ffa8cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4d00b2c_40f7e197","updated":"2022-11-21 16:08:14.000000000","message":"looks good, I have a few questions too though","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69cfee1b8e68ec66aa1e83ba5d7624cbce9ec93f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69ae9d1a_b3e0d185","updated":"2022-11-18 18:24:49.000000000","message":"test is passing fine https://8f934895f3c98f9beb6d-3ef9e777966cf361bd9799f22afa5b88.ssl.cf1.rackcdn.com/864968/4/check/tempest-full-py3/0af117e/testr_results.html","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"6b0a193f5d5919705d586ad6560cdf23d6fa6221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dd08c489_e1f330f3","updated":"2022-11-23 10:35:15.000000000","message":"Looks good to me","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3543e14c6af06ff89b7436df626b2343c6247250","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"938126db_11102564","updated":"2022-11-23 14:05:19.000000000","message":"lgtm, let\u0027s go while gates work ","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"420c590f97676a9b10efef549eda9eb630ba5b2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"739735ae_f8babeb2","updated":"2022-11-23 08:18:25.000000000","message":"recheck database connection failed","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"85e5a4059db829dce988ecd91c72466fdb9f1213","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0827e12_4d65ed3f","updated":"2022-11-22 23:59:11.000000000","message":"recheck ssh timeout","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d6d96d81d3ca0ad74cf199dbe97698e0d430e83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4657992_fef07195","updated":"2022-11-22 01:12:37.000000000","message":"recheck ssh timeout","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5698fe226d2d900c250708440d6b30a85ac6f02a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d85b84d1_3fa7a162","updated":"2022-11-22 07:41:22.000000000","message":"recheck timeout","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a3f0e25851d851215fcf4fc5a2edbf3f59bee82b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"91763eeb_4c0dc9e8","updated":"2022-11-22 17:58:54.000000000","message":"recheck volume state error","commit_id":"81bd0e9e19c30fb2685c744aedbc40c766885a9a"}],"tempest/api/compute/admin/test_server_external_events.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fa6c7e77d37b828fd83f0dca652419e1ffa8cda","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"a5bbb194_e3114d74","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2022-11-21 16:08:14.000000000","message":"2022?","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a835961b1827d41555174e15747bc4a999bf29f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"a614e49a_e344165d","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"a5bbb194_e3114d74","updated":"2022-11-21 20:27:50.000000000","message":"Done","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0e88654cdfdb2837bce9b9ed3a2ab53fd289ebd7","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Test server external events test\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u00276bbf4723-61d2-4372-af55-7ba27f1c9ba6\u0027)"},{"line_number":23,"context_line":"    def test_create_server_external_events(self):"},{"line_number":24,"context_line":"        \"\"\"Test getting server diagnostics\"\"\""},{"line_number":25,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]"},{"line_number":26,"context_line":"        events \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"c62bc343_f0f34820","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":42},"updated":"2022-11-21 10:15:20.000000000","message":"Would not be test_create_network_changed_external_event name better? For example, if we plan to add tests for other events in future (network-vif-plugged, network-vif-unplugged, ...)?","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"6b0a193f5d5919705d586ad6560cdf23d6fa6221","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Test server external events test\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u00276bbf4723-61d2-4372-af55-7ba27f1c9ba6\u0027)"},{"line_number":23,"context_line":"    def test_create_server_external_events(self):"},{"line_number":24,"context_line":"        \"\"\"Test getting server diagnostics\"\"\""},{"line_number":25,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]"},{"line_number":26,"context_line":"        events \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"d1624524_772268df","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":42},"in_reply_to":"77877fd7_14688ad8","updated":"2022-11-23 10:35:15.000000000","message":"Ack","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"888dfcf4b684caa7366eb58635f15fd780565343","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Test server external events test\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u00276bbf4723-61d2-4372-af55-7ba27f1c9ba6\u0027)"},{"line_number":23,"context_line":"    def test_create_server_external_events(self):"},{"line_number":24,"context_line":"        \"\"\"Test getting server diagnostics\"\"\""},{"line_number":25,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]"},{"line_number":26,"context_line":"        events \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"77877fd7_14688ad8","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":42},"in_reply_to":"c62bc343_f0f34820","updated":"2022-11-21 20:30:01.000000000","message":"API is only one for generating any event. so if we want to add other event test then I think we can add those in events request body in this test or may be new test with specific name to test something special about any other event. This test is generic for testing the external event not specific to network-changed only","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0e88654cdfdb2837bce9b9ed3a2ab53fd289ebd7","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u00276bbf4723-61d2-4372-af55-7ba27f1c9ba6\u0027)"},{"line_number":23,"context_line":"    def test_create_server_external_events(self):"},{"line_number":24,"context_line":"        \"\"\"Test getting server diagnostics\"\"\""},{"line_number":25,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]"},{"line_number":26,"context_line":"        events \u003d ["},{"line_number":27,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7593db64_f3ff7279","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":45},"updated":"2022-11-21 10:15:20.000000000","message":"Is it really correct?","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"888dfcf4b684caa7366eb58635f15fd780565343","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u00276bbf4723-61d2-4372-af55-7ba27f1c9ba6\u0027)"},{"line_number":23,"context_line":"    def test_create_server_external_events(self):"},{"line_number":24,"context_line":"        \"\"\"Test getting server diagnostics\"\"\""},{"line_number":25,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]"},{"line_number":26,"context_line":"        events \u003d ["},{"line_number":27,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"8dc66970_c6cdd46a","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":45},"in_reply_to":"7593db64_f3ff7279","updated":"2022-11-21 20:30:01.000000000","message":"Done","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"}],"tempest/lib/api_schema/response/compute/v2_1/server_external_events.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fa6c7e77d37b828fd83f0dca652419e1ffa8cda","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"d371890a_8cb72a8d","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":13},"updated":"2022-11-21 16:08:14.000000000","message":"nit: a line with the Copyright is missing, although some time ago I was told that line isn\u0027t a requirement just the the license is","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a835961b1827d41555174e15747bc4a999bf29f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"8c204182_690d16eb","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":13},"in_reply_to":"d371890a_8cb72a8d","updated":"2022-11-21 20:27:50.000000000","message":"Done","commit_id":"c18271f65872cf43a1e12e746e4fa49f24752475"}]}