)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5eb576cff33637f207606bf80b794aa6c4b3ec5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eaa20b82_cd0e11c9","updated":"2022-11-18 17:26:21.000000000","message":"Neutron CI job, testing patch: https://review.opendev.org/c/openstack/neutron/+/865039/\n\n\"neutron-ovs-tempest-multinode-full\" is is passing now. I\u0027ll re-check again this patch several times in order to confirm this tempest patch solves this issue (including the Neutron patch https://review.opendev.org/c/openstack/neutron/+/837780)","commit_id":"b08c1dbbf5f95f726b9792d89877a64f3810f24f"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"83ebf035efe6e6d0a1ca1147e973e80357b90f3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4c6903c_97a9fdbb","updated":"2022-11-21 09:17:38.000000000","message":"It looks like the patch is still a work in progress. I just added a little suggestion. Feel free to ignore it for now.","commit_id":"26359eedb2684e19b32bf521f1f56d9f5ce1b508"}],"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f59a30849176e14546c714af59b390f54c3e878b","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        self.assertTrue("},{"line_number":287,"context_line":"            test_utils.call_until_true("},{"line_number":288,"context_line":"                self._is_port_status_active, CONF.validation.connect_timeout,"},{"line_number":289,"context_line":"                30, subport[\u0027id\u0027]))"},{"line_number":290,"context_line":"        self.assertTrue("},{"line_number":291,"context_line":"            test_utils.call_until_true("},{"line_number":292,"context_line":"                self._is_port_status_active, CONF.validation.connect_timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa858e81_0dd54f87","line":289,"range":{"start_line":289,"start_character":16,"end_line":289,"end_character":35},"updated":"2022-11-18 21:55:51.000000000","message":"It don\u0027t think this is what you meant. The signature of call_until_true (https://github.com/openstack/tempest/blob/2c6da1db396c018ec6d52961edfadd9fe20cb5ad/tempest/lib/common/utils/test_utils.py#L98) is:\n\ndef call_until_true(func, duration, sleep_for, *args, **kwargs):\n\nSo here we are changing sleep_for, \"The number of seconds to sleep after an unsuccessful invocation of the function\". It seems you  meant to change the duration argument. I\u0027m going to try with 120.","commit_id":"b08c1dbbf5f95f726b9792d89877a64f3810f24f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f6966c426a34dc71b6b27c1c338181519410dcd6","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        self.assertTrue("},{"line_number":287,"context_line":"            test_utils.call_until_true("},{"line_number":288,"context_line":"                self._is_port_status_active, CONF.validation.connect_timeout,"},{"line_number":289,"context_line":"                30, subport[\u0027id\u0027]))"},{"line_number":290,"context_line":"        self.assertTrue("},{"line_number":291,"context_line":"            test_utils.call_until_true("},{"line_number":292,"context_line":"                self._is_port_status_active, CONF.validation.connect_timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"92c99182_52beaed7","line":289,"range":{"start_line":289,"start_character":16,"end_line":289,"end_character":35},"in_reply_to":"fa858e81_0dd54f87","updated":"2022-11-18 22:11:53.000000000","message":"Looking at the logs:\n\nvalidation.connect_timeout     \u003d 60\n\nSo I\u0027m going to double it.","commit_id":"b08c1dbbf5f95f726b9792d89877a64f3810f24f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f59a30849176e14546c714af59b390f54c3e878b","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        self.assertTrue("},{"line_number":291,"context_line":"            test_utils.call_until_true("},{"line_number":292,"context_line":"                self._is_port_status_active, CONF.validation.connect_timeout,"},{"line_number":293,"context_line":"                30, parent[\u0027id\u0027]))"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"class LiveMigrationRemoteConsolesV26Test(LiveMigrationTestBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcc1adff_09a09c4d","line":293,"range":{"start_line":293,"start_character":16,"end_line":293,"end_character":33},"updated":"2022-11-18 21:55:51.000000000","message":"Ditto","commit_id":"b08c1dbbf5f95f726b9792d89877a64f3810f24f"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"83ebf035efe6e6d0a1ca1147e973e80357b90f3c","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        self.assertTrue("},{"line_number":287,"context_line":"            test_utils.call_until_true("},{"line_number":288,"context_line":"                self._is_port_status_active,"},{"line_number":289,"context_line":"                CONF.validation.connect_timeout * 2, 5, subport[\u0027id\u0027]))"},{"line_number":290,"context_line":"        self.assertTrue("},{"line_number":291,"context_line":"            test_utils.call_until_true("},{"line_number":292,"context_line":"                self._is_port_status_active,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b48b935_f6ae7898","line":289,"range":{"start_line":289,"start_character":16,"end_line":289,"end_character":51},"updated":"2022-11-21 09:17:38.000000000","message":"If it were me, I would add a little explanation of the doubling of the time limit here. For example, something like:\n\n```\n# NOTE: Doubling the timeout value as the status update of the \n#       trunk migrated ports takes more time.\ntimeout \u003d CONF.validation.connect_timeout * 2\n\nself.assertTrue(\n      test_utils.call_until_true(\n          self._is_port_status_active,\n          timeout, 5, subport[\u0027id\u0027])\n)\n...\n```","commit_id":"26359eedb2684e19b32bf521f1f56d9f5ce1b508"}]}