)]}'
{"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"81b4f07d982bcc2818b1b2c66a8333929267cbfc","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                                     policies\u003dpolicies)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":"        group_id \u003d body[\u0027id\u0027]"},{"line_number":115,"context_line":"        self.addCleanup(self.client.delete_server_group, group_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        hints \u003d {\u0027group\u0027: group_id}"},{"line_number":118,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_141ce112","line":115,"updated":"2014-05-28 18:47:22.000000000","message":"I am not sure, but maybe it will be better to put self.addCleanup(...) in front of self.assertEqual(...) (L113) to avoid resource leakage.","commit_id":"60a67f755c05010e32a5fb7639f9c47bb95ba5fe"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3687ca2ce822785b6a68b84586a449f518173c8b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                                     policies\u003dpolicies)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":"        group_id \u003d body[\u0027id\u0027]"},{"line_number":115,"context_line":"        self.addCleanup(self.client.delete_server_group, group_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        hints \u003d {\u0027group\u0027: group_id}"},{"line_number":118,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f3126657","line":115,"in_reply_to":"1ae5cdf2_870c8996","updated":"2014-05-30 09:20:27.000000000","message":"OK. Thanks for clarification.","commit_id":"60a67f755c05010e32a5fb7639f9c47bb95ba5fe"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8f4f0e3f6f0b132efe0e2e7a5d912f8a9ec92bf4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                                     policies\u003dpolicies)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":"        group_id \u003d body[\u0027id\u0027]"},{"line_number":115,"context_line":"        self.addCleanup(self.client.delete_server_group, group_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        hints \u003d {\u0027group\u0027: group_id}"},{"line_number":118,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_870c8996","line":115,"in_reply_to":"3ae8d1ca_141ce112","updated":"2014-05-30 02:25:29.000000000","message":"When returning a failure response(not http200), the resource would not be created. so we need to add addCleanup after the status code check.","commit_id":"60a67f755c05010e32a5fb7639f9c47bb95ba5fe"}]}
