)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e48e81aceb1b1e44178dcae3272d4f3d1f22f0c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfdc34b8_bdceaf4c","updated":"2023-01-19 19:16:10.000000000","message":"direction looks good to me, in initial look one comment for logging request info. ","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1cd986461225ef2360f9e2ac5452fec4c3c17a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a07c3339_7928b1da","updated":"2023-01-24 06:05:58.000000000","message":"lgtm, as test skip patch is merged https://review.opendev.org/c/openstack/tempest/+/870974\n\ncan we rebase in on master and try to unskip test to check if chunked download fix the issue?","commit_id":"8f93d9d8d5f448bebb85e482d5b27d2bd638f4d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fb1a0d11cf90042b751fe8ac2e82f245201b08ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"604d6382_01773533","updated":"2023-01-20 14:44:25.000000000","message":"recheck looks like multiple package dep failures","commit_id":"8f93d9d8d5f448bebb85e482d5b27d2bd638f4d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6bb0f3620cb0fb6c78086214d114054722965a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f3a5cb78_b9cf00a1","updated":"2023-01-20 17:43:48.000000000","message":"recheck ovn setup failure","commit_id":"8f93d9d8d5f448bebb85e482d5b27d2bd638f4d7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"597cc975f97befc65630982f80e85d0ea5edb6de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"21b7d928_8ed89cb8","updated":"2023-02-02 02:02:45.000000000","message":"lgtm thanks. ","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dbe0c70ec2b5dda5a2027296538cb9d7b3347fca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bba3d010_d32b6bd9","updated":"2023-02-03 16:59:57.000000000","message":"recheck another job timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"735856067d9db8a78217224b43c658d3df583fdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4f398ac0_0496001b","updated":"2023-02-03 21:49:14.000000000","message":"recheck failed distro package install","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dc4218312df727c60e89a82d307fc80cb766871f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"96a09a25_94545ebd","updated":"2023-02-09 23:20:43.000000000","message":"recheck failed one ssh timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e89bae7010c2abb98db47df05a92d9447602f632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"86783ef0_c89463b5","updated":"2023-02-08 21:40:46.000000000","message":"recheck failed one vol test in gate...again","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7e4d429f2d4c0cc559fcee8411e3bc1b6c5fcace","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07442395_3900cecb","updated":"2023-02-08 14:54:12.000000000","message":"recheck gateway timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ea61a6203eb9ea0dac77106c5dccc816d9a1b52a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd5725b4_2ed32022","updated":"2023-01-26 15:39:34.000000000","message":"recheck job timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a7b3de41030cfae414ce7e9dfa71b9bd8b7effd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ffafd036_930fdd3a","updated":"2023-02-02 07:13:36.000000000","message":"recheck multinode job is unstable ","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"95c029af0aa274a4f70fb9de754b2717124e3f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4c335665_6eeba6a6","updated":"2023-02-09 14:42:17.000000000","message":"recheck mysql OOM","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e93aa0a8fb519908feb8a170a9bb4b932fb5e5c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6d5b38d9_eb101555","updated":"2023-02-01 16:07:59.000000000","message":"recheck ssh to guest timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"80afe4df5405bd6f424af8f393740cc0bc65f435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"04b11f0a_135c9fd8","updated":"2023-02-02 22:02:04.000000000","message":"recheck timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d71aa1fa97998f1f44a84cba0ea59c0d02368449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23cffcf2_e3d476fc","updated":"2023-02-09 08:26:19.000000000","message":"recheck timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfda0349c6e7291112ace38ef9e1739a7938a29c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"570dd45a_44b5dfea","updated":"2023-02-10 02:27:20.000000000","message":"recheck timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ed8e6d7076bf6e3d02fb57786cb7efe98809db2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"92ac1989_cc304017","updated":"2023-02-03 07:22:06.000000000","message":"recheck timeout in multinode","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8565a5689e520ae7185d7d84df32f732f8f1dc6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"453aa3b7_f2fac743","updated":"2023-02-09 02:19:12.000000000","message":"recheck timeout in rbac-default job","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"83e2337d026b055fd4918c20cac8d99bbeacd280","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5a86b61b_2a9fbbf1","updated":"2023-02-05 20:59:47.000000000","message":"recheck timeout out in yet different job now ..","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"412d880849971fc411bfe45f4b23de45d6faf005","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efa8b751_71d1c12b","updated":"2023-02-02 12:15:13.000000000","message":"recheck weird random timeout ","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"72e1d65b7bd2970957c7c54d2a2edb5595ff7ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b24d6d7b_e0ba26bc","updated":"2023-02-06 11:15:51.000000000","message":"recheck weird timeout","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"163523956704ee9c4282bb651f1b450a6f45be60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2923c52_e65b37c5","updated":"2023-02-07 15:15:10.000000000","message":"recheck why can\u0027t all jobs timeout at the same time? 😄 ","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b415b5942c61dca7d13a76ea84ca063d595c8916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e622e72_bdde7dcb","updated":"2023-02-02 02:03:01.000000000","message":"recheck yoga job timeout unrelated to this change","commit_id":"2c192f46db1b253fe312f6539bfda4735bd07e15"}],"tempest/api/compute/admin/test_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e48e81aceb1b1e44178dcae3272d4f3d1f22f0c8","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        # NOTE(danms): We need to stream this, so chunked\u003dTrue means we get"},{"line_number":51,"context_line":"        # back a urllib3.HTTPResponse and have to carefully pass it to"},{"line_number":52,"context_line":"        # store_image_file() to upload it in pieces."},{"line_number":53,"context_line":"        image_data_resp \u003d self.admin_image_client.show_image_file("},{"line_number":54,"context_line":"            CONF.compute.image_ref, chunked\u003dTrue)"},{"line_number":55,"context_line":"        create_dict \u003d {"},{"line_number":56,"context_line":"            \u0027container_format\u0027: image[\u0027container_format\u0027],"},{"line_number":57,"context_line":"            \u0027disk_format\u0027: image[\u0027disk_format\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a96c4f8_9e944f8c","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"updated":"2023-01-19 19:16:10.000000000","message":"Now we are not downloading the image data here which is all good as this test is not for download image as such. If need to test if image data is downloadable without preload_content then we can add new test which can iterate over chunked data and check if complete image data is downloadable.","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8febe16a4e727bd4b09dff692994eab137158ff","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # NOTE(danms): We need to stream this, so chunked\u003dTrue means we get"},{"line_number":51,"context_line":"        # back a urllib3.HTTPResponse and have to carefully pass it to"},{"line_number":52,"context_line":"        # store_image_file() to upload it in pieces."},{"line_number":53,"context_line":"        image_data_resp \u003d self.admin_image_client.show_image_file("},{"line_number":54,"context_line":"            CONF.compute.image_ref, chunked\u003dTrue)"},{"line_number":55,"context_line":"        create_dict \u003d {"},{"line_number":56,"context_line":"            \u0027container_format\u0027: image[\u0027container_format\u0027],"},{"line_number":57,"context_line":"            \u0027disk_format\u0027: image[\u0027disk_format\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1077a6bd_2074b8f9","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"in_reply_to":"1a96c4f8_9e944f8c","updated":"2023-01-19 19:31:17.000000000","message":"Ack","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e48e81aceb1b1e44178dcae3272d4f3d1f22f0c8","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        create_dict.update(kwargs)"},{"line_number":63,"context_line":"        new_image \u003d self.admin_image_client.create_image(**create_dict)"},{"line_number":64,"context_line":"        self.addCleanup(self.admin_image_client.wait_for_resource_deletion,"},{"line_number":65,"context_line":"                        new_image[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.addCleanup(self.admin_image_client.delete_image, new_image[\u0027id\u0027])"},{"line_number":67,"context_line":"        self.admin_image_client.store_image_file(new_image[\u0027id\u0027],"},{"line_number":68,"context_line":"                                                 image_data_resp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return new_image[\u0027id\u0027]"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9205d4ac_8ea8fd3d","line":68,"range":{"start_line":63,"start_character":0,"end_line":68,"end_character":65},"updated":"2023-01-19 19:16:10.000000000","message":"If we are making request of downaload image with preload_content false (L53) then we need to close the http connection manually before we use that right? (as service client are using same http object throughout their instance)\n\nor I am missing something if connection is relaesed already?","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8febe16a4e727bd4b09dff692994eab137158ff","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        create_dict.update(kwargs)"},{"line_number":63,"context_line":"        new_image \u003d self.admin_image_client.create_image(**create_dict)"},{"line_number":64,"context_line":"        self.addCleanup(self.admin_image_client.wait_for_resource_deletion,"},{"line_number":65,"context_line":"                        new_image[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.addCleanup(self.admin_image_client.delete_image, new_image[\u0027id\u0027])"},{"line_number":67,"context_line":"        self.admin_image_client.store_image_file(new_image[\u0027id\u0027],"},{"line_number":68,"context_line":"                                                 image_data_resp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return new_image[\u0027id\u0027]"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f6f626fd_dee39e95","line":68,"range":{"start_line":63,"start_character":0,"end_line":68,"end_character":65},"in_reply_to":"9205d4ac_8ea8fd3d","updated":"2023-01-19 19:31:17.000000000","message":"Nope, you\u0027re right, I just forgot to circle back and do this. It won\u0027t hurt anything acutely, it just leaks a pool worker that gets stuck.","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e001b2ec6b7e669548ba474b5c45faca3c472f86","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        create_dict.update(kwargs)"},{"line_number":63,"context_line":"        new_image \u003d self.admin_image_client.create_image(**create_dict)"},{"line_number":64,"context_line":"        self.addCleanup(self.admin_image_client.wait_for_resource_deletion,"},{"line_number":65,"context_line":"                        new_image[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.addCleanup(self.admin_image_client.delete_image, new_image[\u0027id\u0027])"},{"line_number":67,"context_line":"        self.admin_image_client.store_image_file(new_image[\u0027id\u0027],"},{"line_number":68,"context_line":"                                                 image_data_resp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return new_image[\u0027id\u0027]"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"278999f8_ff6800ac","line":68,"range":{"start_line":63,"start_character":0,"end_line":68,"end_character":65},"in_reply_to":"f6f626fd_dee39e95","updated":"2023-02-01 16:09:42.000000000","message":"Done","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"}],"tempest/lib/common/http.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0453135d0daaa0c149a12c362f22afca358088ce","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        if not kwargs.get(\u0027preload_content\u0027, True):"},{"line_number":64,"context_line":"            # This means we asked urllib3 for streaming content, so we"},{"line_number":65,"context_line":"            # need to return the raw response and not read any data yet"},{"line_number":66,"context_line":"            return r, b\u0027\u0027"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            return Response(r), r.data"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"cd27d92d_52b13852","line":66,"updated":"2023-01-20 09:35:29.000000000","message":"huhh this makes the return type depend on a flag. But I see you documented this on  higher levels so it I won\u0027t block on it. \n\nMaybe a better API would be to always do preload_content \u003d False, return the raw object, and let the caller force the load by reading the data. But I know that it would affect all places using a GET request so that would be a very disruptive change.","commit_id":"8f93d9d8d5f448bebb85e482d5b27d2bd638f4d7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bc1053381031bcee661224b99c854bdadcb93f31","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if not kwargs.get(\u0027preload_content\u0027, True):"},{"line_number":64,"context_line":"            # This means we asked urllib3 for streaming content, so we"},{"line_number":65,"context_line":"            # need to return the raw response and not read any data yet"},{"line_number":66,"context_line":"            return r, b\u0027\u0027"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            return Response(r), r.data"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5698b3b6_348cdb3e","line":66,"in_reply_to":"a52b9199_2a2394b7","updated":"2023-01-20 15:12:27.000000000","message":"yeah.","commit_id":"8f93d9d8d5f448bebb85e482d5b27d2bd638f4d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0dba89ac5a7af52351a595c87dde6b5545fd8c7a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        if not kwargs.get(\u0027preload_content\u0027, True):"},{"line_number":64,"context_line":"            # This means we asked urllib3 for streaming content, so we"},{"line_number":65,"context_line":"            # need to return the raw response and not read any data yet"},{"line_number":66,"context_line":"            return r, b\u0027\u0027"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            return Response(r), r.data"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a52b9199_2a2394b7","line":66,"in_reply_to":"cd27d92d_52b13852","updated":"2023-01-20 14:41:18.000000000","message":"Yeah, it\u0027s also unfortunate that there are so many layers in general (although I know why), and I also think it\u0027s kind of unfortunate that we\u0027re returning something that is supposed to look like the HTTPResponse, but in dict form. It took me a minute to realize that we\u0027re not actually returning the response itself to tests. At the very least, in this case we\u0027re returning the real type that the dict is based off of, so in reality, it\u0027s not very different and a bunch of code in between actually doesn\u0027t notice.\n\nUntil the recent type annotation enforcement craze, Python used to be all about duck typing :)","commit_id":"8f93d9d8d5f448bebb85e482d5b27d2bd638f4d7"}],"tempest/lib/common/rest_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e48e81aceb1b1e44178dcae3272d4f3d1f22f0c8","unresolved":true,"context_lines":[{"line_number":640,"context_line":"            body\u003dbody, chunked\u003dchunked, preload_content\u003dpreload)"},{"line_number":641,"context_line":"        end \u003d time.time()"},{"line_number":642,"context_line":"        req_body \u003d body if log_req_body is None else log_req_body"},{"line_number":643,"context_line":"        if preload:"},{"line_number":644,"context_line":"            # NOTE(danms): If we are reading the whole response, we can do"},{"line_number":645,"context_line":"            # this logging. If not, skip the logging because it will result"},{"line_number":646,"context_line":"            # in us reading the response data prematurely."},{"line_number":647,"context_line":"            self._log_request(method, url, resp, secs\u003d(end - start),"},{"line_number":648,"context_line":"                              req_headers\u003dheaders, req_body\u003dreq_body,"},{"line_number":649,"context_line":"                              resp_body\u003dresp_body)"},{"line_number":650,"context_line":"        return resp, resp_body"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2d17bdbf_aa943a8f","line":649,"range":{"start_line":643,"start_character":0,"end_line":649,"end_character":50},"updated":"2023-01-19 19:16:10.000000000","message":"let\u0027s log at least the info for this case and we can skip _log_request_full when requesting with chunked in GET by adding flag check @L497","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8febe16a4e727bd4b09dff692994eab137158ff","unresolved":true,"context_lines":[{"line_number":640,"context_line":"            body\u003dbody, chunked\u003dchunked, preload_content\u003dpreload)"},{"line_number":641,"context_line":"        end \u003d time.time()"},{"line_number":642,"context_line":"        req_body \u003d body if log_req_body is None else log_req_body"},{"line_number":643,"context_line":"        if preload:"},{"line_number":644,"context_line":"            # NOTE(danms): If we are reading the whole response, we can do"},{"line_number":645,"context_line":"            # this logging. If not, skip the logging because it will result"},{"line_number":646,"context_line":"            # in us reading the response data prematurely."},{"line_number":647,"context_line":"            self._log_request(method, url, resp, secs\u003d(end - start),"},{"line_number":648,"context_line":"                              req_headers\u003dheaders, req_body\u003dreq_body,"},{"line_number":649,"context_line":"                              resp_body\u003dresp_body)"},{"line_number":650,"context_line":"        return resp, resp_body"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a7df5c1b_357e2cb9","line":649,"range":{"start_line":643,"start_character":0,"end_line":649,"end_character":50},"in_reply_to":"2d17bdbf_aa943a8f","updated":"2023-01-19 19:31:17.000000000","message":"That\u0027s not enough. The first thing in _log_request() does the \"in resp\" looking for headers and that triggers a FULL read of the response. Took me a while to figure that one out :)\n\nMaybe we can just log the req?","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0753bea6e743303b530883b4ad56a290b6ec3687","unresolved":true,"context_lines":[{"line_number":640,"context_line":"            body\u003dbody, chunked\u003dchunked, preload_content\u003dpreload)"},{"line_number":641,"context_line":"        end \u003d time.time()"},{"line_number":642,"context_line":"        req_body \u003d body if log_req_body is None else log_req_body"},{"line_number":643,"context_line":"        if preload:"},{"line_number":644,"context_line":"            # NOTE(danms): If we are reading the whole response, we can do"},{"line_number":645,"context_line":"            # this logging. If not, skip the logging because it will result"},{"line_number":646,"context_line":"            # in us reading the response data prematurely."},{"line_number":647,"context_line":"            self._log_request(method, url, resp, secs\u003d(end - start),"},{"line_number":648,"context_line":"                              req_headers\u003dheaders, req_body\u003dreq_body,"},{"line_number":649,"context_line":"                              resp_body\u003dresp_body)"},{"line_number":650,"context_line":"        return resp, resp_body"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d193ddca_0b634774","line":649,"range":{"start_line":643,"start_character":0,"end_line":649,"end_character":50},"in_reply_to":"a7df5c1b_357e2cb9","updated":"2023-01-19 19:34:42.000000000","message":"you are right. we can skip the resp header and data and rest all we can log","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1cd986461225ef2360f9e2ac5452fec4c3c17a9","unresolved":true,"context_lines":[{"line_number":640,"context_line":"            body\u003dbody, chunked\u003dchunked, preload_content\u003dpreload)"},{"line_number":641,"context_line":"        end \u003d time.time()"},{"line_number":642,"context_line":"        req_body \u003d body if log_req_body is None else log_req_body"},{"line_number":643,"context_line":"        if preload:"},{"line_number":644,"context_line":"            # NOTE(danms): If we are reading the whole response, we can do"},{"line_number":645,"context_line":"            # this logging. If not, skip the logging because it will result"},{"line_number":646,"context_line":"            # in us reading the response data prematurely."},{"line_number":647,"context_line":"            self._log_request(method, url, resp, secs\u003d(end - start),"},{"line_number":648,"context_line":"                              req_headers\u003dheaders, req_body\u003dreq_body,"},{"line_number":649,"context_line":"                              resp_body\u003dresp_body)"},{"line_number":650,"context_line":"        return resp, resp_body"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfd597a6_eec0518f","line":649,"range":{"start_line":643,"start_character":0,"end_line":649,"end_character":50},"in_reply_to":"d193ddca_0b634774","updated":"2023-01-24 06:05:58.000000000","message":"as it need refactoring in _log_request method and we at least log request mehtod/url in L640, I am ok to do this in followup.","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"66d71837105d1b4e9f170c22e2b1943e6621101d","unresolved":true,"context_lines":[{"line_number":640,"context_line":"            body\u003dbody, chunked\u003dchunked, preload_content\u003dpreload)"},{"line_number":641,"context_line":"        end \u003d time.time()"},{"line_number":642,"context_line":"        req_body \u003d body if log_req_body is None else log_req_body"},{"line_number":643,"context_line":"        if preload:"},{"line_number":644,"context_line":"            # NOTE(danms): If we are reading the whole response, we can do"},{"line_number":645,"context_line":"            # this logging. If not, skip the logging because it will result"},{"line_number":646,"context_line":"            # in us reading the response data prematurely."},{"line_number":647,"context_line":"            self._log_request(method, url, resp, secs\u003d(end - start),"},{"line_number":648,"context_line":"                              req_headers\u003dheaders, req_body\u003dreq_body,"},{"line_number":649,"context_line":"                              resp_body\u003dresp_body)"},{"line_number":650,"context_line":"        return resp, resp_body"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"68ebfaab_697e4436","line":649,"range":{"start_line":643,"start_character":0,"end_line":649,"end_character":50},"in_reply_to":"dfd597a6_eec0518f","updated":"2023-01-25 14:36:10.000000000","message":"Yep, I\u0027ll push this up with the skip un-skipped","commit_id":"284fa8522c8663725fa3a348231e7cd876ba9e00"}]}