)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"da3fe435bb079b226abcb5e8ba374076eaa8fbb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"086fc2b0_9aa2f61d","updated":"2023-02-13 07:38:40.000000000","message":"recheck","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"c53d25a1a444a3607d30ebd24f4f0006745b3573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38d6d790_368a7e26","updated":"2023-02-11 13:35:25.000000000","message":"recheck","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"9da9292acf19c3c15e4ba1d23c5462d023e48998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"956bdb5e_f94074f1","updated":"2023-02-12 15:35:11.000000000","message":"recheck","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"cdccd5ffa4a62992caf6fbef24cc74312796a300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"addd4c18_405c1f43","updated":"2023-02-01 07:22:10.000000000","message":"recheck","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"70e91d625de2d80239f749575025be113cb13121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d70bd8d5_37b2dd1a","updated":"2023-02-04 19:04:45.000000000","message":"recheck","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"99b30a43e69cff902871212f1bf3f1e25ab92df2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4955f1e4_97eba167","updated":"2023-02-16 02:57:31.000000000","message":"thanks for fix. please check comment inline","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"6a8f0852b27049cbde9bf51296168874f27b6607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c4a8b66_f86b14cf","in_reply_to":"4955f1e4_97eba167","updated":"2023-02-16 10:14:41.000000000","message":"Hello, Ghanshyam Mann !\nThank you for review !\n\n1 \"even with the old account.yaml, scope will  be set to \u0027project\u0027 by L132.\" \n\n1.1 Well, where to find example of new account.yaml :) ?\n1.2 In case I need to get system scope I have leave empty project and domain:\n\n- username: \u0027tempest-adm1\u0027\n  password: \u0027pass\u0027\n  roles:\n     - \u0027admin\u0027\n  resources:\n    network: \u0027tempest-adm-net1\u0027\n  system: \u0027system\u0027\n  \n  In this case there wiil be no project neither domain scope (cause of if-elif):\n\n            if \u0027project_name\u0027 in account:\n                scope \u003d \u0027project\u0027\n            elif \u0027domain_name\u0027 in account:\n                scope \u003d \u0027domain\u0027\n            elif \u0027system\u0027 in account:\n                scope \u003d \u0027system\u0027\n\n2. I like your code proposal but it leads to some unit tests failures during tox, so it looks like that code proposed by me is less becward distructive :)\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFailed 10 tests - output below:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\ntempest.tests.common.test_admin_available.TestAdminAvailableV3.test__no_dynamic_creds__accounts_file__admin_role\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentialsV3.test__get_creds_by_roles_list_role\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentialsV3.test__get_creds_by_roles_no_admin\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentialsV3.test__get_creds_by_roles_one_role\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentialsV3.test_get_alt_creds_none_available\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentialsV3.test_get_primary_creds_none_available\ntempest.tests.common.test_admin_available.TestAdminAvailable.test__no_dynamic_creds__accounts_file__admin_role\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentials.test__get_creds_by_roles_no_admin\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentials.test_get_alt_creds_none_available\ntempest.tests.lib.common.test_preprov_creds.TestPreProvisionedCredentials.test_get_primary_creds_none_available","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b220c8f44d5560eb84e695384842c41957fb8224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4d19133_0445b4f3","in_reply_to":"7c4a8b66_f86b14cf","updated":"2023-03-11 01:23:55.000000000","message":"\u003e 1.1 Well, where to find example of new account.yaml :) ?\n\u003e 1.2 In case I need to get system scope I have leave empty project and domain:\n\nYou can find the new sample file at below location. You are right. for system token there will not be any project.domain  name/id \n  \n- https://github.com/openstack/tempest/blob/baa3cc712cbf37a077291f69d8b621bd6f759132/etc/rbac-persona-accounts.yaml.sample\n\nFor unit test, let me check if they are valid failure or some backward incompatibility","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"}],"tempest/lib/common/preprov_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"99b30a43e69cff902871212f1bf3f1e25ab92df2","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            temp_hash_key \u003d temp_hash.hexdigest()"},{"line_number":142,"context_line":"            hash_dict[\u0027creds\u0027][temp_hash_key] \u003d account"},{"line_number":143,"context_line":"            for role in roles:"},{"line_number":144,"context_line":"                if scope !\u003d \u0027system\u0027:"},{"line_number":145,"context_line":"                    hash_dict \u003d cls._append_role("},{"line_number":146,"context_line":"                        role, temp_hash_key, hash_dict)"},{"line_number":147,"context_line":"                if scope:"},{"line_number":148,"context_line":"                    hash_dict \u003d cls._append_scoped_role("},{"line_number":149,"context_line":"                        scope, role, temp_hash_key, hash_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd74d08a_20aff8f8","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":55},"updated":"2023-02-16 02:57:31.000000000","message":"everything is scoped now and even with the old account.yaml, scope will  be set to \u0027project\u0027 by L132.\n\nThis code is wrong as we should not store the same account in two place, one as role L145 and other with scope L147. It should be stored with scope only. We can replace this for loop with below so that we store account with only \u003cscope\u003e_\u003crole\u003e hash only\n\n             for role in roles:\n                if scope:\n                    hash_dict \u003d cls._append_scoped_role(\n                        scope, role, temp_hash_key, hash_dict)\n                else:\n                    hash_dict \u003d cls._append_role(\n                        role, temp_hash_key, hash_dict)","commit_id":"d57a45037cb2288e88c4737e8363f3bc3b083643"}]}