)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"429cc2ced1eccd2b099c17427c53914f935d41e6","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.client.wait_for_server_status(self.server_id, \u0027VERIFY_RESIZE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.client.confirm_resize(self.server_id)"},{"line_number":204,"context_line":"        self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":207,"context_line":"        self.assertEqual(new_flavor_ref, server[\u0027flavor\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FbXI%3D","line":204,"updated":"2014-04-14 16:43:45.000000000","message":"if stop the vm_state should be SHUTOFF so this should fail","commit_id":"0f84e4512c0ae2a1d4c3c5b4ffceb40e7ce0b439"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"b431dfc4786e213a7edc757428e1e9bdfbbefbe9","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d \\"},{"line_number":191,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if stop:"},{"line_number":194,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":195,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":196,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FZG4%3D","line":193,"updated":"2014-04-14 22:27:26.000000000","message":"I don\u0027t know how I feel about embedding the stop action into this function. The case could be made to do this for any number of other actions such as suspend or lock. The test case is a good idea, but I don\u0027t think encapsulating the stop into the resize function would be a good design","commit_id":"4d73de664db4d0ea54bf6e231e81be5ca7901f97"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"cd48c8927ced313b348ef01dbc5362ac99b0991e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d \\"},{"line_number":191,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if stop:"},{"line_number":194,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":195,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":196,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FTek%3D","line":193,"in_reply_to":"AAAAW3%2F%2FTjY%3D","updated":"2014-04-15 13:27:17.000000000","message":"I totally understand your point. What I was thinking was to generalize this function so that it worked with other actions that should also cause resize failures as well","commit_id":"4d73de664db4d0ea54bf6e231e81be5ca7901f97"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22fc7f13f5bb2c6a143bc528c7015ea5b61dd24b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d \\"},{"line_number":191,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if stop:"},{"line_number":194,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":195,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":196,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FTjY%3D","line":193,"in_reply_to":"AAAAW3%2F%2FZG4%3D","updated":"2014-04-15 13:20:30.000000000","message":"The idea was to avoid a lot of duplicate code between the existing test and the new one since most of the test is the same.  The point of the stop is to test that wrinkle with the API, not to test the stop API itself.","commit_id":"4d73de664db4d0ea54bf6e231e81be5ca7901f97"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"858f15725409bd1d54a1d8372f681e2511708c7a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if stop:"},{"line_number":195,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":196,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":197,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":198,"context_line":"                                                       \u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_0fe2519f","line":195,"updated":"2014-04-29 07:38:44.000000000","message":"unused variable \"server\"","commit_id":"e3d7dcf86738e47c280290e513741739f72d0c0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c7859a203de76f5b3c16d199fc5d918b10df8d2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if stop:"},{"line_number":195,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":196,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":197,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":198,"context_line":"                                                       \u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_583586d8","line":195,"in_reply_to":"9ad9bd40_083d7dde","updated":"2014-05-05 14:00:11.000000000","message":"Done","commit_id":"e3d7dcf86738e47c280290e513741739f72d0c0d"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"4da8df72287378cefb2c77514afbb22585344487","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if stop:"},{"line_number":195,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":196,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":197,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":198,"context_line":"                                                       \u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_083d7dde","line":195,"in_reply_to":"9ad9bd40_6f481d2e","updated":"2014-05-05 06:26:42.000000000","message":"yes, or\n\nresp \u003d self.servers_client.stop(self.server_id)[0]","commit_id":"e3d7dcf86738e47c280290e513741739f72d0c0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f806d80cca36ab5f515cf890dd0c6875020b1543","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if stop:"},{"line_number":195,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":196,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":197,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":198,"context_line":"                                                       \u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_6f481d2e","line":195,"in_reply_to":"bad4c104_0fe2519f","updated":"2014-05-01 01:42:39.000000000","message":"Do you prefer:\n\nresp, _ \u003d self.servers_client.stop(self.server_id)?","commit_id":"e3d7dcf86738e47c280290e513741739f72d0c0d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"957fdef8223e226c6d916fc2b3c2d43c3c029400","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if stop:"},{"line_number":221,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":222,"context_line":"            self.client.start(self.server_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":225,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_4d858205","line":222,"updated":"2014-05-19 06:10:58.000000000","message":"Needs to wait for the server to become ACTIVE as same server is being used by other test also.","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a51f3510afbee5bc7e05fc9202e55831e6895f3","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if stop:"},{"line_number":221,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":222,"context_line":"            self.client.start(self.server_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":225,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_8552eb32","line":222,"in_reply_to":"7adec928_4d858205","updated":"2014-05-19 14:31:50.000000000","message":"The tearDown does that wait already, see line 48 that calls into this:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/base.py#n151","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01f04ef9e30475ce3cf25c7fdf8f6a47cbf2c640","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if stop:"},{"line_number":221,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":222,"context_line":"            self.client.start(self.server_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":225,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_d6b1fd47","line":222,"in_reply_to":"7adec928_8552eb32","updated":"2014-05-20 01:24:27.000000000","message":"Thanks Matt for explanation. \nYes, In tearDown it is handled to perform delete operation correctly but my point was for other test. For example, after running this test, when other test runs and found this server not in ACTIVE state which might cause failure in those test.\n\nIn general, each test should leave the common resources in the standard usable state for other test.","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc25248c7339f289db86d869d5fddc84bb8609f6","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if stop:"},{"line_number":221,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":222,"context_line":"            self.client.start(self.server_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":225,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_d8adab32","line":222,"in_reply_to":"7adec928_96593590","updated":"2014-05-20 03:45:49.000000000","message":"Yes got it. My bad :(. Thanks Matt for clarifying.","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d39faa268e836623d9a5d8dde047c63b4d266d75","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if stop:"},{"line_number":221,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":222,"context_line":"            self.client.start(self.server_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":225,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_96593590","line":222,"in_reply_to":"7adec928_d6b1fd47","updated":"2014-05-20 02:07:48.000000000","message":"tearDown is called between each test case, tearDownClass is called between each test class, so this is already handled between test cases in tearDown.\n\nIf this was an issue, test_rebuild_server_in_stop_state would have the same problem and Jenkins would most likely be failing.","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"}],"tempest/api/compute/v3/servers/test_server_actions.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"858f15725409bd1d54a1d8372f681e2511708c7a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            self._detect_server_image_flavor(self.server_id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        if stop:"},{"line_number":186,"context_line":"            resp, server \u003d self.servers_client.stop(self.server_id)"},{"line_number":187,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":188,"context_line":"            self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":189,"context_line":"                                                       \u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bad4c104_8f72e1e3","line":186,"updated":"2014-04-29 07:38:44.000000000","message":"unused variable \"server\"","commit_id":"e3d7dcf86738e47c280290e513741739f72d0c0d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"957fdef8223e226c6d916fc2b3c2d43c3c029400","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if stop:"},{"line_number":214,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":215,"context_line":"            self.client.start(self.server_id)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":218,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_b033bdf4","line":215,"updated":"2014-05-19 06:10:58.000000000","message":"same here","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a51f3510afbee5bc7e05fc9202e55831e6895f3","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if stop:"},{"line_number":214,"context_line":"            # NOTE(mriedem): tearDown requires the server to be started."},{"line_number":215,"context_line":"            self.client.start(self.server_id)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":218,"context_line":"                          \u0027Resize not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_a53447fc","line":215,"in_reply_to":"7adec928_b033bdf4","updated":"2014-05-19 14:31:50.000000000","message":"see other response","commit_id":"9fd63b8e886b97e068eac4e98b35c7e170c40056"}]}