)]}'
{"tempest/services/botoclients.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3e479f3b4d8b3f96bb7f020f620a2258448bf09d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self._config_boto_timeout(self.connection_timeout, self.num_retries)"},{"line_number":94,"context_line":"        if not all((self.connection_data[\"aws_access_key_id\"],"},{"line_number":95,"context_line":"                   self.connection_data[\"aws_secret_access_key\"])):"},{"line_number":96,"context_line":"            if all([self.ks_cred[v] is not None for v in self.ks_cred.keys()]):"},{"line_number":97,"context_line":"                ec2_cred \u003d self._keystone_aws_get()"},{"line_number":98,"context_line":"                self.connection_data[\"aws_access_key_id\"] \u003d \\"},{"line_number":99,"context_line":"                    ec2_cred.access"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_06859cac","line":96,"updated":"2014-05-02 12:20:58.000000000","message":"please roll this out into a separate named variable for what the list comprehension semantically is. I think this level of density will serve us poorly in the future.","commit_id":"ea75f8c3dd45a8838def9e93d70d6ebe6fbf5aa4"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"ba976f7a5dd6bf8d41b01d99b0a89ef912149430","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self._config_boto_timeout(self.connection_timeout, self.num_retries)"},{"line_number":94,"context_line":"        if not all((self.connection_data[\"aws_access_key_id\"],"},{"line_number":95,"context_line":"                   self.connection_data[\"aws_secret_access_key\"])):"},{"line_number":96,"context_line":"            if all([self.ks_cred[v] is not None for v in self.ks_cred.keys()]):"},{"line_number":97,"context_line":"                ec2_cred \u003d self._keystone_aws_get()"},{"line_number":98,"context_line":"                self.connection_data[\"aws_access_key_id\"] \u003d \\"},{"line_number":99,"context_line":"                    ec2_cred.access"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_11c0747b","line":96,"in_reply_to":"9ad9bd40_06859cac","updated":"2014-05-02 12:44:42.000000000","message":"I\u0027d prefer to drop the line completely. All it does is ensure that the caller has not passed None as any of the values. The previous all() did this even more implicitly than my replacement.\n\nI think that requiring sane input in a test is perfectly reasonable and that catching it and raising an exception is being too kind to test creators.","commit_id":"ea75f8c3dd45a8838def9e93d70d6ebe6fbf5aa4"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"84ec75ca2c23c4c8a9c4e0946ebb1ff3f53bab65","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self._config_boto_timeout(self.connection_timeout, self.num_retries)"},{"line_number":94,"context_line":"        if not all((self.connection_data[\"aws_access_key_id\"],"},{"line_number":95,"context_line":"                   self.connection_data[\"aws_secret_access_key\"])):"},{"line_number":96,"context_line":"            if all([self.ks_cred[v] is not None for v in self.ks_cred.keys()]):"},{"line_number":97,"context_line":"                ec2_cred \u003d self._keystone_aws_get()"},{"line_number":98,"context_line":"                self.connection_data[\"aws_access_key_id\"] \u003d \\"},{"line_number":99,"context_line":"                    ec2_cred.access"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_ece59309","line":96,"in_reply_to":"9ad9bd40_11c0747b","updated":"2014-05-17 22:15:50.000000000","message":"As I remember for doping this code part , devstack need to configure the aws credentials in the tempest conf.\nWhen I tried to have devstack do it,  after the n-th review I had some `grenade` issue, related to the ec2 friendly userrc files existence.","commit_id":"ea75f8c3dd45a8838def9e93d70d6ebe6fbf5aa4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3b4efd3fb0ea63277c954f24e0d3368ebd36d343","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                 *args, **kwargs):"},{"line_number":38,"context_line":"        # FIXME(andreaf) replace credentials and auth_url with auth_provider"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        dscv \u003d CONF.identity.disable_ssl_certificate_validation"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.connection_timeout \u003d str(CONF.boto.http_socket_timeout)"},{"line_number":43,"context_line":"        self.num_retries \u003d str(CONF.boto.num_retries)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_fd312c0c","line":40,"updated":"2014-05-31 15:06:16.000000000","message":"instead of calling it dscv, which my brain doesn\u0027t parse, can we call it \u0027insecure_ssl\u0027 everywhere.\n\nOtherwise I\u0027m +2","commit_id":"b02782ffee90906d11cffe97b1c1e9c248d55d20"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e090d915e6f5dd83cb9997b2339b0e0504ebd47a","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":117,"context_line":"        super(APIClientEC2, self).__init__(*args, **kwargs)"},{"line_number":118,"context_line":"        insecure_ssl \u003d CONF.identity.disable_ssl_certificate_validation"},{"line_number":119,"context_line":"        aws_access \u003d CONF.boto.aws_access"},{"line_number":120,"context_line":"        aws_secret \u003d CONF.boto.aws_secret"},{"line_number":121,"context_line":"        purl \u003d urlparse.urlparse(CONF.boto.ec2_url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_a6a73e4f","line":118,"updated":"2014-06-11 14:21:42.000000000","message":"Why do you need this again? It\u0027s a subclass of BotoClientBase where you already pulled this, just set it to a class level variable above or pull it from ks_cred.","commit_id":"aead3c2028dca518ff9fcfb14074c52c0fc1fea4"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e090d915e6f5dd83cb9997b2339b0e0504ebd47a","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":197,"context_line":"        super(ObjectClientS3, self).__init__(*args, **kwargs)"},{"line_number":198,"context_line":"        insecure_ssl \u003d CONF.identity.disable_ssl_certificate_validation"},{"line_number":199,"context_line":"        aws_access \u003d CONF.boto.aws_access"},{"line_number":200,"context_line":"        aws_secret \u003d CONF.boto.aws_secret"},{"line_number":201,"context_line":"        purl \u003d urlparse.urlparse(CONF.boto.s3_url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_066ab2ed","line":198,"updated":"2014-06-11 14:21:42.000000000","message":"Same here","commit_id":"aead3c2028dca518ff9fcfb14074c52c0fc1fea4"}]}