)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ff78a84c33e42a3904433175d3c081a0bbf493af","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jorge San Emeterio \u003cjsanemet@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-16 15:02:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create a tempest test to verify bz#2118968"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I99b57c27c8a4425389bec2b7f05af660bab85610"},{"line_number":10,"context_line":"Change-Id: I7c9588212a05347f9b20016aff028df6c48dafa1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"17647424_501ec17d","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":42},"updated":"2023-02-17 08:23:07.000000000","message":"could you add a launchpad or storyboard reference?","commit_id":"9664d574379b4f67fb3945f5e8d17874bbd8f452"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"338f922bbdf83532729f258779649f3537b4a786","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jorge San Emeterio \u003cjsanemet@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-16 15:02:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create a tempest test to verify bz#2118968"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I99b57c27c8a4425389bec2b7f05af660bab85610"},{"line_number":10,"context_line":"Change-Id: I7c9588212a05347f9b20016aff028df6c48dafa1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9c562b99_4dc4762d","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":42},"in_reply_to":"17647424_501ec17d","updated":"2023-02-22 14:12:07.000000000","message":"Sure, I have just added one.","commit_id":"9664d574379b4f67fb3945f5e8d17874bbd8f452"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4ee28b2475ae38f0c405a37aff822b79ee8c612f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a tempest test to verify lack of cgroupsv2 support for cpu controller."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Created a test that goes through the steps of the bug ticket and verifies that an error occurs when trying to create a flavor with cpu quota on a system running cgroupsv2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Bug: #2008102"},{"line_number":12,"context_line":"Resolves: rhbz#2118968"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"0caecd11_36bf09eb","line":9,"updated":"2023-02-23 11:03:31.000000000","message":"nit: the commit message is... not great. I understand that the bug is linked and the info is there, but the commit message should ideally be self-containing as much as is reasonnable.","commit_id":"3952b0be7a5927680a41f28c7512db6eb227d09d"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"4ba7ff8bf609c532039bf8bbf4cc50cb15a0d468","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a tempest test to verify lack of cgroupsv2 support for cpu controller."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Created a test that goes through the steps of the bug ticket and verifies that an error occurs when trying to create a flavor with cpu quota on a system running cgroupsv2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Bug: #2008102"},{"line_number":12,"context_line":"Resolves: rhbz#2118968"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"dd629ac9_a4b9d102","line":9,"in_reply_to":"0caecd11_36bf09eb","updated":"2023-02-23 12:01:40.000000000","message":"Makes sense, there is not much said there than anyone could guess. I have added another comment explaining in better detail what the test is meant for.","commit_id":"3952b0be7a5927680a41f28c7512db6eb227d09d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4ee28b2475ae38f0c405a37aff822b79ee8c612f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Created a test that goes through the steps of the bug ticket and verifies that an error occurs when trying to create a flavor with cpu quota on a system running cgroupsv2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Bug: #2008102"},{"line_number":12,"context_line":"Resolves: rhbz#2118968"},{"line_number":13,"context_line":"Depends-On: I99b57c27c8a4425389bec2b7f05af660bab85610"},{"line_number":14,"context_line":"Change-Id: I7c9588212a05347f9b20016aff028df6c48dafa1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"f9086e71_6a580882","line":12,"updated":"2023-02-23 11:03:31.000000000","message":"No downstream artifacts upstream, please :) \nAt most we can link our BZ from the additional info section of the Launchpad bug.","commit_id":"3952b0be7a5927680a41f28c7512db6eb227d09d"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"4ba7ff8bf609c532039bf8bbf4cc50cb15a0d468","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Created a test that goes through the steps of the bug ticket and verifies that an error occurs when trying to create a flavor with cpu quota on a system running cgroupsv2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Bug: #2008102"},{"line_number":12,"context_line":"Resolves: rhbz#2118968"},{"line_number":13,"context_line":"Depends-On: I99b57c27c8a4425389bec2b7f05af660bab85610"},{"line_number":14,"context_line":"Change-Id: I7c9588212a05347f9b20016aff028df6c48dafa1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"06183722_e7bf6b8e","line":12,"in_reply_to":"f9086e71_6a580882","updated":"2023-02-23 12:01:40.000000000","message":"Removed. \n\nI also added a link to bugzilla as a comment on the ticket.","commit_id":"3952b0be7a5927680a41f28c7512db6eb227d09d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7485e955567d8680e93950a5722500974285429f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Created a tempest test that builds a flavor enriched with the"},{"line_number":10,"context_line":"\"quota:cpu_quota\" property. Then, it builds a server based on that flavor"},{"line_number":11,"context_line":"and checks that it reaches the \"ACTIVE\" state. The server could fail to do so though,"},{"line_number":12,"context_line":"because under systems that operate under cgroups v2, such as \"RHEL-9\" or"},{"line_number":13,"context_line":"\"Ubuntu 22.04\", the host is not capable of determining if it has support"},{"line_number":14,"context_line":"for the cpu controller, even when the kernel does so. The test result"},{"line_number":15,"context_line":"relies then on the underlying os that it is run on."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #2008102"},{"line_number":18,"context_line":"Depends-On: I99b57c27c8a4425389bec2b7f05af660bab85610"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1c2889f3_8906a67a","line":15,"range":{"start_line":11,"start_character":47,"end_line":15,"end_character":51},"updated":"2023-07-06 19:54:44.000000000","message":"you mean this test will fail on system under cgroups v2 ? and as you mentioned this test can fail based on what OS it run against. In that case we need to add a config option and run this test based on that config option.","commit_id":"85cb3d96cc7837cb14c1c00de0623d3c9bd44e3d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"a9e086a410668ec9dea0d9f90c1dd2b708895769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bd836706_4076f8f9","updated":"2023-02-16 14:02:03.000000000","message":"Mostly done, I just need to create a launchpad ticket to link the test into.","commit_id":"9664d574379b4f67fb3945f5e8d17874bbd8f452"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4ee28b2475ae38f0c405a37aff822b79ee8c612f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1f1ef8e2_e9891cb4","updated":"2023-02-23 11:03:31.000000000","message":"Coupe of nits inline while we wait for the new run.\n\nFor other reviewers: this is a bit weird in that the Nova code that is being tested depends on the underlying host OS. Hosts with cgroups v2 (rhel 9, ubuntu \u003e\u003d 21.10 I believe) will pass one host check in Nova, hosts with cgroups v1 will pass another. In both cases this new tempest test is expected to pass, but it\u0027s why I asked Jorge to add logging to the Nova patch, so that we can see which host check got executed/passed.","commit_id":"3952b0be7a5927680a41f28c7512db6eb227d09d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c316650712ce03723ad4b92a7531577dcc0feadb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"15118d4f_535b0944","updated":"2023-02-23 10:58:19.000000000","message":"recheck run with new dependant patchset","commit_id":"3952b0be7a5927680a41f28c7512db6eb227d09d"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"599161e840848d2f65ec82f85881d72523425c1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fbbc0247_698e1def","updated":"2023-04-03 10:12:50.000000000","message":"Looks good to me. I tested this test on Ubuntu 22.04 with the fix [1] in nova and without it. The test passed/failed as expected (even though it seems that there needs to be some changes in the fix before it gets merged). I just added two small comments.\n\n[1] https://review.opendev.org/c/openstack/nova/+/873127","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2459bcfaadc9855e5f962a42c025a0297baf9ae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2115f70b_2c978cf2","updated":"2023-07-13 07:35:48.000000000","message":"With the fix (https://review.opendev.org/c/openstack/nova/+/873127) for https://bugs.launchpad.net/nova/+bug/2008102 merged in Nova (and with unit tests in the fix) - and with Jorge changing teams internally and no longer working on Nova, we can just abandon this patch, I think.","commit_id":"85cb3d96cc7837cb14c1c00de0623d3c9bd44e3d"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fb541f3cb08ae3480bf73fc402e5bd99cde82473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0fbb62c6_a6df538b","updated":"2023-04-11 11:01:50.000000000","message":"recheck\nThe timeout in grenade job is not caused by this patch.","commit_id":"85cb3d96cc7837cb14c1c00de0623d3c9bd44e3d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8119446d916edcd6f798756b06df4dbda2651a42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2473992a_bd12ed5f","updated":"2023-06-30 19:47:26.000000000","message":"recheck refresh log","commit_id":"85cb3d96cc7837cb14c1c00de0623d3c9bd44e3d"}],"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"599161e840848d2f65ec82f85881d72523425c1d","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        cgroupsv2 failed to do so."},{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        flavor \u003d self.create_flavor("},{"line_number":236,"context_line":"            id\u003ddata_utils.rand_int_id(start\u003d1000),"},{"line_number":237,"context_line":"            ram\u003d2048,"},{"line_number":238,"context_line":"            disk\u003d10,"},{"line_number":239,"context_line":"            vcpus\u003d2"}],"source_content_type":"text/x-python","patch_set":16,"id":"de9d062d_205cdfd2","line":236,"updated":"2023-04-03 10:12:50.000000000","message":"Nit: Can we remove this? It shouldn\u0027t be necessary.\n\nhttps://opendev.org/openstack/tempest/src/commit/94649e792e08fcfb3859a4f7cf314070287f985c/tempest/api/compute/base.py#L681","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fb541f3cb08ae3480bf73fc402e5bd99cde82473","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        cgroupsv2 failed to do so."},{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        flavor \u003d self.create_flavor("},{"line_number":236,"context_line":"            id\u003ddata_utils.rand_int_id(start\u003d1000),"},{"line_number":237,"context_line":"            ram\u003d2048,"},{"line_number":238,"context_line":"            disk\u003d10,"},{"line_number":239,"context_line":"            vcpus\u003d2"}],"source_content_type":"text/x-python","patch_set":16,"id":"f253ee44_cfe65acf","line":236,"in_reply_to":"adb1ac59_243cfcf3","updated":"2023-04-11 11:01:50.000000000","message":"Ack","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"1d07af30ce2f40f44cc7164cd05358a5d0984103","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        cgroupsv2 failed to do so."},{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        flavor \u003d self.create_flavor("},{"line_number":236,"context_line":"            id\u003ddata_utils.rand_int_id(start\u003d1000),"},{"line_number":237,"context_line":"            ram\u003d2048,"},{"line_number":238,"context_line":"            disk\u003d10,"},{"line_number":239,"context_line":"            vcpus\u003d2"}],"source_content_type":"text/x-python","patch_set":16,"id":"adb1ac59_243cfcf3","line":236,"in_reply_to":"de9d062d_205cdfd2","updated":"2023-04-10 10:54:59.000000000","message":"Done.","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"599161e840848d2f65ec82f85881d72523425c1d","unresolved":true,"context_lines":[{"line_number":250,"context_line":"        )"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        server \u003d self.create_test_server("},{"line_number":253,"context_line":"            name\u003d\"vm-r9-qcow2\","},{"line_number":254,"context_line":"            flavor\u003dflavor[\"id\"]"},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"8bce7519_dc540aaf","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":11},"updated":"2023-04-03 10:12:50.000000000","message":"Nit: Can we remove also this? create_test_server() creates a name for the test server.\n\nhttps://opendev.org/openstack/tempest/src/commit/94649e792e08fcfb3859a4f7cf314070287f985c/tempest/api/compute/base.py#L257","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"1d07af30ce2f40f44cc7164cd05358a5d0984103","unresolved":true,"context_lines":[{"line_number":250,"context_line":"        )"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        server \u003d self.create_test_server("},{"line_number":253,"context_line":"            name\u003d\"vm-r9-qcow2\","},{"line_number":254,"context_line":"            flavor\u003dflavor[\"id\"]"},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"d5a47931_ead6a444","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":11},"in_reply_to":"8bce7519_dc540aaf","updated":"2023-04-10 10:54:59.000000000","message":"Done.","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fb541f3cb08ae3480bf73fc402e5bd99cde82473","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        )"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        server \u003d self.create_test_server("},{"line_number":253,"context_line":"            name\u003d\"vm-r9-qcow2\","},{"line_number":254,"context_line":"            flavor\u003dflavor[\"id\"]"},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"d6fe8f19_c3120e77","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":11},"in_reply_to":"d5a47931_ead6a444","updated":"2023-04-11 11:01:50.000000000","message":"Ack","commit_id":"2b96cdf491caf6aab77f9a341f78ee2c6f766c3b"}]}