)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cf7a7ffbc28ffbc7db6664c85dddcb75e8119077","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When `--os-identity-api-version` is used except for swift and openstack clients, the following fixes were made to prevent passing options to the client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Add a statement in the `cmd_with_auth` method that `--os-identity-api-version` is used only for swift and openstack"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1980252"},{"line_number":16,"context_line":"Change-Id: I8cfe63551cadd2f773c7455786b01f12e4843796"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"40a8a57e_334708eb","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":117},"updated":"2023-02-24 23:32:36.000000000","message":"There are other client also who support this flag, let\u0027s exclude this arg from the client who does not support it.\n\nhttps://codesearch.opendev.org/?q\u003d--os-identity-api-version\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"2aecc5a8bf7dec886c6d00e2e080327f36eae8a5"},{"author":{"_account_id":35612,"name":"Takemi Asakura","display_name":"Takemi","email":"tasakura@redhat.com","username":"tasakura"},"change_message_id":"5d35236ae6340706be57e39ff83e3781b1ad04b1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When `--os-identity-api-version` is used except for swift and openstack clients, the following fixes were made to prevent passing options to the client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Add a statement in the `cmd_with_auth` method that `--os-identity-api-version` is used only for swift and openstack"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1980252"},{"line_number":16,"context_line":"Change-Id: I8cfe63551cadd2f773c7455786b01f12e4843796"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0f46ff34_2a64c23a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":117},"in_reply_to":"3a2abf4d_3aeff217","updated":"2023-03-01 07:53:18.000000000","message":"I did not take into account that the CLIClient class inherits from plugins. I understand that I should use class variables for clients that do not use the identity version only within the CLIClient class. Thanks for the advice!","commit_id":"2aecc5a8bf7dec886c6d00e2e080327f36eae8a5"},{"author":{"_account_id":35612,"name":"Takemi Asakura","display_name":"Takemi","email":"tasakura@redhat.com","username":"tasakura"},"change_message_id":"c7b61ecdd2e0a2c22e57f48a668cd862903609aa","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When `--os-identity-api-version` is used except for swift and openstack clients, the following fixes were made to prevent passing options to the client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Add a statement in the `cmd_with_auth` method that `--os-identity-api-version` is used only for swift and openstack"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1980252"},{"line_number":16,"context_line":"Change-Id: I8cfe63551cadd2f773c7455786b01f12e4843796"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a5530446_1348ec98","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":117},"in_reply_to":"40a8a57e_334708eb","updated":"2023-02-27 23:32:38.000000000","message":"Hello Ghanshyam,\n\nThanks for the review, I appreciate it!\n\nIf I understand correctly, some of the applicable clients in the code search were clients(such as barbican) that are not included in the `CLIClient` class in tempest/lib/cli/base.py. I confirmed that the only clients that use the `--os-identity-api-version` option in the method defined in the `CLIClient` class are swift and openstackclient, so I excluded the other clients except swift and openstackclient.\n\nThe clients of the method defined in the CLIClient class are as follows.\n\n nova\n nova_manage\n keystone\n glance\n ceilometer\n heat\n cinder\n swift\n neutron\n sahara\n openstack\n \nI have verified that there is no `--os-identity-api-version` option in the help for clients other than swift and openstackclient, as follows.\n```\nstack@ubuntu:~/tempest/tempest/lib/cli$ nova help | grep identity\nnova CLI is deprecated and will be a removed in a future release\nstack@ubuntu:~/tempest/tempest/lib/cli$ nova-manage -h | grep identity\nModules with known eventlet monkey patching issues were imported prior to eventlet monkey patching: urllib3. This warning can usually be ignored if the caller is only importing and not executing nova code.\nstack@ubuntu:~/tempest/tempest/lib/cli$ which keystone\nstack@ubuntu:~/tempest/tempest/lib/cli$ glance --help | grep identity\nstack@ubuntu:~$ sudo /snap/bin/ceilometer --help | grep identity\n/snap/openstackclients/328/lib/python3.6/site-packages/ceilometerclient/shell.py:177: UserWarning: ceilometerclient is now deprecated as the Ceilometer API has been deprecated. Please use either aodhclient, pankoclient or gnocchiclient.\n\"ceilometerclient is now deprecated as the Ceilometer API has \"\nstack@ubuntu:~$ sudo /snap/bin/heat --help | grep identity\nstack@ubuntu:~/tempest/tempest/lib/cli$ cinder help | grep identity\nstack@ubuntu:~$ swift --help | grep identity\n--os-identity-api-version \u003cauth_version\u003e ]\n-V\u003dAUTH_VERSION, --auth-version\u003dAUTH_VERSION, --os-identity-api-version\u003dAUTH_VERSION\nstack@ubuntu:~$ neutron --help | grep identity\nneutron CLI is deprecated and will be removed in the Z cycle. Use openstack CLI instead.\nstack@ubuntu:~$ which sahara\nstack@ubuntu:~$ openstack --help | grep identity\n[--os-identity-api-version \u003cidentity-api-version\u003e]\n[--os-identity-provider \u003cauth-identity-provider\u003e]\n[--os-identity-provider-url \u003cauth-identity-provider-url\u003e]\n--os-identity-api-version \u003cidentity-api-version\u003e\n--os-identity-provider \u003cauth-identity-provider\u003e\n--os-identity-provider-url \u003cauth-identity-provider-url\u003e\nidentity provider create  Create new identity provider\nidentity provider delete  Delete identity provider(s)\nidentity provider list  List identity providers\nidentity provider set  Set identity provider properties\nidentity provider show  Display identity provider details\n```\n\nBest Regards,\nTakemi","commit_id":"2aecc5a8bf7dec886c6d00e2e080327f36eae8a5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"da6dfff68099a605709a84cda3fed38828c83fcb","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When `--os-identity-api-version` is used except for swift and openstack clients, the following fixes were made to prevent passing options to the client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Add a statement in the `cmd_with_auth` method that `--os-identity-api-version` is used only for swift and openstack"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1980252"},{"line_number":16,"context_line":"Change-Id: I8cfe63551cadd2f773c7455786b01f12e4843796"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a2abf4d_3aeff217","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":117},"in_reply_to":"a5530446_1348ec98","updated":"2023-02-28 03:16:52.000000000","message":"but this is base class CLIClient and any plugin can inherit the new class from it to use its method and putting this condition not to pass identity version will impact them for example, barbican tempest plugin inheriting their CLI class will not be able to ass identity version.\n\nTo make it work for all cases, we can make a configurable flag class level variable with default value of list of clients does not support identity version and any plugin inheriting this class can define their own list.\n\n    CLIENTS_WITHOUT_IDENTITY_VERSION \u003d [\u0027nova\u0027, \u0027cinder\u0027, ......]","commit_id":"2aecc5a8bf7dec886c6d00e2e080327f36eae8a5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9265b0ca657ce866c1e52ab441ac8cdd289bc49b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12a281c6_9ced9a98","updated":"2023-03-01 19:30:40.000000000","message":"LGTM, thank you, Takemi, for proposing the fix!","commit_id":"30a269ceeefde605bbc8f9b68b65f99f30af9184"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df277e3679b4f4ce85460f13bfe1a876efc7ebda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed2081bf_268a2f71","updated":"2023-03-01 19:17:52.000000000","message":"thanks, lgtm","commit_id":"30a269ceeefde605bbc8f9b68b65f99f30af9184"},{"author":{"_account_id":35612,"name":"Takemi Asakura","display_name":"Takemi","email":"tasakura@redhat.com","username":"tasakura"},"change_message_id":"f61b282999113c1a484ec0a15a11bcfea61fe0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a3ab3cf_d02584a3","in_reply_to":"12a281c6_9ced9a98","updated":"2023-03-02 08:28:40.000000000","message":"Hello Martin,\n\nThank you for the workflow and code review on the code modification!\nI learned many things this time, and I learned how wonderful and fun it is to contribute to upstream!\n\nBest Regards,\nTakemi","commit_id":"30a269ceeefde605bbc8f9b68b65f99f30af9184"},{"author":{"_account_id":35612,"name":"Takemi Asakura","display_name":"Takemi","email":"tasakura@redhat.com","username":"tasakura"},"change_message_id":"f61b282999113c1a484ec0a15a11bcfea61fe0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d13e17d_316d777e","in_reply_to":"ed2081bf_268a2f71","updated":"2023-03-02 08:28:40.000000000","message":"Hello Ghanshyam,\n\nThank you for your kind advice and review. It was my first code fix, and I learned a lot!\n\nBest Regards,\nTakemi","commit_id":"30a269ceeefde605bbc8f9b68b65f99f30af9184"}],"tempest/lib/cli/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"da6dfff68099a605709a84cda3fed38828c83fcb","unresolved":true,"context_lines":[{"line_number":377,"context_line":"                  self.password,"},{"line_number":378,"context_line":"                  self.uri))"},{"line_number":379,"context_line":"        if self.identity_api_version:"},{"line_number":380,"context_line":"            if cmd \u003d\u003d \u0027swift\u0027 or cmd \u003d\u003d \u0027openstack\u0027:"},{"line_number":381,"context_line":"                creds +\u003d \u0027 --os-identity-api-version %s\u0027 % ("},{"line_number":382,"context_line":"                    self.identity_api_version)"},{"line_number":383,"context_line":"        if self.user_domain_name is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf95ce06_34769266","line":380,"range":{"start_line":380,"start_character":12,"end_line":380,"end_character":52},"updated":"2023-02-28 03:16:52.000000000","message":"here we can use\n\n if cmd not in self.CLIENTS_WITHOUT_IDENTITY_VERSION:\n                 creds +\u003d \u0027 --os-identity-api-version %s\u0027 % (\n                    self.identity_api_version)","commit_id":"2aecc5a8bf7dec886c6d00e2e080327f36eae8a5"},{"author":{"_account_id":35612,"name":"Takemi Asakura","display_name":"Takemi","email":"tasakura@redhat.com","username":"tasakura"},"change_message_id":"5d35236ae6340706be57e39ff83e3781b1ad04b1","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                  self.password,"},{"line_number":378,"context_line":"                  self.uri))"},{"line_number":379,"context_line":"        if self.identity_api_version:"},{"line_number":380,"context_line":"            if cmd \u003d\u003d \u0027swift\u0027 or cmd \u003d\u003d \u0027openstack\u0027:"},{"line_number":381,"context_line":"                creds +\u003d \u0027 --os-identity-api-version %s\u0027 % ("},{"line_number":382,"context_line":"                    self.identity_api_version)"},{"line_number":383,"context_line":"        if self.user_domain_name is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"51d550c1_b913ab53","line":380,"range":{"start_line":380,"start_character":12,"end_line":380,"end_character":52},"in_reply_to":"bf95ce06_34769266","updated":"2023-03-01 07:53:18.000000000","message":"I will create a CLIENTS_WITHOUT_IDENTITY_VERSION class variable and modify it to exclude clients that do not use the identity version only in the CLIClient class.","commit_id":"2aecc5a8bf7dec886c6d00e2e080327f36eae8a5"}]}