)]}'
{"tempest/api/volume/admin/test_volumes_actions.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"1439b30fb8f7975ce299b1368c5139631c8efefc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        resp, _ \u003d self.client.volume_retype(self.volume[\u0027id\u0027],"},{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F8wc%3D","line":129,"updated":"2014-04-16 10:03:27.000000000","message":"here should add some codes to check volume has new type, not only status code.","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"5c760ef5fa7657e361d77324585a75bec5fb5a1f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        resp, _ \u003d self.client.volume_retype(self.volume[\u0027id\u0027],"},{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FfWk%3D","line":129,"in_reply_to":"AAAAXH%2F%2F2PA%3D","updated":"2014-04-21 10:53:23.000000000","message":"Okie..I will check this too.","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"a4f3abdb63feaa8248eb88b1b92f3aae3b131626","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        resp, _ \u003d self.client.volume_retype(self.volume[\u0027id\u0027],"},{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F2PA%3D","line":129,"in_reply_to":"AAAAXH%2F%2F8uI%3D","updated":"2014-04-17 01:08:57.000000000","message":"we can get the data of volume using get_volume(), then check the volume type is the new one.","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"f0e831f0f74868fc78a3e1fe80e7714794b1cb92","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        resp, _ \u003d self.client.volume_retype(self.volume[\u0027id\u0027],"},{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F8uI%3D","line":129,"in_reply_to":"AAAAXH%2F%2F8wc%3D","updated":"2014-04-16 10:11:38.000000000","message":"This API doesn\u0027t return any body.","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"1439b30fb8f7975ce299b1368c5139631c8efefc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F8yI%3D","line":130,"updated":"2014-04-16 10:03:27.000000000","message":"please use \u0027addCleanUp\u0027 to cleanup this volume type.","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"5c760ef5fa7657e361d77324585a75bec5fb5a1f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FfWo%3D","line":130,"in_reply_to":"AAAAXH%2F%2F2NU%3D","updated":"2014-04-21 10:53:23.000000000","message":"Thank You, I will add this.","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"a4f3abdb63feaa8248eb88b1b92f3aae3b131626","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F2NU%3D","line":130,"in_reply_to":"AAAAXH%2F%2F8tA%3D","updated":"2014-04-17 01:08:57.000000000","message":"yes, but this delete_volume_type wouldn\u0027t be executed if test failed before this line.\nwe could use \u0027addCleanup\u0027 like other testcases to help clean test data.\n\ne.g.\nafter line 124:\n self.addCleanup(self.volume_type_client.delete_volume_type, types[\u0027id\u0027])","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"f0e831f0f74868fc78a3e1fe80e7714794b1cb92","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                            new_type,"},{"line_number":128,"context_line":"                                            policy)"},{"line_number":129,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":130,"context_line":"        resp, _ \u003d self.volume_type_client.delete_volume_type(types[\u0027id\u0027])"},{"line_number":131,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F8tA%3D","line":130,"in_reply_to":"AAAAXH%2F%2F8yI%3D","updated":"2014-04-16 10:11:38.000000000","message":"delete_volume_type should delete the craeted volume-type.\nIsn\u0027t it ?","commit_id":"44c04248e78daf536541103ea5fddcf66a1c7a0f"}],"tempest/api/volume/base.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"30b8911c528d1fd505231777bbc6c9cdea449004","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        return volume"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @classmethod"},{"line_number":151,"context_line":"    def create_test_volume_type(cls):"},{"line_number":152,"context_line":"        resp, types \u003d cls.volume_types_client.create_volume_type("},{"line_number":153,"context_line":"            data_utils.rand_name(\u0027volume-type\u0027))"},{"line_number":154,"context_line":"        cls.volume_types.append(types[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_dcb6b3f8","line":151,"updated":"2014-08-28 19:29:53.000000000","message":"do we need to explicitly call out it\u0027s a \u0027_test_\u0027? can we just say create_volume_type?","commit_id":"0f576243e3c650f08907864056c815a0913e54a0"}],"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"30b8911c528d1fd505231777bbc6c9cdea449004","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        created volume must have a type initialy"},{"line_number":171,"context_line":"        \"\"\""},{"line_number":172,"context_line":"        if old_type:"},{"line_number":173,"context_line":"            # Craete volume with a volume-type"},{"line_number":174,"context_line":"            created_volume \u003d self.create_volume(volume_type\u003dold_type[\u0027name\u0027])"},{"line_number":175,"context_line":"            self.assertEqual(old_type[\u0027name\u0027], created_volume[\u0027volume_type\u0027])"},{"line_number":176,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_fcf8cf7d","line":173,"updated":"2014-08-28 19:29:53.000000000","message":"/Craete/Create/","commit_id":"0f576243e3c650f08907864056c815a0913e54a0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"30b8911c528d1fd505231777bbc6c9cdea449004","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # Verify volume retype"},{"line_number":192,"context_line":"        resp, retype_volume2 \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":193,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":194,"context_line":"        self.assertEqual(new_type[\u0027name\u0027], retype_volume2[\u0027volume_type\u0027])"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # Delete the created volume"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_bcb3b798","line":193,"updated":"2014-08-28 19:29:53.000000000","message":"im not sure we need to get this again... you already got the volume above in line 187","commit_id":"0f576243e3c650f08907864056c815a0913e54a0"}],"tempest/api/volume/v2/test_volume_actions.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"30b4c6152943d91bcb5f2d0bb8d0679570b2c014","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Create a test shared volume for tests"},{"line_number":38,"context_line":"        vol_name \u003d utils.rand_name(cls.__name__ + \u0027-Volume-\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        resp, cls.volume \u003d cls.client.create_volume(size\u003d1,"},{"line_number":41,"context_line":"                                                    display_name\u003dvol_name)"},{"line_number":42,"context_line":"        cls.client.wait_for_volume_status(cls.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":43,"context_line":"        cls.volumes.append(cls.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F5Lg%3D","line":40,"updated":"2014-04-25 13:47:30.000000000","message":"unused variable \"resp\"","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"6939af4479bbaa6bd81dbf0ad1a357c9bde51a97","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Create a test shared volume for tests"},{"line_number":38,"context_line":"        vol_name \u003d utils.rand_name(cls.__name__ + \u0027-Volume-\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        resp, cls.volume \u003d cls.client.create_volume(size\u003d1,"},{"line_number":41,"context_line":"                                                    display_name\u003dvol_name)"},{"line_number":42,"context_line":"        cls.client.wait_for_volume_status(cls.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":43,"context_line":"        cls.volumes.append(cls.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FxYk%3D","line":40,"in_reply_to":"AAAAXX%2F%2F5Lg%3D","updated":"2014-04-28 03:38:47.000000000","message":"Done","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"30b4c6152943d91bcb5f2d0bb8d0679570b2c014","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # Reset the volume status"},{"line_number":65,"context_line":"        resp, body \u003d self.admin_volume_client.reset_volume_status(volume_id,"},{"line_number":66,"context_line":"                                                                  status)"},{"line_number":67,"context_line":"        return resp, body"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def tearDown(self):"},{"line_number":70,"context_line":"        # Set volume\u0027s status to available after test"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F5KI%3D","line":67,"updated":"2014-04-25 13:47:30.000000000","message":"may be would be better:\n\nreturn self.admin_volume_client.reset_volume_status(volume_id, status)\n\n?","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"6939af4479bbaa6bd81dbf0ad1a357c9bde51a97","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # Reset the volume status"},{"line_number":65,"context_line":"        resp, body \u003d self.admin_volume_client.reset_volume_status(volume_id,"},{"line_number":66,"context_line":"                                                                  status)"},{"line_number":67,"context_line":"        return resp, body"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def tearDown(self):"},{"line_number":70,"context_line":"        # Set volume\u0027s status to available after test"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FxYg%3D","line":67,"in_reply_to":"AAAAXX%2F%2F5KI%3D","updated":"2014-04-28 03:38:47.000000000","message":"Done","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"30b4c6152943d91bcb5f2d0bb8d0679570b2c014","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                            new_type[\u0027name\u0027],"},{"line_number":108,"context_line":"                                            policy)"},{"line_number":109,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":110,"context_line":"        resp, retype_volume \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.client.wait_for_volume_status(retype_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":112,"context_line":"        resp, retype_volume2 \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertEqual(new_type[\u0027name\u0027], retype_volume2[\u0027volume_type\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F5JE%3D","line":110,"updated":"2014-04-25 13:47:30.000000000","message":"unused variable \"resp\"","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"6939af4479bbaa6bd81dbf0ad1a357c9bde51a97","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                            new_type[\u0027name\u0027],"},{"line_number":108,"context_line":"                                            policy)"},{"line_number":109,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":110,"context_line":"        resp, retype_volume \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.client.wait_for_volume_status(retype_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":112,"context_line":"        resp, retype_volume2 \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertEqual(new_type[\u0027name\u0027], retype_volume2[\u0027volume_type\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FxYc%3D","line":110,"in_reply_to":"AAAAXX%2F%2F5JE%3D","updated":"2014-04-28 03:38:47.000000000","message":"Done","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"30b4c6152943d91bcb5f2d0bb8d0679570b2c014","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":110,"context_line":"        resp, retype_volume \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.client.wait_for_volume_status(retype_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":112,"context_line":"        resp, retype_volume2 \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertEqual(new_type[\u0027name\u0027], retype_volume2[\u0027volume_type\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F5I0%3D","line":112,"updated":"2014-04-25 13:47:30.000000000","message":"unused variable \"resp\"","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"6939af4479bbaa6bd81dbf0ad1a357c9bde51a97","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":110,"context_line":"        resp, retype_volume \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.client.wait_for_volume_status(retype_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":112,"context_line":"        resp, retype_volume2 \u003d self.client.get_volume(created_volume[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertEqual(new_type[\u0027name\u0027], retype_volume2[\u0027volume_type\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FxYY%3D","line":112,"in_reply_to":"AAAAXX%2F%2F5I0%3D","updated":"2014-04-28 03:38:47.000000000","message":"Done","commit_id":"94ddaab74a50105ad9623b22e386eb5f5dd14a99"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"a5f56a36271874664acaf278c3b87e82710c32f9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumesActionsTest(base.BaseVolumeV2AdminTest):"},{"line_number":23,"context_line":"    _interface \u003d \"json\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_81571102","line":22,"updated":"2014-04-30 08:57:17.000000000","message":"VolumesActionsTest -\u003e VolumesV2ActionsTest","commit_id":"786409f0276b07823e7961ca34ec8ded760341ac"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"2cbff4a22210c7b2f50a6d3123c8070132039253","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumesActionsTest(base.BaseVolumeV2AdminTest):"},{"line_number":23,"context_line":"    _interface \u003d \"json\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_32f9314e","line":22,"in_reply_to":"9ad9bd40_81571102","updated":"2014-04-30 10:43:46.000000000","message":"Done","commit_id":"786409f0276b07823e7961ca34ec8ded760341ac"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"a5f56a36271874664acaf278c3b87e82710c32f9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self._volume_retype_with_given_policy(\"on-demand\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class VolumesActionsTestXML(VolumesActionsTest):"},{"line_number":128,"context_line":"    _interface \u003d \"xml\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_c1ae79e7","line":127,"updated":"2014-04-30 08:57:17.000000000","message":"VolumesActionsTestXML -\u003e VolumesV2ActionsTestXML","commit_id":"786409f0276b07823e7961ca34ec8ded760341ac"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"2cbff4a22210c7b2f50a6d3123c8070132039253","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self._volume_retype_with_given_policy(\"on-demand\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class VolumesActionsTestXML(VolumesActionsTest):"},{"line_number":128,"context_line":"    _interface \u003d \"xml\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_5295d5e2","line":127,"in_reply_to":"9ad9bd40_c1ae79e7","updated":"2014-04-30 10:43:46.000000000","message":"Done","commit_id":"786409f0276b07823e7961ca34ec8ded760341ac"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"49d8651ba661dbd552caaf629cee1e33845a101f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def tearDownClass(cls):"},{"line_number":47,"context_line":"        # Delete the test volume"},{"line_number":48,"context_line":"        for volume in cls.volumes:"},{"line_number":49,"context_line":"            try:"},{"line_number":50,"context_line":"                cls.client.delete_volume(volume)"},{"line_number":51,"context_line":"                cls.client.wait_for_resource_deletion(volume)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_d8835602","line":48,"updated":"2014-05-05 14:31:01.000000000","message":"This mechanism is already implemented in class BaseVolumeTest()","commit_id":"0bdd95a4d9f71b998b093842ee89ed0632691bff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"49d8651ba661dbd552caaf629cee1e33845a101f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            except exceptions.NotFound:"},{"line_number":53,"context_line":"                pass"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        for volume_type in cls.volume_types:"},{"line_number":56,"context_line":"            try:"},{"line_number":57,"context_line":"                cls.volume_type_client.delete_volume_type(volume_type)"},{"line_number":58,"context_line":"            except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_78724a4a","line":55,"updated":"2014-05-05 14:31:01.000000000","message":"This is good but I\u0027d rather see it implemented in the base class  BaseVolumeTest()","commit_id":"0bdd95a4d9f71b998b093842ee89ed0632691bff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"49d8651ba661dbd552caaf629cee1e33845a101f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        super(VolumesV2ActionsTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _reset_volume_status(self, volume_id, status):"},{"line_number":64,"context_line":"        # Reset the volume status"},{"line_number":65,"context_line":"        return self.admin_volume_client.reset_volume_status(volume_id,"},{"line_number":66,"context_line":"                                                            status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_b8d77222","line":63,"updated":"2014-05-05 14:31:01.000000000","message":"This function is used only once and is only one line. I\u0027d rather you inline the code (ie delete this function)","commit_id":"0bdd95a4d9f71b998b093842ee89ed0632691bff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"49d8651ba661dbd552caaf629cee1e33845a101f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Set volume\u0027s status to available after test"},{"line_number":70,"context_line":"        for volume in self.volumes:"},{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                self._reset_volume_status(volume, \u0027available\u0027)"},{"line_number":73,"context_line":"            except exceptions.NotFound:"},{"line_number":74,"context_line":"                pass"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_b8be92d2","line":72,"updated":"2014-05-05 14:31:01.000000000","message":"I am not sure, why you have to do this ?","commit_id":"0bdd95a4d9f71b998b093842ee89ed0632691bff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"49d8651ba661dbd552caaf629cee1e33845a101f","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        super(VolumesV2ActionsTest, self).tearDown()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _create_test_volume_with_volume_type(self, vol_type):"},{"line_number":79,"context_line":"        resp, volume \u003d self.client.create_volume("},{"line_number":80,"context_line":"            size\u003d1,"},{"line_number":81,"context_line":"            display_name\u003dutils.rand_name(\u0027Volume\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_38cd225e","line":78,"updated":"2014-05-05 14:31:01.000000000","message":"You may want to use methode create_volume() of class BaseVolumeV2Test(). The kwargs should allow you to do what you want and could reduce code duplication.","commit_id":"0bdd95a4d9f71b998b093842ee89ed0632691bff"}]}