)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3f4c29f8167d7d59c0238cedc3c5b8ae7c6b02c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Milana Levy \u003cmillevy@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-02 16:20:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This change was written so that a new volume could be created by another client other than the primary admin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I122a08aaf273a1f786e13737f31f2a0ab9c7bfdb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"aa7a7f5a_d9c8a0b3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":108},"updated":"2023-03-02 19:36:09.000000000","message":"commit msg need a summary line followed by empty line and then the full details,\n\nPlease check for the commit msg format https://docs.openstack.org/contributors/common/git.html#commit-messages","commit_id":"332be97a94c56c1c5029e1d5369ada78c62b5da0"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"e1ceaaab2ab24e6764080be04af43924b656e6c2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Milana Levy \u003cmillevy@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-02 16:20:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This change was written so that a new volume could be created by another client other than the primary admin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I122a08aaf273a1f786e13737f31f2a0ab9c7bfdb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a00257d_8cc92faa","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":108},"in_reply_to":"aa7a7f5a_d9c8a0b3","updated":"2023-03-05 08:36:30.000000000","message":"Done","commit_id":"332be97a94c56c1c5029e1d5369ada78c62b5da0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"0157a18e810d49f094c7c1d392f0e64585ae7469","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"21468cab_015b46b2","updated":"2023-03-02 16:32:56.000000000","message":"Please review the change the Lukas Piwowarski made ,thank you.","commit_id":"332be97a94c56c1c5029e1d5369ada78c62b5da0"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"e1ceaaab2ab24e6764080be04af43924b656e6c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a82cb3d_7f8d2b18","updated":"2023-03-05 08:36:30.000000000","message":"Changed the comment. Thank you for the review.","commit_id":"df60645cc5cf8aa72ac145151df3fc72e0474cd1"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"3cfee8f8d4f7b6f93892eec6a4b8acfeb97400bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4815f6b7_b54ae121","updated":"2023-03-07 11:48:27.000000000","message":"recheck\nThe failure of the test_hotplug_nic[compute,id-c5adff73-e961-41f1-b4a9-343614f18cfa,network] test was not caused by the patch. ","commit_id":"805e0c2ac341dcf820f37866d1eb8c04974b4423"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"b0a3240d8d93ddd922dfadf8b75738610710b190","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"823c4e01_d9f650f9","updated":"2023-03-07 08:12:01.000000000","message":"recheck\nThe failure of the test_hotplug_nic[compute,id-c5adff73-e961-41f1-b4a9-343614f18cfa,network] test was not caused by the patch. ","commit_id":"805e0c2ac341dcf820f37866d1eb8c04974b4423"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c2af36338cff35c157cab2621ad42f01e9ad3c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b67991b4_ff3187fe","updated":"2023-03-07 19:38:14.000000000","message":"thanks, almost lgtm. 1 comemnt","commit_id":"805e0c2ac341dcf820f37866d1eb8c04974b4423"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f0b4ebfd6ef51b8f1b3f5b812c548d52ee8067d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f2e8d060_9b762ee9","updated":"2023-03-13 19:52:11.000000000","message":"thank you Milana, it looks great, let\u0027s proceed ","commit_id":"e9a58a1cc79feb7d96b7d6db7587e6c39f2450a5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"feae540448d4368de5c67e8b9b0453b714634490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df90f267_94586c7b","updated":"2023-03-13 18:09:22.000000000","message":"thanks, lgtm","commit_id":"e9a58a1cc79feb7d96b7d6db7587e6c39f2450a5"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c2af36338cff35c157cab2621ad42f01e9ad3c7","unresolved":true,"context_lines":[{"line_number":861,"context_line":"                  image_name, server[\u0027name\u0027])"},{"line_number":862,"context_line":"        return snapshot_image"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"    def nova_volume_attach(self, server, volume_to_attach, clients\u003dNone,"},{"line_number":865,"context_line":"                           **kwargs):"},{"line_number":866,"context_line":"        \"\"\"Compute volume attach"},{"line_number":867,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"842022ad_5d8c2665","line":864,"range":{"start_line":864,"start_character":59,"end_line":864,"end_character":71},"updated":"2023-03-07 19:38:14.000000000","message":"volumes_client\u003dNone, servers_client\u003dNone, **kwargs):","commit_id":"805e0c2ac341dcf820f37866d1eb8c04974b4423"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a721010599f70b3b7ec94f95afb408cbb4b0fda1","unresolved":true,"context_lines":[{"line_number":861,"context_line":"                  image_name, server[\u0027name\u0027])"},{"line_number":862,"context_line":"        return snapshot_image"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"    def nova_volume_attach(self, server, volume_to_attach, clients\u003dNone,"},{"line_number":865,"context_line":"                           **kwargs):"},{"line_number":866,"context_line":"        \"\"\"Compute volume attach"},{"line_number":867,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"97388722_03d21db4","line":864,"range":{"start_line":864,"start_character":59,"end_line":864,"end_character":71},"in_reply_to":"842022ad_5d8c2665","updated":"2023-03-13 10:18:27.000000000","message":"+1, agree","commit_id":"805e0c2ac341dcf820f37866d1eb8c04974b4423"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c2af36338cff35c157cab2621ad42f01e9ad3c7","unresolved":true,"context_lines":[{"line_number":867,"context_line":""},{"line_number":868,"context_line":"        This utility attaches volume from compute and waits for the"},{"line_number":869,"context_line":"        volume status to be \u0027in-use\u0027 state."},{"line_number":870,"context_line":"        \"\"\""},{"line_number":871,"context_line":"        if clients is None:"},{"line_number":872,"context_line":"            servers_client \u003d self.servers_client"},{"line_number":873,"context_line":"            volumes_client \u003d self.volumes_client"},{"line_number":874,"context_line":"        else:"},{"line_number":875,"context_line":"            servers_client \u003d clients.servers_client"},{"line_number":876,"context_line":"            volumes_client \u003d clients.volumes_client_latest"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        volume \u003d servers_client.attach_volume("},{"line_number":879,"context_line":"            server[\u0027id\u0027], volumeId\u003dvolume_to_attach[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"0a5bf2f4_1d6b6974","line":876,"range":{"start_line":870,"start_character":0,"end_line":876,"end_character":58},"updated":"2023-03-07 19:38:14.000000000","message":"I think taking two client in parameter volumes_client\u003dNone, servers_client\u003dNone will be easy to understand and then use then separately. like below\n\n        if volumes_client is None:\n            volumes_client \u003d self.volumes_client\n        if servers_client is None:\n            servers_client \u003d self.servers_client","commit_id":"805e0c2ac341dcf820f37866d1eb8c04974b4423"}]}
