)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e93cfa315e98cf19f8632f0413570223d3cbc2d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed65e7a7_802e8162","updated":"2023-02-22 22:12:08.000000000","message":"lgtm as discussed in IRC.","commit_id":"40ba550c3d3b809fbb6d515d7d3158b76b2d759c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f5b3e56ff2e5adf6694684691880d6cf982ce7ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0117e426_a0eecd3d","updated":"2023-02-23 06:50:07.000000000","message":"looks good,thanks for improving this","commit_id":"40ba550c3d3b809fbb6d515d7d3158b76b2d759c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f0884e5edc1c55dafd0129da3f361b1f52166ed4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9849c7b_9507c542","updated":"2023-02-22 22:12:43.000000000","message":"recheck to trigger jobs again to verify if still volume detach error happening","commit_id":"40ba550c3d3b809fbb6d515d7d3158b76b2d759c"}],"tempest/api/volume/base.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ecfa8c3d429f2dfea946a0775eefcc286f92921e","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        volume \u003d self.volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":129,"context_line":"        self.cleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":130,"context_line":"                     self._delete_volume_for_cleanup, volume[\u0027id\u0027])"},{"line_number":131,"context_line":"        if wait_until:"},{"line_number":132,"context_line":"            waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":133,"context_line":"                                                    volume[\u0027id\u0027], wait_until)"}],"source_content_type":"text/x-python","patch_set":2,"id":"471c63f5_533f5e01","line":130,"updated":"2023-02-22 15:25:22.000000000","message":"There\u0027s a different way we could handle this, if people prefer, detailed below.","commit_id":"11a96c671587d4cbd0bb893317bd6b900790922c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ecfa8c3d429f2dfea946a0775eefcc286f92921e","unresolved":true,"context_lines":[{"line_number":191,"context_line":"    @staticmethod"},{"line_number":192,"context_line":"    def delete_volume(client, volume_id):"},{"line_number":193,"context_line":"        \"\"\"Delete volume by the given client\"\"\""},{"line_number":194,"context_line":"        client.delete_volume(volume_id)"},{"line_number":195,"context_line":"        client.wait_for_resource_deletion(volume_id)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @cleanup_order"}],"source_content_type":"text/x-python","patch_set":2,"id":"491e2c0c_51eb695b","line":194,"updated":"2023-02-22 15:25:22.000000000","message":"We could make this tolerate and retry on the specific error indicating that it is still attached. The problem is that we just get a 400 from cinder, so we would need to look for something in the actual error text to indicate that we should retry it. Doing the above wait-for-status feels more \"tempesty\" to me.","commit_id":"11a96c671587d4cbd0bb893317bd6b900790922c"}]}
