)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"218c6c1cd0dcf39f8c35fafda150fde94847e246","unresolved":true,"context_lines":[{"line_number":15,"context_line":"BaseV2ComputeTest.delete_server function which waits for the successful"},{"line_number":16,"context_line":"deletion of the server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1954535"},{"line_number":19,"context_line":"Change-Id: Ic1ed48fda03ce3c13198d2dd299b57d68b06e63d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"be5dee85_0da7c8ef","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"updated":"2023-03-01 20:20:25.000000000","message":"Closes ? if i understand correctly that this fixes the bug","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fc6e14b3a246b16e09162b595504b31f2f690391","unresolved":false,"context_lines":[{"line_number":15,"context_line":"BaseV2ComputeTest.delete_server function which waits for the successful"},{"line_number":16,"context_line":"deletion of the server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1954535"},{"line_number":19,"context_line":"Change-Id: Ic1ed48fda03ce3c13198d2dd299b57d68b06e63d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"84b8482b_236cc393","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"27f9c6b7_0b7748d3","updated":"2023-03-03 08:10:23.000000000","message":"ack, done.","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"e59148556e4b7ca2ad576fa77e9f724979d9c468","unresolved":true,"context_lines":[{"line_number":15,"context_line":"BaseV2ComputeTest.delete_server function which waits for the successful"},{"line_number":16,"context_line":"deletion of the server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1954535"},{"line_number":19,"context_line":"Change-Id: Ic1ed48fda03ce3c13198d2dd299b57d68b06e63d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fd5bdc4e_8df43281","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"be5dee85_0da7c8ef","updated":"2023-03-02 16:49:50.000000000","message":"The bug mentions refstack as well. Maybe we should change the default version that is used in refstack-client and then close this? [1] \n\n[1] https://opendev.org/openinfra/refstack-client/src/commit/6d56d3372e80018142ea21a80b2a64a62ef550de/setup_env#L5","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f459cf0d2baf88b8bcf91cd703fd3a819ae1e1eb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"BaseV2ComputeTest.delete_server function which waits for the successful"},{"line_number":16,"context_line":"deletion of the server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1954535"},{"line_number":19,"context_line":"Change-Id: Ic1ed48fda03ce3c13198d2dd299b57d68b06e63d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"27f9c6b7_0b7748d3","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"fd5bdc4e_8df43281","updated":"2023-03-02 19:31:48.000000000","message":"you can add refstack in that bug but as it is fixed in tempest so we can mark Close for tempest.","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a118e4a798dc8bbf639ea6bf498edcc2b8cb9d67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0f27576_d786a2b9","updated":"2023-03-01 20:29:43.000000000","message":"I think Martin has good point","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"218c6c1cd0dcf39f8c35fafda150fde94847e246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d01bf751_92edf8ff","updated":"2023-03-01 20:20:25.000000000","message":"hmm, this seems to be like a good idea, but one question inline about waiting in the loop ","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6e4797ae53babd77fb45ffc36e2cf487145633d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8d4d3c4_d64b1efc","updated":"2023-03-01 13:31:11.000000000","message":"recheck\nFailure of tempest.api.identity.admin.v3.test_credentials.CredentialsTestJSON.test_credentials_create_get_update_delete is not caused by this patch.","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f459cf0d2baf88b8bcf91cd703fd3a819ae1e1eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93152605_8cfcd510","updated":"2023-03-02 19:31:48.000000000","message":"lgtm but we can mention Close bug in commit message as that is all from tempest side need fix.","commit_id":"906fcf16d536e5da4a03e802a85d01d6feced914"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d1d3c03d6f105c4d183f01426dc5f7db6c28ca66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d1ffdd4_dedd0a53","updated":"2023-03-05 14:35:53.000000000","message":"recheck - not related issues, the change lgtm, thanks Lukas, you not only fixed the bug but also optimized the test run, great job!","commit_id":"d78e405364ca3725820fc7bd4b2f2af198ccc624"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39cb3bcc8a383a8424e4e5722793df200f366392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eef6982e_cccccc62","updated":"2023-03-03 18:09:16.000000000","message":"recheck stable job timeout","commit_id":"d78e405364ca3725820fc7bd4b2f2af198ccc624"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1053c675c1dfe1106407fea2808df28d246d0905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bec963ac_bd04bad5","updated":"2023-03-03 18:09:07.000000000","message":"thanks","commit_id":"d78e405364ca3725820fc7bd4b2f2af198ccc624"}],"tempest/api/compute/servers/test_multiple_create.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"218c6c1cd0dcf39f8c35fafda150fde94847e246","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            min_count\u003d2,"},{"line_number":36,"context_line":"            tenant_network\u003dtenant_network)"},{"line_number":37,"context_line":"        for server in servers:"},{"line_number":38,"context_line":"            self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":39,"context_line":"        # NOTE(maurosr): do status response check and also make sure that"},{"line_number":40,"context_line":"        # reservation_id is not in the response body when the request send"},{"line_number":41,"context_line":"        # contains return_reservation_id\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ed7bede_78766606","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":61},"updated":"2023-03-01 20:20:25.000000000","message":"this seems correct to me, most of the tests which call servers_client.delete_server also wait for the server termination - the other tests which don\u0027t wait, they don\u0027t so because they don\u0027t need to, the nature of the tests is different in those cases\n\nTherefore I think that this is a good idea, however, as I see that we\u0027re in a for loop, I have to question whether it\u0027s a good idea to wait in the loop - what we could do is delete in the loop and then in another one wait for the deletion of all of the servers - the difference is that we will start deleting all the servers at once, not one by one, what do you think?","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fc6e14b3a246b16e09162b595504b31f2f690391","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            min_count\u003d2,"},{"line_number":36,"context_line":"            tenant_network\u003dtenant_network)"},{"line_number":37,"context_line":"        for server in servers:"},{"line_number":38,"context_line":"            self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":39,"context_line":"        # NOTE(maurosr): do status response check and also make sure that"},{"line_number":40,"context_line":"        # reservation_id is not in the response body when the request send"},{"line_number":41,"context_line":"        # contains return_reservation_id\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e16d268_3c241851","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":61},"in_reply_to":"8c3b3311_08c885ab","updated":"2023-03-03 08:10:23.000000000","message":"Done","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a118e4a798dc8bbf639ea6bf498edcc2b8cb9d67","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            min_count\u003d2,"},{"line_number":36,"context_line":"            tenant_network\u003dtenant_network)"},{"line_number":37,"context_line":"        for server in servers:"},{"line_number":38,"context_line":"            self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":39,"context_line":"        # NOTE(maurosr): do status response check and also make sure that"},{"line_number":40,"context_line":"        # reservation_id is not in the response body when the request send"},{"line_number":41,"context_line":"        # contains return_reservation_id\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"f17aabb1_f32f65b4","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":61},"in_reply_to":"9ed7bede_78766606","updated":"2023-03-01 20:29:43.000000000","message":"+1 agree with you. Let\u0027s put another for loop which will add wait for delete in addcleanup and let this for loop to place the delete request only.","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"e59148556e4b7ca2ad576fa77e9f724979d9c468","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            min_count\u003d2,"},{"line_number":36,"context_line":"            tenant_network\u003dtenant_network)"},{"line_number":37,"context_line":"        for server in servers:"},{"line_number":38,"context_line":"            self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":39,"context_line":"        # NOTE(maurosr): do status response check and also make sure that"},{"line_number":40,"context_line":"        # reservation_id is not in the response body when the request send"},{"line_number":41,"context_line":"        # contains return_reservation_id\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c3b3311_08c885ab","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":61},"in_reply_to":"f17aabb1_f32f65b4","updated":"2023-03-02 16:49:50.000000000","message":"It\u0027s a good point. I did not think about that.","commit_id":"e68078599972ee4456a5c2ef6f70be32ea15d7d5"}]}