)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"e30642ac392b318ca6c1f97e7e10662a0d0afd45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d7dedca1_ce30a467","updated":"2023-03-13 09:40:05.000000000","message":"recheck one last try to get the test to fail","commit_id":"a6f116ff91f12bbbcf78827147e8c5a258aae057"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"9b52a48546828f0a46eb6258dc26eae4ce377dd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"877a262c_6fcbd4cc","updated":"2023-03-09 13:44:42.000000000","message":"recheck see if I can get the test to fail.","commit_id":"a6f116ff91f12bbbcf78827147e8c5a258aae057"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"04106be1d79ab7b4350641dfd70dd0230de9ba9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13b1a715_cd27a27b","updated":"2023-03-29 09:54:04.000000000","message":"I am not entirely sure whether \"Server boot request ID:\" is precise in this case [1]. Maybe we can change this to \"Request ID:\"? I\u0027m not sure about this, just an idea. \n\nExcept this it looks good to me!\n\n[1] https://opendev.org/openstack/tempest/src/commit/94649e792e08fcfb3859a4f7cf314070287f985c/tempest/common/waiters.py#L80","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"edcaf525711e842b15b547504ef850484456bc07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c171b22_56e8edce","updated":"2023-03-17 23:13:14.000000000","message":"Idea is good, and code inspection checks out (see inline).","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"30698c3472eeab7872fc20dfad937b922fd28288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e3cb825_ca3765d2","updated":"2023-03-14 09:44:04.000000000","message":"The change replicates what was already done under this one: https://review.opendev.org/c/openstack/tempest/+/818831.","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"55b5f73e46ed48f79605b338891f763148819e94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6b3db97_1092b3a8","updated":"2023-03-14 09:42:33.000000000","message":"Unfortunately, I have not been able to get the test to fail under this change, which means that I do not have proof that it does what it says. However, it is a pretty simple fix and I have manually verified that it does so.\n\nIn order to get the test to fail locally, run it under a devstack that has the: \"NOVA_BACKEND\u003dlvm\" flag set.","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32665eff8ab7eb7b3d0055145191c7114e62fe0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d008e36e_118ee2eb","updated":"2023-04-28 18:21:18.000000000","message":"lgtm thanks","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"662d4b66b9bc56fad4110bef66d3d6e28df1ff75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a365aa0_1542dc05","updated":"2023-03-21 08:35:49.000000000","message":"this is a good idea, looks good, thanks","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"edcaf525711e842b15b547504ef850484456bc07","unresolved":true,"context_lines":[{"line_number":462,"context_line":"        self, server_id, new_flavor_id, wait_until\u003d\u0027ACTIVE\u0027, **kwargs"},{"line_number":463,"context_line":"    ):"},{"line_number":464,"context_line":"        \"\"\"resize and confirm_resize an server, waits for it to be ACTIVE.\"\"\""},{"line_number":465,"context_line":"        body \u003d self.servers_client.resize_server("},{"line_number":466,"context_line":"            server_id, new_flavor_id, **kwargs)"},{"line_number":467,"context_line":"        waiters.wait_for_server_status("},{"line_number":468,"context_line":"            self.servers_client, server_id, \u0027VERIFY_RESIZE\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"322e24f9_cea4c6e8","line":465,"updated":"2023-03-17 23:13:14.000000000","message":"Which is set here.","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"}],"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"edcaf525711e842b15b547504ef850484456bc07","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            if isinstance(body, bytes):"},{"line_number":231,"context_line":"                body \u003d body.decode(\u0027utf-8\u0027)"},{"line_number":232,"context_line":"        self.validate_response(schema, resp, body)"},{"line_number":233,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def create_backup(self, server_id, **kwargs):"},{"line_number":236,"context_line":"        \"\"\"Backup a server instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"a63e02df_d0a41047","line":233,"updated":"2023-03-17 23:13:14.000000000","message":"This returns the response body","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"edcaf525711e842b15b547504ef850484456bc07","unresolved":true,"context_lines":[{"line_number":316,"context_line":"        kwargs[\u0027flavorRef\u0027] \u003d flavor_ref"},{"line_number":317,"context_line":"        if \u0027disk_config\u0027 in kwargs:"},{"line_number":318,"context_line":"            kwargs[\u0027OS-DCF:diskConfig\u0027] \u003d kwargs.pop(\u0027disk_config\u0027)"},{"line_number":319,"context_line":"        return self.action(server_id, \u0027resize\u0027, **kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def confirm_resize_server(self, server_id, **kwargs):"},{"line_number":322,"context_line":"        \"\"\"Confirm the flavor change for a server."}],"source_content_type":"text/x-python","patch_set":2,"id":"57acd4d0_0ff147d1","line":319,"updated":"2023-03-17 23:13:14.000000000","message":"Which is just returned again here","commit_id":"572ac54250fdd1a61809b57cbd15a49209c83f16"}]}
