)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e1095e37f2f3735044baff91c7586db47c955eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f572e715_badba1b9","updated":"2023-03-13 21:34:13.000000000","message":"I think we need to keep only one config option instead of two.","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"db63d85c630879798912484d39eeaccf1d77ffca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba1b6fa2_5521d59c","updated":"2023-03-13 19:55:46.000000000","message":"looks good, the logic of the test isn\u0027t changed, only the networks aren\u0027t hardcoded anymore so a user can customize them if required","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8929302f882cf2394f7cdad691fd6b8fd3fbec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b9e2fd03_74ca74b0","updated":"2023-03-14 22:29:29.000000000","message":"thanks for doing it.","commit_id":"4e7fcb96fcf9d8256ae3e06cb4ea3c56436a52d6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7b6a43db73e66134a445204d19aa2a93059d66a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8ec91c57_ff862960","updated":"2023-03-23 12:02:29.000000000","message":"recheck timeout","commit_id":"80851ad9061f289053b19030f72e05699a513160"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f5ec58f513c90f6b92394a47759c36a225e6f98a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ed164cd8_3c63fd68","updated":"2023-03-23 07:23:53.000000000","message":"this is clever, thank you for improving the test!","commit_id":"80851ad9061f289053b19030f72e05699a513160"}],"tempest/config.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"db63d85c630879798912484d39eeaccf1d77ffca","unresolved":true,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1e647e92_1cdf47fa","line":767,"range":{"start_line":767,"start_character":17,"end_line":767,"end_character":38},"updated":"2023-03-13 19:55:46.000000000","message":"It feels a bit odd as the name is almost the same as the name of the above opt. However, as I think about it, I can\u0027t come up with a better and clearer one.","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":35578,"name":"Pragadeeswaran Sathyanarayanan","display_name":"Pragadee","email":"psathyan@redhat.com","username":"psathyan"},"change_message_id":"6678cfae4b55280233f02dd0380aeee53832df08","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"22194777_4b582b86","line":767,"range":{"start_line":767,"start_character":17,"end_line":767,"end_character":38},"in_reply_to":"1e647e92_1cdf47fa","updated":"2023-03-14 09:33:15.000000000","message":"Ack","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e1095e37f2f3735044baff91c7586db47c955eb","unresolved":true,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"},{"line_number":771,"context_line":"               default\u003d28,"},{"line_number":772,"context_line":"               help\u003d\"The mask bits for project ipv4 subnets\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d3dd7bf_4f75394f","line":769,"range":{"start_line":767,"start_character":0,"end_line":769,"end_character":71},"updated":"2023-03-13 21:34:13.000000000","message":"this seems really confusing. We should not keep both where first config option need can be completed by the new one.\n\nLet\u0027s deprecate the exiting config option project_network_cidr in favor of new one and we can use new config option first value (CONF.network.project_networks_cidr[0]) for the existing config value usage and as a pool for this change.\n\n    cfg.ListOpt(\u0027project_networks_cidr\u0027,\n                default\u003d[\"10.100.0.0/16\", \"10.80.0.0/16\"],\n                deprecated_opts\u003d[\n                    cfg.DeprecatedOpt(\u0027project_network_cidr\u0027, group\u003d\u0027network_group\u0027)\n                    group\u003d\u0027DEFAULT\u0027),\n                ],\n                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8929302f882cf2394f7cdad691fd6b8fd3fbec5","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"},{"line_number":771,"context_line":"               default\u003d28,"},{"line_number":772,"context_line":"               help\u003d\"The mask bits for project ipv4 subnets\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d5e6327_ebffb5f2","line":769,"range":{"start_line":767,"start_character":0,"end_line":769,"end_character":71},"in_reply_to":"15ef7786_98d0af04","updated":"2023-03-14 22:29:29.000000000","message":"yeah it will be big change in multiple repo but that will be good to solve instead of adding one more extra config option. But this might need change as we are changing the config option type also.\n\nAlong with tempest, you need to change in devstack, neutron-tempest-pluing etc, a few places are:\n\nLet\u0027s do the below changes also with depends-on on this change and we will see if all work well.\n\n- https://opendev.org/openstack/devstack/src/branch/master/lib/tempest#L348\n\n- https://github.com/openstack/neutron-tempest-plugin/search?q\u003dCONF.network.project_network_cidr\n\n- https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/whitebox_tempest_plugin/api/compute/test_sriov.py#L107\n\n- https://opendev.org/openstack/zun-tempest-plugin/src/branch/master/zun_tempest_plugin/tests/tempest/base.py#L170","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":35578,"name":"Pragadeeswaran Sathyanarayanan","display_name":"Pragadee","email":"psathyan@redhat.com","username":"psathyan"},"change_message_id":"9a600914bcc1f10da0ea33a4b8e2ab8a63225e22","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"},{"line_number":771,"context_line":"               default\u003d28,"},{"line_number":772,"context_line":"               help\u003d\"The mask bits for project ipv4 subnets\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"15ef7786_98d0af04","line":769,"range":{"start_line":767,"start_character":0,"end_line":769,"end_character":71},"in_reply_to":"6d3dd7bf_4f75394f","updated":"2023-03-14 09:23:14.000000000","message":"Thanks for the pointer and feedback. I agree with the assessment that it is confusing. My initial thoughts was to change the type of project_network_cidr but abstained from it due to the magnitude of the changes that it would bring in.\n\nLet me make the required changes and we could take it from there.","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":35578,"name":"Pragadeeswaran Sathyanarayanan","display_name":"Pragadee","email":"psathyan@redhat.com","username":"psathyan"},"change_message_id":"a24c1524c18d99d53a777094f6a2445f368b1465","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"},{"line_number":771,"context_line":"               default\u003d28,"},{"line_number":772,"context_line":"               help\u003d\"The mask bits for project ipv4 subnets\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfaa8f1e_42cb4f23","line":769,"range":{"start_line":767,"start_character":0,"end_line":769,"end_character":71},"in_reply_to":"6d5e6327_ebffb5f2","updated":"2023-03-21 09:50:56.000000000","message":"Thank you for all the pointers. Frankly speaking I was uncomfortable doing all the changes.\n\nInstead opted to split the existing project_network_cidr into smaller blocks. This way we can avoid the churn that would be introduced by change in OptType.\n\nAt the same time avoid hard coding of the subnets. Please let me know if this makes sense.","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7c7be2946360674d20b189fdbf92fd4b78fc8ba6","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    cfg.StrOpt(\u0027project_network_cidr\u0027,"},{"line_number":765,"context_line":"               default\u003d\"10.100.0.0/16\","},{"line_number":766,"context_line":"               help\u003d\"The cidr block to allocate project ipv4 subnets from\"),"},{"line_number":767,"context_line":"    cfg.ListOpt(\u0027project_networks_cidr\u0027,"},{"line_number":768,"context_line":"                default\u003d[\"19.80.0.0/24\", \"19.86.0.0/24\"],"},{"line_number":769,"context_line":"                help\u003d\"The cidr blocks pool for project ipv4 subnets.\"),"},{"line_number":770,"context_line":"    cfg.IntOpt(\u0027project_network_mask_bits\u0027,"},{"line_number":771,"context_line":"               default\u003d28,"},{"line_number":772,"context_line":"               help\u003d\"The mask bits for project ipv4 subnets\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fb0d3602_cf89e4a7","line":769,"range":{"start_line":767,"start_character":0,"end_line":769,"end_character":71},"in_reply_to":"dfaa8f1e_42cb4f23","updated":"2023-03-22 23:38:21.000000000","message":"thanks, that works for me.","commit_id":"902994f44eb64aebab0efdfeec41b8579fa34fab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8929302f882cf2394f7cdad691fd6b8fd3fbec5","unresolved":true,"context_lines":[{"line_number":762,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":763,"context_line":"               help\u003d\"The endpoint type to use for the network service.\"),"},{"line_number":764,"context_line":"    cfg.ListOpt(\u0027prject_network_cidrs\u0027,"},{"line_number":765,"context_line":"                default\u003d[\"10.100.0.0/16\"],"},{"line_number":766,"context_line":"                help\u003d\"CIDR blocks to allocate project ipv4 subnets from\","},{"line_number":767,"context_line":"                deprecated_opts\u003d["},{"line_number":768,"context_line":"                    cfg.DeprecatedOpt("}],"source_content_type":"text/x-python","patch_set":6,"id":"52744baf_801d794f","line":765,"range":{"start_line":765,"start_character":24,"end_line":765,"end_character":42},"updated":"2023-03-14 22:29:29.000000000","message":"may be to use [\"10.100.0.0/16\", \"10.80.0.0/16\"] as default so that it work for multinic test also","commit_id":"4e7fcb96fcf9d8256ae3e06cb4ea3c56436a52d6"},{"author":{"_account_id":35578,"name":"Pragadeeswaran Sathyanarayanan","display_name":"Pragadee","email":"psathyan@redhat.com","username":"psathyan"},"change_message_id":"a24c1524c18d99d53a777094f6a2445f368b1465","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":763,"context_line":"               help\u003d\"The endpoint type to use for the network service.\"),"},{"line_number":764,"context_line":"    cfg.ListOpt(\u0027prject_network_cidrs\u0027,"},{"line_number":765,"context_line":"                default\u003d[\"10.100.0.0/16\"],"},{"line_number":766,"context_line":"                help\u003d\"CIDR blocks to allocate project ipv4 subnets from\","},{"line_number":767,"context_line":"                deprecated_opts\u003d["},{"line_number":768,"context_line":"                    cfg.DeprecatedOpt("}],"source_content_type":"text/x-python","patch_set":6,"id":"c322a522_526c50a9","line":765,"range":{"start_line":765,"start_character":24,"end_line":765,"end_character":42},"in_reply_to":"52744baf_801d794f","updated":"2023-03-21 09:50:56.000000000","message":"Ack.\n\nI have opted for an approach that would avoid this change. We can proceed if not suitable.","commit_id":"4e7fcb96fcf9d8256ae3e06cb4ea3c56436a52d6"}]}