)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"476ef0af4987985b1eac9ea35ac936148913491d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecdf122b_ff89d911","updated":"2023-04-27 01:36:42.000000000","message":"Hmm, this must not be right. It works locally for some but not all... Help?","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eebda138b5f0d53500de12e8ea702befd1f3257c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85837f2d_b26ceafe","in_reply_to":"ecdf122b_ff89d911","updated":"2023-04-27 04:32:15.000000000","message":"I think creating the default network is needed. commented inline","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b9f1d6a4c7292782a7d1735671dc9cc4479ceb3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25798f04_ba058cb9","updated":"2023-04-27 16:13:52.000000000","message":"So does this look closer?","commit_id":"14356bde896c5ffd6e0284614c5a675e84f298f0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d5448bb72714aa2ca496caaf6739db7fdc7af2a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7c6f7698_186047f1","updated":"2023-05-01 13:41:35.000000000","message":"recheck unrelated images failure","commit_id":"93a74d3f0d78d142cf6320de9eac77999eccf862"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15360e4f6878c4abd42a249535b745c02949204e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7133b905_dfc43722","updated":"2023-05-02 00:06:43.000000000","message":"lgtm, we need to make a few method as common to share between API and scenario but that is separate change.","commit_id":"7abfad9e9d7922a7e41828f6ae0197c01e6e5e43"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"867093fe63b3372d103e8f6e76ed484cffc8ccc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ce5dc83e_c3d23236","updated":"2023-05-03 13:51:19.000000000","message":"looks good to me, thanks","commit_id":"49c2b3ba830f83eb44cf3c165f1ff1c02a38f18d"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ccd644edd60de7cf663f591cd199e588b64f1d65","unresolved":true,"context_lines":[{"line_number":184,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":187,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":188,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Wrapper utility that returns a test server."},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"97583e01_abb3f914","line":187,"range":{"start_line":187,"start_character":41,"end_line":187,"end_character":60},"updated":"2023-04-27 15:54:05.000000000","message":"here we can default to SSHABLE and test does not to valiodate ssh can ass ACTIVE","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96a3e76aedd212df19604b58874e80c0df08a7bf","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":187,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":188,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Wrapper utility that returns a test server."},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5c56c0bb_5bfcce73","line":187,"range":{"start_line":187,"start_character":41,"end_line":187,"end_character":60},"in_reply_to":"97583e01_abb3f914","updated":"2023-04-28 16:51:18.000000000","message":"Ack","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed68ce9c49a86f54e48676d405b93438f700b693","unresolved":true,"context_lines":[{"line_number":303,"context_line":"                kwargs[\u0027networks\u0027] \u003d ports"},{"line_number":304,"context_line":"            self.ports \u003d ports"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5d8ae8f_f47f1f4b","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":50},"updated":"2023-04-27 04:31:49.000000000","message":"As we are making SSHable by default, we need to have proper network setup for tenant and that need to create network resource in setup\n\n    @classmethod\n    def setup_credentials(cls):\n        # Setting network\u003dTrue, subnet\u003dTrue creates a default network\n        cls.set_network_resources(\n            network\u003dTrue,\n            subnet\u003dTrue,\n            router\u003dTrue,\n            dhcp\u003dTrue)\n        super(ScenarioTest, cls).setup_credentials()\n        \n      \nI saw few tests explicitly disable to create the default network resource[1] and if any test not doing that and start failing can disable it explicitly by calling  cls.set_network_resources().\n\n[1] https://github.com/openstack/tempest/blob/310c87856b93c5021e8b909a410df490213b5520/tempest/scenario/test_network_advanced_server_ops.py#L61","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ccd644edd60de7cf663f591cd199e588b64f1d65","unresolved":true,"context_lines":[{"line_number":303,"context_line":"                kwargs[\u0027networks\u0027] \u003d ports"},{"line_number":304,"context_line":"            self.ports \u003d ports"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"73859c0f_a0e1dc4e","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":50},"in_reply_to":"3c28a4ad_3760b76d","updated":"2023-04-27 15:54:05.000000000","message":"yeah","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96a3e76aedd212df19604b58874e80c0df08a7bf","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                kwargs[\u0027networks\u0027] \u003d ports"},{"line_number":304,"context_line":"            self.ports \u003d ports"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"01430de7_5d5de23c","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":50},"in_reply_to":"73859c0f_a0e1dc4e","updated":"2023-04-28 16:51:18.000000000","message":"Done","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f6762810be2f0c81c5ab8b7bde54f8531ee00df","unresolved":true,"context_lines":[{"line_number":303,"context_line":"                kwargs[\u0027networks\u0027] \u003d ports"},{"line_number":304,"context_line":"            self.ports \u003d ports"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c28a4ad_3760b76d","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":50},"in_reply_to":"a5d8ae8f_f47f1f4b","updated":"2023-04-27 15:46:44.000000000","message":"Meaning we need `setup_credentials()` on this class with these flags\u003dtrue?","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed68ce9c49a86f54e48676d405b93438f700b693","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"45ec217f_aa7c451d","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"updated":"2023-04-27 04:31:49.000000000","message":"if CONF.validation.run_validation and wait_until \u003d\u003d SSHABLE:\n\nso that if wait is requested only for ACTIVE then we do not need to create validation resource.","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ccd644edd60de7cf663f591cd199e588b64f1d65","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2cae8c1b_4707601b","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"in_reply_to":"0f1ab9b8_47a575e8","updated":"2023-04-27 15:54:05.000000000","message":"we can make arg wait_until default to SSHABLE L186 and test does not want can pass ACTIVE ?","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b9f1d6a4c7292782a7d1735671dc9cc4479ceb3b","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c857de3a_700ef549","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"in_reply_to":"2cae8c1b_4707601b","updated":"2023-04-27 16:13:52.000000000","message":"Ack, I just wasn\u0027t sure if that\u0027s what you meant. My local cinder will no longer create volumes, so I pushed up a change to get a run started here and will I guess need to restack locally to see.","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f6762810be2f0c81c5ab8b7bde54f8531ee00df","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f1ab9b8_47a575e8","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"in_reply_to":"45ec217f_aa7c451d","updated":"2023-04-27 15:46:44.000000000","message":"But the point is to make everyone that calls this wait until sshable. Are you saying we need to go change every test to wait until sshable? Or change the default for wait_until above to be sshable?","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96a3e76aedd212df19604b58874e80c0df08a7bf","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae6cb84d_321cbd91","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"in_reply_to":"755313ab_daae7697","updated":"2023-04-28 16:51:18.000000000","message":"Done","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"57b6b2259c808cc23ce9d8a5ecb143d94b2d20f0","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6385883_e1afd4c3","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"in_reply_to":"c857de3a_700ef549","updated":"2023-04-27 17:10:23.000000000","message":"but we can add  wait_until \u003d\u003d SSHABLE in if condition here means if any test explicitly not want to SSH then we do not create/apss validation things to compute.create_test_server","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8c0c9c43c5f652363c5971b315541f1e513b5264","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":310,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if CONF.validation.run_validation:"},{"line_number":313,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":314,"context_line":"                self.os_primary)"},{"line_number":315,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"755313ab_daae7697","line":312,"range":{"start_line":312,"start_character":41,"end_line":312,"end_character":42},"in_reply_to":"e6385883_e1afd4c3","updated":"2023-04-27 17:11:52.000000000","message":"Ah right, sorry I missed that.","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed68ce9c49a86f54e48676d405b93438f700b693","unresolved":true,"context_lines":[{"line_number":323,"context_line":"            image_id\u003dimage_id, **kwargs)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        server \u003d clients.servers_client.show_server(body[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":326,"context_line":"        if CONF.validation.run_validation:"},{"line_number":327,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":328,"context_line":"                compute.get_server_ip(server, validation_resources),"},{"line_number":329,"context_line":"                CONF.validation.image_ssh_user,"},{"line_number":330,"context_line":"                password\u003dNone,"},{"line_number":331,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":332,"context_line":"                server\u003dserver,"},{"line_number":333,"context_line":"                servers_client\u003dclients.servers_client)"},{"line_number":334,"context_line":"            linux_client.validate_authentication()"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":337,"context_line":"                        clients.servers_client, body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7fb17881_ab808d14","line":334,"range":{"start_line":326,"start_character":0,"end_line":334,"end_character":50},"updated":"2023-04-27 04:31:49.000000000","message":"this is not needed if we pass wait_until as SSHable in compute.create_test_server (L318)","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96a3e76aedd212df19604b58874e80c0df08a7bf","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            image_id\u003dimage_id, **kwargs)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        server \u003d clients.servers_client.show_server(body[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":326,"context_line":"        if CONF.validation.run_validation:"},{"line_number":327,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":328,"context_line":"                compute.get_server_ip(server, validation_resources),"},{"line_number":329,"context_line":"                CONF.validation.image_ssh_user,"},{"line_number":330,"context_line":"                password\u003dNone,"},{"line_number":331,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":332,"context_line":"                server\u003dserver,"},{"line_number":333,"context_line":"                servers_client\u003dclients.servers_client)"},{"line_number":334,"context_line":"            linux_client.validate_authentication()"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":337,"context_line":"                        clients.servers_client, body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2ec1f6d_d236ad3a","line":334,"range":{"start_line":326,"start_character":0,"end_line":334,"end_character":50},"in_reply_to":"150c789a_4b14377f","updated":"2023-04-28 16:51:18.000000000","message":"Done","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f6762810be2f0c81c5ab8b7bde54f8531ee00df","unresolved":true,"context_lines":[{"line_number":323,"context_line":"            image_id\u003dimage_id, **kwargs)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        server \u003d clients.servers_client.show_server(body[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":326,"context_line":"        if CONF.validation.run_validation:"},{"line_number":327,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":328,"context_line":"                compute.get_server_ip(server, validation_resources),"},{"line_number":329,"context_line":"                CONF.validation.image_ssh_user,"},{"line_number":330,"context_line":"                password\u003dNone,"},{"line_number":331,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":332,"context_line":"                server\u003dserver,"},{"line_number":333,"context_line":"                servers_client\u003dclients.servers_client)"},{"line_number":334,"context_line":"            linux_client.validate_authentication()"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":337,"context_line":"                        clients.servers_client, body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"150c789a_4b14377f","line":334,"range":{"start_line":326,"start_character":0,"end_line":334,"end_character":50},"in_reply_to":"7fb17881_ab808d14","updated":"2023-04-27 15:46:44.000000000","message":"Ah, okay.","commit_id":"48f997e5bd6fe759b0279a388b7ade01b46f8ec1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6933a92aa3e4c0b817cea62f51a3b93cbce2f970","unresolved":true,"context_lines":[{"line_number":320,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if CONF.validation.run_validation:"},{"line_number":323,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":324,"context_line":"                self.os_primary)"},{"line_number":325,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"},{"line_number":326,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"}],"source_content_type":"text/x-python","patch_set":2,"id":"53f4ef3e_2975d627","line":323,"range":{"start_line":323,"start_character":40,"end_line":323,"end_character":70},"updated":"2023-04-27 17:16:29.000000000","message":"missed this, as this is instance level method we can use get_test_validation_resources so that we create/delete validation resources at test level only","commit_id":"14356bde896c5ffd6e0284614c5a675e84f298f0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96a3e76aedd212df19604b58874e80c0df08a7bf","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if CONF.validation.run_validation:"},{"line_number":323,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":324,"context_line":"                self.os_primary)"},{"line_number":325,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"},{"line_number":326,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"}],"source_content_type":"text/x-python","patch_set":2,"id":"48ad0b1b_54485042","line":323,"range":{"start_line":323,"start_character":40,"end_line":323,"end_character":70},"in_reply_to":"53f4ef3e_2975d627","updated":"2023-04-28 16:51:18.000000000","message":"Done","commit_id":"14356bde896c5ffd6e0284614c5a675e84f298f0"}]}