)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"79ed80c35f7c4d9e0f3c6446e8a7f473ddbddc8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1a5a4d9_154a4ceb","updated":"2023-05-05 07:32:34.000000000","message":"makes sense","commit_id":"6574469293645c492c8d951a0ef81174287663ee"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"93cd72df5cca6f0699304d48ded7a3b9aeca124f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aaf79f7f_484c8722","updated":"2023-05-05 00:12:00.000000000","message":"recheck unrelated test_server_connectivity_live_migration failure","commit_id":"6574469293645c492c8d951a0ef81174287663ee"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f52c053d3bd276f84eb234e280c0d3d26aa6361b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ee0fd4f_4b77ea5e","updated":"2023-05-05 03:36:48.000000000","message":"thanks, lgtm","commit_id":"6574469293645c492c8d951a0ef81174287663ee"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eeafab233fc5ac7f8fa7786a8860f8dbdea85c3f","unresolved":true,"context_lines":[{"line_number":335,"context_line":"                validation_resources \u003d copy.deepcopy(validation_resources)"},{"line_number":336,"context_line":"                validation_resources.update("},{"line_number":337,"context_line":"                    keypair\u003dkeypair)"},{"line_number":338,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"},{"line_number":339,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"},{"line_number":340,"context_line":"        if keypair:"},{"line_number":341,"context_line":"            kwargs.update({\u0027key_name\u0027: keypair[\u0027name\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8f13ca1_59e769c5","line":338,"updated":"2023-05-04 19:40:50.000000000","message":"we need to avoid override validatable here if we are taking it at L323. and let compute.py L343 fail if test does not pass it True and ask for SSHABLE","commit_id":"9e91cd4136c2c16c1b96cbfb7efc9e662be2f4e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"007046894ed7432f85339ceb0aaca4d76be95ec0","unresolved":true,"context_lines":[{"line_number":335,"context_line":"                validation_resources \u003d copy.deepcopy(validation_resources)"},{"line_number":336,"context_line":"                validation_resources.update("},{"line_number":337,"context_line":"                    keypair\u003dkeypair)"},{"line_number":338,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"},{"line_number":339,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"},{"line_number":340,"context_line":"        if keypair:"},{"line_number":341,"context_line":"            kwargs.update({\u0027key_name\u0027: keypair[\u0027name\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"18cadfcf_62b1e13f","line":338,"in_reply_to":"4041a51f_dcb42b97","updated":"2023-05-04 21:49:55.000000000","message":"oh, default is not None. I think it make sense to make it None which does not introduce any incompatible change instead can unhide if anyone passing SSHABLE and replying on default value which is False.\n\nLet\u0027s make it default to None and then make it True if None","commit_id":"9e91cd4136c2c16c1b96cbfb7efc9e662be2f4e4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"893497c5cf02c3ab93b441a18cb31da9d6c8dba0","unresolved":true,"context_lines":[{"line_number":335,"context_line":"                validation_resources \u003d copy.deepcopy(validation_resources)"},{"line_number":336,"context_line":"                validation_resources.update("},{"line_number":337,"context_line":"                    keypair\u003dkeypair)"},{"line_number":338,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"},{"line_number":339,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"},{"line_number":340,"context_line":"        if keypair:"},{"line_number":341,"context_line":"            kwargs.update({\u0027key_name\u0027: keypair[\u0027name\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"4041a51f_dcb42b97","line":338,"in_reply_to":"628c53c3_b39a1267","updated":"2023-05-04 21:45:45.000000000","message":"Just to be clear, the point of doing this here was to make SSHABLE all you had to ask for. So I need to make this override to True if it was not passed (i.e. None) and otherwise pass in the value they chose. That means changing the default param in this function. Is that what you want?\n\nMy change on L332 was just so that we\u0027d pass it through if you provided it and didn\u0027t wait_until\u003dSSHABLE, so it could also go in the else: of L326.","commit_id":"9e91cd4136c2c16c1b96cbfb7efc9e662be2f4e4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cbc6ddbacb42d2ce2361313576f18e813324b872","unresolved":true,"context_lines":[{"line_number":335,"context_line":"                validation_resources \u003d copy.deepcopy(validation_resources)"},{"line_number":336,"context_line":"                validation_resources.update("},{"line_number":337,"context_line":"                    keypair\u003dkeypair)"},{"line_number":338,"context_line":"            kwargs.update({\u0027validatable\u0027: True,"},{"line_number":339,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"},{"line_number":340,"context_line":"        if keypair:"},{"line_number":341,"context_line":"            kwargs.update({\u0027key_name\u0027: keypair[\u0027name\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"628c53c3_b39a1267","line":338,"in_reply_to":"d8f13ca1_59e769c5","updated":"2023-05-04 20:29:27.000000000","message":"I mean, I guess.. I figured it was okay to enforce it here if we\u0027re throwing validation_resources into the dict always. But sure, if you prefer.","commit_id":"9e91cd4136c2c16c1b96cbfb7efc9e662be2f4e4"}]}