)]}'
{"tempest/clients.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"df630e8cd70ec2146026d88ac5b453b4d3e59af2","unresolved":false,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def _get_object_storage_client(self, username, password, tenant_name):"},{"line_number":594,"context_line":"        if not CONF.service_available.swift:"},{"line_number":595,"context_line":"            return None"},{"line_number":596,"context_line":"        import swiftclient"},{"line_number":597,"context_line":"        auth_url \u003d CONF.identity.uri"},{"line_number":598,"context_line":"        if CONF.compute.allow_tenant_isolation and CONF.has_admin_creds:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FFLA%3D","line":595,"updated":"2014-04-24 06:59:24.000000000","message":"Just thinking if it would make more sense to raise an exception instead of returning None? But I think we could fix that later.","commit_id":"ebe590e09d7569764a07809c7b928485ca8ef19a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"6ad4a396d0d011139e985d1f8713fdb217038979","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        # preferable to authenticating as a specific user because"},{"line_number":691,"context_line":"        # working with certain resources (public routers and networks)"},{"line_number":692,"context_line":"        # often requires admin privileges anyway."},{"line_number":693,"context_line":"        if not CONF.service_available.neutron or not CONF.has_admin_creds:"},{"line_number":694,"context_line":"            return None"},{"line_number":695,"context_line":"        import neutronclient.v2_0.client"},{"line_number":696,"context_line":"        username \u003d CONF.identity.admin_username"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FPXc%3D","line":693,"updated":"2014-04-23 04:59:41.000000000","message":"I think this is fine as a first step, but eventually we should have a neutron admin account defined, so that it is possible to run neutron tests without having an identity admin account.\nIn devstack there is not difference between admin accounts, but it is possible and likely to have better admin role granularity in a real deployment.","commit_id":"ebe590e09d7569764a07809c7b928485ca8ef19a"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"dd7899782f2ae84a6eb6645ede4917fdfea9c7a2","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        # preferable to authenticating as a specific user because"},{"line_number":691,"context_line":"        # working with certain resources (public routers and networks)"},{"line_number":692,"context_line":"        # often requires admin privileges anyway."},{"line_number":693,"context_line":"        if not CONF.service_available.neutron or not CONF.has_admin_creds:"},{"line_number":694,"context_line":"            return None"},{"line_number":695,"context_line":"        import neutronclient.v2_0.client"},{"line_number":696,"context_line":"        username \u003d CONF.identity.admin_username"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FLLg%3D","line":693,"in_reply_to":"AAAAXH%2F%2FPXc%3D","updated":"2014-04-23 14:57:00.000000000","message":"Interestingly I had a discussion about removing the \"compute-admin\" because it did not seem to be used.","commit_id":"ebe590e09d7569764a07809c7b928485ca8ef19a"}],"tempest/test.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"df630e8cd70ec2146026d88ac5b453b4d3e59af2","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    return decorator"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def requires_admin():"},{"line_number":202,"context_line":"    \"\"\"A decorator to skip tests if admin credentials are not available"},{"line_number":203,"context_line":"    \"\"\""},{"line_number":204,"context_line":"    def decorator(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FFNU%3D","line":201,"updated":"2014-04-24 06:59:24.000000000","message":"Where is this decorator used? If this is just for future usage can we at least add a unit test in test_decorator.py?","commit_id":"ebe590e09d7569764a07809c7b928485ca8ef19a"}]}