)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bd9cc68abd3d58a85a36c9b6e0be3d80d15421d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"958b3584_24d0c700","updated":"2023-06-07 09:12:16.000000000","message":"recheck","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c51a5f319052c7e0e1ec4565ffae7670e314b227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b5cae45_170f47e3","updated":"2023-05-25 13:23:21.000000000","message":"recheck unrelated failures across multiple jobs","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"03689c3a96d3368c91c61edf6c6ecd4ddfa1d43f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7658a4aa_b78a1868","updated":"2023-05-26 12:15:02.000000000","message":"recheck unrelated testcase failure","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f84921eb73a4760a0ddbda5bf503e59207c1928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db57d294_5221a70b","updated":"2023-06-07 23:43:23.000000000","message":"thanks, agree with the problem but let\u0027s not skip the tests instead we can pass even list is empty/","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"}],"tempest/api/compute/admin/test_networks.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f84921eb73a4760a0ddbda5bf503e59207c1928","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        if CONF.compute.fixed_network_name:"},{"line_number":64,"context_line":"            configured_network \u003d CONF.compute.fixed_network_name"},{"line_number":65,"context_line":"            self.assertIn(configured_network, [x[\u0027label\u0027] for x in networks])"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            raise self.skipException("},{"line_number":68,"context_line":"                \"Environment has no known-for-sure existing network.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"795c5e00_197124dd","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":70},"updated":"2023-06-07 23:43:23.000000000","message":"I think we can remove this else part. because test is to list the network not to find the configured network which is above test. This list the network and check if configured network is there otherwise if list is empty it still pass the listing the networks from API operation perspective.","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a1b20c4006350398c6b2495d66eb005e4a228a4","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        if CONF.compute.fixed_network_name:"},{"line_number":64,"context_line":"            configured_network \u003d CONF.compute.fixed_network_name"},{"line_number":65,"context_line":"            self.assertIn(configured_network, [x[\u0027label\u0027] for x in networks])"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            raise self.skipException("},{"line_number":68,"context_line":"                \"Environment has no known-for-sure existing network.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d56582f5_c02719d6","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":70},"in_reply_to":"00779d41_e65bd369","updated":"2023-07-20 23:07:46.000000000","message":"sorry for missing your response. yeah it is deprecated API :).\n\nMy point was even nova list_networks return empty list because there is no actual network is still a valid thing but I think I got your point of false interpretation of test passing means there are some network present. I agree to skip the test now.","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"184ed67c178012bfdc78f26fe580823c3a6e5acd","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        if CONF.compute.fixed_network_name:"},{"line_number":64,"context_line":"            configured_network \u003d CONF.compute.fixed_network_name"},{"line_number":65,"context_line":"            self.assertIn(configured_network, [x[\u0027label\u0027] for x in networks])"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            raise self.skipException("},{"line_number":68,"context_line":"                \"Environment has no known-for-sure existing network.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"00779d41_e65bd369","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":70},"in_reply_to":"795c5e00_197124dd","updated":"2023-06-20 16:31:37.000000000","message":"I think the logic in this test is the following:\n1) If there is a pre-configured network then that should be returned by the list_networks() call. But there can be other non preconfigured networks returned. Therefore we only check that the preconfigured is in the list but we allow more in that list. \n2) If there is no pre-configured network then there is nothing we can check in that list retuned by list_networks(). The list can be empty or non empty. \n\nSo I don\u0027t follow what you suggest here. I can blind say\n```\n    else:\n        return \n```\nif we want to pass the test but I think skipping is better.\n\nAlso please note that the API tested here is deprecated since Newton :)","commit_id":"0e8fcab930e1922833bfc4cfeeb45bf2da540070"}]}