)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"b1a1b29df8e947104ab46cefe87c865896bb3b72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa0bd58e_ab185b38","updated":"2023-05-29 16:55:27.000000000","message":"recheck\n\nUnrelated failure","commit_id":"92529b57900e4d7404292fa2e033b1cb05e1102a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"303db85425a270313f4f12b1b20defa6169bcc13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c73647b_463cf937","updated":"2023-06-01 01:51:44.000000000","message":"thanks for fixing it","commit_id":"92529b57900e4d7404292fa2e033b1cb05e1102a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"69af881eb39d82a9390cdbbd61723e09c1f4ae68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0162edf9_53f9df10","updated":"2023-06-01 14:00:50.000000000","message":"That fix work for me, thanks!","commit_id":"8e809f750a74dc86273a5c605bc2e6bace1d5a3b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"963510861cd7d96de3fa9c524feac6dda04ac227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b784a154_8824414e","updated":"2023-06-01 12:54:29.000000000","message":"This looks good to me!\n\nI just added a small comment. But it is only just an idea and I think it is not important.","commit_id":"8e809f750a74dc86273a5c605bc2e6bace1d5a3b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"88789f3a6d746a83a4c63b72057e3de652a2c1e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88df2661_1fe96cc7","updated":"2023-06-01 12:54:56.000000000","message":"recheck\nThe failure in tempest-slow-py3 is not caused by this patch.","commit_id":"8e809f750a74dc86273a5c605bc2e6bace1d5a3b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b46c1e3799424fb9489c743d7d081dbd3b9ae014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e207ed17_3bc3e526","updated":"2023-06-01 14:02:10.000000000","message":"recheck unrelated tests failed:\n- tempest.api.compute.volumes.test_attach_volume.AttachVolumeMultiAttachTest.test_resize_server_with_multiattached_volume for tempest-full-ubuntu-focal\n\n- tempest.scenario.test_network_advanced_server_ops.TestNetworkAdvancedServerOps.test_server_connectivity_live_migration for tempest-slow-py3","commit_id":"8e809f750a74dc86273a5c605bc2e6bace1d5a3b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9ddf9e69e7413bffa2bd2fc80af37bb4267a9128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0d10f4b5_ec7569f1","updated":"2023-06-02 07:51:58.000000000","message":"lgtm, thanks Roman for fixing this!","commit_id":"86b8b6204c08aa304b57c0758b2ae3321513614b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"71fed2a3502598a5eef8a423f2b808058e7395ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21cf290f_5919eea2","updated":"2023-06-05 07:34:53.000000000","message":"recheck\nTIMED_OUT errors not caused by this patch","commit_id":"86b8b6204c08aa304b57c0758b2ae3321513614b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"afa821678fbd6fef2cd09b5546bd7f6669646428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4408ca3_ccea02e0","updated":"2023-06-02 14:24:12.000000000","message":"recheck post failures","commit_id":"86b8b6204c08aa304b57c0758b2ae3321513614b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f21f73ad12d9856ee1a488540d7d4a033110b586","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"14bbd394_1e488564","updated":"2023-06-02 07:51:44.000000000","message":"recheck timeouts again","commit_id":"86b8b6204c08aa304b57c0758b2ae3321513614b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12e056ce950bd4c2cb0d3a252a1df42b44089c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f9843f0_2ba09a0e","updated":"2023-06-01 17:03:53.000000000","message":"thanks for the fix.","commit_id":"86b8b6204c08aa304b57c0758b2ae3321513614b"}],"tempest/scenario/test_server_basic_ops.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0e4e6b209e06a7c7bba534f1b282467d30a6204f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            # Obtain a floating IP if floating_ips is enabled"},{"line_number":53,"context_line":"            if (CONF.network_feature_enabled.floating_ips and"},{"line_number":54,"context_line":"                CONF.network.floating_network_name):"},{"line_number":55,"context_line":"                self.ip \u003d self.get_server_ip(self.instance)"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                server \u003d self.servers_client.show_server("},{"line_number":58,"context_line":"                    self.instance[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"0120de8b_e9e232ac","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":59},"updated":"2023-05-29 16:18:19.000000000","message":"hm, i need to do further digging because i don\u0027t understand why we can pass self.instance here, however, we had to call show_server first in the below else branch.\n\nIn the meantime we\u0027ll see here whether this fixes the issue:\nhttps://review.opendev.org/c/openinfra/python-tempestconf/+/881551","commit_id":"92529b57900e4d7404292fa2e033b1cb05e1102a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"bc391e3046d090520c65d76bc2d2c69ea8af6470","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            # Obtain a floating IP if floating_ips is enabled"},{"line_number":53,"context_line":"            if (CONF.network_feature_enabled.floating_ips and"},{"line_number":54,"context_line":"                CONF.network.floating_network_name):"},{"line_number":55,"context_line":"                self.ip \u003d self.get_server_ip(self.instance)"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                server \u003d self.servers_client.show_server("},{"line_number":58,"context_line":"                    self.instance[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a164ebbe_bda4a658","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":59},"in_reply_to":"0120de8b_e9e232ac","updated":"2023-05-30 09:54:34.000000000","message":"I\u0027m not sure about this if-else statement. It might be wrong but here\u0027s what I am thinking about:\n\nThe goal of get_server_ip() function is to get IP that can be used for validation of whether we can connect to a VM.\n\nSo why can\u0027t we drop this if-else statement and replace it with a single self.get_server_ip()? If the logic inside the get_server_ip() is incorrect then we should fix the logic there (?). \n\nAlso I\u0027m thinking whether this function verify_ssh() is needed after all. Thanks to this patch we should wait for a server to be SSHABLE so there should be no need to verify again here? [1] \n\nhttps://opendev.org/openstack/tempest/commit/49c2b3ba830f83eb44cf3c165f1ff1c02a38f18d","commit_id":"92529b57900e4d7404292fa2e033b1cb05e1102a"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"26413c408c5ec01898e288462a050e941282609a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            # Obtain a floating IP if floating_ips is enabled"},{"line_number":53,"context_line":"            if (CONF.network_feature_enabled.floating_ips and"},{"line_number":54,"context_line":"                CONF.network.floating_network_name):"},{"line_number":55,"context_line":"                self.ip \u003d self.get_server_ip(self.instance)"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                server \u003d self.servers_client.show_server("},{"line_number":58,"context_line":"                    self.instance[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc20d7c9_e14d695b","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":59},"in_reply_to":"43b398ff_bfe557d3","updated":"2023-06-01 08:38:18.000000000","message":"Done","commit_id":"92529b57900e4d7404292fa2e033b1cb05e1102a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"303db85425a270313f4f12b1b20defa6169bcc13","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            # Obtain a floating IP if floating_ips is enabled"},{"line_number":53,"context_line":"            if (CONF.network_feature_enabled.floating_ips and"},{"line_number":54,"context_line":"                CONF.network.floating_network_name):"},{"line_number":55,"context_line":"                self.ip \u003d self.get_server_ip(self.instance)"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                server \u003d self.servers_client.show_server("},{"line_number":58,"context_line":"                    self.instance[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"43b398ff_bfe557d3","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":59},"in_reply_to":"a164ebbe_bda4a658","updated":"2023-06-01 01:51:44.000000000","message":"we need verify_ssh to set  self.ssh_client which is used by all other verify method.\n\nLukas is right, we do not need to create/deal with the FIP. remove the L53-L58 and just keep self.get_server_ip and it will work.","commit_id":"92529b57900e4d7404292fa2e033b1cb05e1102a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"963510861cd7d96de3fa9c524feac6dda04ac227","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        self.run_ssh \u003d CONF.validation.run_validation"},{"line_number":48,"context_line":"        self.ssh_user \u003d CONF.validation.image_ssh_user"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def verify_ssh(self, keypair):"},{"line_number":51,"context_line":"        if self.run_ssh:"},{"line_number":52,"context_line":"            # Obtain server IP"},{"line_number":53,"context_line":"            self.ip \u003d self.get_server_ip(self.instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b08ff78_0f28e4d6","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":18},"updated":"2023-06-01 12:54:29.000000000","message":"If we keep this function I would rename this to create_ssh_client() Because the verification is done by the create_server() and this is really mainly about creating the ssh_client. It would make the test more readable in my opinion. Now it is a little bit confusing \u003d\u003e verify_ssh() is creating a ssh_client that is used by all the other functions in this class.","commit_id":"8e809f750a74dc86273a5c605bc2e6bace1d5a3b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12e056ce950bd4c2cb0d3a252a1df42b44089c97","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        self.run_ssh \u003d CONF.validation.run_validation"},{"line_number":48,"context_line":"        self.ssh_user \u003d CONF.validation.image_ssh_user"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def verify_ssh(self, keypair):"},{"line_number":51,"context_line":"        if self.run_ssh:"},{"line_number":52,"context_line":"            # Obtain server IP"},{"line_number":53,"context_line":"            self.ip \u003d self.get_server_ip(self.instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"106119d4_9eae1cc6","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":18},"in_reply_to":"8b08ff78_0f28e4d6","updated":"2023-06-01 17:03:53.000000000","message":"I am ok with this as getting the ssh client means we are able to do the ssh, get_remote_client() method do validate_authentication() also. So basically this method verify the ssh and also return the ssh client for more verification.","commit_id":"8e809f750a74dc86273a5c605bc2e6bace1d5a3b"}]}