)]}'
{"tempest/api/baremetal/test_nodes.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"51b51e0d2c0827470e6768eb6704a855f8ad3119","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        container \u003d list()"},{"line_number":104,"context_line":"        for key, value in body.iteritems():"},{"line_number":105,"context_line":"            container.append(key)"},{"line_number":106,"context_line":"        for interface in core_interfaces:"},{"line_number":107,"context_line":"            self.assertIn(interface, container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Ff%2BM%3D","line":105,"updated":"2014-04-21 08:07:14.000000000","message":"the interface name could be got directly from body.keys(), don\u0027t need the for loop.\n\ncontainer \u003d body.keys()","commit_id":"4666ec33843f8ff5c4c0554652c614d881391db4"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1559b5cf155a5652df7f03bbfb8bb51361805513","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        container \u003d list()"},{"line_number":104,"context_line":"        for key, value in body.iteritems():"},{"line_number":105,"context_line":"            container.append(key)"},{"line_number":106,"context_line":"        for interface in core_interfaces:"},{"line_number":107,"context_line":"            self.assertIn(interface, container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FfzY%3D","line":105,"in_reply_to":"AAAAXH%2F%2Ff%2BM%3D","updated":"2014-04-21 09:04:03.000000000","message":"Will be done in next patch.","commit_id":"4666ec33843f8ff5c4c0554652c614d881391db4"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"805294734bba6bf4944747f32e2286e30645e51f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        for interface in core_interfaces:"},{"line_number":104,"context_line":"            self.assertIn(interface, body.keys())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_e255121e","line":104,"updated":"2014-05-01 20:22:32.000000000","message":"The .keys() is not necessary because body is a dict, and also creates an n^2 loop. This is always a bad code fragment though does not really matter in this case.","commit_id":"ba92203bccffdef3a302c9f68ce56405438b9c98"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b3f383bfb4e557322a9aa51939546417d611a83e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        for interface in core_interfaces:"},{"line_number":104,"context_line":"            self.assertIn(interface, body.keys())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b94f9dbd","line":104,"in_reply_to":"7adec928_19751598","updated":"2014-06-02 11:04:28.000000000","message":"Done","commit_id":"ba92203bccffdef3a302c9f68ce56405438b9c98"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ac53688185e045fab7c4c6db78a23faddc26d6d7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        for interface in core_interfaces:"},{"line_number":104,"context_line":"            self.assertIn(interface, body.keys())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_19751598","line":104,"in_reply_to":"9ad9bd40_06503c5d","updated":"2014-05-09 02:09:41.000000000","message":"+1 for David\u0027s comments","commit_id":"ba92203bccffdef3a302c9f68ce56405438b9c98"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b3f383bfb4e557322a9aa51939546417d611a83e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        for interface in core_interfaces:"},{"line_number":104,"context_line":"            self.assertIn(interface, body.keys())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9954a155","line":104,"in_reply_to":"9ad9bd40_06503c5d","updated":"2014-06-02 11:04:28.000000000","message":"Done","commit_id":"ba92203bccffdef3a302c9f68ce56405438b9c98"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"31650ec1725a81f20b9feb65e564108715889f2c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        for interface in core_interfaces:"},{"line_number":104,"context_line":"            self.assertIn(interface, body.keys())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_06503c5d","line":104,"in_reply_to":"9ad9bd40_57bbd4e4","updated":"2014-05-02 12:17:13.000000000","message":"Maybe I am missing something but why can\u0027t you just do \nself.assertIn(interface, body) ?","commit_id":"ba92203bccffdef3a302c9f68ce56405438b9c98"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b28bbb266135c9b567b7a66f743298860782d158","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":102,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"},{"line_number":103,"context_line":"        for interface in core_interfaces:"},{"line_number":104,"context_line":"            self.assertIn(interface, body.keys())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_57bbd4e4","line":104,"in_reply_to":"9ad9bd40_e255121e","updated":"2014-05-02 05:08:22.000000000","message":"Ok, I think one solution of this to create a list and append all keys of body in this and then assertIn should be called. what you say ??","commit_id":"ba92203bccffdef3a302c9f68ce56405438b9c98"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e8d83f660179e7f9a3417e287415c35182ccb1e7","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":92,"context_line":"    def test_validate_driver_interface(self):"},{"line_number":93,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":94,"context_line":"        resp, body \u003d self.client.validate_driver_interface(node[\u0027uuid\u0027])"},{"line_number":95,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_3a155f9b","line":93,"updated":"2014-06-24 08:53:24.000000000","message":"This test fails like:\n\nTraceback (most recent call last):\n  File \"tempest/api/baremetal/test_nodes.py\", line 93, in test_validate_driver_interface\n    node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]\nTypeError: tuple indices must be integers, not str\n\non http://logs.openstack.org/22/88522/5/check/check-tempest-dsvm-ironic-nv/2ac2bc7/logs/testr_results.html.gz\n\nPlease check check-tempest-dsvm-ironic-nv or something when creating tests related to ironic.","commit_id":"5c8ca6b3eb0e953c4609b7757bd57dd0ed7b9415"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"50153dca24378a657dc500f0af9f93be66611945","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":92,"context_line":"    def test_validate_driver_interface(self):"},{"line_number":93,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":94,"context_line":"        resp, body \u003d self.client.validate_driver_interface(node[\u0027uuid\u0027])"},{"line_number":95,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_466c16d1","line":93,"in_reply_to":"1ae5cdf2_3a155f9b","updated":"2014-06-24 10:18:41.000000000","message":"Thanks Ohmichi san :) it is done in next patch.","commit_id":"5c8ca6b3eb0e953c4609b7757bd57dd0ed7b9415"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f48e887b20ad0fca850466a190f55ece31a3023c","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":92,"context_line":"    def test_validate_driver_interface(self):"},{"line_number":93,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":94,"context_line":"        resp, body \u003d self.client.validate_driver_interface(node[\u0027uuid\u0027])"},{"line_number":95,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"        core_interfaces \u003d [\u0027power\u0027, \u0027deploy\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_e64fe232","line":93,"in_reply_to":"1ae5cdf2_466c16d1","updated":"2014-06-24 10:20:35.000000000","message":"Raies-san,\n\nwelcome, and we need to wait for gate tests ;-)","commit_id":"5c8ca6b3eb0e953c4609b7757bd57dd0ed7b9415"}]}