)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"cbb2b5e4f7b98b8fa64341a8f6993127b3006be1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f839f423_46add553","updated":"2023-06-22 09:23:36.000000000","message":"lgtm, the test works and takes about 8 sec, which isn\u0027t that bad .. one idea inline for an open discussion","commit_id":"16746bb1544d796b1774062c45665ac9597a351e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc292acb581946ada5c7af9672153a3911d2c808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55cc176a_099daf45","updated":"2023-06-25 09:53:33.000000000","message":"recheck","commit_id":"876c3438fd1deb33b83a1f8f5af89f2c1df9b002"}],"tempest/api/volume/test_volumes_snapshots_negative.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"cbb2b5e4f7b98b8fa64341a8f6993127b3006be1","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027677863d1-34f9-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":53,"context_line":"    def test_volume_from_snapshot_decreasing_size(self):"},{"line_number":54,"context_line":"        \"\"\"Test creating volume from snapshot with decreasing size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        creating volume from snapshot with decreasing size should fail."}],"source_content_type":"text/x-python","patch_set":1,"id":"1abe2c04_d045dc63","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"updated":"2023-06-22 09:23:36.000000000","message":"just throwing an idea for open discussion:\nwhat if we moved this test together with the new one to a new class (still in this file) - then we could share the volume and snapshot between the 2 test cases - we wouldn\u0027t need to create it twice\n\non the other hand the new test takes only about 8 seconds, not sure if that\u0027s worth of optimizing\n\n(i checked and this test isn\u0027t part of interop, so moving it around shouldn\u0027t cause issues)","commit_id":"16746bb1544d796b1774062c45665ac9597a351e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c08eeb8d85b342a07e0c55985427046a220e3a95","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027677863d1-34f9-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":53,"context_line":"    def test_volume_from_snapshot_decreasing_size(self):"},{"line_number":54,"context_line":"        \"\"\"Test creating volume from snapshot with decreasing size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        creating volume from snapshot with decreasing size should fail."}],"source_content_type":"text/x-python","patch_set":1,"id":"b91a2c4b_345043de","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"1abe2c04_d045dc63","updated":"2023-06-22 09:31:07.000000000","message":"I\u0027m fine with that, but why do we need a separated class? these tests are already in the same class.","commit_id":"16746bb1544d796b1774062c45665ac9597a351e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"088a6b408364635879d12c72588cd8ef9b4c66a8","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027677863d1-34f9-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":53,"context_line":"    def test_volume_from_snapshot_decreasing_size(self):"},{"line_number":54,"context_line":"        \"\"\"Test creating volume from snapshot with decreasing size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        creating volume from snapshot with decreasing size should fail."}],"source_content_type":"text/x-python","patch_set":1,"id":"c75daef6_4ec8d988","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"69c0fefb_f7b5b1af","updated":"2023-06-22 10:01:29.000000000","message":"I reduced the runtime of the class","commit_id":"16746bb1544d796b1774062c45665ac9597a351e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"088a6b408364635879d12c72588cd8ef9b4c66a8","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027677863d1-34f9-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":53,"context_line":"    def test_volume_from_snapshot_decreasing_size(self):"},{"line_number":54,"context_line":"        \"\"\"Test creating volume from snapshot with decreasing size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        creating volume from snapshot with decreasing size should fail."}],"source_content_type":"text/x-python","patch_set":1,"id":"07cc93e2_58590712","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"69c0fefb_f7b5b1af","updated":"2023-06-22 10:01:29.000000000","message":"This change reduces the runtime of the class significantly.\nI tested it multiple times:\n\nNo shared resources:\nRan: 7 tests in 13.7360 sec.\nRan: 7 tests in 12.4952 sec.\nRan: 7 tests in 12.7631 sec.\n\nShared resources:\nRan: 7 tests in 0.3285 sec.\nRan: 7 tests in 0.3224 sec.\n\nThanks Martin!","commit_id":"16746bb1544d796b1774062c45665ac9597a351e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7e62f8b571a3b33358063a4600e033b13c6cfdba","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027677863d1-34f9-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":53,"context_line":"    def test_volume_from_snapshot_decreasing_size(self):"},{"line_number":54,"context_line":"        \"\"\"Test creating volume from snapshot with decreasing size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        creating volume from snapshot with decreasing size should fail."}],"source_content_type":"text/x-python","patch_set":1,"id":"69c0fefb_f7b5b1af","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"b91a2c4b_345043de","updated":"2023-06-22 09:36:30.000000000","message":"right, we don\u0027t need that, we can share the resource within this class (/me gonna get another coffee :P )","commit_id":"16746bb1544d796b1774062c45665ac9597a351e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de717d9be1feb35b2312b713936bcd3b59da5de8","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":92,"context_line":"                          self.snapshots_client.list_snapshots,"},{"line_number":93,"context_line":"                          marker\u003ddata_utils.rand_uuid())"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":96,"context_line":"    @decorators.idempotent_id(\u0027ad1b2fbe-7188-4dfd-8b39-c03778b07475\u0027)"},{"line_number":97,"context_line":"    def test_delete_parent_volume_with_associated_snapshot(self):"},{"line_number":98,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":99,"context_line":"                          self.volumes_client.delete_volume,"},{"line_number":100,"context_line":"                          self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"8601b59a_442c5cac","line":100,"range":{"start_line":94,"start_character":0,"end_line":100,"end_character":44},"updated":"2023-06-30 18:36:16.000000000","message":"I do not think we need more such negative test which can be covered or might be already exist in project unit or functional tests https://docs.openstack.org/tempest/latest/HACKING.html#negative-tests","commit_id":"876c3438fd1deb33b83a1f8f5af89f2c1df9b002"}]}