)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95df5b981c0a7cfd5bb52376567fc727ec3bd578","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46b0c4b6_dc503db7","updated":"2023-06-30 19:38:21.000000000","message":"I am ok to have this test, few comment inline","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c25669f94624aa65253056cdac8591157adfa3a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8805b0d2_e3ccdcee","updated":"2023-09-18 07:34:01.000000000","message":"recheck\nunrelated failures in live migration tests in \"nova-live-migration\" gate","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"66b3f2da5a5510f7e130e11dc67729d7b3313b14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6f11318_09c2d119","updated":"2023-07-30 09:37:15.000000000","message":"recheck\nunrelated timeout exception","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fbdc818a5a6832a71e0dda124be5a5d03c7c5eb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e931a9fc_a0bfc748","updated":"2023-07-26 08:44:59.000000000","message":"recheck\nunrelated timeout exception","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71a835fdd65af2749a30cd7d4fe6f714869eb237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf71e871_3a2f0365","updated":"2023-09-15 18:35:08.000000000","message":"recheck refresh log to check the test result","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ac2a0da9999429dd96a719677efc2a59dd3c7317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71f6f7c7_b3f57368","updated":"2023-09-19 18:58:27.000000000","message":"recheck stestr issue has been fixed in latest release and it is good idea to use u-c in pep8 job so that we can avoid such issue in future, below change is doing the same\n- https://review.opendev.org/c/openstack/tempest/+/895627","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"82b41f1621f9b1b7805a66570ee02bca9cf9da6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee9db251_fed4ae84","updated":"2023-11-15 08:56:47.000000000","message":"recheck to see the latest gate results","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"33e871b42e41ef2afbf31ffade939501f97b1ad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2afd59dd_ee3df2f4","updated":"2023-09-19 18:57:39.000000000","message":"test is passing fine https://zuul.opendev.org/t/openstack/build/b1c22a0c6c5e4912948b868030012d39/log/job-output.txt#23662","commit_id":"1ada65ab6fdbf4dd0f8317ffd830fbfa0a6f3e30"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2cb4bdf69bc356400c9a141c1825c4ce4d692826","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c04748d_6a219f6a","line":176,"updated":"2023-06-13 09:07:28.000000000","message":"there are a few incremental backup tests in cinder-tempest-plugin, maybe it should be added there?\n\nAlso, it may overlap with https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/652771","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c9bf03b47f03d9724414eed2ecac98632f29b1d8","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d64d1413_d1401253","line":176,"in_reply_to":"2c04748d_6a219f6a","updated":"2023-06-22 09:33:55.000000000","message":"if it already exists in a plugin, we don\u0027t need that in tempest","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4355d125c9bbccc3250a5833da58df2b56c14ecf","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5cd441cc_39706a2c","line":176,"in_reply_to":"4f6259c0_cf476842","updated":"2024-03-11 12:04:20.000000000","message":"The issue with \"it was not discussed in the past 4 months\" is a bit more nunanced than that and while partially my fault, I find it a bit harsh to set a strict deadline like this.\nIt was not clear on my side, but I was waiting also on an answer from you, as tempest maintainers, whether my point above made sense. I think also Liron didn\u0027t propose them to cinder-tempest-plugin because he was waiting from a clear answer.\n\nAlso, unfortunately the person working on https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/652771 is not working on openstack anymore. I\u0027d have liked to have a bit more of help with that patch rather than going with a new one.\n\nIf we want a decision, yes, instead of adding a new test from scratch here, I \u0027d still like to see that more complete scenario being fixed in cinder-tempest-plugin.","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4379f82dc803c84d94730bb2a515dbf4abf54136","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"b84bbe42_3027d03c","line":176,"in_reply_to":"5cd441cc_39706a2c","updated":"2024-03-11 18:19:26.000000000","message":"I agree that we should not duplicate the tests between tempest and plugins but we can always merge/remove them if in future there will be test in plugin covering more cases. \n\nI think we should not stop this to merge especially seeing plugin tests change still not merged for 4 years or so. let\u0027s merge it and if plugin test change is ready and cover more wider scenario or that is superset of it then we can merge both in plugin or delete from tempest.","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"92bfe03ab7a2fc6dfcb57a41c9a5537e6b5a657b","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9d908a8_5a65b41d","line":176,"in_reply_to":"a6a353f7_664ca06a","updated":"2023-11-15 11:29:39.000000000","message":"What I meant is that, apart from that patch, incremental backup tests do exist in cinder-tempest-plugin, so it may be better to add them there?","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"82b41f1621f9b1b7805a66570ee02bca9cf9da6c","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6a353f7_664ca06a","line":176,"in_reply_to":"aa2bfa69_91ee4ec3","updated":"2023-11-15 08:56:47.000000000","message":"the one that Luigi linked above .. however, as there have been no updates since, we can proceed with this patch","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"0701171e7cc3064075486f4565edc0d034ba3342","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbd10313_19bbd773","line":176,"in_reply_to":"afe07396_e1042505","updated":"2024-03-11 08:53:43.000000000","message":"Martin? I still think it would be better to add those tests to cinder-tempest-plugin.","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"985d811f1068b1e46331762c808127856f82cbd2","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f6259c0_cf476842","line":176,"in_reply_to":"bbd10313_19bbd773","updated":"2024-03-11 10:55:08.000000000","message":"judging by the fact that this hasn\u0027t been proposed to cinder-tempest-plugin yet (it\u0027s been 4 months we has this discussion) I must assume, the cores of the plugin don\u0027t want it there, otherwise it would be have been proposed there and merged already.\n\nGhanshyam already +2 and I don\u0027t have any strong opinion on where the test is, I don\u0027t mind it here, if the plugin has similar ones and you want it there, let it be there. I\u0027m kind of disappointed that only the fact whether the test is here or there have been preventing the patch from being merged for 4 months.\n\nPlease, have a discussion in the plugin team and decide if you want the test there - if I don\u0027t see a link to a review adding this test to the plugin within 24 hours, I\u0027ll merge this.","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5070243712e8e3ff72a67c052b529f5cd36bd92a","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa2bfa69_91ee4ec3","line":176,"in_reply_to":"d64d1413_d1401253","updated":"2023-06-22 09:39:42.000000000","message":"Can you please share the test that covers this scenario ?","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"697cb9e2b1bcae80c23aeee580b4c4c061c2575b","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027f86eff09-2a6d-43c1-905e-8079e5754f1e\u0027)"},{"line_number":174,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":175,"context_line":"    @decorators.related_bug(\u00271703011\u0027)"},{"line_number":176,"context_line":"    def test_volume_backup_incremental(self):"},{"line_number":177,"context_line":"        \"\"\"Test create a backup when latest incremental backup is deleted\"\"\""},{"line_number":178,"context_line":"        # Create a volume"},{"line_number":179,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"afe07396_e1042505","line":176,"in_reply_to":"d9d908a8_5a65b41d","updated":"2024-03-10 06:46:28.000000000","message":"So what is the decision made?","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95df5b981c0a7cfd5bb52376567fc727ec3bd578","unresolved":true,"context_lines":[{"line_number":179,"context_line":"        volume \u003d self.create_volume()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # Create a server"},{"line_number":182,"context_line":"        server \u003d self.create_server()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # Attach volume to the server"},{"line_number":185,"context_line":"        self.attach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"31ffc69b_08745072","line":182,"range":{"start_line":182,"start_character":22,"end_line":182,"end_character":35},"updated":"2023-06-30 19:38:21.000000000","message":"let\u0027s create the SSH-able server here which is needed for attaching/detaching volume","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"84f89823842cc965ad30754f79076f25bff12399","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        volume \u003d self.create_volume()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # Create a server"},{"line_number":182,"context_line":"        server \u003d self.create_server()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # Attach volume to the server"},{"line_number":185,"context_line":"        self.attach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"f869bc0f_4783d785","line":182,"range":{"start_line":182,"start_character":22,"end_line":182,"end_character":35},"in_reply_to":"31ffc69b_08745072","updated":"2023-07-02 09:50:26.000000000","message":"Done","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95df5b981c0a7cfd5bb52376567fc727ec3bd578","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        self.assertEqual(False, backup_info[\u0027is_incremental\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Create an incremental backup"},{"line_number":196,"context_line":"        backup2 \u003d self.backups_client.create_backup("},{"line_number":197,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":198,"context_line":"        self.addCleanup(self._delete_backup, backup2[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":200,"context_line":"                                                backup2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Validate incremental backup details"},{"line_number":203,"context_line":"        backup2_info \u003d self.backups_client.show_backup(backup2[\u0027id\u0027])[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"539b987a_68a27809","line":200,"range":{"start_line":196,"start_character":18,"end_line":200,"end_character":75},"updated":"2023-06-30 19:38:21.000000000","message":"cannot we use the self.create_backup here and for other inc backup also","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"84f89823842cc965ad30754f79076f25bff12399","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.assertEqual(False, backup_info[\u0027is_incremental\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Create an incremental backup"},{"line_number":196,"context_line":"        backup2 \u003d self.backups_client.create_backup("},{"line_number":197,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":198,"context_line":"        self.addCleanup(self._delete_backup, backup2[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":200,"context_line":"                                                backup2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Validate incremental backup details"},{"line_number":203,"context_line":"        backup2_info \u003d self.backups_client.show_backup(backup2[\u0027id\u0027])[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"d63e8ff9_663f1053","line":200,"range":{"start_line":196,"start_character":18,"end_line":200,"end_character":75},"in_reply_to":"539b987a_68a27809","updated":"2023-07-02 09:50:26.000000000","message":"Done","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95df5b981c0a7cfd5bb52376567fc727ec3bd578","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        # Verify that the parent backup has a dependent backup"},{"line_number":223,"context_line":"        backup2_info \u003d self.backups_client.show_backup(backup2[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":224,"context_line":"        self.assertEqual(True, backup2_info[\u0027has_dependent_backups\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Delete the last incremental backup that was created"},{"line_number":227,"context_line":"        self.backups_client.delete_backup(backup3[\u0027id\u0027])"},{"line_number":228,"context_line":"        self.backups_client.wait_for_resource_deletion(backup3[\u0027id\u0027])"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # Create another incremental backup"},{"line_number":231,"context_line":"        backup4 \u003d self.backups_client.create_backup("},{"line_number":232,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":233,"context_line":"        self.addCleanup(self._delete_backup, backup4[\u0027id\u0027])"},{"line_number":234,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":235,"context_line":"                                                backup4[\u0027id\u0027], \u0027available\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate incremental backup details"},{"line_number":238,"context_line":"        backup4_info \u003d self.backups_client.show_backup(backup4[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":239,"context_line":"        self.assertEqual(True, backup4_info[\u0027is_incremental\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(False, backup4_info[\u0027has_dependent_backups\u0027])"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class VolumesBackupsV39Test(base.BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1bc35667_630978aa","line":240,"range":{"start_line":225,"start_character":0,"end_line":240,"end_character":70},"updated":"2023-06-30 19:38:21.000000000","message":"do we need to test this? what exactly it verify.","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"84f89823842cc965ad30754f79076f25bff12399","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        # Verify that the parent backup has a dependent backup"},{"line_number":223,"context_line":"        backup2_info \u003d self.backups_client.show_backup(backup2[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":224,"context_line":"        self.assertEqual(True, backup2_info[\u0027has_dependent_backups\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Delete the last incremental backup that was created"},{"line_number":227,"context_line":"        self.backups_client.delete_backup(backup3[\u0027id\u0027])"},{"line_number":228,"context_line":"        self.backups_client.wait_for_resource_deletion(backup3[\u0027id\u0027])"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # Create another incremental backup"},{"line_number":231,"context_line":"        backup4 \u003d self.backups_client.create_backup("},{"line_number":232,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":233,"context_line":"        self.addCleanup(self._delete_backup, backup4[\u0027id\u0027])"},{"line_number":234,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":235,"context_line":"                                                backup4[\u0027id\u0027], \u0027available\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate incremental backup details"},{"line_number":238,"context_line":"        backup4_info \u003d self.backups_client.show_backup(backup4[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":239,"context_line":"        self.assertEqual(True, backup4_info[\u0027is_incremental\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(False, backup4_info[\u0027has_dependent_backups\u0027])"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class VolumesBackupsV39Test(base.BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a455f39_eb5f2b03","line":240,"range":{"start_line":225,"start_character":0,"end_line":240,"end_character":70},"in_reply_to":"1bc35667_630978aa","updated":"2023-07-02 09:50:26.000000000","message":"There was a bug related to this specific scenario:\nhttps://bugs.launchpad.net/cinder/+bug/1703011","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8d84108b0d385f6c296c54e0b63acb86e407f96f","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        # Verify that the parent backup has a dependent backup"},{"line_number":223,"context_line":"        backup2_info \u003d self.backups_client.show_backup(backup2[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":224,"context_line":"        self.assertEqual(True, backup2_info[\u0027has_dependent_backups\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Delete the last incremental backup that was created"},{"line_number":227,"context_line":"        self.backups_client.delete_backup(backup3[\u0027id\u0027])"},{"line_number":228,"context_line":"        self.backups_client.wait_for_resource_deletion(backup3[\u0027id\u0027])"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # Create another incremental backup"},{"line_number":231,"context_line":"        backup4 \u003d self.backups_client.create_backup("},{"line_number":232,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":233,"context_line":"        self.addCleanup(self._delete_backup, backup4[\u0027id\u0027])"},{"line_number":234,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":235,"context_line":"                                                backup4[\u0027id\u0027], \u0027available\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate incremental backup details"},{"line_number":238,"context_line":"        backup4_info \u003d self.backups_client.show_backup(backup4[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":239,"context_line":"        self.assertEqual(True, backup4_info[\u0027is_incremental\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(False, backup4_info[\u0027has_dependent_backups\u0027])"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class VolumesBackupsV39Test(base.BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e91d994_119be61b","line":240,"range":{"start_line":225,"start_character":0,"end_line":240,"end_character":70},"in_reply_to":"333da281_dce5ee2b","updated":"2023-07-26 07:10:11.000000000","message":"It can be removed.","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5a02fcff0392ff92e7a99ee1b0b4cc42e691fa3","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        # Verify that the parent backup has a dependent backup"},{"line_number":223,"context_line":"        backup2_info \u003d self.backups_client.show_backup(backup2[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":224,"context_line":"        self.assertEqual(True, backup2_info[\u0027has_dependent_backups\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Delete the last incremental backup that was created"},{"line_number":227,"context_line":"        self.backups_client.delete_backup(backup3[\u0027id\u0027])"},{"line_number":228,"context_line":"        self.backups_client.wait_for_resource_deletion(backup3[\u0027id\u0027])"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # Create another incremental backup"},{"line_number":231,"context_line":"        backup4 \u003d self.backups_client.create_backup("},{"line_number":232,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":233,"context_line":"        self.addCleanup(self._delete_backup, backup4[\u0027id\u0027])"},{"line_number":234,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":235,"context_line":"                                                backup4[\u0027id\u0027], \u0027available\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate incremental backup details"},{"line_number":238,"context_line":"        backup4_info \u003d self.backups_client.show_backup(backup4[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":239,"context_line":"        self.assertEqual(True, backup4_info[\u0027is_incremental\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(False, backup4_info[\u0027has_dependent_backups\u0027])"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class VolumesBackupsV39Test(base.BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"333da281_dce5ee2b","line":240,"range":{"start_line":225,"start_character":0,"end_line":240,"end_character":70},"in_reply_to":"6a455f39_eb5f2b03","updated":"2023-07-20 03:40:36.000000000","message":"I mean validating the 4th backup. what exactly this 4th backup test?","commit_id":"6ea97cdfb5f1b74679072cd8d468ca3428cb279e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5a02fcff0392ff92e7a99ee1b0b4cc42e691fa3","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        self.assertEqual(True, backup_info[\u0027has_dependent_backups\u0027])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Create another incremental backup"},{"line_number":205,"context_line":"        backup3 \u003d self.backups_client.create_backup("},{"line_number":206,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":207,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":208,"context_line":"                                                backup3[\u0027id\u0027], \u0027available\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # Validate incremental backup details"},{"line_number":211,"context_line":"        backup3_info \u003d self.backups_client.show_backup(backup3[\u0027id\u0027])[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"8cb68e6c_2834ad64","line":208,"range":{"start_line":205,"start_character":0,"end_line":208,"end_character":75},"updated":"2023-07-20 03:40:36.000000000","message":"here also, we can use self.create_backup","commit_id":"90f8de72f91c39a960b407f3dc165169a45e7b46"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8d84108b0d385f6c296c54e0b63acb86e407f96f","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        self.assertEqual(True, backup_info[\u0027has_dependent_backups\u0027])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Create another incremental backup"},{"line_number":205,"context_line":"        backup3 \u003d self.backups_client.create_backup("},{"line_number":206,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)[\u0027backup\u0027]"},{"line_number":207,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":208,"context_line":"                                                backup3[\u0027id\u0027], \u0027available\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # Validate incremental backup details"},{"line_number":211,"context_line":"        backup3_info \u003d self.backups_client.show_backup(backup3[\u0027id\u0027])[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"580bba54_e8503ac9","line":208,"range":{"start_line":205,"start_character":0,"end_line":208,"end_character":75},"in_reply_to":"8cb68e6c_2834ad64","updated":"2023-07-26 07:10:11.000000000","message":"No, the incremental backup should be delete before the next incremental backup creation and not at the end of the test. This is the idea of the test as it\u0027s described in the bug.","commit_id":"90f8de72f91c39a960b407f3dc165169a45e7b46"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5a02fcff0392ff92e7a99ee1b0b4cc42e691fa3","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        self.backups_client.delete_backup(backup3[\u0027id\u0027])"},{"line_number":221,"context_line":"        self.backups_client.wait_for_resource_deletion(backup3[\u0027id\u0027])"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # Create another incremental backup"},{"line_number":224,"context_line":"        backup4 \u003d self.create_backup("},{"line_number":225,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        # Validate incremental backup details"},{"line_number":228,"context_line":"        backup4_info \u003d self.backups_client.show_backup(backup4[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":229,"context_line":"        self.assertEqual(True, backup4_info[\u0027is_incremental\u0027])"},{"line_number":230,"context_line":"        self.assertEqual(False, backup4_info[\u0027has_dependent_backups\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"class VolumesBackupsV39Test(base.BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"cfd952a7_113c40b6","line":230,"range":{"start_line":223,"start_character":0,"end_line":230,"end_character":70},"updated":"2023-07-20 03:40:36.000000000","message":"I am not sure what this 4th backup test exactly. can we remove this to decrease the test execution time?","commit_id":"90f8de72f91c39a960b407f3dc165169a45e7b46"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8d84108b0d385f6c296c54e0b63acb86e407f96f","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        self.backups_client.delete_backup(backup3[\u0027id\u0027])"},{"line_number":221,"context_line":"        self.backups_client.wait_for_resource_deletion(backup3[\u0027id\u0027])"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # Create another incremental backup"},{"line_number":224,"context_line":"        backup4 \u003d self.create_backup("},{"line_number":225,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], incremental\u003dTrue, force\u003dTrue)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        # Validate incremental backup details"},{"line_number":228,"context_line":"        backup4_info \u003d self.backups_client.show_backup(backup4[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":229,"context_line":"        self.assertEqual(True, backup4_info[\u0027is_incremental\u0027])"},{"line_number":230,"context_line":"        self.assertEqual(False, backup4_info[\u0027has_dependent_backups\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"class VolumesBackupsV39Test(base.BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"73346422_fc5061a9","line":230,"range":{"start_line":223,"start_character":0,"end_line":230,"end_character":70},"in_reply_to":"cfd952a7_113c40b6","updated":"2023-07-26 07:10:11.000000000","message":"Right, it seems unnecessary.","commit_id":"90f8de72f91c39a960b407f3dc165169a45e7b46"}]}