)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"0e9d89d192ea559ea611d050189aefca468e3583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"034529d1_c9e1d48f","updated":"2023-07-19 06:14:36.000000000","message":"recheck","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9dccb88abd842827e729344eca54ae97b6f9275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11040897_210b3f5b","updated":"2023-07-20 01:58:22.000000000","message":"thanks. some initial comments","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c8678dada0383806c88ab501fe046c51f059446a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"38f1aceb_f94ca408","updated":"2023-07-21 11:10:27.000000000","message":"recheck","commit_id":"3c2d4c07f53acee9e68aacb4334398070bf2ed40"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"f5a906be68e79cf2caa6cc963e7df1b1e3391da1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"db89a9f5_ba087675","updated":"2023-07-23 10:53:00.000000000","message":"recheck","commit_id":"8f073644c95279466b15f4a3c2167741ce775693"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"1dd8575d36d013cecbf8a056facd3bb33160e528","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"560a39ed_cc61c5ba","updated":"2023-07-23 13:28:58.000000000","message":"recheck","commit_id":"057da5c1caea9914878cc189d828087f7a7b404d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"90731331b66134f097fa5123784903525ae25897","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"43491d5a_58f32155","updated":"2023-07-24 07:24:34.000000000","message":"the pep8 error is a real one and it won\u0027t go away with rechecks or rebases, please fix it","commit_id":"057da5c1caea9914878cc189d828087f7a7b404d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"a920fba48b38f13136c12a95e62e0faabed75d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ebcecd8c_5f4a8d27","in_reply_to":"43491d5a_58f32155","updated":"2023-07-24 07:36:11.000000000","message":"Weird.If i run autopep it doesn\u0027t find this error","commit_id":"057da5c1caea9914878cc189d828087f7a7b404d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"27124a098a37bb979fef9f95dd63a8cc9b135852","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ed7384b9_66f4039d","in_reply_to":"ebcecd8c_5f4a8d27","updated":"2023-07-24 08:06:02.000000000","message":"Did you run tox -e pep8? The error is not about a pep8 validation, but the pep8 tox environment defined for this repository which runs several tests, including flake8 with a customer configuration:\n\nhttps://opendev.org/openstack/tempest/src/branch/master/tox.ini#L415","commit_id":"057da5c1caea9914878cc189d828087f7a7b404d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"a6133e163102c1af5fedb7d3cb95eeb6b7cb8dca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4a1010bd_a0d11193","in_reply_to":"ed7384b9_66f4039d","updated":"2023-07-24 08:18:52.000000000","message":"I runned with tox -e pep8 and autopep with tox configuration.","commit_id":"057da5c1caea9914878cc189d828087f7a7b404d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"1937356092ff112cb4b959c78ba7cedd4e33a02e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"081fa694_4f0df22f","updated":"2023-07-25 07:59:19.000000000","message":"From logs looks like node can\u0027t resolve address and download file from cirros site.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6d03370edc9e7a17c93f52671abee68e04b39698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"539fe68e_f938e9c1","updated":"2023-07-25 10:21:32.000000000","message":"recheck the nodes download images regularly (e.g. devstack) so it shouldn\u0027t be an issue","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9393b734_d8aaffbe","updated":"2023-07-25 17:54:45.000000000","message":"thanks for updates. few comment inline","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"41c40c9b591b102a97c14025f75f32f9c62ac809","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c7a05b15_1d1de37a","updated":"2023-07-27 10:09:28.000000000","message":"recheck","commit_id":"fe24415c6e97cf4a4b7fd8d82fbea2fee238ee73"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"67affc0f413d7dfa9368023805bb413e43318b20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b6773ff7_a58a4ed1","updated":"2023-07-31 09:08:36.000000000","message":"In the logs you can see that removing the first space in the docstrings should be enough:).\n\nYou can run pep8 checks locally before submitting the change `tox -epep8`.","commit_id":"406d8b11ac3e7c476669cdfd78037c3be55154ca"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"727861d3a06d5d2100b16f333f5252dd628185ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8f965d86_a7a1d245","updated":"2023-07-31 12:06:37.000000000","message":"I think in test_image_task.py imports sorted incorrectly and passed pep8 tests.Should be in alphabetically order:\nfrom tempest import config\nfrom tempest.api.image import base\nfrom tempest.common import waiters\nfrom tempest.lib import decorators\nfrom tempest.lib.common.utils import data_utils","commit_id":"c8a7217098b8288607b6487cbffd3bc6d92e8f29"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"405bedb6b6b27d75f6a712b4834c6c0ea9226f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0f23ae45_9624120b","updated":"2023-08-01 02:27:00.000000000","message":"thanks for update, a few comments/question inline.\n\nAlso, please add a release notes for the new image task client. example - https://review.opendev.org/c/openstack/tempest/+/825111/10/releasenotes/notes/add-image-cache-apis-as-tempest-clients-fbcd186927a85e2f.yaml","commit_id":"c8a7217098b8288607b6487cbffd3bc6d92e8f29"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d36caba269712e117aa2da9b8849cd4376dfb239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"505c098c_49d96975","updated":"2023-08-07 16:32:46.000000000","message":"Skip proposed: https://review.opendev.org/c/openstack/tempest/+/890687","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d8083b58060c050e7eff2c4e8c171c6977aa252a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b7aaa1c2_122337f4","updated":"2023-08-07 08:39:25.000000000","message":"The test is flaky and failing intermittently (seen 7-8 failures).\nMight need to understand the failures and rework on it. \n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0e4/886811/8/check/glance-multistore-cinder-import/0e4cdf7/testr_results.html\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_875/886811/8/check/nova-ceph-multistore/875816c/testr_results.html","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"7ead27063ab9d1392d6e780f34625f2449411026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"75049e21_a66217b3","updated":"2023-08-03 18:39:03.000000000","message":"recheck","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a6d7039c696b4ca58da69666f3643e5b22470559","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"74b7fbda_abc120f6","updated":"2023-08-06 11:19:21.000000000","message":"recheck\nunrelated failures","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"861d7339967fde5be4bb65573e891f556bec6702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f2daf31b_f4b9f5b1","updated":"2023-08-05 22:29:14.000000000","message":"recheck rbac job failing for other failure","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"861d7339967fde5be4bb65573e891f556bec6702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c14a39ce_2b34f122","updated":"2023-08-05 22:29:14.000000000","message":"thanks, this lgtm.\n\ntest passing fine \n\n- https://zuul.opendev.org/t/openstack/build/96a6e1b5c34a40518a264bf7eb191df3/log/job-output.txt#22875\n\n- https://zuul.opendev.org/t/openstack/build/70c067c866d74461a9a9179f6cd7a470/log/job-output.txt#22968","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3301fbfec7ed56fa0110582cade734f6d44e57e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b97df0c8_b69c87f5","in_reply_to":"003b0584_68399aee","updated":"2023-08-07 13:45:53.000000000","message":"skip the job with skip decorator","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1873722db85f3c906e2ff49faecd4c4ec2dcc6a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"57e9145c_aa988464","in_reply_to":"6662d7fe_7d7de567","updated":"2023-08-07 16:10:30.000000000","message":"did you propose the change to skip it?","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9c96af94f222d265caaf2e793ba31ac8ba074fed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"003b0584_68399aee","in_reply_to":"ae67f367_fa48ae4a","updated":"2023-08-07 10:37:14.000000000","message":"Revert or skip the job? I think it may be better to file file a bug and add a skip decorator to the test which fails, or even conditionally skip it if it\u0027s possible to detect that multistore is enabled","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"f004bde9c744c74607ce192ad291d0a483e11fef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ae67f367_fa48ae4a","in_reply_to":"b7aaa1c2_122337f4","updated":"2023-08-07 09:34:16.000000000","message":"Going to revert the patch as glance-multistore-cinder-import gate failed","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7630f10308e3007d55b8a2f4940bbb5a8de014f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6662d7fe_7d7de567","in_reply_to":"b97df0c8_b69c87f5","updated":"2023-08-07 16:07:40.000000000","message":"did not notice the imoport job due to non voting. We should have that voting to have it notice. I tried to make it voting but that job itslf not stable-  https://review.opendev.org/c/openstack/tempest/+/885810\n\n++ on skipping the test instead of full revert","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"}],"tempest/api/image/v2/admin/test_image_task.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ImageTaskCreate(base.BaseV2ImageTest):"},{"line_number":26,"context_line":"    \"\"\"Test image task operations\"\"\""},{"line_number":27,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"669fbc60_d342bc2d","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":42},"updated":"2023-07-25 17:54:45.000000000","message":"as these are admin tests, you can drive it from base.BaseV2ComputeAdminTest","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ImageTaskCreate(base.BaseV2ImageTest):"},{"line_number":26,"context_line":"    \"\"\"Test image task operations\"\"\""},{"line_number":27,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"37a89dc6_8fd50663","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":42},"in_reply_to":"669fbc60_d342bc2d","updated":"2023-07-27 09:55:17.000000000","message":"Or inherit from BaseV2ImageAdminTest","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ImageTaskCreate(base.BaseV2ImageTest):"},{"line_number":26,"context_line":"    \"\"\"Test image task operations\"\"\""},{"line_number":27,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ea5712b6_c45a47b0","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":38},"updated":"2023-07-25 17:54:45.000000000","message":"and once you drive it from BaseV2ComputeAdminTest then you do not need to do this as base class already provisioned primary and admin creds.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ImageTaskCreate(base.BaseV2ImageTest):"},{"line_number":26,"context_line":"    \"\"\"Test image task operations\"\"\""},{"line_number":27,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fb4612e_f50073e0","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":38},"in_reply_to":"ea5712b6_c45a47b0","updated":"2023-07-27 09:55:17.000000000","message":"Or Drive it from BaseV2ImageAdminTest","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        # glance ceph backend then will be available"},{"line_number":33,"context_line":"        # in tempest image service config options."},{"line_number":34,"context_line":"        super(ImageTaskCreate, cls).skip_checks()"},{"line_number":35,"context_line":"        if not CONF.image.http_image:"},{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"eb28d7d3_8d9d45a5","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":45},"updated":"2023-07-25 17:54:45.000000000","message":"and this? do we need http_image for these tests?","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"405bedb6b6b27d75f6a712b4834c6c0ea9226f50","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # glance ceph backend then will be available"},{"line_number":33,"context_line":"        # in tempest image service config options."},{"line_number":34,"context_line":"        super(ImageTaskCreate, cls).skip_checks()"},{"line_number":35,"context_line":"        if not CONF.image.http_image:"},{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"f97bddc5_917ed140","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":45},"in_reply_to":"60e0ed74_9e605163","updated":"2023-08-01 02:27:00.000000000","message":"I see, thanks","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # glance ceph backend then will be available"},{"line_number":33,"context_line":"        # in tempest image service config options."},{"line_number":34,"context_line":"        super(ImageTaskCreate, cls).skip_checks()"},{"line_number":35,"context_line":"        if not CONF.image.http_image:"},{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"60e0ed74_9e605163","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":45},"in_reply_to":"eb28d7d3_8d9d45a5","updated":"2023-07-27 09:55:17.000000000","message":"yes we need.In this test we created task type \u0027import\u0027 images","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"},{"line_number":42,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1cc1a908_4e093190","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":45},"updated":"2023-07-25 17:54:45.000000000","message":"you do not do import in this test right then we do not need to skip this.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"405bedb6b6b27d75f6a712b4834c6c0ea9226f50","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"},{"line_number":42,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"4e84aadb_7c825df3","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":45},"in_reply_to":"00641998_2ec0c725","updated":"2023-08-01 02:27:00.000000000","message":"ok. But in that case do not we need to define the import_method as web-download in task ?","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"},{"line_number":42,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"00641998_2ec0c725","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":45},"in_reply_to":"1cc1a908_4e093190","updated":"2023-07-27 09:55:17.000000000","message":"we created task type \u0027import\u0027.In our test we import image from web.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"95a1c4e40e1627d66387f4f617d424fa23df66c3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as http_image is not avaible\" %"},{"line_number":37,"context_line":"                        cls.__name__)"},{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":"        if not CONF.image_feature_enabled.import_image:"},{"line_number":40,"context_line":"            skip_msg \u003d \\"},{"line_number":41,"context_line":"                (\"%s skipped as image import is not available\" % cls.__name__)"},{"line_number":42,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"c43a7bf2_6824bcfa","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":45},"in_reply_to":"4e84aadb_7c825df3","updated":"2023-08-03 18:37:03.000000000","message":"As you mentioned in first comment,i remove this skip check as we not import image in this test.Thanks.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        super(ImageTaskCreate, cls).resource_setup()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def _prepare_image_tasks(type\u003d\"import\","},{"line_number":50,"context_line":"                             disk_format\u003d[\u0027qcow2\u0027],"},{"line_number":51,"context_line":"                             image_from_format\u003d[\u0027qcow2\u0027],"},{"line_number":52,"context_line":"                             image_location\u003dCONF.image.http_image):"}],"source_content_type":"text/x-python","patch_set":12,"id":"4f346761_38602af5","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":28},"updated":"2023-07-25 17:54:45.000000000","message":"this name is confusing on if it create task that is what I thought when i initially saw it. As it prepare the tesks API parameter only let\u0027s name it  _prepare_image_tasks_param","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(ImageTaskCreate, cls).resource_setup()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def _prepare_image_tasks(type\u003d\"import\","},{"line_number":50,"context_line":"                             disk_format\u003d[\u0027qcow2\u0027],"},{"line_number":51,"context_line":"                             image_from_format\u003d[\u0027qcow2\u0027],"},{"line_number":52,"context_line":"                             image_location\u003dCONF.image.http_image):"}],"source_content_type":"text/x-python","patch_set":12,"id":"af6ae1a1_0371acf5","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":28},"in_reply_to":"4f346761_38602af5","updated":"2023-07-27 09:55:17.000000000","message":"Done","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        task_body \u003d self.os_admin.tasks_client.show_tasks(task_id)"},{"line_number":111,"context_line":"        self._verify_disk_format(task_body)"},{"line_number":112,"context_line":"        task_image_id \u003d task_body[\u0027result\u0027][\u0027image_id\u0027]"},{"line_number":113,"context_line":"        self.addCleanup(self.os_admin.image_client_v2.delete_image,"},{"line_number":114,"context_line":"                        task_image_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Verify if image created"},{"line_number":117,"context_line":"        image_body \u003d self.client.show_image(task_image_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"af31f1bc_6a38f225","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":38},"updated":"2023-07-25 17:54:45.000000000","message":"you need to add this cleanup right create_tasks method after L107 othewrwise any in between operation can fail and delete tasks will not happen and leave resource uncleaned.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        task_body \u003d self.os_admin.tasks_client.show_tasks(task_id)"},{"line_number":111,"context_line":"        self._verify_disk_format(task_body)"},{"line_number":112,"context_line":"        task_image_id \u003d task_body[\u0027result\u0027][\u0027image_id\u0027]"},{"line_number":113,"context_line":"        self.addCleanup(self.os_admin.image_client_v2.delete_image,"},{"line_number":114,"context_line":"                        task_image_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Verify if image created"},{"line_number":117,"context_line":"        image_body \u003d self.client.show_image(task_image_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ea7400db_3d0de323","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":38},"in_reply_to":"af31f1bc_6a38f225","updated":"2023-07-27 09:55:17.000000000","message":"This cleanup delete image created by task.The status of task create method is in \u0027pending\u0027 status after creation.This mean we can\u0027t clean image right after task create.I will move this cleanup after task waiter.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"405bedb6b6b27d75f6a712b4834c6c0ea9226f50","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        task_body \u003d self.os_admin.tasks_client.show_tasks(task_id)"},{"line_number":111,"context_line":"        self._verify_disk_format(task_body)"},{"line_number":112,"context_line":"        task_image_id \u003d task_body[\u0027result\u0027][\u0027image_id\u0027]"},{"line_number":113,"context_line":"        self.addCleanup(self.os_admin.image_client_v2.delete_image,"},{"line_number":114,"context_line":"                        task_image_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Verify if image created"},{"line_number":117,"context_line":"        image_body \u003d self.client.show_image(task_image_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"cfa2906b_2113af16","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":38},"in_reply_to":"ea7400db_3d0de323","updated":"2023-08-01 02:27:00.000000000","message":"this is not deleting the image right away, it add the delete operation in addCleanup which get executed at the end of test. Adding this addCleanup right after the task creation will make sure in any case we have added the cleanup of image deletion in addCleanup list.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01624470f46ae42d74a4c6b19b341a6d4737be3e","unresolved":true,"context_lines":[{"line_number":120,"context_line":"            task_image_id,"},{"line_number":121,"context_line":"            message\u003d\"Can\u0027t find expected image id %s\" % task_image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Verify image status"},{"line_number":124,"context_line":"        self.assertEqual(image_body[\u0027status\u0027],"},{"line_number":125,"context_line":"                         \u0027active\u0027, message\u003d\"Image is not in active\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Verify image container format"},{"line_number":128,"context_line":"        task_container_format \u003d \\"}],"source_content_type":"text/x-python","patch_set":12,"id":"bc650140_a595cd11","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":68},"updated":"2023-07-25 17:54:45.000000000","message":"will image go to active status immediately task is \u0027success\u0027 ? I think we need to wait here as task is async operation and its \u0027success\u0027 status means taskration is accepted and initiated by glance but not neccassary to be completed. Correct me if I am wrong.","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c0f88b46bb92775df09f4e0f1be33c3a89e0ec45","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            task_image_id,"},{"line_number":121,"context_line":"            message\u003d\"Can\u0027t find expected image id %s\" % task_image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Verify image status"},{"line_number":124,"context_line":"        self.assertEqual(image_body[\u0027status\u0027],"},{"line_number":125,"context_line":"                         \u0027active\u0027, message\u003d\"Image is not in active\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Verify image container format"},{"line_number":128,"context_line":"        task_container_format \u003d \\"}],"source_content_type":"text/x-python","patch_set":12,"id":"eb314953_439cab80","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":68},"in_reply_to":"bc650140_a595cd11","updated":"2023-07-27 09:55:17.000000000","message":"Added waiter for image status","commit_id":"31cb3941eb4eeda880c9b0799c5e8c0513f25acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"405bedb6b6b27d75f6a712b4834c6c0ea9226f50","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        self._verify_disk_format(task_body)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Verify if image created"},{"line_number":120,"context_line":"        image_body \u003d self.client.show_image(task_image_id)"},{"line_number":121,"context_line":"        self.assertIn("},{"line_number":122,"context_line":"            image_body[\u0027id\u0027],"},{"line_number":123,"context_line":"            task_image_id,"},{"line_number":124,"context_line":"            message\u003d\"Can\u0027t find expected image id %s\" % task_image_id)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Verify image status"},{"line_number":127,"context_line":"        self.assertEqual(image_body[\u0027status\u0027],"},{"line_number":128,"context_line":"                         \u0027active\u0027, message\u003d\"Image is not active\")"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # Verify image container format"},{"line_number":131,"context_line":"        task_container_format \u003d \\"}],"source_content_type":"text/x-python","patch_set":16,"id":"5c6691e4_6f16a18b","line":128,"range":{"start_line":120,"start_character":0,"end_line":128,"end_character":65},"updated":"2023-08-01 02:27:00.000000000","message":"this whole thing can be replaced by the waiter you added in L116\n\nwaiters.wait_for_image_status(self.client, task_image_id, \u0027active\u0027)\n\nThis will check\n1. image exit\n2. image status reach to active within expected time.","commit_id":"c8a7217098b8288607b6487cbffd3bc6d92e8f29"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"95a1c4e40e1627d66387f4f617d424fa23df66c3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self._verify_disk_format(task_body)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Verify if image created"},{"line_number":120,"context_line":"        image_body \u003d self.client.show_image(task_image_id)"},{"line_number":121,"context_line":"        self.assertIn("},{"line_number":122,"context_line":"            image_body[\u0027id\u0027],"},{"line_number":123,"context_line":"            task_image_id,"},{"line_number":124,"context_line":"            message\u003d\"Can\u0027t find expected image id %s\" % task_image_id)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Verify image status"},{"line_number":127,"context_line":"        self.assertEqual(image_body[\u0027status\u0027],"},{"line_number":128,"context_line":"                         \u0027active\u0027, message\u003d\"Image is not active\")"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # Verify image container format"},{"line_number":131,"context_line":"        task_container_format \u003d \\"}],"source_content_type":"text/x-python","patch_set":16,"id":"5ee8600a_7f58d2f1","line":128,"range":{"start_line":120,"start_character":0,"end_line":128,"end_character":65},"in_reply_to":"5c6691e4_6f16a18b","updated":"2023-08-03 18:37:03.000000000","message":"Done","commit_id":"c8a7217098b8288607b6487cbffd3bc6d92e8f29"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"1e36d8ce930322c27e6f204c0debbf74f2142776","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        task_id \u003d body[\u0027id\u0027]"},{"line_number":107,"context_line":"        task_body \u003d waiters.wait_for_tasks_status(self.os_admin.tasks_client,"},{"line_number":108,"context_line":"                                                  task_id, \u0027success\u0027)"},{"line_number":109,"context_line":"        self.addCleanup(self.admin_client.delete_image,"},{"line_number":110,"context_line":"                        task_body[\u0027result\u0027][\u0027image_id\u0027])"},{"line_number":111,"context_line":"        task_image_id \u003d task_body[\u0027result\u0027][\u0027image_id\u0027]"},{"line_number":112,"context_line":"        waiters.wait_for_image_status(self.client, task_image_id, \u0027active\u0027)"},{"line_number":113,"context_line":"        self._verify_disk_format(task_body)"}],"source_content_type":"text/x-python","patch_set":17,"id":"b3e8f531_9edf2bb8","line":110,"range":{"start_line":109,"start_character":8,"end_line":110,"end_character":56},"updated":"2023-08-03 19:58:49.000000000","message":"when task in \u0027pending\u0027 status the image still not created.Moved cleanup after task  status is \u0027success\u0027.","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"861d7339967fde5be4bb65573e891f556bec6702","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        task_id \u003d body[\u0027id\u0027]"},{"line_number":107,"context_line":"        task_body \u003d waiters.wait_for_tasks_status(self.os_admin.tasks_client,"},{"line_number":108,"context_line":"                                                  task_id, \u0027success\u0027)"},{"line_number":109,"context_line":"        self.addCleanup(self.admin_client.delete_image,"},{"line_number":110,"context_line":"                        task_body[\u0027result\u0027][\u0027image_id\u0027])"},{"line_number":111,"context_line":"        task_image_id \u003d task_body[\u0027result\u0027][\u0027image_id\u0027]"},{"line_number":112,"context_line":"        waiters.wait_for_image_status(self.client, task_image_id, \u0027active\u0027)"},{"line_number":113,"context_line":"        self._verify_disk_format(task_body)"}],"source_content_type":"text/x-python","patch_set":17,"id":"2ad233ae_ec291fed","line":110,"range":{"start_line":109,"start_character":8,"end_line":110,"end_character":56},"in_reply_to":"b3e8f531_9edf2bb8","updated":"2023-08-05 22:29:14.000000000","message":"good idea","commit_id":"88660d436bd020f82d9c18542d04b9e8eaf5890a"}],"tempest/scenario/test_image_task.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9dccb88abd842827e729344eca54ae97b6f9275","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3f60047_880c8793","updated":"2023-07-20 01:58:22.000000000","message":"as these are API test, please add them under https://github.com/openstack/tempest/tree/master/tempest/api/image/v2/admin\n\ninstead of scenario tests","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c8678dada0383806c88ab501fe046c51f059446a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"55f5842e_cc2bab69","in_reply_to":"d3f60047_880c8793","updated":"2023-07-21 11:10:27.000000000","message":"Done","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9dccb88abd842827e729344eca54ae97b6f9275","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.image import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.common import waiters"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest.common import utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tempest.scenario import manager"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.lib import decorators"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8c46d7ff_8f5ef13e","line":28,"range":{"start_line":15,"start_character":0,"end_line":28,"end_character":47},"updated":"2023-07-20 01:58:22.000000000","message":"these all can be together, not need to separate them with new line","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c8678dada0383806c88ab501fe046c51f059446a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.image import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.common import waiters"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest.common import utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tempest.scenario import manager"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.lib import decorators"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f75d85ad_24801e9d","line":28,"range":{"start_line":15,"start_character":0,"end_line":28,"end_character":47},"in_reply_to":"8c46d7ff_8f5ef13e","updated":"2023-07-21 11:10:27.000000000","message":"Done","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9dccb88abd842827e729344eca54ae97b6f9275","unresolved":true,"context_lines":[{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class ImageTaskCreateAndBoot(base.BaseV2ImageTest, manager.ScenarioTest):"},{"line_number":34,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"d96ad403_0004ae19","line":33,"range":{"start_line":33,"start_character":49,"end_line":33,"end_character":73},"updated":"2023-07-20 01:58:22.000000000","message":"these are just API tests so we do not need to derive it from scenario manager.","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"c8678dada0383806c88ab501fe046c51f059446a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class ImageTaskCreateAndBoot(base.BaseV2ImageTest, manager.ScenarioTest):"},{"line_number":34,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"766f98ba_91f81921","line":33,"range":{"start_line":33,"start_character":49,"end_line":33,"end_character":73},"in_reply_to":"d96ad403_0004ae19","updated":"2023-07-21 11:10:27.000000000","message":"Done","commit_id":"137aba210b6e622ad5cde87585f6aaba80e19647"}]}