)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"6ed7f6e5a8fd3a1630a178afe3d91f49d822ab12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e23af97_c775e821","updated":"2023-07-24 08:38:42.000000000","message":"Looks good to me. I just added two small comments.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"099e28101db27520d9b34ce4b8d29eb39df78808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c34a165c_e9b7e087","updated":"2023-07-24 18:13:20.000000000","message":"lgtm, thanks","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b2152400de33b7152c0470f410392221ff08c97d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78829c4c_f3fcbda8","updated":"2023-07-30 07:51:29.000000000","message":"recheck again ...","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e7b8862b09068104d5e2b0b585bb9b84ef709ddf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a130cf58_37adaee8","updated":"2023-08-02 16:49:32.000000000","message":"recheck dep failed","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0309974d397984ff8ea60a218d89b8176586ae9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db0c0794_dc486c83","updated":"2023-08-02 07:46:11.000000000","message":"recheck depends on got rechecked","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ebd41a4f5017389f5b715040a261a03c14be798a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"512d9238_643144b7","updated":"2023-07-27 13:40:41.000000000","message":"recheck docs timeout","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3d5e7163a626b01896f25c5c7c8c29d31898117a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f84e1e69_09975f7b","updated":"2023-07-31 07:38:20.000000000","message":"recheck flaky jobs","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"135b98e63ec769089b30032ed76f20b5a93939ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c21418d5_1869d13d","updated":"2023-07-27 16:43:30.000000000","message":"recheck lots of failed tests, including the overlapping router segment issue which indicates extremely slow response times of things like neutron.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e7327fef6c3dedb0c60f2abd758456230d3cde43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1adfd1fa_7236d46e","updated":"2023-07-22 01:40:47.000000000","message":"recheck plugin tests clearly not related to this","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638b1a6e54dbef594059171f75f3bbf7cf4b5226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2fc5f565_82d228e0","updated":"2023-07-27 10:30:39.000000000","message":"recheck random issue","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f9047e09b075850b59a05d491ff6297bc4976163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1404c441_2f378059","updated":"2023-08-01 14:38:25.000000000","message":"recheck random issues","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"56979f472fe6f01263b058f6057af4ac81055dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e1557093_bd6a87ee","updated":"2023-08-01 11:51:40.000000000","message":"recheck still the same story","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7cfe400d9d0be997289812d65f2e83d2e9266ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ac97961_7d9514e4","updated":"2023-08-02 21:10:34.000000000","message":"recheck timed out during scenario","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efc84cd42c274d36388316534685f58c11413deb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d069849_fb9f27b3","updated":"2023-07-23 18:50:54.000000000","message":"recheck unrelated failure in volume type tests","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"75b7a401527c530d71fa54da690a53564151fbe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e1bf4f3c_a02f6eb0","updated":"2023-07-27 07:31:25.000000000","message":"recheck unrelated failures","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4a2c4d9f4ac3218471ea3bbfe9589c5f7442daea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e87c8f1b_34caa5c2","updated":"2023-07-24 17:43:19.000000000","message":"we were creating 2 servers indeed, we should have avoided that .. anyway, this does not only avoids creating 2 servers but also makes the code more elegant, thanks Dan!","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"099e28101db27520d9b34ce4b8d29eb39df78808","unresolved":true,"context_lines":[{"line_number":837,"context_line":"    @classmethod"},{"line_number":838,"context_line":"    def resource_setup(cls):"},{"line_number":839,"context_line":"        super(ServerActionsV293TestJSON, cls).resource_setup()"},{"line_number":840,"context_line":"        cls.server_id \u003d cls.recreate_server(None, volume_backed\u003dTrue,"},{"line_number":841,"context_line":"                                            validatable\u003dTrue)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    @utils.services(\u0027volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b05135f_6cca21a2","line":840,"range":{"start_line":840,"start_character":50,"end_line":840,"end_character":69},"updated":"2023-07-24 18:13:20.000000000","message":"++, in future if we add more tests in this class and they do not need volume backed server then we can think of creating a non volume backed but as this class has only 1 test need this volume backed, I am ok to it in setup.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"6ed7f6e5a8fd3a1630a178afe3d91f49d822ab12","unresolved":true,"context_lines":[{"line_number":837,"context_line":"    @classmethod"},{"line_number":838,"context_line":"    def resource_setup(cls):"},{"line_number":839,"context_line":"        super(ServerActionsV293TestJSON, cls).resource_setup()"},{"line_number":840,"context_line":"        cls.server_id \u003d cls.recreate_server(None, volume_backed\u003dTrue,"},{"line_number":841,"context_line":"                                            validatable\u003dTrue)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a5a897d_5414d411","line":841,"range":{"start_line":840,"start_character":7,"end_line":841,"end_character":61},"updated":"2023-07-24 08:38:42.000000000","message":"Maybe we can use here just create_test_server()?","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2172dca35c001138bf638f00e21bcceb4fdc4e3c","unresolved":true,"context_lines":[{"line_number":837,"context_line":"    @classmethod"},{"line_number":838,"context_line":"    def resource_setup(cls):"},{"line_number":839,"context_line":"        super(ServerActionsV293TestJSON, cls).resource_setup()"},{"line_number":840,"context_line":"        cls.server_id \u003d cls.recreate_server(None, volume_backed\u003dTrue,"},{"line_number":841,"context_line":"                                            validatable\u003dTrue)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7edbbe2d_0d222f7d","line":841,"range":{"start_line":840,"start_character":7,"end_line":841,"end_character":61},"in_reply_to":"1a5a897d_5414d411","updated":"2023-07-24 13:51:08.000000000","message":"All of the classes in this area use `recreate_server()` in their `resource_setup()` (as did this one). So, perhaps, but that should probably be a separate cleanup change.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fcc78ed30d7a14f07995ddb089d29094c687b6bd","unresolved":false,"context_lines":[{"line_number":837,"context_line":"    @classmethod"},{"line_number":838,"context_line":"    def resource_setup(cls):"},{"line_number":839,"context_line":"        super(ServerActionsV293TestJSON, cls).resource_setup()"},{"line_number":840,"context_line":"        cls.server_id \u003d cls.recreate_server(None, volume_backed\u003dTrue,"},{"line_number":841,"context_line":"                                            validatable\u003dTrue)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"75642ec1_282e0817","line":841,"range":{"start_line":840,"start_character":7,"end_line":841,"end_character":61},"in_reply_to":"7edbbe2d_0d222f7d","updated":"2023-07-24 15:23:43.000000000","message":"Ok, I agree.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"6ed7f6e5a8fd3a1630a178afe3d91f49d822ab12","unresolved":true,"context_lines":[{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":845,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":846,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":847,"context_line":"        self.validation_resources \u003d self.get_class_validation_resources("},{"line_number":848,"context_line":"            self.os_primary)"},{"line_number":849,"context_line":"        server \u003d self.servers_client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":850,"context_line":"        volume_id \u003d server[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e8bf0ec_3970ed46","line":847,"range":{"start_line":847,"start_character":8,"end_line":847,"end_character":33},"updated":"2023-07-24 08:38:42.000000000","message":"Why self.validation_resources not just validation_resources?","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"fcc78ed30d7a14f07995ddb089d29094c687b6bd","unresolved":true,"context_lines":[{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":845,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":846,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":847,"context_line":"        self.validation_resources \u003d self.get_class_validation_resources("},{"line_number":848,"context_line":"            self.os_primary)"},{"line_number":849,"context_line":"        server \u003d self.servers_client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":850,"context_line":"        volume_id \u003d server[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c832f89_98f9f509","line":847,"range":{"start_line":847,"start_character":8,"end_line":847,"end_character":33},"in_reply_to":"249779b2_6003eeba","updated":"2023-07-24 15:23:43.000000000","message":"I understand it in the `setUp()` but I\u0027m not certain whether it is really needed here. I\u0027ve just tested this change without the `self.` and it worked fine. But maybe I\u0027m missing something.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"281a06745d63300a5636e94314e6e6bbd701f064","unresolved":true,"context_lines":[{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":845,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":846,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":847,"context_line":"        self.validation_resources \u003d self.get_class_validation_resources("},{"line_number":848,"context_line":"            self.os_primary)"},{"line_number":849,"context_line":"        server \u003d self.servers_client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":850,"context_line":"        volume_id \u003d server[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"293cea85_f2283ef6","line":847,"range":{"start_line":847,"start_character":8,"end_line":847,"end_character":33},"in_reply_to":"2c832f89_98f9f509","updated":"2023-07-24 15:33:43.000000000","message":"Yeah, this might be left-over from me initially trying to move the server creation into the `setUp()` before I realized it was actually creating the second server in the `resource_setup()` phase.\n\nI\u0027m not sure it\u0027s really important, but if I respin this I will eliminate the extra changed lines.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2172dca35c001138bf638f00e21bcceb4fdc4e3c","unresolved":true,"context_lines":[{"line_number":844,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":845,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":846,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":847,"context_line":"        self.validation_resources \u003d self.get_class_validation_resources("},{"line_number":848,"context_line":"            self.os_primary)"},{"line_number":849,"context_line":"        server \u003d self.servers_client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":850,"context_line":"        volume_id \u003d server[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"249779b2_6003eeba","line":847,"range":{"start_line":847,"start_character":8,"end_line":847,"end_character":33},"in_reply_to":"5e8bf0ec_3970ed46","updated":"2023-07-24 13:51:08.000000000","message":"Well, to mirror the usual pattern in `setUp()` such as earlier in this file. If this calls anything that expects `self.validation_resources()` to already be set, this makes it consistent. I think maybe the original code kept it separate for just this test because it was creating an extra server and thought that separate `validation_resources` were required? I also seem to recall something else breaking when this was not set on the instance, like a call out to one of the common routines, but I\u0027d have to reproduce to try.","commit_id":"55962e1b50ed0794425df73e8ca947c464b6fd95"}]}