)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4dd55e8c585727997d17d0ca2b89c67a440298ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5e80ba8_57b5c981","updated":"2023-08-02 21:09:46.000000000","message":"recheck mysql oom le sigh","commit_id":"81b6e72201b86d784db90df55fbae1615f9b45cf"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f5c4934faf2cf1a331eafc83dfa8b947cd0fabc4","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        # create and add floating IP to server1"},{"line_number":97,"context_line":"        ip_for_server \u003d self.get_server_ip(server)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Make sure the machine ssh-able before attaching the volume"},{"line_number":100,"context_line":"        linux_client \u003d self.get_remote_client("},{"line_number":101,"context_line":"            ip_for_server, private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":102,"context_line":"            server\u003dserver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"92166887_0e356ecc","line":99,"updated":"2023-08-02 16:31:42.000000000","message":"I considered making the same change to this test awhile back but saw this comment and then looked at get_remote_client:\n\nhttps://github.com/openstack/tempest/blob/4025fa3c8e5ba8de3f2cb60f4a225f1bc550b5e4/tempest/scenario/manager.py#L746\n\nIt seems like it does in fact wait for ssh-able, so I\u0027m not sure if doing it in create_server will change anything (?)","commit_id":"52bd3ade49929db7593e91a05ead2d03cfc594c8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"041c51fb9ea425999c2841364ab1d0ef82db50a6","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        # create and add floating IP to server1"},{"line_number":97,"context_line":"        ip_for_server \u003d self.get_server_ip(server)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Make sure the machine ssh-able before attaching the volume"},{"line_number":100,"context_line":"        linux_client \u003d self.get_remote_client("},{"line_number":101,"context_line":"            ip_for_server, private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":102,"context_line":"            server\u003dserver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6212603_ab084d45","line":99,"in_reply_to":"92166887_0e356ecc","updated":"2023-08-02 16:40:45.000000000","message":"I don\u0027t see any retrying there and I saw one case recently where it looked like maybe we jumped the gun because we assumed as soon as the server went active. We failed to ssh to get the disks-before list on this test only and not the many others where we poll for sshable. Since this was never converted with many of the others, I figured it\u0027d be better to go ahead and make it like the others.\n\nNote that this is not necessarily related to the mkfs timeout issue, but more in support of the other work I was doing to make sure we use wait_until\u003dSSHABLE as much as possible.","commit_id":"52bd3ade49929db7593e91a05ead2d03cfc594c8"}]}