)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"49ded858b1c71416cba39897701d7642bae942f0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This patch skips the object storage test only when pre-prov creds"},{"line_number":14,"context_line":"are used. When dynamic credentials are used the test should"},{"line_number":15,"context_line":"not fail."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If94facd5a926f7eadd092dfc8f0368d8e4b8d630"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fc642daf_fa62fdef","line":16,"updated":"2023-08-08 15:39:25.000000000","message":"Closes-Bug: #2028671","commit_id":"616c9c7c4c720f2e174df6d91d325e66852ca83b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0f003acee4c6b40600546460effaa2e5d615dff8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch skips the object storage test only when pre-prov creds"},{"line_number":14,"context_line":"are used. When dynamic credentials are used the test should"},{"line_number":15,"context_line":"not fail."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If94facd5a926f7eadd092dfc8f0368d8e4b8d630"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2240fb27_979a8198","line":16,"in_reply_to":"fc642daf_fa62fdef","updated":"2023-08-11 14:38:05.000000000","message":"Done","commit_id":"616c9c7c4c720f2e174df6d91d325e66852ca83b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0f003acee4c6b40600546460effaa2e5d615dff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bb354f99_57e4f6b4","updated":"2023-08-11 14:38:05.000000000","message":"I think this is ready for review. I\u0027m not sure whether this is the best solution but it seems to be working.","commit_id":"bfba40f263a7404bfa0ff3d68b17e14095b773a0"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0b7b48b22624bc316acf98c75a86968771f6022f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a8115f8e_496bdb57","updated":"2023-08-16 15:00:58.000000000","message":"lgtm, one edit as you suggested","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f888bbd46e039afa7159569ec060a5ceb8be27c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a470f616_dae557d0","updated":"2023-08-11 22:02:41.000000000","message":"looks ok but 1 question inline to understand the cinder workflow","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f5a8184d810ddfdef19cf2a70bac8979bd6c057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"947e0936_8826faad","updated":"2023-08-22 16:12:12.000000000","message":"Thanks for updates. few comment inline","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"24053794992fcd887e869d995caaa7c758a7abf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"be8df946_70650b9b","updated":"2023-08-17 12:16:23.000000000","message":"lgtm","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6daaadae5a8a367095ab45a48c4952c6bf6723e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c99653fd_b9cf4057","updated":"2023-08-24 10:57:25.000000000","message":"I\u0027m sorry Ghanshyam I overlooked the rest of your comments. I think I fixed all the things you thought were incorrect.","commit_id":"cd1140785671c731136f976589585696d7a95430"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"adc1f982f72bc8a60a53f337a8a384287f160cbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b263819d_1223f999","updated":"2023-08-23 17:38:33.000000000","message":"Thanks Lukas for fixing the name thing. my two comment are not yet address so -1 ohterwise this is going in right direction","commit_id":"cd1140785671c731136f976589585696d7a95430"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"87d0361289d469d33af784f8a1a37f70b66bbbaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4f8ba93c_9fa6301e","updated":"2023-09-01 21:36:48.000000000","message":"check experimental","commit_id":"2c2484ca6e1835105b4e322a65f6e7f588736e61"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a8a9d3d963d6fe4ce09f568fb7cbc71d41ecba7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"851f3edd_306dc74b","updated":"2023-09-05 08:05:08.000000000","message":"check experimental","commit_id":"2c2484ca6e1835105b4e322a65f6e7f588736e61"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"125ab782bc471c3ed3d535fa5c9595f132ffdbd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0b073355_3306f5d2","updated":"2023-09-05 11:58:52.000000000","message":"lgtm","commit_id":"2c2484ca6e1835105b4e322a65f6e7f588736e61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1e350e055a82846f29e1dedc27d4967ffa6f4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5b9d49ce_b331efbf","updated":"2023-09-05 17:10:00.000000000","message":"thanks, lgtm","commit_id":"2c2484ca6e1835105b4e322a65f6e7f588736e61"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ea743c0169efbaf13ca62a90bf18f1c5981bc441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e670dee2_f75d844c","in_reply_to":"851f3edd_306dc74b","updated":"2023-09-05 08:07:07.000000000","message":"Failures in https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_732/890798/10/experimental/tempest-with-latest-microversion/7325a64/testr_results.html aren\u0027t related to this patch.\n\nHowever, I wanna see if tempest.scenario.test_unified_limits fails again in https://16914890dac5609d49b0-6ce456e6f9c28bd8511060ffded7cac7.ssl.cf2.rackcdn.com/890798/10/experimental/tempest-full-test-account-no-admin-py3/339ad65/testr_results.html ... it would mean we have a reproducer for this LP: https://bugs.launchpad.net/tempest/+bug/2031539","commit_id":"2c2484ca6e1835105b4e322a65f6e7f588736e61"}],"tempest/api/object_storage/test_account_services.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0bac1b14fb21e52b3e7efd7d200c3bf6778bd799","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_credentials(cls):"},{"line_number":37,"context_line":"        super(AccountTest, cls).setup_credentials()"},{"line_number":38,"context_line":"        cls.os_operator \u003d cls.os_roles_operator_alt"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a1ad220c_dcafbc13","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":24},"updated":"2023-08-09 17:36:43.000000000","message":"this is confusing, we should name it to  cls.os_operator_alt otherwise it seems like the operator role not the alt operator.","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0f003acee4c6b40600546460effaa2e5d615dff8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_credentials(cls):"},{"line_number":37,"context_line":"        super(AccountTest, cls).setup_credentials()"},{"line_number":38,"context_line":"        cls.os_operator \u003d cls.os_roles_operator_alt"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"c574bf13_45876291","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":24},"in_reply_to":"a1ad220c_dcafbc13","updated":"2023-08-11 14:38:05.000000000","message":"Ack","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1972e3a77a36889df8c2c43c41c9f839010f1812","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                          container_list)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027884ec421-fbad-4fcc-916b-0580f2699565\u0027)"},{"line_number":67,"context_line":"    @testtools.skipIf(not CONF.auth.use_dynamic_credentials,"},{"line_number":68,"context_line":"                      \"Users can have containers assigned that were created \""},{"line_number":69,"context_line":"                      \"by volume backup tests.\")"},{"line_number":70,"context_line":"    def test_list_no_containers(self):"},{"line_number":71,"context_line":"        \"\"\"Test listing containers for an account without container\"\"\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"caae68b6_97ceec11","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":48},"updated":"2023-08-08 20:54:20.000000000","message":"I do not think we should skip this test for the pre-provisioned creds instead we should fix/modify the test itself.\n\nBut before that I asked question about Cinder behaviour in bug report https://bugs.launchpad.net/cinder/+bug/2028671/comments/6","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6daaadae5a8a367095ab45a48c4952c6bf6723e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          container_list)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027884ec421-fbad-4fcc-916b-0580f2699565\u0027)"},{"line_number":67,"context_line":"    @testtools.skipIf(not CONF.auth.use_dynamic_credentials,"},{"line_number":68,"context_line":"                      \"Users can have containers assigned that were created \""},{"line_number":69,"context_line":"                      \"by volume backup tests.\")"},{"line_number":70,"context_line":"    def test_list_no_containers(self):"},{"line_number":71,"context_line":"        \"\"\"Test listing containers for an account without container\"\"\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"11d2e92b_4e77a148","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":48},"in_reply_to":"4e7da235_332aa50b","updated":"2023-08-24 10:57:25.000000000","message":"Done","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"0f003acee4c6b40600546460effaa2e5d615dff8","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                          container_list)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027884ec421-fbad-4fcc-916b-0580f2699565\u0027)"},{"line_number":67,"context_line":"    @testtools.skipIf(not CONF.auth.use_dynamic_credentials,"},{"line_number":68,"context_line":"                      \"Users can have containers assigned that were created \""},{"line_number":69,"context_line":"                      \"by volume backup tests.\")"},{"line_number":70,"context_line":"    def test_list_no_containers(self):"},{"line_number":71,"context_line":"        \"\"\"Test listing containers for an account without container\"\"\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4e7da235_332aa50b","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":48},"in_reply_to":"5a5dd0c1_ca6986f8","updated":"2023-08-11 14:38:05.000000000","message":"Thank you for the ideas. I tried the first option for now.","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"2392473a739167d8bd3fde8a185984524b0c8861","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                          container_list)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027884ec421-fbad-4fcc-916b-0580f2699565\u0027)"},{"line_number":67,"context_line":"    @testtools.skipIf(not CONF.auth.use_dynamic_credentials,"},{"line_number":68,"context_line":"                      \"Users can have containers assigned that were created \""},{"line_number":69,"context_line":"                      \"by volume backup tests.\")"},{"line_number":70,"context_line":"    def test_list_no_containers(self):"},{"line_number":71,"context_line":"        \"\"\"Test listing containers for an account without container\"\"\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f809b352_a9ac28a2","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":48},"in_reply_to":"caae68b6_97ceec11","updated":"2023-08-09 08:26:58.000000000","message":"I\u0027m thinking what is the best solution here if we do not want to skip this. \n- Should we just ignore the containers created by the volume backup tests in this test?\n- Or maybe modify the cleanup for the volume backup tests?\n\nI\u0027ve already asked your question on the cinder IRC channel and it seems that the behaviour of cinder not deleting the container is expected. They closed the linked bugzilla with \"Invalid\" for Cinder [2].\n\n[1] https://docs.openstack.org/cinder/rocky/configuration/block-storage/backup/swift-backup-driver.html\n[2] https://bugs.launchpad.net/cinder/+bug/2028671/comments/2","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45859fe83a01745f7e8104bd99f6618fe8556bfd","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                          container_list)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027884ec421-fbad-4fcc-916b-0580f2699565\u0027)"},{"line_number":67,"context_line":"    @testtools.skipIf(not CONF.auth.use_dynamic_credentials,"},{"line_number":68,"context_line":"                      \"Users can have containers assigned that were created \""},{"line_number":69,"context_line":"                      \"by volume backup tests.\")"},{"line_number":70,"context_line":"    def test_list_no_containers(self):"},{"line_number":71,"context_line":"        \"\"\"Test listing containers for an account without container\"\"\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5dd0c1_ca6986f8","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":48},"in_reply_to":"e44095a4_9abd89a4","updated":"2023-08-09 19:30:39.000000000","message":"Because this is very common issue in pre-provisioned case. If test does not cleanup any resources of any pre-provisioend account creds then it can fail other tests in the similar way this test is failing.\n\nEither we have to be careful about each test cleanup all their created resources or make these type of test little flexible to assert the things. So we can\n1. First try to cleanup the container in backup test\n2. if we are not able to do that and test still fail then we can modify this test to check that cls.os_operator (it should be name as cls.os_operator_alt) user does not have any container from cls.containers list. This way we will verify that a new user containers list does not include the other user containers.","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0bac1b14fb21e52b3e7efd7d200c3bf6778bd799","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                          container_list)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027884ec421-fbad-4fcc-916b-0580f2699565\u0027)"},{"line_number":67,"context_line":"    @testtools.skipIf(not CONF.auth.use_dynamic_credentials,"},{"line_number":68,"context_line":"                      \"Users can have containers assigned that were created \""},{"line_number":69,"context_line":"                      \"by volume backup tests.\")"},{"line_number":70,"context_line":"    def test_list_no_containers(self):"},{"line_number":71,"context_line":"        \"\"\"Test listing containers for an account without container\"\"\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e44095a4_9abd89a4","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":48},"in_reply_to":"f809b352_a9ac28a2","updated":"2023-08-09 17:36:43.000000000","message":"Yeah, Rajat replied the reason of not deleting the container which make sense to me.\n\nYou are right, we should delete the created container in backup tests otherwise not this test we might see other test failing too. But can we identify the containers created by hat backup test if so then let\u0027s delete that in backup test cleanup. That will be the actual operation admin/operators are doing in this case.","commit_id":"c43a0c6046bb5379a1b6964de3cda81a5e998d5c"}],"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f888bbd46e039afa7159569ec060a5ceb8be27c","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"a9114647_5011f4e8","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":38},"updated":"2023-08-11 22:02:41.000000000","message":"so this way we are asking cider to always create the container even there is already one?","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f5a8184d810ddfdef19cf2a70bac8979bd6c057","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"cc89cc62_bd7266a0","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":38},"in_reply_to":"89be8b23_34dc68b1","updated":"2023-08-22 16:12:12.000000000","message":"yeah, let\u0027s generate the name from data_utils. commented inline in next file.","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"26a9f27b942862454d30dcbd3f1d0b307c825595","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"c1c40d6b_ff4a94bf","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":38},"in_reply_to":"a9114647_5011f4e8","updated":"2023-08-14 15:06:22.000000000","message":"Yes, this will create a new container if we specify the container name. If we do not specify the container name then the backup will be stored into a container with a name defined by the backup_swift_container config option [1].\n\nIt got me thinking. Shouldn\u0027t I remove this line [2] from the test_volume_backup_create_get_detailed_list_restore_delete test? It either uses or creates a container named \"container\". The name sounds too generic and it might be a problem if we now want to add deleting of the containers into the cleanup.\n\n[1] https://docs.openstack.org/cinder/latest/configuration/block-storage/backup/swift-backup-driver.html\n[2] https://opendev.org/openstack/tempest/src/commit/054c06aec9b5ba5f7e08833f0d0382260a1a1415/tempest/api/volume/test_volumes_backup.py#L84","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0b7b48b22624bc316acf98c75a86968771f6022f","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"89be8b23_34dc68b1","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":38},"in_reply_to":"c1c40d6b_ff4a94bf","updated":"2023-08-16 15:00:58.000000000","message":"I agree with you Lukas, I\u0027d delete that line together with the line #93 as we won\u0027t be able to do the assert plus I think that the assert is very low level for tempest (the assert only checked whether the container was named with the provided name - that\u0027s something which is probably tested on the service\u0027s side)\n\nhttps://opendev.org/openstack/tempest/src/commit/054c06aec9b5ba5f7e08833f0d0382260a1a1415/tempest/api/volume/test_volumes_backup.py#L93","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6daaadae5a8a367095ab45a48c4952c6bf6723e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5eadda04_1348e143","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":38},"in_reply_to":"cc89cc62_bd7266a0","updated":"2023-08-24 10:57:25.000000000","message":"Done","commit_id":"bfdb63f43b4798f59a2fccf73aae4621ebfccf3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f5a8184d810ddfdef19cf2a70bac8979bd6c057","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.object_storage.base import delete_containers"},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":8,"id":"e32b7959_03b49f03","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":61},"updated":"2023-08-22 16:12:12.000000000","message":"I am not sure if we should do this. importing the each service base class can cause deps issue in future. How about moving the delete_containers method in new file tempest.common.object_storage class and from there we can use it in volume test?  This common file will help in future too if we want to move more common stuff from swift tests.","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6daaadae5a8a367095ab45a48c4952c6bf6723e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.object_storage.base import delete_containers"},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":8,"id":"6849a636_bda76bb1","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":61},"in_reply_to":"e32b7959_03b49f03","updated":"2023-08-24 10:57:25.000000000","message":"Done","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f5a8184d810ddfdef19cf2a70bac8979bd6c057","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if CONF.service_available.swift:"},{"line_number":196,"context_line":"            self.addCleanup(delete_containers, kwargs[\u0027container\u0027],"},{"line_number":197,"context_line":"                            container_client, object_client)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # addCleanup uses list pop to cleanup. Wait should be added before"},{"line_number":200,"context_line":"        # the backup is deleted"}],"source_content_type":"text/x-python","patch_set":8,"id":"0be5dace_53bdc1d1","line":197,"range":{"start_line":196,"start_character":12,"end_line":197,"end_character":60},"updated":"2023-08-22 16:12:12.000000000","message":"if container get deleted then it will fail test. how about deleting container and ignore the NotFound error?","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6daaadae5a8a367095ab45a48c4952c6bf6723e","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if CONF.service_available.swift:"},{"line_number":196,"context_line":"            self.addCleanup(delete_containers, kwargs[\u0027container\u0027],"},{"line_number":197,"context_line":"                            container_client, object_client)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # addCleanup uses list pop to cleanup. Wait should be added before"},{"line_number":200,"context_line":"        # the backup is deleted"}],"source_content_type":"text/x-python","patch_set":8,"id":"c95012af_142b8e47","line":197,"range":{"start_line":196,"start_character":12,"end_line":197,"end_character":60},"in_reply_to":"0be5dace_53bdc1d1","updated":"2023-08-24 10:57:25.000000000","message":"NotFound error should be ignored by the delete_containers function [1]. Or did you mean something else?\n\n[1] https://opendev.org/openstack/tempest/src/commit/28336ece6fa684fd0b3e174b6d642ac81dd749b4/tempest/api/object_storage/base.py#L50","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"87d0361289d469d33af784f8a1a37f70b66bbbaf","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if CONF.service_available.swift:"},{"line_number":196,"context_line":"            self.addCleanup(delete_containers, kwargs[\u0027container\u0027],"},{"line_number":197,"context_line":"                            container_client, object_client)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # addCleanup uses list pop to cleanup. Wait should be added before"},{"line_number":200,"context_line":"        # the backup is deleted"}],"source_content_type":"text/x-python","patch_set":8,"id":"4ae0eb52_3cd687e6","line":197,"range":{"start_line":196,"start_character":12,"end_line":197,"end_character":60},"in_reply_to":"c95012af_142b8e47","updated":"2023-09-01 21:36:48.000000000","message":"+1, delete_containers  of object_storage method take care of it.","commit_id":"e34a91df454e89b0afad8665b2bd0fae16da1435"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"adc1f982f72bc8a60a53f337a8a384287f160cbb","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("}],"source_content_type":"text/x-python","patch_set":9,"id":"a5e168a4_e0c84f2b","line":189,"range":{"start_line":189,"start_character":67,"end_line":189,"end_character":77},"updated":"2023-08-23 17:38:33.000000000","message":"can we name it \u0027backup-container\u0027 so that it will be easy to know this container is from cinder backup. We can get to know from class name too but this will be more easy to read instead of checking this test class has back up test or not","commit_id":"cd1140785671c731136f976589585696d7a95430"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b6daaadae5a8a367095ab45a48c4952c6bf6723e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":187,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":188,"context_line":"        if \u0027container\u0027 not in kwargs:"},{"line_number":189,"context_line":"            cont \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-container\u0027)"},{"line_number":190,"context_line":"            kwargs[\u0027container\u0027] \u003d cont"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        backup \u003d backup_client.create_backup("}],"source_content_type":"text/x-python","patch_set":9,"id":"8489e464_a0adba6d","line":189,"range":{"start_line":189,"start_character":67,"end_line":189,"end_character":77},"in_reply_to":"a5e168a4_e0c84f2b","updated":"2023-08-24 10:57:25.000000000","message":"Done","commit_id":"cd1140785671c731136f976589585696d7a95430"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f5a8184d810ddfdef19cf2a70bac8979bd6c057","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        description \u003d data_utils.rand_name(\"volume-backup-description\")"},{"line_number":81,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":82,"context_line":"                                    name\u003dbackup_name,"},{"line_number":83,"context_line":"                                    description\u003ddescription,"},{"line_number":84,"context_line":"                                    container\u003d\u0027container\u0027)"},{"line_number":85,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":86,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":87,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"52ee7c70_004b8a83","side":"PARENT","line":84,"range":{"start_line":83,"start_character":59,"end_line":84,"end_character":58},"updated":"2023-08-22 16:12:12.000000000","message":"let\u0027s generate the name from data_utils\n\nbackup_name \u003d data_utils.rand_name(\n            self.__class__.__name__ + \u0027-Backup-container\u0027)","commit_id":"fbd3dbc638ede072b7947c7a005404f389da2901"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"35d3411f8fce414273b4cf832c5a40e25049297e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        description \u003d data_utils.rand_name(\"volume-backup-description\")"},{"line_number":81,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":82,"context_line":"                                    name\u003dbackup_name,"},{"line_number":83,"context_line":"                                    description\u003ddescription,"},{"line_number":84,"context_line":"                                    container\u003d\u0027container\u0027)"},{"line_number":85,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":86,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":87,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"162c6b81_844bc833","side":"PARENT","line":84,"range":{"start_line":83,"start_character":59,"end_line":84,"end_character":58},"in_reply_to":"52ee7c70_004b8a83","updated":"2023-08-23 07:30:46.000000000","message":"Ack, using the rand_name is definitely better.","commit_id":"fbd3dbc638ede072b7947c7a005404f389da2901"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f5a8184d810ddfdef19cf2a70bac8979bd6c057","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        backup \u003d self.backups_client.show_backup(backup[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":91,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(description, backup[\u0027description\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(\u0027container\u0027, backup[\u0027container\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Get all backups with detail"},{"line_number":96,"context_line":"        backups \u003d self.backups_client.list_backups(detail\u003dTrue)[\u0027backups\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7fa6b4d3_e0f86651","side":"PARENT","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":58},"updated":"2023-08-22 16:12:12.000000000","message":"let\u0027s keep this assert too","commit_id":"fbd3dbc638ede072b7947c7a005404f389da2901"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"35d3411f8fce414273b4cf832c5a40e25049297e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        backup \u003d self.backups_client.show_backup(backup[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":91,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(description, backup[\u0027description\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(\u0027container\u0027, backup[\u0027container\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Get all backups with detail"},{"line_number":96,"context_line":"        backups \u003d self.backups_client.list_backups(detail\u003dTrue)[\u0027backups\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3d584f63_2bd55be3","side":"PARENT","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":58},"in_reply_to":"7fa6b4d3_e0f86651","updated":"2023-08-23 07:30:46.000000000","message":"Ack","commit_id":"fbd3dbc638ede072b7947c7a005404f389da2901"}]}