)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"720ccd1df9cab0dd50cb647b04caa6758afaf56f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c4903c4_bb2c55b8","updated":"2023-08-08 18:52:06.000000000","message":"got some good feedback from Dan on IRC, need to update this.","commit_id":"af3031a70ca9ec28c82ec7c868663810fa72d4cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7e2b77f247a7c76eeee881ed4833fd53b1da7ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e9e65dc_3f827745","updated":"2023-08-10 13:52:15.000000000","message":"It took me a bit to figure out the logic here, so I just want to confirm I understand the goal here. If I\u0027m right, then this makes sense I think.","commit_id":"ec63f4aaf696e37459523de517cfb9b086b8811e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"877d9c14f0fa5511dae9265e0d3951d36882182d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3789c73_cd64beac","updated":"2023-08-13 21:03:44.000000000","message":"looks good, thanks for improving that","commit_id":"ec63f4aaf696e37459523de517cfb9b086b8811e"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"12773a5c2d4d746304e2deb0cfa747f136a0e62b","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        # If the server was rebuilt on a different image, restore it to the"},{"line_number":148,"context_line":"        # original image once the test ends"},{"line_number":149,"context_line":"        if self.image_ref_alt !\u003d self.image_ref:"},{"line_number":150,"context_line":"            self.addCleanup(self._rebuild_server_and_check, self.image_ref,"},{"line_number":151,"context_line":"                            rebuilt_server)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # Verify the properties in the initial response are correct"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb1aa971_7a4a521b","line":150,"updated":"2023-08-08 20:04:02.000000000","message":"This will still rebuild the server in cleanup right?","commit_id":"3b564fa2d2124fc29e6a5e6309cf2314aa0f497c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7e2b77f247a7c76eeee881ed4833fd53b1da7ff","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # If the server was rebuilt on a different image, restore it to the"},{"line_number":148,"context_line":"        # original image once the test ends"},{"line_number":149,"context_line":"        if self.image_ref_alt !\u003d self.image_ref:"},{"line_number":150,"context_line":"            self.addCleanup(self._rebuild_server_and_check, self.image_ref,"},{"line_number":151,"context_line":"                            rebuilt_server)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # Verify the properties in the initial response are correct"}],"source_content_type":"text/x-python","patch_set":2,"id":"e29fc689_b08a6f6e","line":150,"in_reply_to":"8114a082_49c7ba5b","updated":"2023-08-10 13:52:15.000000000","message":"Done","commit_id":"3b564fa2d2124fc29e6a5e6309cf2314aa0f497c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19d0869fa677182ca511ccd0cef528b98c039eaa","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        # If the server was rebuilt on a different image, restore it to the"},{"line_number":148,"context_line":"        # original image once the test ends"},{"line_number":149,"context_line":"        if self.image_ref_alt !\u003d self.image_ref:"},{"line_number":150,"context_line":"            self.addCleanup(self._rebuild_server_and_check, self.image_ref,"},{"line_number":151,"context_line":"                            rebuilt_server)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # Verify the properties in the initial response are correct"}],"source_content_type":"text/x-python","patch_set":2,"id":"8114a082_49c7ba5b","line":150,"in_reply_to":"fb1aa971_7a4a521b","updated":"2023-08-08 20:08:07.000000000","message":"right. need to skip this step too. thanks","commit_id":"3b564fa2d2124fc29e6a5e6309cf2314aa0f497c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7e2b77f247a7c76eeee881ed4833fd53b1da7ff","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        The server should be rebuilt using the provided image and data."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":268,"context_line":"        _, servers \u003d compute.create_test_server("},{"line_number":269,"context_line":"            self.os_primary,"},{"line_number":270,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":271,"context_line":"            tenant_network\u003dtenant_network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fc5d5e6_d9f5288e","line":268,"updated":"2023-08-10 13:52:15.000000000","message":"So, when we setup the class, we\u0027ll always create a server to use, but this test doesn\u0027t use that.\n\nAre you thinking that all the other tests in this class use that server, except for the rebuild one to avoid needing to rebuild it back?","commit_id":"ec63f4aaf696e37459523de517cfb9b086b8811e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa8ed181730dfc285653728c64f683f10a80141c","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        The server should be rebuilt using the provided image and data."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":268,"context_line":"        _, servers \u003d compute.create_test_server("},{"line_number":269,"context_line":"            self.os_primary,"},{"line_number":270,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":271,"context_line":"            tenant_network\u003dtenant_network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0dd8ad93_f2df9777","line":268,"in_reply_to":"1fc5d5e6_d9f5288e","updated":"2023-08-10 16:53:27.000000000","message":"setup class only recreate the server if that is corrupted by any tests (other than rebuild tests now) and cannot reach to Active state.\n\nWith this change, goal is same you mentioned that to avoid rebuild tests rebuilding the class level server twice (which is used by the other servers) which take time as well more chance to corrupt the class level server.","commit_id":"ec63f4aaf696e37459523de517cfb9b086b8811e"}]}